Inspection of "fixing syncTo/syncFrom" - flipboxfactory/craft-hubspot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 76527a...6d8075 )

by Nate

created 2018-07-05 20:32 UTC

Status

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -8,6 +8,14 @@  discard block
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\CompanyContactsBuilder;
 use flipbox\hubspot\builders\CompanyContactsBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
@@ -16,19 +24,11 @@  discard block
 block discarded – undo
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
+use flipbox\hubspot\transformers\DynamicModelSuccess;
 use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use flipbox\hubspot\transformers\DynamicModelSuccess;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/ContactListContacts.php 1 patch

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -8,6 +8,14 @@  discard block
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ContactListContactsBuilder;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
@@ -16,19 +24,11 @@  discard block
 block discarded – undo
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
+use flipbox\hubspot\transformers\DynamicModelSuccess;
 use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use flipbox\hubspot\transformers\DynamicModelSuccess;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/Contacts.php 1 patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -8,27 +8,27 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Create;
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Delete;
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\ReadById;
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Update;
+use Psr\SimpleCache\CacheInterface;
 use craft\base\Element;
 use craft\base\ElementInterface;
 use craft\helpers\ArrayHelper;
 use craft\helpers\Json;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ContactBuilder;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ContactCriteria;
 use flipbox\hubspot\criteria\ObjectCriteriaInterface;
 use flipbox\hubspot\fields\Objects;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\pipeline\stages\ElementAssociationStage;
+use flipbox\hubspot\transformers\DynamicModelSuccess;
 use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use flipbox\hubspot\transformers\DynamicModelSuccess;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Create;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Delete;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\ReadById;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Update;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/traits/SyncByElementTrait.php 1 patch

Doc Comments +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -31,9 +31,9 @@  discard block
 block discarded – undo
 
     /**
      * @param string $id
-     * @param ConnectionInterface|string|null $connection
-     * @param CacheInterface|string|null $cache
-     * @param TransformerCollectionInterface|array|null $transformer
+     * @param null|ConnectionInterface $connection
+     * @param null|CacheInterface $cache
+     * @param null|TransformerCollectionInterface $transformer
      * @return PipelineBuilderInterface
      */
     public abstract function rawReadPipeline(
@@ -46,9 +46,9 @@  discard block
 block discarded – undo
     /**
      * @param array $payload
      * @param string|null $identifier
-     * @param ConnectionInterface|string|null $connection
-     * @param CacheInterface|string|null $cache
-     * @param TransformerCollectionInterface|array|null $transformer
+     * @param null|ConnectionInterface $connection
+     * @param null|CacheInterface $cache
+     * @param null|TransformerCollectionInterface $transformer
      * @return PipelineBuilderInterface
      */
     public abstract function rawUpsertPipeline(
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
     /**
      * @param ElementInterface $element
      * @param Objects $field
-     * @param ConnectionInterface|string|null $connection
-     * @param CacheInterface|string|null $cache
+     * @param null|ConnectionInterface $connection
+     * @param null|CacheInterface $cache
      * @return bool
      */
     public function syncDown(
@@ -95,9 +95,9 @@  discard block
 block discarded – undo
     /**
      * @param ElementInterface $element
      * @param Objects $field
-     * @param ConnectionInterface|string|null $connection
-     * @param CacheInterface|string|null $cache
-     * @return false|string
+     * @param null|ConnectionInterface $connection
+     * @param null|CacheInterface $cache
+     * @return boolean
      */
     public function syncUp(
         ElementInterface $element,

Please login to merge, or discard this patch.

		@@ -8,6 +8,14 @@ discard block
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\Builder\RelayBuilderInterface;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
	14	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
	15	+use League\Pipeline\PipelineBuilderInterface;
	16	+use Psr\Http\Message\ResponseInterface;
	17	+use Psr\SimpleCache\CacheInterface;
	18	+use flipbox\hubspot\HubSpot;
11	19	use flipbox\hubspot\builders\CompanyContactsBuilder;
12	20	use flipbox\hubspot\builders\CompanyContactsBuilderInterface;
13	21	use flipbox\hubspot\connections\ConnectionInterface;
		@@ -16,19 +24,11 @@ discard block
		block discarded – undo
16	24	use flipbox\hubspot\helpers\CacheHelper;
17	25	use flipbox\hubspot\helpers\ConnectionHelper;
18	26	use flipbox\hubspot\helpers\TransformerHelper;
19		-use flipbox\hubspot\HubSpot;
20	27	use flipbox\hubspot\pipeline\Resource;
21	28	use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
	29	+use flipbox\hubspot\transformers\DynamicModelSuccess;
22	30	use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
23	31	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
24		-use flipbox\hubspot\transformers\DynamicModelSuccess;
25		-use Flipbox\Relay\Builder\RelayBuilderInterface;
26		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
27		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
28		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
29		-use League\Pipeline\PipelineBuilderInterface;
30		-use Psr\Http\Message\ResponseInterface;
31		-use Psr\SimpleCache\CacheInterface;
32	32	use yii\base\Component;
33	33
34	34	/**

		@@ -8,27 +8,27 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Create;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Delete;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\ReadById;
	14	+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Update;
	15	+use Psr\SimpleCache\CacheInterface;
11	16	use craft\base\Element;
12	17	use craft\base\ElementInterface;
13	18	use craft\helpers\ArrayHelper;
14	19	use craft\helpers\Json;
	20	+use flipbox\hubspot\HubSpot;
15	21	use flipbox\hubspot\builders\ContactBuilder;
16	22	use flipbox\hubspot\builders\ObjectBuilderInterface;
17	23	use flipbox\hubspot\connections\ConnectionInterface;
18	24	use flipbox\hubspot\criteria\ContactCriteria;
19	25	use flipbox\hubspot\criteria\ObjectCriteriaInterface;
20	26	use flipbox\hubspot\fields\Objects;
21		-use flipbox\hubspot\HubSpot;
22	27	use flipbox\hubspot\pipeline\Resource;
23	28	use flipbox\hubspot\pipeline\stages\ElementAssociationStage;
	29	+use flipbox\hubspot\transformers\DynamicModelSuccess;
24	30	use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
25	31	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
26		-use flipbox\hubspot\transformers\DynamicModelSuccess;
27		-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Create;
28		-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Delete;
29		-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\ReadById;
30		-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Update;
31		-use Psr\SimpleCache\CacheInterface;
32	32	use yii\base\Component;
33	33
34	34	/**

		@@ -31,9 +31,9 @@ discard block
		block discarded – undo
31	31
32	32	/**
33	33	* @param string $id
34		- * @param ConnectionInterface\|string\|null $connection
35		- * @param CacheInterface\|string\|null $cache
36		- * @param TransformerCollectionInterface\|array\|null $transformer
	34	+ * @param null\|ConnectionInterface $connection
	35	+ * @param null\|CacheInterface $cache
	36	+ * @param null\|TransformerCollectionInterface $transformer
37	37	* @return PipelineBuilderInterface
38	38	*/
39	39	public abstract function rawReadPipeline(
		@@ -46,9 +46,9 @@ discard block
		block discarded – undo
46	46	/**
47	47	* @param array $payload
48	48	* @param string\|null $identifier
49		- * @param ConnectionInterface\|string\|null $connection
50		- * @param CacheInterface\|string\|null $cache
51		- * @param TransformerCollectionInterface\|array\|null $transformer
	49	+ * @param null\|ConnectionInterface $connection
	50	+ * @param null\|CacheInterface $cache
	51	+ * @param null\|TransformerCollectionInterface $transformer
52	52	* @return PipelineBuilderInterface
53	53	*/
54	54	public abstract function rawUpsertPipeline(
		@@ -62,8 +62,8 @@ discard block
		block discarded – undo
62	62	/**
63	63	* @param ElementInterface $element
64	64	* @param Objects $field
65		- * @param ConnectionInterface\|string\|null $connection
66		- * @param CacheInterface\|string\|null $cache
	65	+ * @param null\|ConnectionInterface $connection
	66	+ * @param null\|CacheInterface $cache
67	67	* @return bool
68	68	*/
69	69	public function syncDown(
		@@ -95,9 +95,9 @@ discard block
		block discarded – undo
95	95	/**
96	96	* @param ElementInterface $element
97	97	* @param Objects $field
98		- * @param ConnectionInterface\|string\|null $connection
99		- * @param CacheInterface\|string\|null $cache
100		- * @return false\|string
	98	+ * @param null\|ConnectionInterface $connection
	99	+ * @param null\|CacheInterface $cache
	100	+ * @return boolean
101	101	*/
102	102	public function syncUp(
103	103	ElementInterface $element,

flipboxfactory / craft-hubspot

Push — develop ( 76527a...6d8075 )

Status

Category

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

Doc Comments +11 added lines, -11 removed lines patch added patch discarded remove patch