Passed
Push — master ( 3c7506...404c28 )
by Andreas
26:22
created
lib/net/nehmer/blog/handler/feed.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 
52 52
         if ($handler_id == 'feed-category-rss2') {
53 53
             // This is not a predefined category from configuration, check if site maintainer allows us to show it
54
-            if (   !in_array($args[0], $data['categories'])
54
+            if (!in_array($args[0], $data['categories'])
55 55
                 && !$this->_config->get('categories_custom_enable')) {
56 56
                 throw new midcom_error('Custom category support is disabled');
57 57
             }
Please login to merge, or discard this patch.
lib/midcom/helper/nav/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
         while ($parent = $object->get_parent()) {
337 337
             // Verify that this topic is within the current sites tree, if it is not,
338 338
             // we ignore it.
339
-            if (   is_a($parent, midcom_db_topic::class)
339
+            if (is_a($parent, midcom_db_topic::class)
340 340
                 && $this->is_node_in_tree($parent->id, $this->get_root_node())) {
341 341
                 return $parent;
342 342
             }
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
                     $entry = "<span class=\"{$current_class}\">{$entry}</span>";
391 391
                 }
392 392
             } else {
393
-                if (   !empty($data['napobject'][MIDCOM_NAV_GUID])
393
+                if (!empty($data['napobject'][MIDCOM_NAV_GUID])
394 394
                     && in_array($data['napobject'][MIDCOM_NAV_GUID], $skip_guids)) {
395 395
                     continue;
396 396
                 }
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
                     $id = "custom-{$key}";
505 505
 
506 506
                     $url = "{$prefix}{$entry[MIDCOM_NAV_URL]}";
507
-                    if (   str_starts_with($entry[MIDCOM_NAV_URL], '/')
507
+                    if (str_starts_with($entry[MIDCOM_NAV_URL], '/')
508 508
                         || preg_match('|^https?://|', $entry[MIDCOM_NAV_URL])) {
509 509
                         $url = $entry[MIDCOM_NAV_URL];
510 510
                     }
Please login to merge, or discard this patch.
lib/midcom/helper/imagepopup/handler/upload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
         $temp = array_shift($_FILES);
21 21
 
22 22
         // Verify file extension
23
-        if (   is_uploaded_file($temp['tmp_name'])
23
+        if (is_uploaded_file($temp['tmp_name'])
24 24
             && !in_array(strtolower(pathinfo($temp['name'], PATHINFO_EXTENSION)), ["gif", "jpg", "png"])) {
25 25
             throw new midcom_error('Invalid extension.');
26 26
         }
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/link/log.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
 
26 26
     public function _on_creating() : bool
27 27
     {
28
-        if (   !$this->referrer
28
+        if (!$this->referrer
29 29
             && !empty($_SERVER['HTTP_REFERER'])) {
30 30
             $this->referrer = $_SERVER['HTTP_REFERER'];
31 31
         }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/salesproject.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
             }
120 120
         }
121 121
         $profit = $value - $cost;
122
-        if (   $this->value != $value
122
+        if ($this->value != $value
123 123
             || $this->profit != $profit) {
124 124
             $this->value = $value;
125 125
             $this->profit = $value - $cost;
@@ -184,12 +184,12 @@  discard block
 block discarded – undo
184 184
 
185 185
     public function _on_updating() : bool
186 186
     {
187
-        if (   $this->state != self::STATE_ACTIVE
187
+        if ($this->state != self::STATE_ACTIVE
188 188
             && !$this->end) {
189 189
             //Not active anymore and end not set, set it to now
190 190
             $this->end = time();
191 191
         }
192
-        if (   $this->end
192
+        if ($this->end
193 193
             && $this->state == self::STATE_ACTIVE) {
194 194
             //Returned to active state, clear the end marker.
195 195
             $this->end = 0;
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/invoice/item.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
     public function _on_creating() : bool
27 27
     {
28
-        if (   $this->invoice
28
+        if ($this->invoice
29 29
             && $this->position == 0) {
30 30
             $invoice = org_openpsa_invoices_invoice_dba::get_cached($this->invoice);
31 31
             $this->position = count($invoice->get_invoice_items()) + 1;
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
             } catch (midcom_error $e) {
76 76
             }
77 77
         }
78
-        if (   $url == ''
78
+        if ($url == ''
79 79
             && $sales_url) {
80 80
             try {
81 81
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
                 $invoice = new org_openpsa_invoices_invoice_dba($this->invoice);
98 98
                 $old_sum = $invoice->sum;
99 99
                 self::update_invoice($invoice);
100
-                if (   $old_sum != $invoice->sum
100
+                if ($old_sum != $invoice->sum
101 101
                     && !empty($this->deliverable)) {
102 102
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
103 103
                     self::update_deliverable($deliverable);
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
         if ($invoiced != $deliverable->invoiced) {
137 137
             $deliverable->invoiced = $invoiced;
138
-            if (   $deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
138
+            if ($deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
139 139
                 && $deliverable->state < org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED) {
140 140
                 $deliverable->state = org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED;
141 141
             }
Please login to merge, or discard this patch.
lib/net/nemein/tag/tag.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
     public function _on_creating() : bool
42 42
     {
43
-        return (   $this->validate_tag($this->tag)
43
+        return ($this->validate_tag($this->tag)
44 44
                 && $this->_check_duplicates() == 0);
45 45
     }
46 46
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
     public function _on_updating() : bool
71 71
     {
72
-        return (   $this->validate_tag($this->tag)
72
+        return ($this->validate_tag($this->tag)
73 73
                 && $this->_check_duplicates() == 0);
74 74
     }
75 75
 
Please login to merge, or discard this patch.
lib/net/nemein/wiki/wikipage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
     public function _on_creating() : bool
30 30
     {
31
-        if (   $this->title == ''
31
+        if ($this->title == ''
32 32
             || !$this->topic) {
33 33
             // We must have wikiword and topic at this stage
34 34
             return false;
Please login to merge, or discard this patch.
src/midcom/datamanager/storage/image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
             $this->save_attachment_list();
57 57
         }
58 58
 
59
-        if (   array_intersect_key(array_flip(['description', 'title', 'score']), $this->value)
59
+        if (array_intersect_key(array_flip(['description', 'title', 'score']), $this->value)
60 60
             && $main = $this->get_main()) {
61 61
             $needs_update = false;
62 62
             if (array_key_exists('description', $this->value)) {
Please login to merge, or discard this patch.