View GitHub Repository openpsa

Schedule Inspection
Subscribe
Passed
Push — master ( 3c7506...404c28 )
by Andreas
26:22
created
Status
Category
Toggle Patches
lib/org/openpsa/sales/midcom/interfaces.php 1 patch
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,8 @@  discard block
 
 block discarded – undo
31 31 
             try {
32 32 
                 $agreement = new org_openpsa_sales_salesproject_deliverable_dba($agreement);
33 33 
                 $agreement->update_units();
34 
-            } catch (midcom_error $e) {
34 
+            }
35 
+            catch (midcom_error $e) {
35 36 
                 $e->log();
36 37 
             }
37 38 
         }
 
@@ -49,7 +50,8 @@  discard block
 
 block discarded – undo
49 50
50 51 
         try {
51 52 
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
52 
-        } catch (midcom_error $e) {
53 
+        }
54 
+        catch (midcom_error $e) {
53 55 
             $handler->print_error("Deliverable {$args['deliverable']} not found: " . midcom_connection::get_error_string());
54 56 
             return false;
55 57 
         }
 
@@ -69,7 +71,8 @@  discard block
 
 block discarded – undo
69 71 
         }
70 72 
         try {
71 73 
             $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']);
72 
-        } catch (midcom_error $e) {
74 
+        }
75 
+        catch (midcom_error $e) {
73 76 
             $handler->print_error('no deliverable with passed GUID: ' . $args['deliverable'] . ', aborting');
74 77 
             return false;
75 78 
         }
 
@@ -77,7 +80,8 @@  discard block
 
 block discarded – undo
77 80 
         //get the owner of the salesproject the deliverable belongs to
78 81 
         try {
79 82 
             $project = new org_openpsa_sales_salesproject_dba($deliverable->salesproject);
80 
-        } catch (midcom_error $e) {
83 
+        }
84 
+        catch (midcom_error $e) {
81 85 
             $handler->print_error('Failed to load salesproject: ' . $e->getMessage());
82 86 
             return false;
83 87 
         }
Please login to merge, or discard this patch.