Passed
Push — master ( d5c2c1...c38e2f )
by Andreas
17:29
created
lib/org/openpsa/contacts/handler/duplicates/person.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 
42 42
     private function load_next()
43 43
     {
44
-        $i =& $this->_request_data['loop_i'];
44
+        $i = & $this->_request_data['loop_i'];
45 45
         while ($i < 100) {
46 46
             debug_add("Loop iteration {$i}");
47 47
             $qb = new midgard_query_builder('midgard_parameter');
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
                 continue;
70 70
             }
71 71
             // Make sure we actually have enough rights to do this
72
-            if (   !$person1->can_do('midgard:update')
72
+            if (!$person1->can_do('midgard:update')
73 73
                 || !$person1->can_do('midgard:delete')
74 74
                 || !$person2->can_do('midgard:update')
75 75
                 || !$person2->can_do('midgard:delete')) {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
                 continue;
79 79
             }
80 80
             // Extra sanity check (in case of semi-successful not-duplicate mark)
81
-            if (   $person1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $person2->guid)
81
+            if ($person1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $person2->guid)
82 82
                 || $person2->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $person1->guid)) {
83 83
                 debug_add("It seems these two (#{$person1->id} and #{$person2->id}) have also marked as not duplicates, some cleanup might be a good thing", MIDCOM_LOG_WARN);
84 84
                 $i++;
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
             if ($keep == 'both') {
103 103
                 $option1->require_do('midgard:update');
104 104
                 $option2->require_do('midgard:update');
105
-                if (   $option1->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option2->guid, time())
105
+                if ($option1->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option2->guid, time())
106 106
                     && $option2->set_parameter('org.openpsa.contacts.duplicates:not_duplicate', $option1->guid, time())) {
107 107
                     // Clear the possible duplicate parameters
108 108
                     $option1->delete_parameter('org.openpsa.contacts.duplicates:possible_duplicate', $option2->guid);
@@ -120,11 +120,11 @@  discard block
 block discarded – undo
120 120
                 }
121 121
             } else {
122 122
                 if ($keep == $option1->guid) {
123
-                    $person1 =& $option1;
124
-                    $person2 =& $option2;
123
+                    $person1 = & $option1;
124
+                    $person2 = & $option2;
125 125
                 } elseif ($keep == $option2->guid) {
126
-                    $person1 =& $option2;
127
-                    $person2 =& $option1;
126
+                    $person1 = & $option2;
127
+                    $person2 = & $option1;
128 128
                 } else {
129 129
                     throw new midcom_error('Something weird happened (basically we got bogus data)');
130 130
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/handler/person/view.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -192,7 +192,8 @@
 block discarded – undo
192 192
         foreach ($this->$identifier as $member) {
193 193
             try {
194 194
                 $this->_request_data['group'] = org_openpsa_contacts_group_dba::get_cached($member->gid);
195
-            } catch (midcom_error $e) {
195
+            }
196
+            catch (midcom_error $e) {
196 197
                 $e->log();
197 198
                 continue;
198 199
             }
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/send.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     {
115 115
         $nap = new midcom_helper_nav();
116 116
         $node = $nap->get_node($nap->get_current_node());
117
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
117
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
118 118
         $this->batch_url_base_full = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
119 119
         debug_add("compose_url: {$compose_url}");
120 120
         debug_add("batch_url base: {$this->batch_url_base_full}");
Please login to merge, or discard this patch.