Passed
Push — master ( 420639...4ea9f2 )
by Andreas
11:06
created
lib/midcom/services/rcs/handler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     {
47 47
         $this->object = $this->load_object($guid);
48 48
 
49
-        if (   !midcom::get()->config->get('midcom_services_rcs_enable')
49
+        if (!midcom::get()->config->get('midcom_services_rcs_enable')
50 50
             || !$this->object->_use_rcs) {
51 51
             throw new midcom_error_notfound("Revision control not supported for " . get_class($this->object) . ".");
52 52
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
             throw new midcom_error_notfound("Revision {$args[1]} does not exist.");
258 258
         }
259 259
 
260
-        $data['preview'] = array_filter($this->backend->get_revision($revision), function ($value, $key) {
260
+        $data['preview'] = array_filter($this->backend->get_revision($revision), function($value, $key) {
261 261
             return !is_array($value)
262 262
                 && !in_array($value, ['', '0000-00-00'])
263 263
                 && midcom_services_rcs::is_field_showable($key);
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
         $this->object->require_do('midgard:update');
288 288
         // TODO: set another privilege for restoring?
289 289
 
290
-        if (   $this->backend->get_history()->version_exists($args[1])
290
+        if ($this->backend->get_history()->version_exists($args[1])
291 291
             && $this->backend->restore_to_revision($args[1])) {
292 292
             midcom::get()->uimessages->add($this->_l10n->get('midcom.admin.rcs'), sprintf($this->_l10n->get('restore to version %s successful'), $args[1]));
293 293
             return new midcom_response_relocate($this->get_object_url());
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/deleted.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
                 'purge' => true
63 63
             ]
64 64
         ]);
65
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
65
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
66 66
             && $object->can_do('midgard:update')
67 67
             && $object->_use_rcs) {
68 68
             $this->_request_data['asgard_toolbar']->add_item([
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/rcs.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
             return parent::load_object($guid);
30 30
         } catch (midcom_error_midgard $e) {
31 31
             $mgd_exception = $e->getPrevious();
32
-            if (   $mgd_exception
32
+            if ($mgd_exception
33 33
                 && $mgd_exception->getCode() == mgd_exception::OBJECT_DELETED) {
34 34
                 return $this->load_deleted($guid);
35 35
             }
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,8 @@
 block discarded – undo
27 27
     {
28 28
         try {
29 29
             return parent::load_object($guid);
30
-        } catch (midcom_error_midgard $e) {
30
+        }
31
+        catch (midcom_error_midgard $e) {
31 32
             $mgd_exception = $e->getPrevious();
32 33
             if (   $mgd_exception
33 34
                 && $mgd_exception->getCode() == mgd_exception::OBJECT_DELETED) {
Please login to merge, or discard this patch.