Passed
Push — master ( 017701...122834 )
by Andreas
28:26
created
src/midcom/datamanager/indexer/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
                     if (!empty($field->vars['value'])) {
172 172
                         //only index the first attachment for now
173 173
                         $attachment = array_shift($field->vars['value']);
174
-                        if (   !$attachment instanceof \midcom_db_attachment
174
+                        if (!$attachment instanceof \midcom_db_attachment
175 175
                             && !empty($attachment['object'])) {
176 176
                             //This is the form edit case
177 177
                             //@todo: In create case, nothing is found currently
Please login to merge, or discard this patch.
lib/midcom/helper/toolbar.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 
341 341
         $item = array_replace($defaults, $item);
342 342
 
343
-        if (   !empty($item[MIDCOM_TOOLBAR_ACCESSKEY])
343
+        if (!empty($item[MIDCOM_TOOLBAR_ACCESSKEY])
344 344
             && !array_key_exists($item[MIDCOM_TOOLBAR_ACCESSKEY], $used_access_keys)) {
345 345
             // We have valid access key, add it to help text
346 346
             $prefix = 'Alt-';
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
     private function set_url(array &$item, string $url)
366 366
     {
367 367
         $item[MIDCOM_TOOLBAR__ORIGINAL_URL] = $url;
368
-        if (   (   empty($item[MIDCOM_TOOLBAR_OPTIONS]["rel"])
368
+        if ((empty($item[MIDCOM_TOOLBAR_OPTIONS]["rel"])
369 369
                 // Some items may want to keep their links unmutilated
370 370
                 || $item[MIDCOM_TOOLBAR_OPTIONS]["rel"] != "directlink")
371 371
             && !str_starts_with($url, '/')
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
 
391 391
         if ($index == 0) {
392 392
             array_shift($this->items);
393
-        } elseif ($index == count($this->items) -1) {
393
+        } elseif ($index == count($this->items) - 1) {
394 394
             array_pop($this->items);
395 395
         } else {
396 396
             $this->items = array_merge(array_slice($this->items, 0, $index),
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
      */
514 514
     public function render() : string
515 515
     {
516
-        $visible_items = array_filter($this->items, function ($item) {
516
+        $visible_items = array_filter($this->items, function($item) {
517 517
             return !$item[MIDCOM_TOOLBAR_HIDDEN];
518 518
         });
519 519
         $this->rendered = true;
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
             // Try finding uppercase version of the accesskey first
577 577
             $accesskey = strtoupper($item[MIDCOM_TOOLBAR_ACCESSKEY]);
578 578
             $position = strpos($label, $accesskey);
579
-            if (   $position === false
579
+            if ($position === false
580 580
                 && midcom::get()->i18n->get_current_language() == 'en') {
581 581
                 // Try lowercase, too
582 582
                 $accesskey = strtolower($accesskey);
@@ -636,7 +636,7 @@  discard block
 block discarded – undo
636 636
             $attributes['title'] = $item[MIDCOM_TOOLBAR_HELPTEXT];
637 637
         }
638 638
 
639
-        if (   $item[MIDCOM_TOOLBAR_ENABLED]
639
+        if ($item[MIDCOM_TOOLBAR_ENABLED]
640 640
             && $item[MIDCOM_TOOLBAR_ACCESSKEY] !== null) {
641 641
             $attributes['class'] = 'accesskey';
642 642
             $attributes['accesskey'] = $item[MIDCOM_TOOLBAR_ACCESSKEY];
@@ -699,7 +699,7 @@  discard block
 block discarded – undo
699 699
     public function get_index_from_url(string $url) : ?int
700 700
     {
701 701
         foreach ($this->items as $i => $item) {
702
-            if (   $item[MIDCOM_TOOLBAR_URL] == $url
702
+            if ($item[MIDCOM_TOOLBAR_URL] == $url
703 703
                 || $item[MIDCOM_TOOLBAR__ORIGINAL_URL] == $url) {
704 704
                 return $i;
705 705
             }
@@ -717,7 +717,7 @@  discard block
 block discarded – undo
717 717
      *
718 718
      * @param mixed $index The integer index or URL to check
719 719
      */
720
-    protected function _check_index($index, bool $raise_error = true) :?int
720
+    protected function _check_index($index, bool $raise_error = true) : ?int
721 721
     {
722 722
         if (is_string($index)) {
723 723
             $url = $index;
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/importer/csv.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,11 +55,11 @@
 block discarded – undo
55 55
         foreach (array_filter($csv_line) as $field => $value) {
56 56
             // Process the row accordingly
57 57
             $field_matching = $this->_settings['fields'][$field];
58
-            if (   $field_matching
58
+            if ($field_matching
59 59
                 && str_contains($field_matching, ':')) {
60 60
                 [$schemadb, $schema_field] = explode(':', $field_matching);
61 61
 
62
-                if (   !array_key_exists($schemadb, $this->_schemadbs)
62
+                if (!array_key_exists($schemadb, $this->_schemadbs)
63 63
                     || !$this->_schemadbs[$schemadb]->get('default')->has_field($schema_field)) {
64 64
                     // Invalid matching, skip
65 65
                     continue;
Please login to merge, or discard this patch.