flack / openpsa

lib/net/nemein/rss/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
         }
 
         // OPML subscription list import support
-        if (   array_key_exists('net_nemein_rss_manage_opml', $_FILES)
+        if (array_key_exists('net_nemein_rss_manage_opml', $_FILES)
             && is_uploaded_file($_FILES['net_nemein_rss_manage_opml']['tmp_name'])) {
             $opml_file = $_FILES['net_nemein_rss_manage_opml']['tmp_name'];
 

src/midcom/datamanager/datamanager.php

Braces +1 added lines, -2 removed lines

@@ -210,8 +210,7 @@
     {
         $ret = [];
 
-        foreach ($this->storage as $field => $value)
-        {
+        foreach ($this->storage as $field => $value) {
             $ret[$field] = $value->get_value();
             $config = $this->schema->get_field($field);
             if (!empty($config['type_config']['allow_multiple'])) {

Spacing +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
 
     public function set_storage(midcom_core_dbaobject $storage = null, string $schemaname = null) : self
     {
-        if (   $schemaname === null
+        if ($schemaname === null
             && !empty($storage->id)) {
             $schemaname = $storage->get_parameter('midcom.helper.datamanager2', 'schema_name');
         }
@@ -164,7 +164,7 @@ 
         }
         $name = $this->get_name($name);
 
-        if (   $this->form === null
+        if ($this->form === null
             || $this->form->getName() != $name) {
             $this->build_form($this->get_builder($name));
         }
@@ -261,7 +261,7 @@ 
     {
         $ret = true;
         foreach ($this->storage as $field) {
-            if (   $field instanceof recreateable
+            if ($field instanceof recreateable
                 && !$field->recreate()) {
                 $ret = false;
             }

lib/org/openpsa/contacts/handler/group/create.php

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 
         $this->_group = new org_openpsa_contacts_group_dba();
 
-        if (   $this->_type == 'organization'
+        if ($this->_type == 'organization'
             && $this->_parent_group) {
             $this->_group->owner = $this->_parent_group->id;
         } else {

lib/org/openpsa/documents/handler/directory/create.php

Spacing +1 added lines, -1 removed lines

@@ -50,6 +50,6 @@
         $indexer = new org_openpsa_documents_midcom_indexer($this->_topic);
         $indexer->index($controller->get_datamanager());
 
-        return $controller->get_datamanager()->get_storage()->get_value()->name. "/";
+        return $controller->get_datamanager()->get_storage()->get_value()->name . "/";
     }
 }

src/midcom/datamanager/storage/dbanode.php

Braces +2 added lines, -1 removed lines

@@ -30,7 +30,8 @@
         $this->config = $config;
     }
 
-    protected function cast($value) {
+    protected function cast($value)
+    {
         if ($this->config['type'] == 'number' && !is_numeric($value)) {
             $value = (float) $value;
         }

lib/net/nemein/wiki/midcom/interfaces.php

Braces +2 added lines, -1 removed lines

@@ -30,7 +30,8 @@
             foreach ($result as $wikipage) {
                 try {
                     $datamanager->set_storage($wikipage);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log(MIDCOM_LOG_WARN);
                     continue;
                 }

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof midcom_db_article
+        if ($object instanceof midcom_db_article
             && $topic->id == $object->topic) {
             if ($object->name == 'index') {
                 return '';

lib/org/openpsa/user/handler/group/privileges.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 
         // Get the calendar root event
         if ($root_event = org_openpsa_calendar_interface::find_root_event()) {
-            $field =& $schemadb->get('default')->get_field('calendar');
+            $field = & $schemadb->get('default')->get_field('calendar');
             $field['type_config']['privilege_object'] = $root_event;
             $field['type_config']['assignee'] = 'group:' . $group->guid;
         }

lib/net/nehmer/blog/handler/archive.php

Braces +2 added lines, -1 removed lines

@@ -409,7 +409,8 @@
             foreach ($this->_articles as $article_counter => $article) {
                 try {
                     $data['datamanager']->set_storage($article);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log();
                     continue;
                 }

Spacing +4 added lines, -4 removed lines

@@ -131,8 +131,8 @@ 
         $year_data = [];
         $first_post = $this->_compute_welcome_first_post();
         $this->_request_data['first_post'] = $first_post;
-        $this->_request_data['total_count'] =& $total_count;
-        $this->_request_data['year_data'] =& $year_data;
+        $this->_request_data['total_count'] = & $total_count;
+        $this->_request_data['year_data'] = & $year_data;
         if (!$first_post) {
             return;
         }
@@ -261,7 +261,7 @@ 
         switch ($handler_id) {
             case 'archive-year-category':
                 $category = trim(strip_tags($args[1]));
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
                     $qb->add_constraint('extra1', '=', $category);
                 } else {
@@ -345,7 +345,7 @@ 
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
         }
 
-        if (   $month < 1
+        if ($month < 1
             || $month > 12) {
             throw new midcom_error_notfound("The month {$month} is not valid.");
         }

lib/net/nehmer/static/handler/view.php

Spacing +4 added lines, -4 removed lines

@@ -46,7 +46,7 @@ 
             ]);
         }
 
-        if (   $this->_article->topic === $this->_topic->id
+        if ($this->_article->topic === $this->_topic->id
             && $this->_article->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
             $buttons[] = $delete->get_button("delete/{$this->_article->guid}/");
@@ -114,7 +114,7 @@ 
         $this->_datamanager->set_storage($this->_article);
 
         $arg = $this->_article->name ?: $this->_article->guid;
-        if (   $arg != 'index'
+        if ($arg != 'index'
             && $this->_config->get('hide_navigation')) {
             $this->add_breadcrumb("{$arg}/", $this->_article->title);
         }
@@ -124,13 +124,13 @@ 
         midcom::get()->metadata->set_request_metadata($this->_article->metadata->revised, $this->_article->guid);
         $this->bind_view_to_object($this->_article, $this->_datamanager->get_schema()->get_name());
 
-        if (   $this->_config->get('indexinnav')
+        if ($this->_config->get('indexinnav')
             || $this->_config->get('autoindex')
             || $this->_article->name != 'index') {
             $this->set_active_leaf($this->_article->id);
         }
 
-        if (   $this->_config->get('folder_in_title')
+        if ($this->_config->get('folder_in_title')
             && $this->_topic->extra != $this->_article->title) {
             midcom::get()->head->set_pagetitle("{$this->_topic->extra}: {$this->_article->title}");
         } else {