flack / openpsa

src/midcom/console/command/reindex.php

Braces +2 added lines, -1 removed lines

@@ -73,7 +73,8 @@
             if ($stat instanceof midcom_services_indexer_client) {
                 try {
                     $stat->reindex();
-                } catch (RequestException $e) {
+                }
+                catch (RequestException $e) {
                     if ($e->hasResponse()) {
                         $crawler = new Crawler($e->getResponse()->getBody()->getContents());
                         $body = $crawler->filterXPath('//body')->html();

lib/midcom/helper/nav/main.php

Spacing +3 added lines, -3 removed lines

@@ -340,7 +340,7 @@ 
         while ($parent = $object->get_parent()) {
             // Verify that this topic is within the current sites tree, if it is not,
             // we ignore it.
-            if (   $parent instanceof midcom_db_topic
+            if ($parent instanceof midcom_db_topic
                 && $this->is_node_in_tree($parent->id, $this->get_root_node())) {
                 return $parent;
             }
@@ -394,7 +394,7 @@ 
                     $entry = "<span class=\"{$current_class}\">{$entry}</span>";
                 }
             } else {
-                if (   !empty($data['napobject'][MIDCOM_NAV_GUID])
+                if (!empty($data['napobject'][MIDCOM_NAV_GUID])
                     && in_array($data['napobject'][MIDCOM_NAV_GUID], $skip_guids)) {
                     continue;
                 }
@@ -508,7 +508,7 @@ 
                     $id = "custom-{$key}";
 
                     $url = "{$prefix}{$entry[MIDCOM_NAV_URL]}";
-                    if (   str_starts_with($entry[MIDCOM_NAV_URL], '/')
+                    if (str_starts_with($entry[MIDCOM_NAV_URL], '/')
                         || preg_match('|^https?://|', $entry[MIDCOM_NAV_URL])) {
                         $url = $entry[MIDCOM_NAV_URL];
                     }

lib/midcom/admin/folder/handler/move.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
     {
         $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
 
-        if (   !($this->_object instanceof midcom_db_topic)
+        if (!($this->_object instanceof midcom_db_topic)
             && !($this->_object instanceof midcom_db_article)) {
             throw new midcom_error_notfound("Moving only topics and articles is supported.");
         }
@@ -74,7 +74,7 @@ 
             $folder = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ROOTTOPIC);
         }
 
-        if (   $this->_object instanceof midcom_db_topic
+        if ($this->_object instanceof midcom_db_topic
             && $folder->up == $this->_object->id) {
             $tree_disabled = true;
         }
@@ -87,7 +87,7 @@ 
             $selected = ' checked="checked"';
         }
 
-        if (   !($this->_object instanceof midcom_db_topic)
+        if (!($this->_object instanceof midcom_db_topic)
             && $folder->component !== $this->current_folder->component) {
             // Non-topic objects may only be moved under folders of same component
             $class = 'wrong_component';

lib/org/openpsa/products/viewer.php

Spacing +3 added lines, -3 removed lines

@@ -30,11 +30,11 @@
         $object = $dm->get_storage()->get_value();
 
         $document = $indexer->new_document($dm);
-        if (   $config->get('enable_scheduling')
+        if ($config->get('enable_scheduling')
             && $object instanceof org_openpsa_products_product_dba) {
             // Check start/end for products
-            if (   $object->start > time()
-                || (   $object->end != 0
+            if ($object->start > time()
+                || ($object->end != 0
                     && $object->end < time())) {
                 // Not in market, remove from index
                 $indexer->delete($document->RI);

lib/midgard/admin/asgard/plugin.php

Spacing +2 added lines, -2 removed lines

@@ -161,7 +161,7 @@ 
 
         $parent = $object->get_parent();
 
-        if (   $object instanceof midcom_db_parameter
+        if ($object instanceof midcom_db_parameter
             && !empty($parent->guid)) {
             // Add "parameters" list to breadcrumb if we're in a param
             $breadcrumb[] = [
@@ -171,7 +171,7 @@ 
         }
 
         $i = 0;
-        while (   !empty($parent->guid)
+        while (!empty($parent->guid)
                && $i < 10) {
             $i++;
             $parent_reflector = midcom_helper_reflector::get($parent);

lib/midgard/admin/asgard/navigation.php

Spacing +14 added lines, -14 removed lines

@@ -41,7 +41,7 @@ 
         $this->_component = 'midgard.admin.asgard';
 
         $this->_object = $object;
-        $this->_request_data =& $request_data;
+        $this->_request_data = & $request_data;
 
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
 
@@ -57,7 +57,7 @@ 
             // we go through the path bottom up and show the first root type we find
             foreach (array_reverse($this->_object_path) as $node) {
                 foreach ($this->root_types as $root_type) {
-                    if (   $node instanceof $root_type
+                    if ($node instanceof $root_type
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
                         $this->expanded_root_types[] = $root_type;
                         break;
@@ -69,7 +69,7 @@ 
 
     protected function _is_collapsed(string $type, int $total) : bool
     {
-        return (   $total > $this->_config->get('max_navigation_entries')
+        return ($total > $this->_config->get('max_navigation_entries')
                 && empty($_GET['show_all_' . $type]));
     }
 
@@ -85,7 +85,7 @@ 
         foreach ($ref->get_child_classes() as $class) {
             $qb = $ref->_child_objects_type_qb($class, $object, false);
 
-            if (   !$qb
+            if (!$qb
                 || !($count = $qb->count_unchecked())) {
                 continue;
             }
@@ -131,7 +131,7 @@ 
     {
         $qb = $ref->_root_objects_qb();
 
-        if (   !$qb
+        if (!$qb
             || !($total = $qb->count_unchecked())) {
             return;
         }
@@ -209,7 +209,7 @@ 
         }
 
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
-        if (   $selected
+        if ($selected
             || $autoexpand) {
             $this->_list_child_elements($object, $level + 1);
         }
@@ -229,7 +229,7 @@ 
                 continue;
             }
 
-            if (   method_exists($class, 'navigation')
+            if (method_exists($class, 'navigation')
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
                 $this->_request_data['expanded'] = true;
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -263,13 +263,13 @@ 
         if ($this->_is_selected($object)) {
             $css_class .= ' selected';
         }
-        if (   is_object($this->_object)
-            && (   $object->guid == $this->_object->guid
-                || (   $this->_object instanceof midcom_db_parameter
+        if (is_object($this->_object)
+            && ($object->guid == $this->_object->guid
+                || ($this->_object instanceof midcom_db_parameter
                     && $object->guid == $this->_object->parentguid))) {
             $css_class .= ' current';
         }
-        if ( !$object->can_do('midgard:update')) {
+        if (!$object->can_do('midgard:update')) {
             $css_class .= ' readonly';
         }
         return $css_class;
@@ -290,7 +290,7 @@ 
         // Get the types that might have special display conditions
         // @TODO: Should this just include to the configuration selection, although it would break the consistency
         // of other similar preference sets, which simply override the global settings?
-        if (   ($selected = midgard_admin_asgard_plugin::get_preference('midgard_types'))
+        if (($selected = midgard_admin_asgard_plugin::get_preference('midgard_types'))
             && preg_match_all('/\|([a-z0-9\.\-_]+)/', $selected, $regs)) {
             $types = array_flip($regs[1]);
             if ($exclude) {
@@ -308,7 +308,7 @@ 
             }
 
             // If the regular expression has been set, check which types should be shown
-            $label_mapping = array_filter($label_mapping, function ($root_type) use ($regexp, $exclude) {
+            $label_mapping = array_filter($label_mapping, function($root_type) use ($regexp, $exclude) {
                 return preg_match($regexp, $root_type) == $exclude;
             }, ARRAY_FILTER_USE_KEY);
         }
@@ -338,7 +338,7 @@ 
          * click if nothing is expanded
          */
         $types_shown = false;
-        if (    !empty($expanded_types)
+        if (!empty($expanded_types)
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
             $this->_draw_select_navigation();
             $types_shown = true;

lib/midgard/admin/asgard/toolbar.php

Spacing +3 added lines, -3 removed lines

@@ -142,7 +142,7 @@ 
             ];
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -203,7 +203,7 @@ 
     private function get_toolbar_update_items($object) : array
     {
         $buttons = [];
-        if (   $object instanceof midcom_db_topic
+        if ($object instanceof midcom_db_topic
             && $object->component
             && $object->can_do('midcom:component_config')) {
             $buttons[] = [
@@ -241,7 +241,7 @@ 
             MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'),
         ];
 
-        if (   midcom::get()->componentloader->is_installed('midcom.helper.replicator')
+        if (midcom::get()->componentloader->is_installed('midcom.helper.replicator')
             && midcom::get()->auth->admin) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/",

lib/midgard/admin/asgard/handler/object/permissions.php

Spacing +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
         $tmp = $this->_object;
 
         $i = 0;
-        while (   !empty($tmp->guid)
+        while (!empty($tmp->guid)
                && !($tmp instanceof midcom_db_topic)
                && $i < 100) {
             // Get the parent; wishing eventually to get a topic
@@ -127,7 +127,7 @@ 
 
         $assignees = $this->load_assignees();
         $this->process_assignees($assignees, $schemadb);
-        $assignee_field =& $schemadb->get('privileges')->get_field('add_assignee');
+        $assignee_field = & $schemadb->get('privileges')->get_field('add_assignee');
 
         if (!$this->additional_assignee) {
             // Populate additional assignee selector