flack / openpsa

lib/midgard/admin/asgard/toolbar.php

Spacing +3 added lines, -3 removed lines

@@ -147,7 +147,7 @@ 
             ];
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -208,7 +208,7 @@ 
     private function get_toolbar_update_items($object) : array
     {
         $buttons = [];
-        if (   is_a($object, midcom_db_topic::class)
+        if (is_a($object, midcom_db_topic::class)
             && $object->component
             && $object->can_do('midcom:component_config')) {
             $buttons[] = [
@@ -246,7 +246,7 @@ 
             MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'),
         ];
 
-        if (   midcom::get()->componentloader->is_installed('midcom.helper.replicator')
+        if (midcom::get()->componentloader->is_installed('midcom.helper.replicator')
             && midcom::get()->auth->admin) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/",

lib/midgard/admin/asgard/schemadb.php

Spacing +7 added lines, -7 removed lines

@@ -160,7 +160,7 @@ 
 
     private function _filter_schema_fields($key) : bool
     {
-        if (   $key == 'metadata'
+        if ($key == 'metadata'
             || in_array($key, $this->_config->get('object_skip_fields'))) {
             return false;
         }
@@ -170,7 +170,7 @@ 
 
     private function _add_string_field($key, $type)
     {
-        if (   $key == 'component'
+        if ($key == 'component'
             && $type == midcom_db_topic::class) {
             $this->_add_component_dropdown($key);
             return;
@@ -248,8 +248,8 @@ 
                 $height = 30;
 
                 // Check the user preference and configuration
-                if (   midgard_admin_asgard_plugin::get_preference('tinymce_enabled')
-                    || (   midgard_admin_asgard_plugin::get_preference('tinymce_enabled') !== '0'
+                if (midgard_admin_asgard_plugin::get_preference('tinymce_enabled')
+                    || (midgard_admin_asgard_plugin::get_preference('tinymce_enabled') !== '0'
                         && $this->_config->get('tinymce_enabled'))) {
                     $widget = 'tinymce';
                 }
@@ -262,8 +262,8 @@ 
                 $height = 30;
 
                 // Check the user preference and configuration
-                if (   midgard_admin_asgard_plugin::get_preference('codemirror_enabled')
-                    || (   midgard_admin_asgard_plugin::get_preference('codemirror_enabled') !== '0'
+                if (midgard_admin_asgard_plugin::get_preference('codemirror_enabled')
+                    || (midgard_admin_asgard_plugin::get_preference('codemirror_enabled') !== '0'
                         && $this->_config->get('codemirror_enabled'))) {
                     $widget = 'codemirror';
                 }
@@ -500,7 +500,7 @@ 
         if ($score1 > $score2) {
             return 1;
         }
-        if (   $score1 < 3
+        if ($score1 < 3
             || $score1 > 6) {
             return strnatcmp($first, $second);
         }

lib/midgard/admin/asgard/navigation.php

Spacing +16 added lines, -16 removed lines

@@ -45,7 +45,7 @@ 
 
         $this->_object = $object;
         $this->get_object_path();
-        $this->_request_data =& $request_data;
+        $this->_request_data = & $request_data;
 
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
 
@@ -59,7 +59,7 @@ 
             // we go through the path bottom up and show the first root type we find
             foreach (array_reverse($this->_object_path) as $node) {
                 foreach ($this->root_types as $root_type) {
-                    if (    is_a($node, $root_type)
+                    if (is_a($node, $root_type)
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
                         $this->expanded_root_types[] = $root_type;
                         break;
@@ -99,7 +99,7 @@ 
 
     protected function _is_collapsed($type, $total) : bool
     {
-        return (   $total > $this->_config->get('max_navigation_entries')
+        return ($total > $this->_config->get('max_navigation_entries')
                 && empty($_GET['show_all_' . $type]));
     }
 
@@ -115,7 +115,7 @@ 
         foreach ($ref->get_child_classes() as $class) {
             $qb = $ref->_child_objects_type_qb($class, $object, false);
 
-            if (   !$qb
+            if (!$qb
                 || !($count = $qb->count_unchecked())) {
                 continue;
             }
@@ -163,7 +163,7 @@ 
     {
         $qb = $ref->_root_objects_qb(false);
 
-        if (   !$qb
+        if (!$qb
             || !($total = $qb->count_unchecked())) {
             return;
         }
@@ -243,7 +243,7 @@ 
         $label = html_entity_decode($label);
 
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
-        if (   $selected
+        if ($selected
             || $autoexpand) {
             $this->_list_child_elements($object, $level + 1);
         }
@@ -263,7 +263,7 @@ 
                 continue;
             }
 
-            if (   method_exists($class, 'navigation')
+            if (method_exists($class, 'navigation')
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
                 $this->_request_data['expanded'] = true;
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -297,13 +297,13 @@ 
         if ($this->_is_selected($object)) {
             $css_class .= ' selected';
         }
-        if (   is_object($this->_object)
-            && (   $object->guid == $this->_object->guid
-                || (   is_a($this->_object, midcom_db_parameter::class)
+        if (is_object($this->_object)
+            && ($object->guid == $this->_object->guid
+                || (is_a($this->_object, midcom_db_parameter::class)
                     && $object->guid == $this->_object->parentguid))) {
             $css_class .= ' current';
         }
-        if ( !$object->can_do('midgard:update')) {
+        if (!$object->can_do('midgard:update')) {
             $css_class .= ' readonly';
         }
     }
@@ -319,7 +319,7 @@ 
         $types = [];
 
         // Get the types that might have special display conditions
-        if (   $this->_config->get('midgard_types')
+        if ($this->_config->get('midgard_types')
             && preg_match_all('/\|([a-z0-9\.\-_]+)/', $this->_config->get('midgard_types'), $regs)) {
             $types = $regs[1];
         }
@@ -327,7 +327,7 @@ 
         // Override with user selected
         // @TODO: Should this just include to the configuration selection, although it would break the consistency
         // of other similar preference sets, which simply override the global settings?
-        if (   midgard_admin_asgard_plugin::get_preference('midgard_types')
+        if (midgard_admin_asgard_plugin::get_preference('midgard_types')
             && preg_match_all('/\|([a-z0-9\.\-_]+)/', midgard_admin_asgard_plugin::get_preference('midgard_types'), $regs)) {
             $types = $regs[1];
         }
@@ -359,7 +359,7 @@ 
         $label_mapping = [];
         foreach ($types as $root_type) {
             // If the regular expression has been set, check which types should be shown
-            if (   $regexp !== '//'
+            if ($regexp !== '//'
                 && (boolean) preg_match($regexp, $root_type) == $exclude) {
                 continue;
             }
@@ -394,7 +394,7 @@ 
          * click if nothing is expanded
          */
         $types_shown = false;
-        if (    !empty($expanded_types)
+        if (!empty($expanded_types)
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
             $this->_draw_select_navigation();
             $types_shown = true;
@@ -433,7 +433,7 @@ 
             echo "    <li class=\"mgdschema-type\">";
 
             $dbaclass = midcom::get()->dbclassloader->get_midcom_class_name_for_mgdschema_object($type);
-            if (   $dbaclass
+            if ($dbaclass
                 && class_exists($dbaclass)) {
                 $object = new $dbaclass;
             } else {