Passed
Push — master ( f9bafc...486dd4 )
by Andreas
21:31
created
lib/midgard/admin/asgard/navigation.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         $this->_component = 'midgard.admin.asgard';
42 42
 
43 43
         $this->_object = $object;
44
-        $this->_request_data =& $request_data;
44
+        $this->_request_data = & $request_data;
45 45
 
46 46
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
47 47
 
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
             // we go through the path bottom up and show the first root type we find
58 58
             foreach (array_reverse($this->_object_path) as $node) {
59 59
                 foreach ($this->root_types as $root_type) {
60
-                    if (   is_a($node, $root_type)
60
+                    if (is_a($node, $root_type)
61 61
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
62 62
                         $this->expanded_root_types[] = $root_type;
63 63
                         break;
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
     protected function _is_collapsed(string $type, int $total) : bool
71 71
     {
72
-        return (   $total > $this->_config->get('max_navigation_entries')
72
+        return ($total > $this->_config->get('max_navigation_entries')
73 73
                 && empty($_GET['show_all_' . $type]));
74 74
     }
75 75
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         foreach ($ref->get_child_classes() as $class) {
86 86
             $qb = $ref->_child_objects_type_qb($class, $object, false);
87 87
 
88
-            if (   !$qb
88
+            if (!$qb
89 89
                 || !($count = $qb->count_unchecked())) {
90 90
                 continue;
91 91
             }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     {
132 132
         $qb = $ref->_root_objects_qb();
133 133
 
134
-        if (   !$qb
134
+        if (!$qb
135 135
             || !($total = $qb->count_unchecked())) {
136 136
             return;
137 137
         }
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
         }
210 210
 
211 211
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
212
-        if (   $selected
212
+        if ($selected
213 213
             || $autoexpand) {
214 214
             $this->_list_child_elements($object, $level + 1);
215 215
         }
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
                 continue;
230 230
             }
231 231
 
232
-            if (   method_exists($class, 'navigation')
232
+            if (method_exists($class, 'navigation')
233 233
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
234 234
                 $this->_request_data['expanded'] = true;
235 235
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -263,13 +263,13 @@  discard block
 block discarded – undo
263 263
         if ($this->_is_selected($object)) {
264 264
             $css_class .= ' selected';
265 265
         }
266
-        if (   is_object($this->_object)
267
-            && (   $object->guid == $this->_object->guid
268
-                || (   is_a($this->_object, midcom_db_parameter::class)
266
+        if (is_object($this->_object)
267
+            && ($object->guid == $this->_object->guid
268
+                || (is_a($this->_object, midcom_db_parameter::class)
269 269
                     && $object->guid == $this->_object->parentguid))) {
270 270
             $css_class .= ' current';
271 271
         }
272
-        if ( !$object->can_do('midgard:update')) {
272
+        if (!$object->can_do('midgard:update')) {
273 273
             $css_class .= ' readonly';
274 274
         }
275 275
         return $css_class;
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         // Get the types that might have special display conditions
291 291
         // @TODO: Should this just include to the configuration selection, although it would break the consistency
292 292
         // of other similar preference sets, which simply override the global settings?
293
-        if (   ($selected = midgard_admin_asgard_plugin::get_preference('midgard_types'))
293
+        if (($selected = midgard_admin_asgard_plugin::get_preference('midgard_types'))
294 294
             && preg_match_all('/\|([a-z0-9\.\-_]+)/', $selected, $regs)) {
295 295
             $types = array_flip($regs[1]);
296 296
             if ($exclude) {
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
             }
309 309
 
310 310
             // If the regular expression has been set, check which types should be shown
311
-            $label_mapping = array_filter($label_mapping, function ($root_type) use ($regexp, $exclude) {
311
+            $label_mapping = array_filter($label_mapping, function($root_type) use ($regexp, $exclude) {
312 312
                 return preg_match($regexp, $root_type) == $exclude;
313 313
             }, ARRAY_FILTER_USE_KEY);
314 314
         }
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
          * click if nothing is expanded
339 339
          */
340 340
         $types_shown = false;
341
-        if (    !empty($expanded_types)
341
+        if (!empty($expanded_types)
342 342
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
343 343
             $this->_draw_select_navigation();
344 344
             $types_shown = true;
Please login to merge, or discard this patch.