flack / midgard-portable

api/midgard/collector.php

Doc Comments +3 added lines

@@ -25,6 +25,9 @@
 
     private $value_properties = array();
 
+    /**
+     * @param string $class
+     */
     function __construct($class, $field, $value)
     {
         parent::__construct($class);

Spacing +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   strpos($property, ".") !== false
+        if (strpos($property, ".") !== false
             && !(strpos($property, "metadata") === 0))
         {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
@@ -154,7 +154,7 @@ 
      */
     public function get($key)
     {
-        if (   !$this->_has_results()
+        if (!$this->_has_results()
             || !isset($this->_results[$key]))
         {
             return false;

api/midgard/connection.php

Doc Comments +3 added lines

@@ -37,6 +37,9 @@
         //??
     }
 
+    /**
+     * @return integer
+     */
     public static function get_instance()
     {
         if (self::$instance === null)

api/midgard/object/class.php

Doc Comments +3 added lines

@@ -106,6 +106,9 @@
         return true;
     }
 
+    /**
+     * @param string $guid
+     */
     public static function get_object_by_guid($guid)
     {
         if (!mgd_is_guid($guid))

api/midgard/query/builder.php

Doc Comments +3 added lines

@@ -22,6 +22,9 @@
         }
     }
 
+    /**
+     * @param string $operator
+     */
     public function add_constraint($name, $operator, $value)
     {
         try

api/midgard/replicator.php

Doc Comments +11 added lines, -2 removed lines

@@ -274,7 +274,7 @@ 
     }
 
     /**
-     * @return boolean Indicating success
+     * @return boolean|null Indicating success
      */
     public static function import_from_xml($xml, $force = false)
     {
@@ -302,6 +302,9 @@ 
         $blob->write_content($blob->content);
     }
 
+    /**
+     * @return string|null
+     */
     private static function resolve_link_id(ClassMetadata $cm, dbobject $object, $name)
     {
         if ($object->$name == 0)
@@ -387,7 +390,7 @@ 
      *
      * @param SimpleXMLElement $node
      * @param boolean $force
-     * @return dbobject
+     * @return blob
      */
     private static function blob_from_xml(SimpleXMLElement $node, $force)
     {
@@ -398,6 +401,9 @@ 
         return $blob;
     }
 
+    /**
+     * @param string $guid
+     */
     private static function get_object_action($guid)
     {
         $result = connection::get_em()
@@ -425,6 +431,9 @@ 
         }
     }
 
+    /**
+     * @return string|null
+     */
     private static function convert_value($value)
     {
         if ($value instanceof midgard_datetime)

Spacing +3 added lines, -3 removed lines

@@ -201,19 +201,19 @@
                 break;
         }
 
-        if (   $dbobject->id > 0
+        if ($dbobject->id > 0
             && $dbobject->metadata->revised >= $object->metadata->revised) {
             midgard_connection::get_instance()->set_error(exception::OBJECT_IMPORTED);
             return false;
         }
 
-        if (   $dbobject->metadata->deleted
+        if ($dbobject->metadata->deleted
             && !$object->metadata->deleted) {
             if (!midgard_object_class::undelete($dbobject->guid)) {
                 return false;
             }
             $dbobject->metadata_deleted = false;
-        } elseif (   !$dbobject->metadata->deleted
+        } elseif (!$dbobject->metadata->deleted
                  && $object->metadata->deleted) {
             return $dbobject->delete();
         }

api/midgard/storage.php

Doc Comments +8 added lines

@@ -61,6 +61,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $classname
+     */
     public static function create_class_storage($classname)
     {
         $em = connection::get_em();
@@ -95,6 +98,11 @@ 
         $generator->generateProxyClass($cm, $filename);
     }
 
+    /**
+     * @param Doctrine\ORM\EntityManagerInterface $em
+     *
+     * @return ClassMetadata
+     */
     private static function get_cm($em, $classname)
     {
         if (!class_exists($classname))

src/api/blob.php

Doc Comments +3 added lines

@@ -31,6 +31,9 @@
         return null;
     }
 
+    /**
+     * @param string $content
+     */
     public function write_content($content)
     {
         return file_put_contents($this->get_path(), $content) !== false;

src/api/config.php

Doc Comments +6 added lines

@@ -30,6 +30,9 @@ 
     public $cachedir = '/var/cache/midgard2';
     public $gdathreads = false;
 
+    /**
+     * @param string $path
+     */
     public function read_file_at_path($path)
     {
         if (   !file_exists($path)
@@ -136,6 +139,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $key
+     */
     private function convert_to_storage($key, $value)
     {
         if (is_bool($value))

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 
     public function read_file_at_path($path)
     {
-        if (   !file_exists($path)
+        if (!file_exists($path)
             || !is_readable($path)) {
             return false;
         }
@@ -145,7 +145,7 @@ 
         $subdirs = array(0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 'A', 'B', 'C', 'D', 'E', 'F');
         foreach ($subdirs as $dir) {
             foreach ($subdirs as $subdir) {
-                if (   !is_dir($this->blobdir . '/' . $dir . '/' . $subdir)
+                if (!is_dir($this->blobdir . '/' . $dir . '/' . $subdir)
                     && !mkdir($this->blobdir . '/' . $dir . '/' . $subdir, 0777, true)) {
                     return false;
                 }

src/query.php

Doc Comments +6 added lines

@@ -239,6 +239,9 @@ 
         }
     }
 
+    /**
+     * @param string $targetclass
+     */
     protected function add_collection_join($current_table, $targetclass)
     {
         if (!array_key_exists($targetclass, $this->join_tables))
@@ -250,6 +253,9 @@ 
         return $this->join_tables[$targetclass];
     }
 
+    /**
+     * @param \midgard_reflection_property $mrp
+     */
     protected function add_join($current_table, $mrp, $property)
     {
         $targetclass = $mrp->get_link_name($property);

Spacing +6 added lines, -6 removed lines

@@ -95,7 +95,7 @@ 
 
             $value = (array) $value;
             $value = array_merge($value, $this->get_child_ids($mapping['targetEntity'], $parentfield, $value));
-        } elseif (   $operator === 'IN'
+        } elseif ($operator === 'IN'
                  || $operator === 'NOT IN') {
             $value = array_values($value);
         } elseif (!in_array($operator, array('=', '>', '<', '<>', '<=', '>=', 'LIKE', 'NOT LIKE'))) {
@@ -254,14 +254,14 @@ 
             $parts = explode('.', $name);
             $column = array_pop($parts);
             foreach ($parts as $part) {
-                if (   $part === 'parameter'
+                if ($part === 'parameter'
                     || $part === 'attachment') {
                     $targetclass = 'midgard_' . $part;
                     $current_table = $this->add_collection_join($current_table, $targetclass);
                 } else {
                     $mrp = new \midgard_reflection_property($targetclass);
 
-                    if (   !$mrp->is_link($part)
+                    if (!$mrp->is_link($part)
                         && !$mrp->is_special_link($part)) {
                         throw exception::ok();
                     }
@@ -278,7 +278,7 @@ 
             $column = $cm->midgard['field_aliases'][$column];
         }
 
-        if (   !$cm->hasField($column)
+        if (!$cm->hasField($column)
             && !$cm->hasAssociation($column)) {
             throw exception::ok();
         }
@@ -295,12 +295,12 @@ 
         $parsed = $this->parse_constraint_name($name);
         $expression = $operator . ' ?' . $this->parameters;
 
-        if (   $operator === 'IN'
+        if ($operator === 'IN'
             || $operator === 'NOT IN') {
             $expression = $operator . '( ?' . $this->parameters . ')';
         }
 
-        if (   $value === 0
+        if ($value === 0
             || $value === null
             || is_array($value)) {
             $cm = connection::get_em()->getClassMetadata($parsed['targetclass']);