flack / midgard-portable

src/storage/connection.php

Spacing +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
             $midgard = midgard_connection::get_instance();
             if ($midgard->config->logfilename) {
                 $logdir = dirname($midgard->config->logfilename);
-                if (   !is_dir($logdir)
+                if (!is_dir($logdir)
                     && !mkdir($logdir, 0777, true)) {
                     throw exception::user_data('Log directory could not be created');
                 }

src/command/schema.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 
         $mgd_config = midgard_connection::get_instance()->config;
         $mgdschema_file = $mgd_config->vardir . '/mgdschema_classes.php';
-        if (   file_exists($mgdschema_file)
+        if (file_exists($mgdschema_file)
             && !unlink($mgdschema_file)) {
             throw new \RuntimeException('Could not unlink ' . $mgdschema_file);
         }
@@ -72,7 +72,7 @@ 
         $cms = $em->getMetadataFactory()->getAllMetadata();
 
         // create storage
-        if (    !midgard_storage::create_base_storage()
+        if (!midgard_storage::create_base_storage()
              && midgard_connection::get_instance()->get_error_string() != 'MGD_ERR_OK') {
             throw new \Exception("Failed to create base database structures" . midgard_connection::get_instance()->get_error_string());
         }

src/classgenerator.php

Indentation +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
                     break;
             }
             if (   $default !== null
-                   // we need to skip working links because in this case, Doctrine expects objects as values
+                    // we need to skip working links because in this case, Doctrine expects objects as values
                 && (   !$property->link
                     || $this->manager->resolve_targetclass($property) === false)) {
                 $line .= ' = ' . $default;

Spacing +7 added lines, -7 removed lines

@@ -68,8 +68,8 @@ 
         }
 
         $types = $this->manager->get_types();
-        uasort($types, function ($a, $b) {
-            if (   !empty($a->extends)
+        uasort($types, function($a, $b) {
+            if (!empty($a->extends)
                 && !empty($b->extends)) {
                 return strnatcmp($a->extends, $b->extends);
             }
@@ -112,7 +112,7 @@ 
         $prefix = $this->get_class_prefix($namespace);
 
         foreach ($this->manager->get_types() as $type) {
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($type->name)) {
                 $this->add_line('class_alias( "' . $prefix . $type->name . '", "' . $type->name . '");');
             }
@@ -120,7 +120,7 @@ 
 
         foreach ($this->manager->get_inherited_mapping() as $child => $parent) {
             $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $prefix . $child . '");');
-            if (   $prefix !== ''
+            if ($prefix !== ''
                 && !class_exists($child)) {
                 $this->add_line('class_alias( "' . $prefix . $parent . '", "' . $child . '");');
             }
@@ -181,9 +181,9 @@ 
                     $objects[$name] = 'new midgard_datetime("0001-01-01 00:00:00")';
                     break;
             }
-            if (   $default !== null
+            if ($default !== null
                    // we need to skip working links because in this case, Doctrine expects objects as values
-                && (   !$property->link
+                && (!$property->link
                     || $this->manager->resolve_targetclass($property) === false)) {
                 $line .= ' = ' . $default;
             }
@@ -243,7 +243,7 @@ 
         $this->write_annotations($type);
         $this->add_line('class ' . $type->name . ' extends ' . $type->extends);
         $mixins = $type->get_mixins();
-        $interfaces = array_filter(array_map(function ($name) {
+        $interfaces = array_filter(array_map(function($name) {
             if (interface_exists('\\midgard\\portable\\storage\\interfaces\\' . $name)) {
                 return '\\midgard\\portable\\storage\\interfaces\\' . $name;
             }

src/mgdschema/type.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
         } else {
             if ($property->parentfield) {
                 $this->parentfield = $property->name;
-                if (   empty($this->parent)
+                if (empty($this->parent)
                     && $property->link) {
                     $this->parent = $property->link['target'];
                 }

api/midgard/replicator.php

Spacing +3 added lines, -3 removed lines

@@ -201,19 +201,19 @@
                 break;
         }
 
-        if (   $dbobject->id > 0
+        if ($dbobject->id > 0
             && $dbobject->metadata->revised->format('U') >= $object->metadata->revised->format('U')) {
             midgard_connection::get_instance()->set_error(exception::OBJECT_IMPORTED);
             return false;
         }
 
-        if (   $dbobject->metadata->deleted
+        if ($dbobject->metadata->deleted
             && !$object->metadata->deleted) {
             if (!midgard_object_class::undelete($dbobject->guid)) {
                 return false;
             }
             $dbobject->metadata_deleted = false;
-        } elseif (   !$dbobject->metadata->deleted
+        } elseif (!$dbobject->metadata->deleted
                  && $object->metadata->deleted) {
             return $dbobject->delete();
         }

src/query.php

Spacing +3 added lines, -3 removed lines

@@ -260,7 +260,7 @@ 
                 } else {
                     $mrp = new \midgard_reflection_property($targetclass);
 
-                    if (   !$mrp->is_link($part)
+                    if (!$mrp->is_link($part)
                         && !$mrp->is_special_link($part)) {
                         throw exception::ok();
                     }
@@ -277,7 +277,7 @@ 
             $column = $cm->midgard['field_aliases'][$column];
         }
 
-        if (   !$cm->hasField($column)
+        if (!$cm->hasField($column)
             && !$cm->hasAssociation($column)) {
             throw exception::ok();
         }
@@ -298,7 +298,7 @@ 
             $expression = $operator . '( ?' . $this->parameters . ')';
         }
 
-        if (   $value === 0
+        if ($value === 0
             || $value === null
             || is_array($value)) {
             $cm = connection::get_em()->getClassMetadata($parsed['targetclass']);

src/mgdschema/manager.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
 
         $fqcn = $this->get_fcqn($property->link['target']);
 
-        if (   isset($this->types[$fqcn])
+        if (isset($this->types[$fqcn])
             || $property->link['target'] === $property->get_parent()->name) {
             return $property->link['target'];
         }

api/midgard/collector.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
         $parsed = $this->parse_constraint_name($property);
 
         // for properties like up.name
-        if (   strpos($property, ".") !== false
+        if (strpos($property, ".") !== false
             && !(strpos($property, "metadata") === 0)) {
             return $parsed['name'] . " as " . str_replace(".", "_", $property);
         }

src/api/mgdobject.php

Spacing +10 added lines, -10 removed lines

@@ -78,7 +78,7 @@ 
 
     public function __get($field)
     {
-        if (   $field === 'metadata'
+        if ($field === 'metadata'
             && $this->metadata === null
             && $this instanceof metadata_interface) {
             $this->metadata = new metadata($this);
@@ -100,7 +100,7 @@ 
         foreach ($candidates as $candidate) {
             if ($this->$candidate !== null) {
                 //Proxies become stale if the object itself is detached, so we have to re-fetch
-                if (   $this->$candidate instanceof Proxy
+                if ($this->$candidate instanceof Proxy
                     && $this->$candidate->__isInitialized()) {
                     try {
                         $this->$candidate->get_by_id($this->$candidate->id);
@@ -128,7 +128,7 @@ 
         }
         // According to Doctrine documentation, proxies should be transparent, but in practice,
         // there will be problems if we don't force-load
-        if (   $entity instanceof Proxy
+        if ($entity instanceof Proxy
             && !$entity->__isInitialized()) {
             try {
                 $entity->__load();
@@ -181,7 +181,7 @@ 
             exception::duplicate();
             return false;
         }
-        if (   !$this->is_unique()
+        if (!$this->is_unique()
             || !$this->check_parent()) {
             return false;
         }
@@ -237,7 +237,7 @@ 
             midgard_connection::get_instance()->set_error(MGD_ERR_INVALID_PROPERTY_VALUE);
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;
@@ -328,7 +328,7 @@ 
     {
         $this->initialize();
 
-        if (   empty($this->cm->midgard['parentfield'])
+        if (empty($this->cm->midgard['parentfield'])
             || empty($this->cm->midgard['parent'])) {
             return true;
         }
@@ -345,7 +345,7 @@ 
         $this->initialize();
 
         foreach ($this->cm->fieldMappings as $name => $field) {
-            if (   $field['midgard:midgard_type'] == translator::TYPE_GUID
+            if ($field['midgard:midgard_type'] == translator::TYPE_GUID
                 && !empty($this->$name)
                 && !mgd_is_guid($this->$name)) {
                 exception::invalid_property_value("'" . $name . "' property's value is not a guid.");
@@ -357,7 +357,7 @@ 
 
     private function check_upfield() : bool
     {
-        if (   !empty($this->id)
+        if (!empty($this->id)
             && !empty($this->cm->midgard['upfield'])
             && $this->__get($this->cm->midgard['upfield']) === $this->id
             && $this->cm->getAssociationMapping($this->cm->midgard['upfield'])['targetEntity'] === $this->cm->getName()) {
@@ -394,7 +394,7 @@ 
             $stat = $results > 0;
         }
 
-        if (   !$stat
+        if (!$stat
             && !empty($this->cm->midgard['childtypes'])) {
             foreach ($this->cm->midgard['childtypes'] as $typename => $parentfield) {
                 $qb = connection::get_em()->createQueryBuilder();
@@ -743,7 +743,7 @@ 
             exception::not_exists();
             return false;
         }
-        if (   $check_dependencies
+        if ($check_dependencies
             && $this->has_dependents()) {
             exception::has_dependants();
             return false;