flack / midgard-portable

src/api/blob.php

Doc Comments +3 added lines

@@ -31,6 +31,9 @@
         return null;
     }
 
+    /**
+     * @param string $content
+     */
     public function write_content($content)
     {
         return file_put_contents($this->get_path(), $content) !== false;

src/storage/connection.php

Spacing +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
             $midgard = midgard_connection::get_instance();
             if ($midgard->config->logfilename) {
                 $logdir = dirname($midgard->config->logfilename);
-                if (   !is_dir($logdir)
+                if (!is_dir($logdir)
                     && !mkdir($logdir, 0777, true)) {
                     throw exception::user_data('Log directory could not be created');
                 }

Doc Comments +4 added lines

@@ -123,6 +123,7 @@ 
 
     /**
      * Toggle autostart
+     * @param boolean $autostart
      */
     public static function set_autostart($autostart)
     {
@@ -156,6 +157,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     public static function get_parameter($name)
     {
         if (!array_key_exists($name, self::$parameters)) {

src/command/schema.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 
         $mgd_config = midgard_connection::get_instance()->config;
         $mgdschema_file = $mgd_config->vardir . '/mgdschema_classes.php';
-        if (   file_exists($mgdschema_file)
+        if (file_exists($mgdschema_file)
             && !unlink($mgdschema_file)) {
             throw new \RuntimeException('Could not unlink ' . $mgdschema_file);
         }
@@ -72,7 +72,7 @@ 
         $cms = $em->getMetadataFactory()->getAllMetadata();
 
         // create storage
-        if (    !midgard_storage::create_base_storage()
+        if (!midgard_storage::create_base_storage()
              && midgard_connection::get_instance()->get_error_string() != 'MGD_ERR_OK') {
             throw new \Exception("Failed to create base database structures" . midgard_connection::get_instance()->get_error_string());
         }

api/midgard/storage.php

Doc Comments +8 added lines

@@ -56,6 +56,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $classname
+     */
     public static function create_class_storage($classname)
     {
         $em = connection::get_em();
@@ -87,6 +90,11 @@ 
         $generator->generateProxyClass($cm, $filename);
     }
 
+    /**
+     * @param Doctrine\ORM\EntityManager $em
+     *
+     * @return ClassMetadata
+     */
     private static function get_cm($em, $classname)
     {
         if (!class_exists($classname)) {

api/midgard/connection.php

Doc Comments +3 added lines

@@ -29,6 +29,9 @@
 
     private $replication_enabled = true;
 
+    /**
+     * @return integer
+     */
     public static function get_instance()
     {
         if (self::$instance === null) {

api/midgard/object/class.php

Doc Comments +3 added lines

@@ -96,6 +96,9 @@
         return true;
     }
 
+    /**
+     * @param string $guid
+     */
     public static function get_object_by_guid($guid)
     {
         if (!mgd_is_guid($guid)) {

api/midgard/replicator.php

Doc Comments +11 added lines, -2 removed lines

@@ -240,7 +240,7 @@ 
     }
 
     /**
-     * @return boolean Indicating success
+     * @return boolean|null Indicating success
      */
     public static function import_from_xml($xml, $force = false)
     {
@@ -264,6 +264,9 @@ 
         $blob->write_content($blob->content);
     }
 
+    /**
+     * @return string|null
+     */
     private static function resolve_link_id(ClassMetadata $cm, dbobject $object, $name)
     {
         if ($object->$name == 0) {
@@ -339,7 +342,7 @@ 
      *
      * @param SimpleXMLElement $node
      * @param boolean $force
-     * @return dbobject
+     * @return blob
      */
     private static function blob_from_xml(SimpleXMLElement $node, $force)
     {
@@ -350,6 +353,9 @@ 
         return $blob;
     }
 
+    /**
+     * @param string $guid
+     */
     private static function get_object_action($guid)
     {
         $result = connection::get_em()
@@ -376,6 +382,9 @@ 
         }
     }
 
+    /**
+     * @return string|null
+     */
     private static function convert_value($value)
     {
         if ($value instanceof midgard_datetime) {

Spacing +3 added lines, -3 removed lines

@@ -201,19 +201,19 @@
                 break;
         }
 
-        if (   $dbobject->id > 0
+        if ($dbobject->id > 0
             && $dbobject->metadata->revised->format('U') >= $object->metadata->revised->format('U')) {
             midgard_connection::get_instance()->set_error(exception::OBJECT_IMPORTED);
             return false;
         }
 
-        if (   $dbobject->metadata->deleted
+        if ($dbobject->metadata->deleted
             && !$object->metadata->deleted) {
             if (!midgard_object_class::undelete($dbobject->guid)) {
                 return false;
             }
             $dbobject->metadata_deleted = false;
-        } elseif (   !$dbobject->metadata->deleted
+        } elseif (!$dbobject->metadata->deleted
                  && $object->metadata->deleted) {
             return $dbobject->delete();
         }

src/api/config.php

Doc Comments +6 added lines

@@ -30,6 +30,9 @@ 
     public $cachedir = '/var/cache/midgard2';
     public $gdathreads = false;
 
+    /**
+     * @param string $path
+     */
     public function read_file_at_path($path)
     {
         if (   !file_exists($path)
@@ -122,6 +125,9 @@ 
         return true;
     }
 
+    /**
+     * @param string $key
+     */
     private function convert_to_storage($key, $value)
     {
         if (is_bool($value)) {

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 
     public function read_file_at_path($path)
     {
-        if (   !file_exists($path)
+        if (!file_exists($path)
             || !is_readable($path)) {
             return false;
         }
@@ -145,7 +145,7 @@ 
         $subdirs = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 'A', 'B', 'C', 'D', 'E', 'F'];
         foreach ($subdirs as $dir) {
             foreach ($subdirs as $subdir) {
-                if (   !is_dir($this->blobdir . '/' . $dir . '/' . $subdir)
+                if (!is_dir($this->blobdir . '/' . $dir . '/' . $subdir)
                     && !mkdir($this->blobdir . '/' . $dir . '/' . $subdir, 0777, true)) {
                     return false;
                 }

src/query.php

Doc Comments +6 added lines

@@ -205,6 +205,9 @@ 
         }
     }
 
+    /**
+     * @param string $targetclass
+     */
     protected function add_collection_join($current_table, $targetclass)
     {
         if (!array_key_exists($targetclass, $this->join_tables)) {
@@ -215,6 +218,9 @@ 
         return $this->join_tables[$targetclass];
     }
 
+    /**
+     * @param \midgard_reflection_property $mrp
+     */
     protected function add_join($current_table, $mrp, $property)
     {
         $targetclass = $mrp->get_link_name($property);

Spacing +6 added lines, -6 removed lines

@@ -103,7 +103,7 @@ 
 
             $value = (array) $value;
             $value = array_merge($value, $this->get_child_ids($mapping['targetEntity'], $parentfield, $value));
-        } elseif (   $operator === 'IN'
+        } elseif ($operator === 'IN'
                  || $operator === 'NOT IN') {
             $value = array_values($value);
         } elseif (!in_array($operator, ['=', '>', '<', '<>', '<=', '>=', 'LIKE', 'NOT LIKE'])) {
@@ -257,14 +257,14 @@ 
             $parts = explode('.', $name);
             $column = array_pop($parts);
             foreach ($parts as $part) {
-                if (   $part === 'parameter'
+                if ($part === 'parameter'
                     || $part === 'attachment') {
                     $targetclass = 'midgard_' . $part;
                     $current_table = $this->add_collection_join($current_table, $targetclass);
                 } else {
                     $mrp = new \midgard_reflection_property($targetclass);
 
-                    if (   !$mrp->is_link($part)
+                    if (!$mrp->is_link($part)
                         && !$mrp->is_special_link($part)) {
                         throw exception::ok();
                     }
@@ -281,7 +281,7 @@ 
             $column = $cm->midgard['field_aliases'][$column];
         }
 
-        if (   !$cm->hasField($column)
+        if (!$cm->hasField($column)
             && !$cm->hasAssociation($column)) {
             throw exception::ok();
         }
@@ -298,12 +298,12 @@ 
         $parsed = $this->parse_constraint_name($name);
         $expression = $operator . ' ?' . $this->parameters;
 
-        if (   $operator === 'IN'
+        if ($operator === 'IN'
             || $operator === 'NOT IN') {
             $expression = $operator . '( ?' . $this->parameters . ')';
         }
 
-        if (   $value === 0
+        if ($value === 0
             || $value === null
             || is_array($value)) {
             $cm = connection::get_em()->getClassMetadata($parsed['targetclass']);