fjbender / magento-2

Helper/Toolkit.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
      *
      * @param  string   $sText
      * @param  string   $aSubstitutionArray
-     * @param  int|bool $iMaxLength
+     * @param  integer $iMaxLength
      * @return string
      */
     public function handleSubstituteReplacement($sText, $aSubstitutionArray, $iMaxLength = false)

Test/Unit/Controller/Onepage/RedirectTest.php

Unused Use Statements -2 removed lines

@@ -28,10 +28,8 @@
 
 use Payone\Core\Controller\Onepage\Redirect as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Checkout\Model\Session;
 use Magento\Framework\App\Action\Context;
-use Magento\Customer\Model\Session as CustomerSession;
 use Magento\Store\App\Response\Redirect as RedirectResponse;
 use Magento\Framework\App\Console\Response;
 use Magento\Framework\UrlInterface;

Test/Unit/Controller/Onepage/ReturnedTest.php

Unused Use Statements -2 removed lines

@@ -28,10 +28,8 @@
 
 use Payone\Core\Controller\Onepage\Returned as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Checkout\Model\Session;
 use Magento\Framework\App\Action\Context;
-use Magento\Customer\Model\Session as CustomerSession;
 use Magento\Store\App\Response\Redirect as RedirectResponse;
 use Magento\Framework\App\Console\Response;
 use Magento\Framework\App\ResponseInterface;

Test/Unit/Controller/Paypal/ExpressTest.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 
 use Payone\Core\Controller\Paypal\Express as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Framework\Controller\Result\Redirect;
 use Magento\Checkout\Model\Session;
 use Magento\Framework\Controller\ResultFactory;

Test/Unit/Controller/Paypal/ReturnedTest.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 
 use Payone\Core\Controller\Paypal\Returned as ClassToTest;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use Magento\Sales\Model\Order as OrderCore;
 use Magento\Framework\Controller\Result\Redirect;
 use Magento\Checkout\Model\Session;
 use Payone\Core\Model\Paypal\ReturnHandler;

Controller/Adminhtml/Config/Export/Index.php

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
                 $sXml = $this->configExport->generateConfigExportXml();
                 if ($sXml !== false) {
                     $oResultRaw->setHeader("Content-Type", "text/xml; charset=\"utf8\"", true);
-                    $oResultRaw->setHeader("Content-Disposition", "attachment; filename=\"payone_config_export" . date('Y-m-d H-i-s') . "_" . md5($sXml) . ".xml\"", true);
+                    $oResultRaw->setHeader("Content-Disposition", "attachment; filename=\"payone_config_export".date('Y-m-d H-i-s')."_".md5($sXml).".xml\"", true);
                     $oResultRaw->setContents($sXml);
                 }
             } catch (\Exception $e) {

Test/Unit/Model/Methods/BaseMethodTest.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -28,11 +28,10 @@
 
 use Magento\Payment\Model\Method\AbstractMethod;
 use Magento\Sales\Model\Order;
-use Payone\Core\Model\Methods\Paydirekt as ClassToTest;
+use Payone\Core\Model\Methods\Paydirekt;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Shop;
 use Magento\Framework\App\Config\ScopeConfigInterface;
-use Payone\Core\Model\Methods\Paydirekt;
 use Payone\Core\Model\PayoneConfig;
 use Magento\Payment\Model\Info;
 use Payone\Core\Model\Api\Request\Authorization;

Model/Api/Payolution/PrivacyDeclaration.php

Doc Comments +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
      * Get fallback template
      *
      * @param  string $sCompany
-     * @return mixed
+     * @return string
      */
     protected function getFallbackText($sCompany)
     {

Unused Use Statements -2 removed lines

@@ -26,8 +26,6 @@
 
 namespace Payone\Core\Model\Api\Payolution;
 
-use Locale;
-
 /**
  * Class for requesting the privacy declaration from payolution
  */

Model/Methods/Payolution/PayolutionBase.php

Doc Comments -1 removed lines

@@ -170,7 +170,6 @@
      * Method to trigger the Payone genericpayment request pre-check
      *
      * @param  float       $dAmount
-     * @param  string|bool $sBirthday
      * @return array
      * @throws LocalizedException
      */

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 
 use Payone\Core\Model\PayoneConfig;
 use Magento\Sales\Model\Order;
-use Magento\Payment\Model\InfoInterface;
 use Magento\Framework\Exception\LocalizedException;
 use Payone\Core\Model\Methods\PayoneMethod;
 use Magento\Framework\DataObject;