fjbender / magento-2

Block/Adminhtml/Config/Form/Field/KlarnaStoreId.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
      *
      * @param  \Magento\Backend\Block\Template\Context      $context
      * @param  \Magento\Framework\Data\Form\Element\Factory $elementFactory
-     * @param  \Payone\Core\Model\Source\TransactionStatus  $klarnaCountries
+     * @param  \Payone\Core\Model\Source\KlarnaCountry  $klarnaCountries
      * @param  array                                        $data
      * @return void
      */

Block/Onepage/Debit.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     /**
      * Returns the mandate text
      *
-     * @return string|bool
+     * @return string|false
      */
     public function getMandateText()
     {

Controller/Onepage/Redirect.php

Doc Comments -1 removed lines

@@ -43,7 +43,6 @@
      *
      * @param  \Magento\Framework\App\Action\Context $context
      * @param  \Magento\Checkout\Model\Session       $checkoutSession
-     * @param  \Magento\Framework\Url\Helper\Data    $urlHelper
      * @return void
      */
     public function __construct(

Controller/Paypal/Returned.php

Doc Comments +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
     /**
      * Redirect to payment-provider or to success page
      *
-     * @return void
+     * @return \Magento\Framework\Controller\Result\Redirect
      */
     public function execute()
     {

Helper/Api.php

Doc Comments +1 added lines

@@ -142,6 +142,7 @@
     /**
      * Generate the request url out of the params and die api url
      *
+     * @param string $sApiUrl
      * @return string
      */
     public function getRequestUrl($aParameters, $sApiUrl)

Spacing +10 added lines, -10 removed lines

@@ -129,9 +129,9 @@ 
             foreach ($aResponse as $iLinenum => $sLine) {// go through line by line
                 $iPos = strpos($sLine, "=");
                 if ($iPos > 0) {// is a "=" as delimiter existing?
-                    $aOutput[substr($sLine, 0, $iPos)] = trim(substr($sLine, $iPos+1));
+                    $aOutput[substr($sLine, 0, $iPos)] = trim(substr($sLine, $iPos + 1));
                 } elseif (!empty($sLine)) {// is line not empty?
-                    $aOutput[$iLinenum] = $sLine;// add the line unedited
+                    $aOutput[$iLinenum] = $sLine; // add the line unedited
                 }
             }
         }
@@ -171,11 +171,11 @@ 
     public function addPayoneOrderData(SalesOrder $oOrder, $aRequest, $aResponse)
     {
         if (isset($aResponse['txid'])) {// txid existing?
-            $oOrder->setPayoneTxid($aResponse['txid']);// add txid to order entity
+            $oOrder->setPayoneTxid($aResponse['txid']); // add txid to order entity
         }
-        $oOrder->setPayoneRefnr($aRequest['reference']);// add refnr to order entity
-        $oOrder->setPayoneAuthmode($aRequest['request']);// add authmode to order entity
-        $oOrder->setPayoneMode($aRequest['mode']);// add payone mode to order entity
+        $oOrder->setPayoneRefnr($aRequest['reference']); // add refnr to order entity
+        $oOrder->setPayoneAuthmode($aRequest['request']); // add authmode to order entity
+        $oOrder->setPayoneMode($aRequest['mode']); // add payone mode to order entity
         if (isset($aRequest['mandate_identification'])) {// mandate id existing in request?
             $oOrder->setPayoneMandateId($aRequest['mandate_identification']);
         } elseif (isset($aResponse['mandate_identification'])) {// mandate id existing in response?
@@ -191,11 +191,11 @@ 
      */
     public function isInvoiceDataNeeded(PayoneMethod $oPayment)
     {
-        $sType = $this->getConfigParam('request_type');// auth or preauth?
-        $blInvoiceEnabled = (bool)$this->getConfigParam('transmit_enabled', 'invoicing');// invoicing enabled?
+        $sType = $this->getConfigParam('request_type'); // auth or preauth?
+        $blInvoiceEnabled = (bool)$this->getConfigParam('transmit_enabled', 'invoicing'); // invoicing enabled?
         if ($oPayment->needsProductInfo() || ($sType == PayoneConfig::REQUEST_TYPE_AUTHORIZATION && $blInvoiceEnabled)) {
-            return true;// invoice data needed
+            return true; // invoice data needed
         }
-        return false;// invoice data not needed
+        return false; // invoice data not needed
     }
 }

Helper/Country.php

Doc Comments +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
      * Get country name by its ISO2 abbreviation
      *
      * @param  string $sCountryCode
-     * @return string|bool
+     * @return string|false
      */
     public function getCountryNameByIso2($sCountryCode)
     {

Helper/Customer.php

Doc Comments -1 removed lines

@@ -102,7 +102,6 @@
     /**
      * Get the region object for the state and country given by PayPal
      *
-     * @param  array $aResponse
      * @return Region|bool
      */
     public function getRegion($sCountry, $sState)

Helper/Order.php

Doc Comments +1 added lines, -1 removed lines

@@ -95,6 +95,7 @@ 
     /**
      * Return the order related to the given TransactionStatus
      *
+     * @param string $sTxid
      * @return SalesOrder|null
      */
     public function getOrderByTxid($sTxid)
@@ -160,7 +161,6 @@ 
      * Fill billing and shipping addresses with the needed information from the response
      *
      * @param  Address $oAddress
-     * @param  array   $aResponse
      * @return Address
      */
     public function fillSingleAddress(Address $oAddress, $sFirstname, $sLastname, $sStreet, $sCity, $sZip, $sCountry, $sState)

Spacing +2 added lines, -2 removed lines

@@ -129,8 +129,8 @@
         }
 
         if (!empty($aRates)) {// more than one shipping method existing?
-            ksort($aRates);// sort by price ascending
-            return array_shift($aRates);// return the cheapest shipping-method
+            ksort($aRates); // sort by price ascending
+            return array_shift($aRates); // return the cheapest shipping-method
         }
         return false;
     }

Helper/Toolkit.php

Doc Comments +1 added lines, -1 removed lines

@@ -181,7 +181,7 @@
      *
      * @param  double $dPrice    price of any sort
      * @param  int    $iDecimals number of digits behind the decimal point
-     * @return double
+     * @return string
      */
     public function formatNumber($dPrice, $iDecimals = 2)
     {

Spacing +3 added lines, -3 removed lines

@@ -135,7 +135,7 @@ 
         if (!empty($sText)) {
             $sText = str_replace(array_keys($aSubstitutionArray), array_values($aSubstitutionArray), $sText);
             if ($iMaxLength !== false && strlen($sText) > $iMaxLength) {
-                $sText = substr($sText, 0, $iMaxLength);// shorten text if too long
+                $sText = substr($sText, 0, $iMaxLength); // shorten text if too long
             }
             return $sText;
         }
@@ -150,7 +150,7 @@ 
      */
     public function getInvoiceAppendix(SalesOrder $oOrder)
     {
-        $sText = $this->getConfigParam('invoice_appendix', 'invoicing');// get invoice appendix from config
+        $sText = $this->getConfigParam('invoice_appendix', 'invoicing'); // get invoice appendix from config
         $aSubstitutionArray = [
             '{{order_increment_id}}' => $oOrder->getIncrementId(),
             '{{customer_id}}' => $oOrder->getCustomerId(),
@@ -168,7 +168,7 @@ 
      */
     public function getNarrativeText(SalesOrder $oOrder, PayoneMethod $oPayment)
     {
-        $sText = $this->getConfigParam($oPayment->getCode(), 'text');// get narrative text for payment from config
+        $sText = $this->getConfigParam($oPayment->getCode(), 'text'); // get narrative text for payment from config
         $aSubstitutionArray = [
             '{{order_increment_id}}' => $oOrder->getIncrementId(),
         ];