View   A
last analyzed

Complexity

Total Complexity 4

Size/Duplication

Total Lines 60
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 0
Metric Value
dl 60
loc 60
c 0
b 0
f 0
wmc 4
lcom 1
cbo 0
rs 10

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 9 9 1
A _isAllowed() 4 4 1
A execute() 11 11 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/**
4
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5
 * it under the terms of the GNU Lesser General Public License as published by
6
 * the Free Software Foundation, either version 3 of the License, or
7
 * (at your option) any later version.
8
 *
9
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
 * GNU Lesser General Public License for more details.
13
 *
14
 * You should have received a copy of the GNU Lesser General Public License
15
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16
 *
17
 * PHP version 5
18
 *
19
 * @category  Payone
20
 * @package   Payone_Magento2_Plugin
21
 * @author    FATCHIP GmbH <[email protected]>
22
 * @copyright 2003 - 2016 Payone GmbH
23
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
24
 * @link      http://www.payone.de
25
 */
26
27
namespace Payone\Core\Controller\Adminhtml\Protocol\Api;
28
29
use Magento\Backend\App\Action\Context;
30
use Magento\Backend\Model\View\Result\ForwardFactory;
31
use Magento\Framework\View\Result\PageFactory;
32
use Magento\Framework\View\Result\Page;
33
34
/**
35
 * Controller class for API-log details-page
36
 */
37 View Code Duplication
class View extends \Magento\Backend\App\Action
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
38
{
39
    /**
40
     * Result page
41
     *
42
     * @var \Magento\Framework\View\Result\PageFactory
43
     */
44
    protected $resultPageFactory;
45
46
    /**
47
     * Result forward
48
     *
49
     * @var \Magento\Backend\Model\View\Result\ForwardFactory
50
     */
51
    protected $resultForwardFactory;
52
53
    /**
54
     * Constructor
55
     *
56
     * @param \Magento\Backend\App\Action\Context               $context
57
     * @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
58
     * @param \Magento\Framework\View\Result\PageFactory        $resultPageFactory
59
     */
60
    public function __construct(
61
        Context $context,
62
        ForwardFactory $resultForwardFactory,
63
        PageFactory $resultPageFactory
64
    ) {
65
        parent::__construct($context);
66
        $this->resultPageFactory = $resultPageFactory;
67
        $this->resultForwardFactory = $resultForwardFactory;
68
    }
69
70
    /**
71
     * Return if the user has the needed rights to view this page
72
     *
73
     * @return bool
74
     */
75
    protected function _isAllowed()
76
    {
77
        return $this->_authorization->isAllowed('Payone_Core::payone_protocol_api');
78
    }
79
80
    /**
81
     * Returns result page
82
     *
83
     * @return Page
84
     */
85
    public function execute()
86
    {
87
        /** @var Page $resultPage */
88
        $resultPage = $this->resultPageFactory->create();
89
        if ($this->_isAllowed()) {
90
            $resultPage->setActiveMenu('Payone_Core::payone_protocol_api');
0 ignored issues
show
Bug introduced by
The method setActiveMenu() does not seem to exist on object<Magento\Framework\View\Result\Page>.

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
91
            $resultPage->getConfig()->getTitle()->prepend(__('Protocol - API'));
92
            $resultPage->getConfig()->getTitle()->prepend(sprintf("#%s", $this->getRequest()->getParam('id')));
93
        }
94
        return $resultPage;
95
    }
96
}
97