Code Duplication - fjbender/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 60-60 lines in 2 locations

Controller/Adminhtml/Protocol/Api/View.php 1 location


/**
 * Controller class for API-log details-page
 */
class View extends \Magento\Backend\App\Action
{
    /**
     * Result page
     *
     * @var \Magento\Framework\View\Result\PageFactory
     */
    protected $resultPageFactory;

    /**
     * Result forward
     *
     * @var \Magento\Backend\Model\View\Result\ForwardFactory
     */
    protected $resultForwardFactory;

    /**
     * Constructor
     *
     * @param \Magento\Backend\App\Action\Context               $context
     * @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
     * @param \Magento\Framework\View\Result\PageFactory        $resultPageFactory
     */
    public function __construct(
        Context $context,
        ForwardFactory $resultForwardFactory,
        PageFactory $resultPageFactory
    ) {
        parent::__construct($context);
        $this->resultPageFactory = $resultPageFactory;
        $this->resultForwardFactory = $resultForwardFactory;
    }

    /**
     * Return if the user has the needed rights to view this page
     *
     * @return bool
     */
    protected function _isAllowed()
    {
        return $this->_authorization->isAllowed('Payone_Core::payone_protocol_api');
    }

    /**
     * Returns result page
     *
     * @return Page
     */
    public function execute()
    {
        /** @var Page $resultPage */
        $resultPage = $this->resultPageFactory->create();
        if ($this->_isAllowed()) {
            $resultPage->setActiveMenu('Payone_Core::payone_protocol_api');
            $resultPage->getConfig()->getTitle()->prepend(__('Protocol - API'));
            $resultPage->getConfig()->getTitle()->prepend(sprintf("#%s", $this->getRequest()->getParam('id')));
        }
        return $resultPage;
    }
}


Controller/Adminhtml/Protocol/Transactionstatus/View.php 1 location


/**
 * Controller class for TransactionStatus details-page
 */
class View extends \Magento\Backend\App\Action
{
    /**
     * Result page factory
     *
     * @var \Magento\Framework\View\Result\PageFactory
     */
    protected $resultPageFactory;

    /**
     * Result forward factory
     *
     * @var \Magento\Backend\Model\View\Result\ForwardFactory
     */
    protected $resultForwardFactory;

    /**
     * Constructor
     *
     * @param Context        $context
     * @param ForwardFactory $resultForwardFactory
     * @param PageFactory    $resultPageFactory
     */
    public function __construct(
        Context $context,
        ForwardFactory $resultForwardFactory,
        PageFactory $resultPageFactory
    ) {
        parent::__construct($context);
        $this->resultForwardFactory = $resultForwardFactory;
        $this->resultPageFactory = $resultPageFactory;
    }

    /**
     * Return if the user has the needed rights to view this page
     *
     * @return bool
     */
    protected function _isAllowed()
    {
        return $this->_authorization->isAllowed('Payone_Core::payone_protocol_transactionstatus');
    }

    /**
     * Returns result page
     *
     * @return Page
     */
    public function execute()
    {
        /** @var Page $resultPage */
        $resultPage = $this->resultPageFactory->create();
        if ($this->_isAllowed()) {
            $resultPage->setActiveMenu('Payone_Core::payone_protocol_transactionstatus');
            $resultPage->getConfig()->getTitle()->prepend(__('Protocol - TransactionStatus'));
            $resultPage->getConfig()->getTitle()->prepend(sprintf("#%s", $this->getRequest()->getParam('id')));
        }
        return $resultPage;
    }
}


		@@ 37-96 (lines=60) @@
34		/**
35		* Controller class for API-log details-page
36		*/
37		class View extends \Magento\Backend\App\Action
38		{
39		/**
40		* Result page
41		*
42		* @var \Magento\Framework\View\Result\PageFactory
43		*/
44		protected $resultPageFactory;
45
46		/**
47		* Result forward
48		*
49		* @var \Magento\Backend\Model\View\Result\ForwardFactory
50		*/
51		protected $resultForwardFactory;
52
53		/**
54		* Constructor
55		*
56		* @param \Magento\Backend\App\Action\Context $context
57		* @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
58		* @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
59		*/
60		public function __construct(
61		Context $context,
62		ForwardFactory $resultForwardFactory,
63		PageFactory $resultPageFactory
64		) {
65		parent::__construct($context);
66		$this->resultPageFactory = $resultPageFactory;
67		$this->resultForwardFactory = $resultForwardFactory;
68		}
69
70		/**
71		* Return if the user has the needed rights to view this page
72		*
73		* @return bool
74		*/
75		protected function _isAllowed()
76		{
77		return $this->_authorization->isAllowed('Payone_Core::payone_protocol_api');
78		}
79
80		/**
81		* Returns result page
82		*
83		* @return Page
84		*/
85		public function execute()
86		{
87		/** @var Page $resultPage */
88		$resultPage = $this->resultPageFactory->create();
89		if ($this->_isAllowed()) {
90		$resultPage->setActiveMenu('Payone_Core::payone_protocol_api');
91		$resultPage->getConfig()->getTitle()->prepend(__('Protocol - API'));
92		$resultPage->getConfig()->getTitle()->prepend(sprintf("#%s", $this->getRequest()->getParam('id')));
93		}
94		return $resultPage;
95		}
96		}
97

		@@ 37-96 (lines=60) @@
34		/**
35		* Controller class for TransactionStatus details-page
36		*/
37		class View extends \Magento\Backend\App\Action
38		{
39		/**
40		* Result page factory
41		*
42		* @var \Magento\Framework\View\Result\PageFactory
43		*/
44		protected $resultPageFactory;
45
46		/**
47		* Result forward factory
48		*
49		* @var \Magento\Backend\Model\View\Result\ForwardFactory
50		*/
51		protected $resultForwardFactory;
52
53		/**
54		* Constructor
55		*
56		* @param Context $context
57		* @param ForwardFactory $resultForwardFactory
58		* @param PageFactory $resultPageFactory
59		*/
60		public function __construct(
61		Context $context,
62		ForwardFactory $resultForwardFactory,
63		PageFactory $resultPageFactory
64		) {
65		parent::__construct($context);
66		$this->resultForwardFactory = $resultForwardFactory;
67		$this->resultPageFactory = $resultPageFactory;
68		}
69
70		/**
71		* Return if the user has the needed rights to view this page
72		*
73		* @return bool
74		*/
75		protected function _isAllowed()
76		{
77		return $this->_authorization->isAllowed('Payone_Core::payone_protocol_transactionstatus');
78		}
79
80		/**
81		* Returns result page
82		*
83		* @return Page
84		*/
85		public function execute()
86		{
87		/** @var Page $resultPage */
88		$resultPage = $this->resultPageFactory->create();
89		if ($this->_isAllowed()) {
90		$resultPage->setActiveMenu('Payone_Core::payone_protocol_transactionstatus');
91		$resultPage->getConfig()->getTitle()->prepend(__('Protocol - TransactionStatus'));
92		$resultPage->getConfig()->getTitle()->prepend(sprintf("#%s", $this->getRequest()->getParam('id')));
93		}
94		return $resultPage;
95		}
96		}
97

fjbender / magento-2

Code Duplication Length = 60-60 lines in 2 locations

Controller/Adminhtml/Protocol/Api/View.php 1 location

Controller/Adminhtml/Protocol/Transactionstatus/View.php 1 location