fjbender / magento-1

lib/Payone/Api/Request/Parameter/Authorization/PersonalData.php

Doc Comments +2 added lines, -2 removed lines

@@ -105,7 +105,7 @@ 
     }
 
     /**
-     * @return string
+     * @return integer
      */
     public function getBirthday()
     {
@@ -311,7 +311,7 @@ 
     }
 
     /**
-     * @return string
+     * @return integer
      */
     public function getUserid()
     {

lib/Payone/Api/Request/Parameter/ManageMandate/PersonalData.php

Doc Comments +1 added lines, -1 removed lines

@@ -181,7 +181,7 @@
     }
 
     /**
-     * @return string
+     * @return integer
      */
     public function getUserid()
     {

lib/Payone/Api/Request/Parameter/Paydata/DataItem.php

Doc Comments -1 removed lines

@@ -40,7 +40,6 @@
     protected $data = NULL;
 
     /**
-     * @param int $key
      * @return array
      */
     public function toArray()

lib/Payone/Api/Response/Abstract.php

Doc Comments +3 added lines, -3 removed lines

@@ -224,7 +224,7 @@ 
     }
 
     /**
-     * @param $name
+     * @param string $name
      * @return null|mixed
      */
     protected function get($name)
@@ -237,7 +237,7 @@ 
 
     /**
      * @param string $name
-     * @param mixed $value
+     * @param string $value
      * @return boolean|null
      */
     protected function set($name, $value)
@@ -257,7 +257,7 @@ 
         $this->rawResponse = $rawResponse;
     }
     /**
-     * @return null
+     * @return string
      */
     public function getRawResponse()
     {

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
     
     protected function _toString($aValue)
     {
-        if($this->applyFilters) {
+        if ($this->applyFilters) {
             $result = $this->applyFilters->apply($aValue);
         } else {
             $protocolFactory     = new Payone_Protocol_Factory();

Braces +1 added lines, -2 removed lines

@@ -75,8 +75,7 @@
         foreach ($this as $key => $data) {
             if ($data === null) {
                 continue;
-            }
-            elseif ($data instanceof Payone_Protocol_Service_ApplyFilters == false) {
+            } elseif ($data instanceof Payone_Protocol_Service_ApplyFilters == false) {
                 $result[$key] = $data;
             }
         }

lib/Payone/ClientApi/Factory.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
     /**
      * @param string $key Service Key, e.g. 'payment/refund'
-     * @return Payone_Api_Service_Payment_Authorize|Payone_Api_Service_Payment_Debit|Payone_Api_Service_Payment_Preauthorize|Payone_Api_Service_Payment_Refund
+     * @return Payone_ClientApi_Service_GenerateHash|null
      * @throws Exception
      */
     public function buildService($key)

lib/Payone/Settings/Factory.php

Doc Comments +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return Payone_Settings_Service_XmlGenerate
      *
      * @throws Exception

lib/Payone/Settings/Service/XmlGenerate.php

Doc Comments +8 added lines, -4 removed lines

@@ -49,7 +49,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string @see SimpleXMLElement::asXml()
      */
     public function generate(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -74,7 +74,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string|false @see SimpleXMLElement::asXml()
      */
     public function execute(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -125,7 +125,7 @@ 
     /**
      * @param Payone_Settings_Data_ConfigFile_Shop $shopConfig
      * @param DOMElement $configXml
-     * @return string
+     * @return DOMElement
      */
     protected function mapShop(Payone_Settings_Data_ConfigFile_Shop $shopConfig, DOMElement $configXml)
     {
@@ -366,6 +366,10 @@ 
         $this->addGlobal($cleatringTypeNode, $valueClearingType);
     }
 
+    /**
+     * @param DOMElement $parent
+     * @param Payone_Settings_Data_ConfigFile_PaymentMethod_Abstract $type
+     */
     public function addGlobal($parent, $type)
     {
 
@@ -401,7 +405,7 @@ 
     /**
      * @param DOMElement $parent
      * @param $object
-     * @param $property
+     * @param string $property
      * @param bool $withCdata
      * @return DOMElement
      */

Spacing +3 added lines, -3 removed lines

@@ -453,9 +453,9 @@ 
      * @param bool $asCdata
      * @return DOMElement
      */
-    protected function appendElement( $parent, $key, $value = null, $asCdata = false)
+    protected function appendElement($parent, $key, $value = null, $asCdata = false)
     {
-        if($asCdata === true)
+        if ($asCdata === true)
         {
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
@@ -464,7 +464,7 @@ 
         else
         {
             $child = $this->dom->createElement($key);
-            if($value !== null)
+            if ($value !== null)
             {
                 $domValue = $this->dom->createTextNode($value);
                 $child->appendChild($domValue);

Braces +5 added lines, -10 removed lines

@@ -108,12 +108,10 @@ 
                     foreach ($value['attribute'] as $attributKey => $attributData) {
                         $node->addAttribute($attributKey, $attributData);
                     }
-                }
-                else {
+                } else {
                     $this->simpleXmlFromNestedArray($key, $value, $parent);
                 }
-            }
-            else {
+            } else {
                 $parent->addChild($key, $value);
             }
         }
@@ -414,8 +412,7 @@ 
             foreach ($data as $key => $value) {
                 $child = $this->appendElement($parentNode, $key, $value, $withCdata);
             }
-        }
-        else {
+        } else {
             if (isset($data)) {
                 $child = $this->appendElement($parent, $property, $data, $withCdata);
             }
@@ -436,8 +433,7 @@ 
             foreach ($value as $key => $data) {
                 $mapNode->setAttribute($key, $data);
             }
-        }
-        else {
+        } else {
             if (!empty($data)) {
                 $mapNode->setAttribute($name, $value);
             }
@@ -460,8 +456,7 @@ 
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
             $child->appendChild($cdata);
-        }
-        else
+        } else
         {
             $child = $this->dom->createElement($key);
             if($value !== null)

lib/Payone/TransactionStatus/Factory.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return Payone_TransactionStatus_Service_HandleRequest
      * @throws Exception
      */

lib/Payone/Config/Abstract.php

Braces +5 added lines, -10 removed lines

@@ -77,8 +77,7 @@ 
     {
         if (empty($data)) {
             $this->config = $this->getDefaultConfigData();
-        }
-        else {
+        } else {
             $this->config = $data;
         }
     }
@@ -127,8 +126,7 @@ 
             // Start recursion:
             return $this->set($newKey, $value, $tree[$currentKey]);
 
-        }
-        else {
+        } else {
             // Set value (can overwrite an existing value)
             $tree[$key] = $value;
             // Exit recursion, Success!
@@ -166,16 +164,13 @@ 
                 // Reassemble key, start recursion:
                 $newKey = implode(self::KEY_SEPARATOR, $explodedKey);
                 return $this->get($newKey, $newTree);
-            }
-            else {
+            } else {
                 return NULL; // Exit recursion, unsuccessful
             }
 
-        }
-        elseif (is_array($tree) and array_key_exists($key, $tree)) {
+        } elseif (is_array($tree) and array_key_exists($key, $tree)) {
             return $tree[$key]; // Exit recursion, Success!
-        }
-        else {
+        } else {
             return NULL; // Exit recursion, unsuccessful
         }
     }