familytree365 / php-gedcom

src/Writer/Indi/Fams.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer\Indi;

class Fams
{
    /**
     * @param \Gedcom\Record\Indi\Fams $attr
     * @param int                      $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\Indi\Fams &$fams, $level = 0)
    {
        $output = '';
        // NAME
        $_fams = $fams->getFams();

The method getFams() does not exist on Gedcom\Record\Indi\Fams. Since you implemented __call, consider adding a @method annotation.

        if (empty($_fams)) {
            return $output;
        }
        $output .= $level.' FAMS @'.$_fams."@\n";

Are you sure $_fams of type Gedcom\Record\Indi\Fams|mixed can be used in concatenation?

        // level up
        $level++;

        // note
        $note = $fams->getNote();

The method getNote() does not exist on Gedcom\Record\Indi\Fams. Since you implemented __call, consider adding a @method annotation.

        if (!empty($note) && count($note) > 0) {

It seems like $note can also be of type Gedcom\Record\Indi\Fams; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($note as $item) {
                $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }
}