Gedcom\Writer\Indi\Fams::convert()

Complexity

Conditions	5
Paths	3

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function convert(\Gedcom\Record\Indi\Fams &$fams, $level = 0)
    {
        $output = '';
        // NAME
        $_fams = $fams->getFams();

The method getFams() does not exist on Gedcom\Record\Indi\Fams. Since you implemented __call, consider adding a @method annotation.

        if (empty($_fams)) {
            return $output;
        }
        $output .= $level.' FAMS @'.$_fams."@\n";

Are you sure $_fams of type Gedcom\Record\Indi\Fams|mixed can be used in concatenation?

        // level up
        $level++;

        // note
        $note = $fams->getNote();

The method getNote() does not exist on Gedcom\Record\Indi\Fams. Since you implemented __call, consider adding a @method annotation.

        if (!empty($note) && count($note) > 0) {

It seems like $note can also be of type Gedcom\Record\Indi\Fams; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($note as $item) {
                $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }