Gedcom\Writer\Indi\Even\Plac::convert()

Complexity

Conditions	9
Paths	16

Size

Total Lines	39
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function convert(\Gedcom\Record\Indi\Even\Plac &$plac, $level = 0)
    {
        $output = '';

        // $plac
        $_plac = $plac->getPlac();
        if (!empty($_plac)) {
            $output .= $level.' PLAC '.$_plac."\n";
        } else {
            $output .= $level." PLAC\n";
        }

        // level up
        $level++;

        // $form
        $form = $plac->getForm();
        if (!empty($form)) {
            $output .= $level.' FORM '.$form."\n";
        }

        // $note -array
        $note = $plac->getNote();
        if ($note && count($note) > 0) {

The expression $note of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($note as $item) {
                $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                $output .= $_convert;
            }
        }
        // $sour -array
        $sour = $plac->getSour();
        if ($sour && count($sour) > 0) {

The expression $sour of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($sour as $item) {
                $_convert = \Gedcom\Writer\SourRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }