Gedcom\Writer\Indi\Even\Plac

Complexity

Total Complexity

9

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	convert()	0	39	9

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer\Indi\Even;

class Plac
{
    /**
     * @param int $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\Indi\Even\Plac &$plac, $level = 0)
    {
        $output = '';

        // $plac
        $_plac = $plac->getPlac();
        if (!empty($_plac)) {
            $output .= $level.' PLAC '.$_plac."\n";
        } else {
            $output .= $level." PLAC\n";
        }

        // level up
        $level++;

        // $form
        $form = $plac->getForm();
        if (!empty($form)) {
            $output .= $level.' FORM '.$form."\n";
        }

        // $note -array
        $note = $plac->getNote();
        if ($note && count($note) > 0) {

The expression $note of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($note as $item) {
                $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                $output .= $_convert;
            }
        }
        // $sour -array
        $sour = $plac->getSour();
        if ($sour && count($sour) > 0) {

The expression $sour of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($sour as $item) {
                $_convert = \Gedcom\Writer\SourRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }
}