Inspection of "Apply fixes from StyleCI" - familytree365/backend - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#90)

by Curtis

created 2021-04-10 14:26 UTC

Status

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -2,7 +2,7 @@  discard block
 block discarded – undo
 
 use Illuminate\Support\Str;
 
-if (! function_exists('unique_random')) {
+if (!function_exists('unique_random')) {
     /**
      * Generate a unique random string of characters
      * uses str_random() helper for generating the random string.
@@ -47,13 +47,13 @@  discard block
 block discarded – undo
             // If unique is still false at this point
             // it will just repeat all the steps until
             // it has generated a random string of characters
-        } while (! $unique);
+        } while (!$unique);
 
         return $random;
     }
 }
 
-if (! function_exists('readCSV')) {
+if (!function_exists('readCSV')) {
     function readCSV($filename = '', $delimiter = ',')
     {
         // Read the file
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
     }
 }
 
-if (! function_exists('writeCSV')) {
+if (!function_exists('writeCSV')) {
     function writeCSV($filename = '', $data = [])
     {
         $file = fopen($filename, 'w');

Please login to merge, or discard this patch.

app/Jobs/DnaMatching.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -43,19 +43,19 @@  discard block
 block discarded – undo
         foreach ($dnas as $dna) {
 //            system('/usr/bin/python3 /home/genealogia/public_html/dna.py ' . $this->var_name . ' ' . $dna->variable_name . ' ' . '/home/genealogia/public_html/storage/app/dna/'. $this->file_name . ' ' . '/home/genealogia/public_html/storage/app/dna/'. $dna->file_name);
             chdir('/var/www/api.familytree365.com/app');
-            exec('python3 dna.py '.$this->var_name.' '.$dna->variable_name.' '.$this->file_name.' '.$dna->file_name);
+            exec('python3 dna.py ' . $this->var_name . ' ' . $dna->variable_name . ' ' . $this->file_name . ' ' . $dna->file_name);
             $dm = new DM();
             $dm->user_id = $user->id;
-            $dm->image = 'shared_dna_'.$this->var_name.'_'.$dna->variable_name.'.png';
-            $dm->file1 = 'discordant_snps_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv';
-            $dm->file2 = 'shared_dna_one_chrom_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv';
+            $dm->image = 'shared_dna_' . $this->var_name . '_' . $dna->variable_name . '.png';
+            $dm->file1 = 'discordant_snps_' . $this->var_name . '_' . $dna->variable_name . '_GRCh37.csv';
+            $dm->file2 = 'shared_dna_one_chrom_' . $this->var_name . '_' . $dna->variable_name . '_GRCh37.csv';
             $dm->save();
 
-            $data = readCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file1), ',');
+            $data = readCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file1), ',');
             array_shift($data);
-            $data = writeCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file1), $data);
+            $data = writeCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file1), $data);
 
-            $data = readCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file2), ',');
+            $data = readCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file2), ',');
             array_shift($data);
 
             $temp_data = $data;
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
             $dm->largest_cm_segment = round($largest_cm, 2);
             $dm->save();
 
-            $data = writeCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file2), $data);
+            $data = writeCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file2), $data);
         }
     }
 }

Please login to merge, or discard this patch.

app/Http/Controllers/MediaObjectController.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -20,8 +20,8 @@  discard block
 block discarded – undo
         if ($request->has('searchTerm')) {
             $columnsToSearch = ['group', 'titl', 'obje_id', 'rin'];
             $search_term = json_decode($request->searchTerm)->searchTerm;
-            if (! empty($search_term)) {
-                $searchQuery = '%'.$search_term.'%';
+            if (!empty($search_term)) {
+                $searchQuery = '%' . $search_term . '%';
                 foreach ($columnsToSearch as $column) {
                     $query->orWhere($column, 'LIKE', $searchQuery);
                 }
@@ -32,8 +32,8 @@  discard block
 block discarded – undo
             $filters = get_object_vars(json_decode($request->columnFilters));
 
             foreach ($filters as $key => $value) {
-                if (! empty($value)) {
-                    $query->orWhere($key, 'like', '%'.$value.'%');
+                if (!empty($value)) {
+                    $query->orWhere($key, 'like', '%' . $value . '%');
                 }
             }
         }

Please login to merge, or discard this patch.

app/Http/Controllers/FamilyController.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -21,8 +21,8 @@  discard block
 block discarded – undo
         if ($request->has('searchTerm')) {
             $columnsToSearch = ['description', 'is_active', 'husband_id', 'wife_id', 'type_id', 'chan', 'nchi', 'rin'];
             $search_term = json_decode($request->searchTerm)->searchTerm;
-            if (! empty($search_term)) {
-                $searchQuery = '%'.$search_term.'%';
+            if (!empty($search_term)) {
+                $searchQuery = '%' . $search_term . '%';
                 foreach ($columnsToSearch as $column) {
                     $query->orWhere($column, 'LIKE', $searchQuery);
                 }
@@ -33,8 +33,8 @@  discard block
 block discarded – undo
             $filters = get_object_vars(json_decode($request->columnFilters));
 
             foreach ($filters as $key => $value) {
-                if (! empty($value)) {
-                    $query->orWhere($key, 'like', '%'.$value.'%');
+                if (!empty($value)) {
+                    $query->orWhere($key, 'like', '%' . $value . '%');
                 }
             }
         }
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
         if ($request->has('perPage')) {
             $rows = $query->paginate($request->perPage);
         }
-        if (! count($request->all())) {
+        if (!count($request->all())) {
             $rows = $query->get();
         }
 

Please login to merge, or discard this patch.

app/Http/Controllers/SourceDataController.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -19,8 +19,8 @@  discard block
 block discarded – undo
         if ($request->has('searchTerm')) {
             $columnsToSearch = ['group', 'date', 'text', 'agnc'];
             $search_term = json_decode($request->searchTerm)->searchTerm;
-            if (! empty($search_term)) {
-                $searchQuery = '%'.$search_term.'%';
+            if (!empty($search_term)) {
+                $searchQuery = '%' . $search_term . '%';
                 foreach ($columnsToSearch as $column) {
                     $query->orWhere($column, 'LIKE', $searchQuery);
                 }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
             $filters = get_object_vars(json_decode($request->columnFilters));
 
             foreach ($filters as $key => $value) {
-                if (! empty($value)) {
-                    $query->orWhere($key, 'like', '%'.$value.'%');
+                if (!empty($value)) {
+                    $query->orWhere($key, 'like', '%' . $value . '%');
                 }
             }
         }

Please login to merge, or discard this patch.

app/Http/Controllers/SourceRefEvenController.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -19,8 +19,8 @@  discard block
 block discarded – undo
         if ($request->has('searchTerm')) {
             $columnsToSearch = ['group', 'even', 'role'];
             $search_term = json_decode($request->searchTerm)->searchTerm;
-            if (! empty($search_term)) {
-                $searchQuery = '%'.$search_term.'%';
+            if (!empty($search_term)) {
+                $searchQuery = '%' . $search_term . '%';
                 foreach ($columnsToSearch as $column) {
                     $query->orWhere($column, 'LIKE', $searchQuery);
                 }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
             $filters = get_object_vars(json_decode($request->columnFilters));
 
             foreach ($filters as $key => $value) {
-                if (! empty($value)) {
-                    $query->orWhere($key, 'like', '%'.$value.'%');
+                if (!empty($value)) {
+                    $query->orWhere($key, 'like', '%' . $value . '%');
                 }
             }
         }

Please login to merge, or discard this patch.

app/Http/Controllers/EventController.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -19,8 +19,8 @@  discard block
 block discarded – undo
         if ($request->has('searchTerm')) {
             $columnsToSearch = ['name', 'email', 'phone'];
             $search_term = json_decode($request->searchTerm)->searchTerm;
-            if (! empty($search_term)) {
-                $searchQuery = '%'.$search_term.'%';
+            if (!empty($search_term)) {
+                $searchQuery = '%' . $search_term . '%';
                 foreach ($columnsToSearch as $column) {
                     $query->orWhere($column, 'LIKE', $searchQuery);
                 }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
             $filters = get_object_vars(json_decode($request->columnFilters));
 
             foreach ($filters as $key => $value) {
-                if (! empty($value)) {
-                    $query->orWhere($key, 'like', '%'.$value.'%');
+                if (!empty($value)) {
+                    $query->orWhere($key, 'like', '%' . $value . '%');
                 }
             }
         }

Please login to merge, or discard this patch.

app/Http/Controllers/RefnController.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -19,8 +19,8 @@  discard block
 block discarded – undo
         if ($request->has('searchTerm')) {
             $columnsToSearch = ['group', 'refn', 'type'];
             $search_term = json_decode($request->searchTerm)->searchTerm;
-            if (! empty($search_term)) {
-                $searchQuery = '%'.$search_term.'%';
+            if (!empty($search_term)) {
+                $searchQuery = '%' . $search_term . '%';
                 foreach ($columnsToSearch as $column) {
                     $query->orWhere($column, 'LIKE', $searchQuery);
                 }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
             $filters = get_object_vars(json_decode($request->columnFilters));
 
             foreach ($filters as $key => $value) {
-                if (! empty($value)) {
-                    $query->orWhere($key, 'like', '%'.$value.'%');
+                if (!empty($value)) {
+                    $query->orWhere($key, 'like', '%' . $value . '%');
                 }
             }
         }

Please login to merge, or discard this patch.

app/Http/Controllers/PersonSubmController.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -19,8 +19,8 @@  discard block
 block discarded – undo
         if ($request->has('searchTerm')) {
             $columnsToSearch = ['group', 'subm'];
             $search_term = json_decode($request->searchTerm)->searchTerm;
-            if (! empty($search_term)) {
-                $searchQuery = '%'.$search_term.'%';
+            if (!empty($search_term)) {
+                $searchQuery = '%' . $search_term . '%';
                 foreach ($columnsToSearch as $column) {
                     $query->orWhere($column, 'LIKE', $searchQuery);
                 }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
             $filters = get_object_vars(json_decode($request->columnFilters));
 
             foreach ($filters as $key => $value) {
-                if (! empty($value)) {
-                    $query->orWhere($key, 'like', '%'.$value.'%');
+                if (!empty($value)) {
+                    $query->orWhere($key, 'like', '%' . $value . '%');
                 }
             }
         }

Please login to merge, or discard this patch.

		@@ -2,7 +2,7 @@ discard block
		block discarded – undo
2	2
3	3	use Illuminate\Support\Str;
4	4
5		-if (! function_exists('unique_random')) {
	5	+if (!function_exists('unique_random')) {
6	6	/**
7	7	* Generate a unique random string of characters
8	8	* uses str_random() helper for generating the random string.
		@@ -47,13 +47,13 @@ discard block
		block discarded – undo
47	47	// If unique is still false at this point
48	48	// it will just repeat all the steps until
49	49	// it has generated a random string of characters
50		- } while (! $unique);
	50	+ } while (!$unique);
51	51
52	52	return $random;
53	53	}
54	54	}
55	55
56		-if (! function_exists('readCSV')) {
	56	+if (!function_exists('readCSV')) {
57	57	function readCSV($filename = '', $delimiter = ',')
58	58	{
59	59	// Read the file
		@@ -70,7 +70,7 @@ discard block
		block discarded – undo
70	70	}
71	71	}
72	72
73		-if (! function_exists('writeCSV')) {
	73	+if (!function_exists('writeCSV')) {
74	74	function writeCSV($filename = '', $data = [])
75	75	{
76	76	$file = fopen($filename, 'w');

		@@ -43,19 +43,19 @@ discard block
		block discarded – undo
43	43	foreach ($dnas as $dna) {
44	44	// system('/usr/bin/python3 /home/genealogia/public_html/dna.py ' . $this->var_name . ' ' . $dna->variable_name . ' ' . '/home/genealogia/public_html/storage/app/dna/'. $this->file_name . ' ' . '/home/genealogia/public_html/storage/app/dna/'. $dna->file_name);
45	45	chdir('/var/www/api.familytree365.com/app');
46		- exec('python3 dna.py '.$this->var_name.' '.$dna->variable_name.' '.$this->file_name.' '.$dna->file_name);
	46	+ exec('python3 dna.py ' . $this->var_name . ' ' . $dna->variable_name . ' ' . $this->file_name . ' ' . $dna->file_name);
47	47	$dm = new DM();
48	48	$dm->user_id = $user->id;
49		- $dm->image = 'shared_dna_'.$this->var_name.'_'.$dna->variable_name.'.png';
50		- $dm->file1 = 'discordant_snps_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv';
51		- $dm->file2 = 'shared_dna_one_chrom_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv';
	49	+ $dm->image = 'shared_dna_' . $this->var_name . '_' . $dna->variable_name . '.png';
	50	+ $dm->file1 = 'discordant_snps_' . $this->var_name . '_' . $dna->variable_name . '_GRCh37.csv';
	51	+ $dm->file2 = 'shared_dna_one_chrom_' . $this->var_name . '_' . $dna->variable_name . '_GRCh37.csv';
52	52	$dm->save();
53	53
54		- $data = readCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file1), ',');
	54	+ $data = readCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file1), ',');
55	55	array_shift($data);
56		- $data = writeCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file1), $data);
	56	+ $data = writeCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file1), $data);
57	57
58		- $data = readCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file2), ',');
	58	+ $data = readCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file2), ',');
59	59	array_shift($data);
60	60
61	61	$temp_data = $data;
		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	$dm->largest_cm_segment = round($largest_cm, 2);
75	75	$dm->save();
76	76
77		- $data = writeCSV(storage_path('app'.DIRECTORY_SEPARATOR.'dna'.DIRECTORY_SEPARATOR.'output'.DIRECTORY_SEPARATOR.$dm->file2), $data);
	77	+ $data = writeCSV(storage_path('app' . DIRECTORY_SEPARATOR . 'dna' . DIRECTORY_SEPARATOR . 'output' . DIRECTORY_SEPARATOR . $dm->file2), $data);
78	78	}
79	79	}
80	80	}

		@@ -20,8 +20,8 @@ discard block
		block discarded – undo
20	20	if ($request->has('searchTerm')) {
21	21	$columnsToSearch = ['group', 'titl', 'obje_id', 'rin'];
22	22	$search_term = json_decode($request->searchTerm)->searchTerm;
23		- if (! empty($search_term)) {
24		- $searchQuery = '%'.$search_term.'%';
	23	+ if (!empty($search_term)) {
	24	+ $searchQuery = '%' . $search_term . '%';
25	25	foreach ($columnsToSearch as $column) {
26	26	$query->orWhere($column, 'LIKE', $searchQuery);
27	27	}
		@@ -32,8 +32,8 @@ discard block
		block discarded – undo
32	32	$filters = get_object_vars(json_decode($request->columnFilters));
33	33
34	34	foreach ($filters as $key => $value) {
35		- if (! empty($value)) {
36		- $query->orWhere($key, 'like', '%'.$value.'%');
	35	+ if (!empty($value)) {
	36	+ $query->orWhere($key, 'like', '%' . $value . '%');
37	37	}
38	38	}
39	39	}

		@@ -21,8 +21,8 @@ discard block
		block discarded – undo
21	21	if ($request->has('searchTerm')) {
22	22	$columnsToSearch = ['description', 'is_active', 'husband_id', 'wife_id', 'type_id', 'chan', 'nchi', 'rin'];
23	23	$search_term = json_decode($request->searchTerm)->searchTerm;
24		- if (! empty($search_term)) {
25		- $searchQuery = '%'.$search_term.'%';
	24	+ if (!empty($search_term)) {
	25	+ $searchQuery = '%' . $search_term . '%';
26	26	foreach ($columnsToSearch as $column) {
27	27	$query->orWhere($column, 'LIKE', $searchQuery);
28	28	}
		@@ -33,8 +33,8 @@ discard block
		block discarded – undo
33	33	$filters = get_object_vars(json_decode($request->columnFilters));
34	34
35	35	foreach ($filters as $key => $value) {
36		- if (! empty($value)) {
37		- $query->orWhere($key, 'like', '%'.$value.'%');
	36	+ if (!empty($value)) {
	37	+ $query->orWhere($key, 'like', '%' . $value . '%');
38	38	}
39	39	}
40	40	}
		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47	if ($request->has('perPage')) {
48	48	$rows = $query->paginate($request->perPage);
49	49	}
50		- if (! count($request->all())) {
	50	+ if (!count($request->all())) {
51	51	$rows = $query->get();
52	52	}
53	53

		@@ -19,8 +19,8 @@ discard block
		block discarded – undo
19	19	if ($request->has('searchTerm')) {
20	20	$columnsToSearch = ['group', 'date', 'text', 'agnc'];
21	21	$search_term = json_decode($request->searchTerm)->searchTerm;
22		- if (! empty($search_term)) {
23		- $searchQuery = '%'.$search_term.'%';
	22	+ if (!empty($search_term)) {
	23	+ $searchQuery = '%' . $search_term . '%';
24	24	foreach ($columnsToSearch as $column) {
25	25	$query->orWhere($column, 'LIKE', $searchQuery);
26	26	}
		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	$filters = get_object_vars(json_decode($request->columnFilters));
32	32
33	33	foreach ($filters as $key => $value) {
34		- if (! empty($value)) {
35		- $query->orWhere($key, 'like', '%'.$value.'%');
	34	+ if (!empty($value)) {
	35	+ $query->orWhere($key, 'like', '%' . $value . '%');
36	36	}
37	37	}
38	38	}

familytree365 / backend

Pull Request — master (#90)

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch