CreateRequest::prepareForValidation() - Code Metrics - faithgen/testimonies - Measure and Improve Code Quality continuously with Scrutinizer

CreateRequest::prepareForValidation() A
last analyzed 2020-06-25 10:55 UTC

↳ Parent: CreateRequest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace Faithgen\Testimonies\Http\Requests;

use Faithgen\Testimonies\Testimonies;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Foundation\Http\FormRequest;

class CreateRequest extends FormRequest
{
    private $primaryRules = [
        'title' => 'required|string',
        'testimony' => 'required|string',
    ];

    /**
     * Gets the rules for a ministry with a premium subscription.
     *
     * @return array an set of premium attributes
     */
    private function getPremiumRules(): array
    {
        return array_merge($this->primaryRules, [
            'images' => 'array|max:'.Testimonies::$premiumImageCount,
            'images.*' => 'base64image',
        ]);
    }

    /**
     * Gets the rules for a ministry with a premuim+ subscription.
     *
     * @return array
     */
    private function getPremiumPlusRules(): array
    {
        return array_merge($this->getPremiumRules(), [
            'images' => 'array|max:'.Testimonies::$premiumPlusImageCount,
            'resource' => 'url',
        ]);
    }

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        $user = auth('web')->user();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        if ($user && $user->active) {
            return true;
        }

        return false;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()

    {
        $subscriptionLevel = auth()->user()->account->level;
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        if ($subscriptionLevel === 'Free') {
            return  $this->primaryRules;
        }
        if ($subscriptionLevel === 'Premium') {
            return $this->getPremiumRules();
        }

        return $this->getPremiumPlusRules();
    }

    public function failedAuthorization()
    {
        throw new AuthorizationException('You are not allowed to be posting testimonies here!');
    }

    /**
     * Converts image string array to usable string in the validation.
     *
     * @return void
     */
    public function prepareForValidation()
    {
        if (is_string($this->images)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->merge([
                'images' => json_decode($this->images, true),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ]);
        }
    }
}


1		<?php
2
3		namespace Faithgen\Testimonies\Http\Requests;
4
5		use Faithgen\Testimonies\Testimonies;
6		use Illuminate\Auth\Access\AuthorizationException;
7		use Illuminate\Foundation\Http\FormRequest;
8
9		class CreateRequest extends FormRequest
10		{
11		private $primaryRules = [
12		'title' => 'required\|string',
13		'testimony' => 'required\|string',
14		];
15
16		/**
17		* Gets the rules for a ministry with a premium subscription.
18		*
19		* @return array an set of premium attributes
20		*/
21		private function getPremiumRules(): array
22		{
23		return array_merge($this->primaryRules, [
24		'images' => 'array\|max:'.Testimonies::$premiumImageCount,
25		'images.*' => 'base64image',
26		]);
27		}
28
29		/**
30		* Gets the rules for a ministry with a premuim+ subscription.
31		*
32		* @return array
33		*/
34		private function getPremiumPlusRules(): array
35		{
36		return array_merge($this->getPremiumRules(), [
37		'images' => 'array\|max:'.Testimonies::$premiumPlusImageCount,
38		'resource' => 'url',
39		]);
40		}
41
42		/**
43		* Determine if the user is authorized to make this request.
44		*
45		* @return bool
46		*/
47		public function authorize()
48		{
49		$user = auth('web')->user();
		0 ignored issues – show Bug introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50		if ($user && $user->active) {
51		return true;
52		}
53
54		return false;
55		}
56
57		/**
58		* Get the validation rules that apply to the request.
59		*
60		* @return array
61		*/
62	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		$subscriptionLevel = auth()->user()->account->level;
		0 ignored issues – show Bug introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
65		if ($subscriptionLevel === 'Free') {
66		return $this->primaryRules;
67		}
68		if ($subscriptionLevel === 'Premium') {
69		return $this->getPremiumRules();
70		}
71
72		return $this->getPremiumPlusRules();
73		}
74
75		public function failedAuthorization()
76		{
77		throw new AuthorizationException('You are not allowed to be posting testimonies here!');
78		}
79
80		/**
81		* Converts image string array to usable string in the validation.
82		*
83		* @return void
84		*/
85		public function prepareForValidation()
86		{
87		if (is_string($this->images)) {
		0 ignored issues – show Documentation introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The property `images` does not exist on `object<Faithgen\Testimon...Requests\CreateRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
88		$this->merge([
89		'images' => json_decode($this->images, true),
		0 ignored issues – show Documentation introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The property `images` does not exist on `object<Faithgen\Testimon...Requests\CreateRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
90		]);
91		}
92		}
93		}
94

faithgen / testimonies

CreateRequest::prepareForValidation() A last analyzed 2020-06-25 10:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

CreateRequest::prepareForValidation() A
last analyzed 2020-06-25 10:55 UTC