Faithgen\Testimonies\Http\Requests\CreateRequest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	85
Duplicated Lines	10.59 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getPremiumRules()	0	7	1
A	getPremiumPlusRules()	0	7	1
A	authorize()	0	9	3
A	rules()	9	12	3
A	failedAuthorization()	0	4	1
A	prepareForValidation()	0	8	2

<?php

namespace Faithgen\Testimonies\Http\Requests;

use Faithgen\Testimonies\Testimonies;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Foundation\Http\FormRequest;

class CreateRequest extends FormRequest
{
    private $primaryRules = [
        'title' => 'required|string',
        'testimony' => 'required|string',
    ];

    /**
     * Gets the rules for a ministry with a premium subscription.
     *
     * @return array an set of premium attributes
     */
    private function getPremiumRules(): array
    {
        return array_merge($this->primaryRules, [
            'images' => 'array|max:'.Testimonies::$premiumImageCount,
            'images.*' => 'base64image',
        ]);
    }

    /**
     * Gets the rules for a ministry with a premuim+ subscription.
     *
     * @return array
     */
    private function getPremiumPlusRules(): array
    {
        return array_merge($this->getPremiumRules(), [
            'images' => 'array|max:'.Testimonies::$premiumPlusImageCount,
            'resource' => 'url',
        ]);
    }

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        $user = auth('web')->user();

The method user does only exist in Illuminate\Contracts\Auth\Guard, but not in Illuminate\Contracts\Auth\Factory.

        if ($user && $user->active) {
            return true;
        }

        return false;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()

This method seems to be duplicated in your project.

    {
        $subscriptionLevel = auth()->user()->account->level;

The method user does only exist in Illuminate\Contracts\Auth\Guard, but not in Illuminate\Contracts\Auth\Factory.

        if ($subscriptionLevel === 'Free') {
            return  $this->primaryRules;
        }
        if ($subscriptionLevel === 'Premium') {
            return $this->getPremiumRules();
        }

        return $this->getPremiumPlusRules();
    }

    public function failedAuthorization()
    {
        throw new AuthorizationException('You are not allowed to be posting testimonies here!');
    }

    /**
     * Converts image string array to usable string in the validation.
     *
     * @return void
     */
    public function prepareForValidation()
    {
        if (is_string($this->images)) {

The property images does not exist on object<Faithgen\Testimonies\Http\Requests\CreateRequest>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->merge([
                'images' => json_decode($this->images, true),

The property images does not exist on object<Faithgen\Testimonies\Http\Requests\CreateRequest>. Since you implemented __get, maybe consider adding a @property annotation.

            ]);
        }
    }
}