SavesDiscussion::getSaveRules() - Code Metrics - Inspection of "availaed storage on all apis" - faithgen/discussions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8fcc32...ae3918 )

by Innocent

created 2020-04-15 15:53 UTC

SavesDiscussion::getSaveRules() A

↳ Parent: SavesDiscussion

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	9.504
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace Faithgen\Discussions\Traits;

use Faithgen\Discussions\Services\DiscussionService;

trait SavesDiscussion
{
    /**
     * Converts image string array to usable string in the validation.
     *
     * @return void
     */
    public function prepareForValidation()
    {
        if (is_string($this->images)) {
            $this->merge([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                'images' => json_decode($this->images, true),
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ]);
        }
    }

    /**
     * Get the update rules for the given ministry level.
     *
     * @return array
     */
    protected function getSaveRules(): array
    {
        if ($discussion = app(DiscussionService::class)->getDiscussion()) {
            $currentCount = $discussion->images()->count();
        } else {
            $currentCount = 0;
        }

        return [
            'Free'        => [
                'discussion' => 'required|string',
            ],
            'Premium'     => [
                'discussion' => 'string',
                'url'        => 'url',
                'images'     => 'array|max:'.(1 - $currentCount),
                'images.*'   => 'base64image',
            ],
            'PremiumPlus' => [
                'discussion' => 'string',
                'url'        => 'url',
                'images'     => 'array|max:'.(5 - $currentCount),
                'images.*'   => 'base64image',
            ],
        ][auth()->user()->account->level];
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			namespace Faithgen\Discussions\Traits;
4
5			use Faithgen\Discussions\Services\DiscussionService;
6
7			trait SavesDiscussion
8			{
9			/**
10			* Converts image string array to usable string in the validation.
11			*
12			* @return void
13			*/
14			public function prepareForValidation()
15			{
16			if (is_string($this->images)) {
17			$this->merge([
			0 ignored issues – show Bug introduced 2020-04-15 15:54 UTC by Report Bug Copy Issue Report It seems like `merge()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18			'images' => json_decode($this->images, true),
			0 ignored issues – show Bug introduced 2020-04-15 15:54 UTC by Report Bug Copy Issue Report The property `images` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			]);
20			}
21			}
22
23			/**
24			* Get the update rules for the given ministry level.
25			*
26			* @return array
27			*/
28			protected function getSaveRules(): array
29			{
30			if ($discussion = app(DiscussionService::class)->getDiscussion()) {
31			$currentCount = $discussion->images()->count();
32			} else {
33			$currentCount = 0;
34			}
35
36			return [
37			'Free' => [
38			'discussion' => 'required\|string',
39			],
40			'Premium' => [
41			'discussion' => 'string',
42			'url' => 'url',
43			'images' => 'array\|max:'.(1 - $currentCount),
44			'images.*' => 'base64image',
45			],
46			'PremiumPlus' => [
47			'discussion' => 'string',
48			'url' => 'url',
49			'images' => 'array\|max:'.(5 - $currentCount),
50			'images.*' => 'base64image',
51			],
52			][auth()->user()->account->level];
			0 ignored issues – show Bug introduced 2020-04-15 15:54 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53			}
54			}
55

faithgen / discussions

Push — master ( 8fcc32...ae3918 )

SavesDiscussion::getSaveRules() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like