Faithgen\Discussions\Traits\SavesDiscussion

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	prepareForValidation()	0	8	2
A	getSaveRules()	0	26	2

<?php

namespace Faithgen\Discussions\Traits;

use Faithgen\Discussions\Services\DiscussionService;

trait SavesDiscussion
{
    /**
     * Converts image string array to usable string in the validation.
     *
     * @return void
     */
    public function prepareForValidation()
    {
        if (is_string($this->images)) {
            $this->merge([

It seems like merge() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                'images' => json_decode($this->images, true),

The property images does not exist. Did you maybe forget to declare it?

            ]);
        }
    }

    /**
     * Get the update rules for the given ministry level.
     *
     * @return array
     */
    protected function getSaveRules(): array
    {
        if ($discussion = app(DiscussionService::class)->getDiscussion()) {
            $currentCount = $discussion->images()->count();
        } else {
            $currentCount = 0;
        }

        return [
            'Free'        => [
                'discussion' => 'required|string',
            ],
            'Premium'     => [
                'discussion' => 'string',
                'url'        => 'url',
                'images'     => 'array|max:'.(1 - $currentCount),
                'images.*'   => 'base64image',
            ],
            'PremiumPlus' => [
                'discussion' => 'string',
                'url'        => 'url',
                'images'     => 'array|max:'.(5 - $currentCount),
                'images.*'   => 'base64image',
            ],
        ][auth()->user()->account->level];

The method user does only exist in Illuminate\Contracts\Auth\Guard, but not in Illuminate\Contracts\Auth\Factory.

    }
}