facebook / facebook-php-ads-sdk

src/FacebookAds/Object/AdImage.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 namespace FacebookAds\Object;
 
 use FacebookAds\Api;
-use FacebookAds\Cursor;
 use FacebookAds\Http\RequestInterface;
 use FacebookAds\Object\Fields\AdImageFields;
 use FacebookAds\Object\Traits\CannotUpdate;

Braces +10 added lines, -20 removed lines

@@ -31,8 +31,7 @@ 
 use FacebookAds\Object\Traits\CannotUpdate;
 use FacebookAds\Object\Traits\FieldValidation;
 
-class AdImage extends AbstractCrudObject
-{
+class AdImage extends AbstractCrudObject {
     use FieldValidation;
     use CannotUpdate;
 
@@ -46,8 +45,7 @@ 
      * @return array
      */
     public static function createFromZip(
-        $file_path, $account_id, array $params = array(), Api $api = null)
-    {
+        $file_path, $account_id, array $params = array(), Api $api = null) {
         $image = new AdImage(null, $account_id, $api);
         $image->{AdImageFields::FILENAME} = $file_path;
         return $image->arrayFromZip($params);
@@ -56,24 +54,21 @@ 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'adimages';
     }
 
     /**
      * @return AdImageFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return AdImageFields::getInstance();
     }
 
     /**
      * @return string
      */
-    protected function getNodePath()
-    {
+    protected function getNodePath() {
         return '/'.$this->assureParentId().'/'.$this->getEndpoint();
     }
 
@@ -85,8 +80,7 @@ 
      * @throws \Exception
      * @throws \RuntimeException
      */
-    public function create(array $params = array())
-    {
+    public function create(array $params = array()) {
         if ($this->data[static::FIELD_ID]) {
             throw new \Exception("Object has already an ID");
         }
@@ -129,8 +123,7 @@ 
      * @param array $params Additional request parameters
      * @return $this
      */
-    public function read(array $fields = array(), array $params = array())
-    {
+    public function read(array $fields = array(), array $params = array()) {
         $fields = implode(',', $fields ?: static::getDefaultReadFields());
         if ($fields) {
             $params['fields'] = $fields;
@@ -159,8 +152,7 @@ 
      * @return void
      * @throws \Exception
      */
-    public function delete(array $params = array())
-    {
+    public function delete(array $params = array()) {
         if (!$this->data[AdImageFields::HASH]) {
             throw new \Exception("AdImage hash is required to delete");
         }
@@ -178,8 +170,7 @@ 
      * @return array
      * @throws \RuntimeException
      */
-    protected function arrayFromZip($params = array())
-    {
+    protected function arrayFromZip($params = array()) {
         if (!$this->isZipFile($this->data[AdImageFields::FILENAME])) {
             throw new \RuntimeException(
                 $this->data[AdImageFields::FILENAME]." doesn't resolve to a zip file");
@@ -220,8 +211,7 @@ 
      * @param string $file_path
      * @return bool
      */
-    protected function isZipFile($file_path)
-    {
+    protected function isZipFile($file_path) {
         $finfo = finfo_open(FILEINFO_MIME_TYPE);
         $file_mime_type = finfo_file($finfo, $file_path);
         return $file_mime_type == 'application/zip' ||

src/FacebookAds/Object/AdVideo.php

Unused Use Statements -2 removed lines

@@ -26,8 +26,6 @@
 
 use FacebookAds\Http\RequestInterface;
 use FacebookAds\Object\Fields\AdVideoFields;
-use FacebookAds\Object\Traits\CannotDelete;
-use FacebookAds\Object\Traits\CannotUpdate;
 use FacebookAds\Object\Traits\FieldValidation;
 
 class AdVideo extends AbstractCrudObject {

Braces +5 added lines, -10 removed lines

@@ -30,28 +30,24 @@ 
 use FacebookAds\Object\Traits\CannotUpdate;
 use FacebookAds\Object\Traits\FieldValidation;
 
-class AdVideo extends AbstractCrudObject
-{
+class AdVideo extends AbstractCrudObject {
     use FieldValidation;
 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'advideos';
     }
 
     /**
      * @return AdVideoFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return AdVideoFields::getInstance();
     }
 
-    public function create(array $params = array())
-    {
+    public function create(array $params = array()) {
         $data = $this->exportData();
         $source = null;
         if (array_key_exists(AdVideoFields::SOURCE, $data)) {
@@ -85,8 +81,7 @@ 
      * @return Cursor
      */
     public function getVideoThumbnails(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             VideoThumbnail::className(), $fields, $params, 'thumbnails');
     }

src/FacebookAds/Object/ProductCatalog.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 
 namespace FacebookAds\Object;
 
-use FacebookAds\Api;
 use FacebookAds\Object\Fields\ProductCatalogFields;
 use FacebookAds\Object\Traits\FieldValidation;
 use FacebookAds\Http\RequestInterface;

Braces +12 added lines, -24 removed lines

@@ -30,23 +30,20 @@ 
 use FacebookAds\Object\Fields\ProductCatalogFields;
 use FacebookAds\Object\Traits\FieldValidation;
 
-class ProductCatalog extends AbstractCrudObject
-{
+class ProductCatalog extends AbstractCrudObject {
     use FieldValidation;
 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'product_catalogs';
     }
 
     /**
      * @return ProductCatalogFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return ProductCatalogFields::getInstance();
     }
 
@@ -56,8 +53,7 @@ 
      * @return Cursor
      */
     public function getProducts(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Product::className(), $fields, $params);
     }
@@ -68,8 +64,7 @@ 
      * @return Cursor
      */
     public function getProductSets(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             ProductSet::className(), $fields, $params);
     }
@@ -80,8 +75,7 @@ 
      * @return Cursor
      */
     public function getProductFeeds(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             ProductFeed::className(), $fields, $params);
     }
@@ -89,8 +83,7 @@ 
     /**
      * @return array
      */
-    public function getExternalEventSources()
-    {
+    public function getExternalEventSources() {
         $response = $this->getApi()->call(
             '/'.$this->assureId().'/external_event_sources',
             RequestInterface::METHOD_GET);
@@ -102,8 +95,7 @@ 
      * @param array $pixel_ids
      * @return bool
      */
-    public function setExternalEventSources(array $pixel_ids)
-    {
+    public function setExternalEventSources(array $pixel_ids) {
         return $this->modifyExternalEventSources(
             RequestInterface::METHOD_POST,
             $pixel_ids);
@@ -113,8 +105,7 @@ 
      * @param array $pixel_ids
      * @return bool
      */
-    public function removeExternalEventSources(array $pixel_ids)
-    {
+    public function removeExternalEventSources(array $pixel_ids) {
         return $this->modifyExternalEventSources(
             RequestInterface::METHOD_DELETE,
             $pixel_ids);
@@ -125,8 +116,7 @@ 
      * @param array $pixel_ids
      * @return bool
      */
-    protected function modifyExternalEventSources($method, array $pixel_ids)
-    {
+    protected function modifyExternalEventSources($method, array $pixel_ids) {
         $params = array(
             ProductCatalogFields::EXTERNAL_EVENT_SOURCES => $pixel_ids,
         );
@@ -143,8 +133,7 @@ 
      * @param int $user_id
      * @param string $role
      */
-    public function addUserPermission($user_id, $role)
-    {
+    public function addUserPermission($user_id, $role) {
         $params = array(
             'user' => $user_id,
             'role' => $role,
@@ -158,8 +147,7 @@ 
     /**
      * @param int $user_id
      */
-    public function deleteUserPermission($user_id)
-    {
+    public function deleteUserPermission($user_id) {
         $params = array(
             'user' => $user_id,
         );

src/FacebookAds/Object/ProductFeedUpload.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 namespace FacebookAds\Object;
 
 use FacebookAds\Object\Fields\ProductFeedUploadFields;
-use FacebookAds\Object\Traits\CannotCreate;
 use FacebookAds\Object\Traits\CannotDelete;
 use FacebookAds\Object\Traits\CannotUpdate;
 use FacebookAds\Cursor;

Braces +4 added lines, -8 removed lines

@@ -30,24 +30,21 @@ 
 use FacebookAds\Object\Traits\CannotDelete;
 use FacebookAds\Object\Traits\CannotUpdate;
 
-class ProductFeedUpload extends AbstractCrudObject
-{
+class ProductFeedUpload extends AbstractCrudObject {
     use CannotDelete;
     use CannotUpdate;
 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'uploads';
     }
 
     /**
      * @return ProductFeedUploadFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return ProductFeedUploadFields::getInstance();
     }
 
@@ -56,8 +53,7 @@ 
      * @param array $params
      * @return Cursor
      */
-    public function getErrors(array $fields = array(), array $params = array())
-    {
+    public function getErrors(array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             ProductFeedUploadError::className(), $fields, $params);
     }

src/FacebookAds/Object/CustomAudienceMultiKey.php

Unused Use Statements -2 removed lines

@@ -27,8 +27,6 @@
 use FacebookAds\Http\RequestInterface;
 use FacebookAds\Object\CustomAudienceNormalizers\HashNormalizer;
 use FacebookAds\Object\Fields\CustomAudienceFields;
-use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
-use FacebookAds\Object\Values\CustomAudienceTypes;
 
 class CustomAudienceMultiKey extends AbstractCrudObject
 {

Braces +4 added lines, -8 removed lines

@@ -30,8 +30,7 @@ 
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
 use FacebookAds\Object\Values\CustomAudienceTypes;
 
-class CustomAudienceMultiKey extends AbstractCrudObject
-{
+class CustomAudienceMultiKey extends AbstractCrudObject {
     /**
      * @var string
      */
@@ -45,24 +44,21 @@ 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'customaudiences';
     }
 
     /**
      * @return CustomAudienceFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return CustomAudienceFields::getInstance();
     }
 
     /**
      * @return \ArrayObject
      */
-    public function getNormalizers()
-    {
+    public function getNormalizers() {
         if ($this->normalizers === null) {
             $this->normalizers = new \ArrayObject(array(
                 new CustomAudienceNormalizers\EmailNormalizer(),

src/FacebookAds/Object/BusinessAdAccount.php

Braces +1 added lines, -2 removed lines

@@ -24,6 +24,5 @@
 
 namespace FacebookAds\Object;
 
-class BusinessAdAccount extends AbstractObject
-{
+class BusinessAdAccount extends AbstractObject {
 }

src/FacebookAds/Object/AbstractCrudObject.php

Braces +25 added lines, -50 removed lines

@@ -29,8 +29,7 @@ 
 use FacebookAds\Http\RequestInterface;
 use FacebookAds\Http\ResponseInterface;
 
-abstract class AbstractCrudObject extends AbstractObject
-{
+abstract class AbstractCrudObject extends AbstractObject {
     /**
      * @var string
      */
@@ -61,8 +60,7 @@ 
      * @param string $parent_id Optional, needed for creating new objects.
      * @param Api $api The Api instance this object should use to make calls
      */
-    public function __construct($id = null, $parent_id = null, Api $api = null)
-    {
+    public function __construct($id = null, $parent_id = null, Api $api = null) {
         parent::__construct();
         $this->data[static::FIELD_ID] = $id;
         $this->parentId = $parent_id;
@@ -72,24 +70,21 @@ 
     /**
      * @param string $id
      */
-    public function setId($id)
-    {
+    public function setId($id) {
         $this->data[static::FIELD_ID] = $id;
     }
 
     /**
      * @param string $parent_id
      */
-    public function setParentId($parent_id)
-    {
+    public function setParentId($parent_id) {
         $this->parentId = $parent_id;
     }
 
     /**
      * @param Api $api The Api instance this object should use to make calls
      */
-    public function setApi(Api $api)
-    {
+    public function setApi(Api $api) {
         $this->api = static::assureApi($api);
     }
 
@@ -103,8 +98,7 @@ 
      * @return Api
      * @throws \InvalidArgumentException
      */
-    protected static function assureApi(Api $instance = null)
-    {
+    protected static function assureApi(Api $instance = null) {
         $instance = $instance ?: Api::instance();
         if (!$instance) {
             throw new \InvalidArgumentException(
@@ -118,8 +112,7 @@ 
     /**
      * @return string|null
      */
-    public function getParentId()
-    {
+    public function getParentId() {
         return $this->parentId;
     }
 
@@ -127,8 +120,7 @@ 
      * @return string
      * @throws \Exception
      */
-    protected function assureParentId()
-    {
+    protected function assureParentId() {
         if (!$this->parentId) {
             throw new \Exception("A parent ID is required.");
         }
@@ -140,8 +132,7 @@ 
      * @return string
      * @throws \Exception
      */
-    protected function assureId()
-    {
+    protected function assureId() {
         if (!$this->data[static::FIELD_ID]) {
             throw new \Exception("field '".static::FIELD_ID."' is required.");
         }
@@ -152,8 +143,7 @@ 
     /**
      * @return Api
      */
-    public function getApi()
-    {
+    public function getApi() {
         return $this->api;
     }
 
@@ -162,8 +152,7 @@ 
      *
      * @return array Key value pairs of changed variables
      */
-    public function getChangedValues()
-    {
+    public function getChangedValues() {
         return $this->changedFields;
     }
 
@@ -172,16 +161,14 @@ 
      *
      * @return array Array of changed field names
      */
-    public function getChangedFields()
-    {
+    public function getChangedFields() {
         return array_keys($this->changedFields);
     }
 
     /**
      * Get the values which have changed, converting them to scalars
      */
-    public function exportData()
-    {
+    public function exportData() {
         $data = array();
         foreach ($this->changedFields as $key => $val) {
             $data[$key] = $val instanceof AbstractObject ? $val->exportData() : $val;
@@ -193,8 +180,7 @@ 
     /**
      * @return void
      */
-    protected function clearHistory()
-    {
+    protected function clearHistory() {
         $this->changedFields = array();
     }
 
@@ -202,8 +188,7 @@ 
      * @param string $name
      * @param mixed $value
      */
-    public function __set($name, $value)
-    {
+    public function __set($name, $value) {
         if (!array_key_exists($name, $this->data)
             || $this->data[$name] !== $value) {
             $this->changedFields[$name] = $value;
@@ -214,24 +199,21 @@ 
     /**
      * @param string[] $fields
      */
-    public static function setDefaultReadFields(array $fields = array())
-    {
+    public static function setDefaultReadFields(array $fields = array()) {
         static::$defaultReadFields = $fields;
     }
 
     /**
      * @return string[]
      */
-    public static function getDefaultReadFields()
-    {
+    public static function getDefaultReadFields() {
         return static::$defaultReadFields;
     }
 
     /**
      * @return string
      */
-    protected function getNodePath()
-    {
+    protected function getNodePath() {
         return '/'.$this->assureId();
     }
 
@@ -242,8 +224,7 @@ 
      * @return $this
      * @throws \Exception
      */
-    public function create(array $params = array())
-    {
+    public function create(array $params = array()) {
         if ($this->data[static::FIELD_ID]) {
             throw new \Exception("Object has already an ID");
         }
@@ -283,8 +264,7 @@ 
      * @param array $params Additional request parameters
      * @return $this
      */
-    public function read(array $fields = array(), array $params = array())
-    {
+    public function read(array $fields = array(), array $params = array()) {
         $fields = implode(',', $fields ?: static::getDefaultReadFields());
         if ($fields) {
             $params['fields'] = $fields;
@@ -308,8 +288,7 @@ 
      * @param array $params Update parameters in assoc
      * @return $this
      */
-    public function update(array $params = array())
-    {
+    public function update(array $params = array()) {
         $this->getApi()->call(
             $this->getNodePath(),
             RequestInterface::METHOD_POST,
@@ -327,8 +306,7 @@ 
      * @param array $params
      * @return void
      */
-    public function delete(array $params = array())
-    {
+    public function delete(array $params = array()) {
         $this->getApi()->call(
             $this->getNodePath(),
             RequestInterface::METHOD_DELETE,
@@ -345,8 +323,7 @@ 
      * @param array $params
      * @return $this
      */
-    public function save(array $params = array())
-    {
+    public function save(array $params = array()) {
         if ($this->data[static::FIELD_ID]) {
             return $this->update($params);
         } else {
@@ -360,8 +337,7 @@ 
      * @return string
      * @throws \InvalidArgumentException
      */
-    protected function assureEndpoint($prototype_class, $endpoint)
-    {
+    protected function assureEndpoint($prototype_class, $endpoint) {
         if (!$endpoint) {
             $prototype = new $prototype_class(null, null, $this->getApi());
             if (!$prototype instanceof AbstractCrudObject) {
@@ -486,8 +462,7 @@ 
      * @param Api $api Api Object to use
      * @return bool Returns true on success
      */
-    public static function deleteIds(array $ids, Api $api = null)
-    {
+    public static function deleteIds(array $ids, Api $api = null) {
         $batch = array();
         foreach ($ids as $id) {
             $request = array(

src/FacebookAds/Object/AbstractObject.php

Braces +13 added lines, -26 removed lines

@@ -26,15 +26,13 @@ 
 
 use FacebookAds\Enum\EmptyEnum;
 
-abstract class AbstractObject
-{
+abstract class AbstractObject {
     /**
      * @var mixed[] set of key value pairs representing data
      */
     protected $data = array();
 
-    public function __construct()
-    {
+    public function __construct() {
         $this->data = static::getFieldsEnum()->getValuesMap();
     }
 
@@ -43,8 +41,7 @@ 
      * @return mixed
      * @throws \InvalidArgumentException
      */
-    public function __get($name)
-    {
+    public function __get($name) {
         if (array_key_exists($name, $this->data)) {
             return $this->data[$name];
         } else {
@@ -56,8 +53,7 @@ 
      * @param string $name
      * @param mixed $value
      */
-    public function __set($name, $value)
-    {
+    public function __set($name, $value) {
         $this->data[$name] = $value;
     }
 
@@ -65,8 +61,7 @@ 
      * @param string $name
      * @return boolean
      */
-    public function __isset($name)
-    {
+    public function __isset($name) {
         return array_key_exists($name, $this->data);
     }
 
@@ -74,8 +69,7 @@ 
      * @param array
      * @return $this
      */
-    public function setData(array $data)
-    {
+    public function setData(array $data) {
         foreach ($data as $key => $value) {
             $this->{$key} = $value;
         }
@@ -89,8 +83,7 @@ 
      * @param array
      * @return $this
      */
-    public function setDataWithoutValidation(array $data)
-    {
+    public function setDataWithoutValidation(array $data) {
         foreach ($data as $key => $value) {
             $this->data[$key] = $value;
         }
@@ -101,8 +94,7 @@ 
     /**
      * @return array
      */
-    public function getData()
-    {
+    public function getData() {
         return $this->data;
     }
 
@@ -110,8 +102,7 @@ 
      * @param mixed $value
      * @return mixed
      */
-    protected function exportValue($value)
-    {
+    protected function exportValue($value) {
         switch (true) {
             case $value === null:
                 break;
@@ -134,32 +125,28 @@ 
     /**
      * @return array
      */
-    public function exportData()
-    {
+    public function exportData() {
         return $this->exportValue($this->data);
     }
 
     /**
      * @return EmptyEnum
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return EmptyEnum::getInstance();
     }
 
     /**
      * @return array
      */
-    public static function getFields()
-    {
+    public static function getFields() {
         return static::getFieldsEnum()->getValues();
     }
 
     /**
      * @return string
      */
-    public static function className()
-    {
+    public static function className() {
         return get_called_class();
     }
 }

src/FacebookAds/Object/Search/DemographicSearchClasses.php

Braces +1 added lines, -2 removed lines

@@ -29,8 +29,7 @@
 /**
  * @method static DemographicSearchClasses getInstance()
  */
-class DemographicSearchClasses extends AbstractEnum
-{
+class DemographicSearchClasses extends AbstractEnum {
     const LIFE_EVENTS = 'life_events';
     const POLITICS = 'politics';
     const MARKETS = 'markets';