facebook / facebook-php-ads-sdk

src/FacebookAds/Api.php

Doc Comments +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
     }
 
     /**
-     * @return Api|null
+     * @return Api
      */
     public static function instance()
     {

Braces +12 added lines, -24 removed lines

@@ -30,8 +30,7 @@ 
 use FacebookAds\Logger\LoggerInterface;
 use FacebookAds\Logger\NullLogger;
 
-class Api
-{
+class Api {
     /**
      * @var string
      */
@@ -80,8 +79,7 @@ 
      * @param string $access_token
      * @return static
      */
-    public static function init($app_id, $app_secret, $access_token)
-    {
+    public static function init($app_id, $app_secret, $access_token) {
         $session = new Session($app_id, $app_secret, $access_token);
         $api = new static(new Client(), $session);
         static::setInstance($api);
@@ -92,16 +90,14 @@ 
     /**
      * @return Api|null
      */
-    public static function instance()
-    {
+    public static function instance() {
         return static::$instance;
     }
 
     /**
      * @param Api $instance
      */
-    public static function setInstance(Api $instance)
-    {
+    public static function setInstance(Api $instance) {
         static::$instance = $instance;
     }
 
@@ -109,8 +105,7 @@ 
      * @param string $string
      * @return string
      */
-    public static function base64UrlEncode($string)
-    {
+    public static function base64UrlEncode($string) {
         $str = strtr(base64_encode($string), '+/', '-_');
         $str = str_replace('=', '', $str);
         return $str;
@@ -151,8 +146,7 @@ 
      * @param RequestInterface $request
      * @return ResponseInterface
      */
-    public function executeRequest(RequestInterface $request)
-    {
+    public function executeRequest(RequestInterface $request) {
         $this->getLogger()->logRequest('debug', $request);
         $response = $request->execute();
         $this->getLogger()->logResponse('debug', $response);
@@ -163,8 +157,7 @@ 
     /**
      * @return string
      */
-    public function getDefaultGraphVersion()
-    {
+    public function getDefaultGraphVersion() {
         if ($this->defaultGraphVersion === null) {
             $match = array();
             if (preg_match("/^\d+\.\d+/", static::VERSION, $match)) {
@@ -178,8 +171,7 @@ 
     /**
      * @param string $version
      */
-    public function setDefaultGraphVersion($version)
-    {
+    public function setDefaultGraphVersion($version) {
         $this->defaultGraphVersion = $version;
     }
 
@@ -204,24 +196,21 @@ 
     /**
      * @return Session
      */
-    public function getSession()
-    {
+    public function getSession() {
         return $this->session;
     }
 
     /**
      * @param LoggerInterface $logger
      */
-    public function setLogger(LoggerInterface $logger)
-    {
+    public function setLogger(LoggerInterface $logger) {
         $this->logger = $logger;
     }
 
     /**
      * @return LoggerInterface
      */
-    public function getLogger()
-    {
+    public function getLogger() {
         if ($this->logger === null) {
             $this->logger = new NullLogger();
         }
@@ -232,8 +221,7 @@ 
     /**
      * @return Client
      */
-    public function getHttpClient()
-    {
+    public function getHttpClient() {
         return $this->httpClient;
     }
 }

src/FacebookAds/Cursor.php

Doc Comments +1 added lines, -1 removed lines

@@ -499,7 +499,7 @@
 
     /**
      * @param mixed $offset
-     * @return mixed
+     * @return AbstractObject|null
      */
     public function offsetGet($offset)
     {

Braces +37 added lines, -74 removed lines

@@ -84,8 +84,7 @@ 
      * @param array $object_data
      * @return AbstractObject
      */
-    protected function createObject(array $object_data)
-    {
+    protected function createObject(array $object_data) {
         $object = clone $this->objectPrototype;
         $object->setDataWithoutValidation($object_data);
 
@@ -97,8 +96,7 @@ 
      * @return array
      * @throws \InvalidArgumentException
      */
-    protected function assureResponseData(ResponseInterface $response)
-    {
+    protected function assureResponseData(ResponseInterface $response) {
         $content = $response->getContent();
         if (!isset($content['data']) || !is_array($content['data'])) {
             throw new \InvalidArgumentException("Malformed response data");
@@ -110,8 +108,7 @@ 
     /**
      * @param ResponseInterface $response
      */
-    protected function prependResponse(ResponseInterface $response)
-    {
+    protected function prependResponse(ResponseInterface $response) {
         $this->response = $response;
         $data = $this->assureResponseData($response);
         if (empty($data)) {
@@ -130,8 +127,7 @@ 
     /**
      * @param ResponseInterface $response
      */
-    protected function appendResponse(ResponseInterface $response)
-    {
+    protected function appendResponse(ResponseInterface $response) {
         $this->response = $response;
         $data = $this->assureResponseData($response);
         if (empty($data)) {
@@ -154,24 +150,21 @@ 
     /**
      * @return bool
      */
-    public static function getDefaultUseImplicitFetch()
-    {
+    public static function getDefaultUseImplicitFetch() {
         return static::$defaultUseImplicitFetch;
     }
 
     /**
      * @param bool $use_implicit_fectch
      */
-    public static function setDefaultUseImplicitFetch($use_implicit_fectch)
-    {
+    public static function setDefaultUseImplicitFetch($use_implicit_fectch) {
         static::$defaultUseImplicitFetch = $use_implicit_fectch;
     }
 
     /**
      * @return bool
      */
-    public function getUseImplicitFetch()
-    {
+    public function getUseImplicitFetch() {
         return $this->useImplicitFectch !== null
             ? $this->useImplicitFectch
             : static::$defaultUseImplicitFetch;
@@ -180,16 +173,14 @@ 
     /**
      * @param bool $use_implicit_fectch
      */
-    public function setUseImplicitFetch($use_implicit_fectch)
-    {
+    public function setUseImplicitFetch($use_implicit_fectch) {
         $this->useImplicitFectch = $use_implicit_fectch;
     }
 
     /**
      * @return string|null
      */
-    public function getBefore()
-    {
+    public function getBefore() {
         $content = $this->getLastResponse()->getContent();
 
         return isset($content['paging']['cursors']['before'])
@@ -200,8 +191,7 @@ 
     /**
      * @return string|null
      */
-    public function getAfter()
-    {
+    public function getAfter() {
         $content = $this->getLastResponse()->getContent();
 
         return isset($content['paging']['cursors']['after'])
@@ -212,8 +202,7 @@ 
     /**
      * @return RequestInterface
      */
-    protected function createUndirectionalizedRequest()
-    {
+    protected function createUndirectionalizedRequest() {
         $request = $this->getLastResponse()->getRequest()->createClone();
         $params = $request->getQueryParams();
         if (array_key_exists('before', $params)) {
@@ -229,8 +218,7 @@ 
     /**
      * @return string|null
      */
-    public function getPrevious()
-    {
+    public function getPrevious() {
         $content = $this->getLastResponse()->getContent();
         if (isset($content['paging']['previous'])) {
             return $content['paging']['previous'];
@@ -249,8 +237,7 @@ 
     /**
      * @return string|null
      */
-    public function getNext()
-    {
+    public function getNext() {
         $content = $this->getLastResponse()->getContent();
         if (isset($content['paging']['next'])) {
             return $content['paging']['next'];
@@ -270,8 +257,7 @@ 
      * @param string $url
      * @return RequestInterface
      */
-    protected function createRequestFromUrl($url)
-    {
+    protected function createRequestFromUrl($url) {
         $components = parse_url($url);
         $request = $this->getLastResponse()->getRequest()->createClone();
         $request->setDomain($components['host']);
@@ -286,8 +272,7 @@ 
     /**
      * @return RequestInterface|null
      */
-    public function createBeforeRequest()
-    {
+    public function createBeforeRequest() {
         $url = $this->getPrevious();
         return $url !== null ? $this->createRequestFromUrl($url) : null;
     }
@@ -295,14 +280,12 @@ 
     /**
      * @return RequestInterface|null
      */
-    public function createAfterRequest()
-    {
+    public function createAfterRequest() {
         $url = $this->getNext();
         return $url !== null ? $this->createRequestFromUrl($url) : null;
     }
 
-    public function fetchBefore()
-    {
+    public function fetchBefore() {
         $request = $this->createBeforeRequest();
         if (!$request) {
             return;
@@ -311,8 +294,7 @@ 
         $this->prependResponse($request->execute());
     }
 
-    public function fetchAfter()
-    {
+    public function fetchAfter() {
         $request = $this->createAfterRequest();
         if (!$request) {
             return;
@@ -325,8 +307,7 @@ 
      * @deprecated Use getArrayCopy()
      * @return AbstractObject[]
      */
-    public function getObjects()
-    {
+    public function getObjects() {
         return $this->objects;
     }
 
@@ -334,8 +315,7 @@ 
      * @param bool $ksort
      * @return AbstractObject[]
      */
-    public function getArrayCopy($ksort = false)
-    {
+    public function getArrayCopy($ksort = false) {
         if ($ksort) {
             // Sort the main array to improve best case performance in future
             // invocations
@@ -349,50 +329,43 @@ 
      * @deprecated Use getLastResponse()
      * @return ResponseInterface
      */
-    public function getResponse()
-    {
+    public function getResponse() {
         return $this->response;
     }
 
     /**
      * @return ResponseInterface
      */
-    public function getLastResponse()
-    {
+    public function getLastResponse() {
         return $this->response;
     }
 
     /**
      * @return int
      */
-    public function getIndexLeft()
-    {
+    public function getIndexLeft() {
         return $this->indexLeft;
     }
 
     /**
      * @return int
      */
-    public function getIndexRight()
-    {
+    public function getIndexRight() {
         return $this->indexRight;
     }
 
-    public function rewind()
-    {
+    public function rewind() {
         $this->position = $this->indexLeft;
     }
 
-    public function end()
-    {
+    public function end() {
         $this->position = $this->indexRight;
     }
 
     /**
      * @param int $position
      */
-    public function seekTo($position)
-    {
+    public function seekTo($position) {
         $position = array_key_exists($position, $this->objects) ? $position : null;
         $this->position = $position;
     }
@@ -400,8 +373,7 @@ 
     /**
      * @return AbstractObject|bool
      */
-    public function current()
-    {
+    public function current() {
         return isset($this->objects[$this->position])
             ? $this->objects[$this->position]
             : false;
@@ -410,13 +382,11 @@ 
     /**
      * @return int
      */
-    public function key()
-    {
+    public function key() {
         return $this->position;
     }
 
-    public function prev()
-    {
+    public function prev() {
         if ($this->position == $this->getIndexLeft()) {
             if ($this->getUseImplicitFetch()) {
                 $this->fetchBefore();
@@ -433,8 +403,7 @@ 
         }
     }
 
-    public function next()
-    {
+    public function next() {
         if ($this->position == $this->getIndexRight()) {
             if ($this->getUseImplicitFetch()) {
                 $this->fetchAfter();
@@ -454,16 +423,14 @@ 
     /**
      * @return bool
      */
-    public function valid()
-    {
+    public function valid() {
         return isset($this->objects[$this->position]);
     }
 
     /**
      * @return int
      */
-    public function count()
-    {
+    public function count() {
         return count($this->objects);
     }
 
@@ -471,8 +438,7 @@ 
      * @param mixed $offset
      * @param mixed $value
      */
-    public function offsetSet($offset, $value)
-    {
+    public function offsetSet($offset, $value) {
         if ($offset === null) {
             $this->objects[] = $value;
         } else {
@@ -484,16 +450,14 @@ 
      * @param mixed $offset
      * @return bool
      */
-    public function offsetExists($offset)
-    {
+    public function offsetExists($offset) {
         return isset($this->objects[$offset]);
     }
 
     /**
      * @param mixed $offset
      */
-    public function offsetUnset($offset)
-    {
+    public function offsetUnset($offset) {
         unset($this->objects[$offset]);
     }
 
@@ -501,8 +465,7 @@ 
      * @param mixed $offset
      * @return mixed
      */
-    public function offsetGet($offset)
-    {
+    public function offsetGet($offset) {
         return isset($this->objects[$offset]) ? $this->objects[$offset] : null;
     }
 }

src/FacebookAds/Logger/CurlLogger.php

Doc Comments +1 added lines, -1 removed lines

@@ -207,7 +207,7 @@
 
     /**
      * @param array $array
-     * @param mixed $key
+     * @param string $key
      * @return mixed
      */
     protected function removeArrayKey(array &$array, $key)

Braces +13 added lines, -26 removed lines

@@ -29,8 +29,7 @@ 
 use FacebookAds\Http\ResponseInterface;
 use FacebookAds\Logger\CurlLogger\JsonAwareParameters;
 
-class CurlLogger implements LoggerInterface
-{
+class CurlLogger implements LoggerInterface {
     /**
      * @var string
      */
@@ -79,16 +78,14 @@ 
     /**
      * @param resource $handle
      */
-    public function __construct($handle = null)
-    {
+    public function __construct($handle = null) {
         $this->handle = is_resource($handle) ? $handle : STDOUT;
     }
 
     /**
      * @return bool
      */
-    public function isJsonPrettyPrint()
-    {
+    public function isJsonPrettyPrint() {
         return $this->jsonPrettyPrint;
     }
 
@@ -96,8 +93,7 @@ 
      * @param bool $json_pretty_print
      * @return $this
      */
-    public function setJsonPrettyPrint($json_pretty_print)
-    {
+    public function setJsonPrettyPrint($json_pretty_print) {
         $this->jsonPrettyPrint = $json_pretty_print;
 
         return $this;
@@ -107,8 +103,7 @@ 
      * @param string $method
      * @return string
      */
-    public static function getMethodFlag($method)
-    {
+    public static function getMethodFlag($method) {
         switch ($method) {
             case RequestInterface::METHOD_GET:
                 return static::METHOD_GET_FLAG;
@@ -126,8 +121,7 @@ 
      * @param string $value
      * @return string
      */
-    public static function getParamFlag($method, $value)
-    {
+    public static function getParamFlag($method, $value) {
         return $method === RequestInterface::METHOD_POST
             ? static::PARAM_POST_FLAG
             : (strstr($value, "\n")
@@ -140,8 +134,7 @@ 
      * @param int $indent
      * @return string
      */
-    protected function indent($string, $indent)
-    {
+    protected function indent($string, $indent) {
         return str_replace("\n", " \n".str_repeat(' ', $indent), $string);
     }
 
@@ -151,8 +144,7 @@ 
      * @param bool $is_file
      * @return string
      */
-    protected function processParams(Parameters $params, $method, $is_file)
-    {
+    protected function processParams(Parameters $params, $method, $is_file) {
         $chunks = array();
         if ($this->isJsonPrettyPrint()) {
             $params = new JsonAwareParameters($params);
@@ -181,8 +173,7 @@ 
      * @param RequestInterface $request
      * @return string
      */
-    protected function processUrl(RequestInterface $request)
-    {
+    protected function processUrl(RequestInterface $request) {
         return $request->getProtocol().$request->getDomain()
             .'/v'.$request->getGraphVersion().$request->getPath();
     }
@@ -190,8 +181,7 @@ 
     /**
      * @param string $buffer
      */
-    protected function flush($buffer)
-    {
+    protected function flush($buffer) {
         fwrite($this->handle, $buffer.PHP_EOL.PHP_EOL);
     }
 
@@ -200,8 +190,7 @@ 
      * @param string $message
      * @param array $context
      */
-    public function log($level, $message, array $context = array())
-    {
+    public function log($level, $message, array $context = array()) {
         // We only care about requests
     }
 
@@ -210,8 +199,7 @@ 
      * @param mixed $key
      * @return mixed
      */
-    protected function removeArrayKey(array &$array, $key)
-    {
+    protected function removeArrayKey(array &$array, $key) {
         if (array_key_exists($key, $array)) {
             $value = $array[$key];
             unset($array[$key]);
@@ -226,8 +214,7 @@ 
      * @param array $params
      * @return array
      */
-    protected function sortParams(array $params)
-    {
+    protected function sortParams(array $params) {
         $access_token = $this->removeArrayKey($params, 'access_token');
         $appsecret_proof = $this->removeArrayKey($params, 'appsecret_proof');
         $access_token !== null && $params['access_token'] = $access_token;

src/FacebookAds/Object/Ad.php

Doc Comments +2 added lines, -2 removed lines

@@ -76,7 +76,7 @@ 
     /**
      * @param array $fields
      * @param array $params
-     * @return TargetingDescription
+     * @return null|AbstractCrudObject
      */
     public function getTargetingDescription(
         array $fields = array(), array $params = array())
@@ -104,7 +104,7 @@ 
     /**
      * @param array $fields
      * @param array $params
-     * @return ReachEstimate
+     * @return null|AbstractCrudObject
      */
     public function getReachEstimate(
         array $fields = array(), array $params = array())

Braces +11 added lines, -22 removed lines

@@ -30,24 +30,21 @@ 
 use FacebookAds\Object\Traits\FieldValidation;
 
 class Ad extends AbstractArchivableCrudObject
-    implements CanRedownloadInterface
-{
+    implements CanRedownloadInterface {
     use FieldValidation;
     use AdLabelAwareCrudObjectTrait;
 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'ads';
     }
 
     /**
      * @return AdFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return AdFields::getInstance();
     }
 
@@ -57,8 +54,7 @@ 
      * @return Cursor
      */
     public function getAdCreatives(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdCreative::className(), $fields, $params);
     }
@@ -68,8 +64,7 @@ 
      * @param array $params
      * @return Cursor
      */
-    public function getLeads(array $fields = array(), array $params = array())
-    {
+    public function getLeads(array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(Lead::className(), $fields, $params);
     }
 
@@ -79,8 +74,7 @@ 
      * @return TargetingDescription
      */
     public function getTargetingDescription(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getOneByConnection(
             TargetingDescription::className(),
             $fields,
@@ -95,8 +89,7 @@ 
      * @return Cursor
      */
     public function getAdPreviews(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdPreview::className(), $fields, $params, 'previews');
     }
@@ -107,8 +100,7 @@ 
      * @return ReachEstimate
      */
     public function getReachEstimate(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getOneByConnection(
             ReachEstimate::className(), $fields, $params, 'reachestimate');
     }
@@ -119,8 +111,7 @@ 
      * @return Cursor
      */
     public function getClickTrackingTag(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             ClickTrackingTag::className(), $fields, $params, 'trackingtag');
     }
@@ -131,8 +122,7 @@ 
      * @return Cursor
      */
     public function getInsights(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Insights::classname(), $fields, $params, 'insights');
     }
@@ -143,8 +133,7 @@ 
      * @return AsyncJobInsights
      */
     public function getInsightsAsync(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->createAsyncJob(
             AsyncJobInsights::className(), $fields, $params);
     }

src/FacebookAds/Object/AdAccount.php

Doc Comments +2 added lines, -2 removed lines

@@ -232,7 +232,7 @@ 
     /**
      * @param array $fields
      * @param array $params
-     * @return ReachEstimate
+     * @return null|AbstractCrudObject
      */
     public function getReachEstimate(
         array $fields = array(), array $params = array())
@@ -256,7 +256,7 @@ 
     /**
      * @param array $fields
      * @param array $params
-     * @return TargetingDescription
+     * @return null|AbstractCrudObject
      */
     public function getTargetingDescription(
         array $fields = array(), array $params = array())

Indentation +26 added lines, -26 removed lines

@@ -1,26 +1,26 @@ 
 <?php
 /**
- * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
- *
- * You are hereby granted a non-exclusive, worldwide, royalty-free license to
- * use, copy, modify, and distribute this software in source code or binary
- * form for use in connection with the web services and APIs provided by
- * Facebook.
- *
- * As with any software that integrates with the Facebook platform, your use
- * of this software is subject to the Facebook Developer Principles and
- * Policies [http://developers.facebook.com/policy/]. This copyright notice
- * shall be included in all copies or substantial portions of the software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
- */
+     * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
+     *
+     * You are hereby granted a non-exclusive, worldwide, royalty-free license to
+     * use, copy, modify, and distribute this software in source code or binary
+     * form for use in connection with the web services and APIs provided by
+     * Facebook.
+     *
+     * As with any software that integrates with the Facebook platform, your use
+     * of this software is subject to the Facebook Developer Principles and
+     * Policies [http://developers.facebook.com/policy/]. This copyright notice
+     * shall be included in all copies or substantial portions of the software.
+     *
+     * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+     * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+     * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+     * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+     * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+     * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+     * DEALINGS IN THE SOFTWARE.
+     *
+     */
 
 namespace FacebookAds\Object;
 
@@ -75,11 +75,11 @@ 
         return $this->getManyByConnection(AdUser::className(), $fields, $params);
     }
 
-     /**
-     * @param array $fields
-     * @param array $params
-     * @return Cursor
-     */
+      /**
+       * @param array $fields
+       * @param array $params
+       * @return Cursor
+       */
     public function getCampaigns(
         array $fields = array(), array $params = array())
     {

Braces +36 added lines, -72 removed lines

@@ -31,8 +31,7 @@ 
 use FacebookAds\Object\Traits\CannotDelete;
 use FacebookAds\Object\Traits\FieldValidation;
 
-class AdAccount extends AbstractCrudObject
-{
+class AdAccount extends AbstractCrudObject {
     use FieldValidation;
     use CannotCreate;
     use CannotDelete;
@@ -40,16 +39,14 @@ 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'adaccounts';
     }
 
     /**
      * @return AdAccountFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return AdAccountFields::getInstance();
     }
 
@@ -59,8 +56,7 @@ 
      * @return Cursor
      */
     public function getActivities(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Activity::className(), $fields, $params, 'activities');
     }
@@ -70,8 +66,7 @@ 
      * @param array $params
      * @return Cursor
      */
-    public function getAdUsers(array $fields = array(), array $params = array())
-    {
+    public function getAdUsers(array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(AdUser::className(), $fields, $params);
     }
 
@@ -81,8 +76,7 @@ 
      * @return Cursor
      */
     public function getCampaigns(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Campaign::className(), $fields, $params);
     }
@@ -92,8 +86,7 @@ 
      * @param array $params
      * @return Cursor
      */
-    public function getAdSets(array $fields = array(), array $params = array())
-    {
+    public function getAdSets(array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(AdSet::className(), $fields, $params);
     }
 
@@ -103,8 +96,7 @@ 
      * @return Cursor
      */
     public function getAds(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(Ad::className(), $fields, $params);
     }
 
@@ -114,8 +106,7 @@ 
      * @return Cursor
      */
     public function getAdCreatives(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdCreative::className(), $fields, $params);
     }
@@ -126,8 +117,7 @@ 
      * @return Cursor
      */
     public function getAdImages(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(AdImage::className(), $fields, $params);
     }
 
@@ -137,8 +127,7 @@ 
      * @return Cursor
      */
     public function getAdsPixels(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(AdsPixel::className(), $fields, $params);
     }
 
@@ -148,8 +137,7 @@ 
      * @return Cursor
      */
     public function getAdVideos(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(AdVideo::className(), $fields, $params);
     }
 
@@ -159,8 +147,7 @@ 
      * @return Cursor
      */
     public function getBroadCategoryTargeting(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             BroadCategoryTargeting::className(),
             $fields,
@@ -175,8 +162,7 @@ 
      * @return Cursor
      */
     public function getConnectionObjects(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             ConnectionObject::className(), $fields, $params, 'connectionobjects');
     }
@@ -187,8 +173,7 @@ 
      * @return Cursor
      */
     public function getCustomAudiences(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             CustomAudience::className(), $fields, $params);
     }
@@ -199,8 +184,7 @@ 
      * @return Cursor
      */
     public function getConversionPixels(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdConversionPixel::className(), $fields, $params);
     }
@@ -211,8 +195,7 @@ 
      * @return Cursor
      */
     public function getPartnerCategories(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             PartnerCategory::className(), $fields, $params);
     }
@@ -223,8 +206,7 @@ 
      * @return Cursor
      */
     public function getRateCards(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             RateCard::className(), $fields, $params, 'ratecard');
     }
@@ -235,8 +217,7 @@ 
      * @return ReachEstimate
      */
     public function getReachEstimate(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getOneByConnection(
             ReachEstimate::className(), $fields, $params, 'reachestimate');
     }
@@ -247,8 +228,7 @@ 
      * @return Cursor
      */
     public function getReachFrequencyPredictions(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             ReachFrequencyPrediction::className(), $fields, $params);
     }
@@ -259,8 +239,7 @@ 
      * @return TargetingDescription
      */
     public function getTargetingDescription(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getOneByConnection(
             TargetingDescription::className(),
             $fields,
@@ -274,8 +253,7 @@ 
      * @return Cursor
      */
     public function getTransactions(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Transaction::className(), $fields, $params, 'transactions');
     }
@@ -286,8 +264,7 @@ 
      * @return Cursor
      */
     public function getAdPreviews(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdPreview::classname(), $fields, $params, 'generatepreviews');
     }
@@ -298,8 +275,7 @@ 
      * @return Cursor
      */
     public function getInsights(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Insights::classname(), $fields, $params, 'insights');
     }
@@ -310,8 +286,7 @@ 
      * @return AsyncJobInsights
      */
     public function getInsightsAsync(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->createAsyncJob(
             AsyncJobInsights::className(), $fields, $params);
     }
@@ -322,8 +297,7 @@ 
      * @return Cursor
      */
     public function getAgencies(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Agency::className(), $fields, $params, 'agencies');
     }
@@ -332,8 +306,7 @@ 
      * @param int $business_id
      * @param array $permitted_roles
      */
-    public function grantAgencyAcccess($business_id, $permitted_roles)
-    {
+    public function grantAgencyAcccess($business_id, $permitted_roles) {
         $params = array(
             'business' => $business_id,
             'permitted_roles' => $permitted_roles,
@@ -348,8 +321,7 @@ 
     /**
      * @param int $business_id
      */
-    public function revokeAgencyAccess($business_id)
-    {
+    public function revokeAgencyAccess($business_id) {
         $params = array(
             'business' => $business_id,
         );
@@ -366,8 +338,7 @@ 
      * @return Cursor
      */
     public function getMinimumBudgets(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             MinimumBudget::className(), $fields, $params, 'minimum_budgets');
     }
@@ -378,8 +349,7 @@ 
      * @return Cursor
      */
     public function getAdPlacePageSets(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdPlacePageSet::className(), $fields, $params);
     }
@@ -390,8 +360,7 @@ 
      * @return Cursor
      */
     public function getAdLabels(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdLabel::className(), $fields, $params);
     }
@@ -402,8 +371,7 @@ 
      * @return Cursor
      */
     public function getCampaignsByLabel(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Campaign::classname(), $fields, $params, 'campaignsbylabels');
     }
@@ -414,8 +382,7 @@ 
      * @return Cursor
      */
     public function getAdSetsByLabel(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdSet::classname(), $fields, $params, 'adsetsbylabels');
     }
@@ -426,8 +393,7 @@ 
      * @return Cursor
      */
     public function getAdsByLabel(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             Ad::classname(), $fields, $params, 'adsbylabels');
     }
@@ -438,8 +404,7 @@ 
      * @return Cursor
      */
     public function getAdCreativesByLabel(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             AdCreative::classname(), $fields, $params, 'adcreativesbylabels');
     }
@@ -450,8 +415,7 @@ 
      * @return Cursor
      */
     public function getCustomConversions(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             CustomConversion::className(), $fields, $params);
     }

src/FacebookAds/Object/AdVideo.php

Doc Comments +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
     /**
      * @param array $fields
      * @param array $params
-     * @return Cursor
+     * @return \FacebookAds\Cursor
      */
     public function getVideoThumbnails(
         array $fields = array(), array $params = array())

Braces +5 added lines, -10 removed lines

@@ -30,28 +30,24 @@ 
 use FacebookAds\Object\Traits\CannotUpdate;
 use FacebookAds\Object\Traits\FieldValidation;
 
-class AdVideo extends AbstractCrudObject
-{
+class AdVideo extends AbstractCrudObject {
     use FieldValidation;
 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'advideos';
     }
 
     /**
      * @return AdVideoFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return AdVideoFields::getInstance();
     }
 
-    public function create(array $params = array())
-    {
+    public function create(array $params = array()) {
         $data = $this->exportData();
         $source = null;
         if (array_key_exists(AdVideoFields::SOURCE, $data)) {
@@ -85,8 +81,7 @@ 
      * @return Cursor
      */
     public function getVideoThumbnails(
-        array $fields = array(), array $params = array())
-    {
+        array $fields = array(), array $params = array()) {
         return $this->getManyByConnection(
             VideoThumbnail::className(), $fields, $params, 'thumbnails');
     }

src/FacebookAds/Object/CustomAudienceMultiKey.php

Unused Use Statements -2 removed lines

@@ -27,8 +27,6 @@
 use FacebookAds\Http\RequestInterface;
 use FacebookAds\Object\CustomAudienceNormalizers\HashNormalizer;
 use FacebookAds\Object\Fields\CustomAudienceFields;
-use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
-use FacebookAds\Object\Values\CustomAudienceTypes;
 
 class CustomAudienceMultiKey extends AbstractCrudObject
 {

Indentation +23 added lines, -23 removed lines

@@ -1,26 +1,26 @@ 
 <?php
 /**
- * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
- *
- * You are hereby granted a non-exclusive, worldwide, royalty-free license to
- * use, copy, modify, and distribute this software in source code or binary
- * form for use in connection with the web services and APIs provided by
- * Facebook.
- *
- * As with any software that integrates with the Facebook platform, your use
- * of this software is subject to the Facebook Developer Principles and
- * Policies [http://developers.facebook.com/policy/]. This copyright notice
- * shall be included in all copies or substantial portions of the software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
- * DEALINGS IN THE SOFTWARE.
- *
- */
+     * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
+     *
+     * You are hereby granted a non-exclusive, worldwide, royalty-free license to
+     * use, copy, modify, and distribute this software in source code or binary
+     * form for use in connection with the web services and APIs provided by
+     * Facebook.
+     *
+     * As with any software that integrates with the Facebook platform, your use
+     * of this software is subject to the Facebook Developer Principles and
+     * Policies [http://developers.facebook.com/policy/]. This copyright notice
+     * shall be included in all copies or substantial portions of the software.
+     *
+     * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+     * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+     * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+     * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+     * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+     * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+     * DEALINGS IN THE SOFTWARE.
+     *
+     */
 
 namespace FacebookAds\Object;
 
@@ -38,8 +38,8 @@ 
     const HASH_TYPE_SHA256 = 'sha256';
 
     /**
-    * @var \ArrayObject
-    */
+     * @var \ArrayObject
+     */
     protected $normalizers;
 
     /**

Braces +4 added lines, -8 removed lines

@@ -30,8 +30,7 @@ 
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
 use FacebookAds\Object\Values\CustomAudienceTypes;
 
-class CustomAudienceMultiKey extends AbstractCrudObject
-{
+class CustomAudienceMultiKey extends AbstractCrudObject {
     /**
      * @var string
      */
@@ -45,24 +44,21 @@ 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'customaudiences';
     }
 
     /**
      * @return CustomAudienceFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return CustomAudienceFields::getInstance();
     }
 
     /**
      * @return \ArrayObject
      */
-    public function getNormalizers()
-    {
+    public function getNormalizers() {
         if ($this->normalizers === null) {
             $this->normalizers = new \ArrayObject(array(
                 new CustomAudienceNormalizers\EmailNormalizer(),

src/FacebookAds/Object/CustomAudienceNormalizers/ValueNormalizerInterface.php

Doc Comments +2 added lines, -2 removed lines

@@ -28,14 +28,14 @@
 {
     /**
      * @param string $key
-     * @param string $key_value
+     * @param string $val
      * @return boolean
      */
     public function shouldNormalize($key, $val);
 
     /**
      * @param string $key
-     * @param string $key_value
+     * @param string $val
      * @return string
      */
     public function normalize($key, $val);

Braces +1 added lines, -2 removed lines

@@ -24,8 +24,7 @@
 
 namespace FacebookAds\Object\CustomAudienceNormalizers;
 
-interface ValueNormalizerInterface
-{
+interface ValueNormalizerInterface {
     /**
      * @param string $key
      * @param string $key_value

src/FacebookAds/Object/CustomConversion.php

Doc Comments +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     }
 
     /**
-     * @return CustomConversionFields
+     * @return Fields\AdConversionPixelFields
      */
     public static function getFieldsEnum()
     {

Braces +3 added lines, -6 removed lines

@@ -27,23 +27,20 @@
 use FacebookAds\Object\Fields\CustomConversionFields;
 use FacebookAds\Object\Traits\CannotDelete;
 
-class CustomConversion extends AbstractCrudObject
-{
+class CustomConversion extends AbstractCrudObject {
     use CannotDelete;
 
     /**
      * @return string
      */
-    protected function getEndpoint()
-    {
+    protected function getEndpoint() {
         return 'customconversions';
     }
 
     /**
      * @return CustomConversionFields
      */
-    public static function getFieldsEnum()
-    {
+    public static function getFieldsEnum() {
         return CustomConversionFields::getInstance();
     }
 }