Inspection of "Added a new configuration setting allowing specifi..." - facade/ignition - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

unknown

created 2019-08-31 01:20 UTC

Status

Unused Use Statements +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -2,54 +2,54 @@
 block discarded – undo
 
 namespace Facade\Ignition;
 
-use Monolog\Logger;
-use Illuminate\Support\Arr;
 use Facade\FlareClient\Flare;
-use Illuminate\Log\LogManager;
-use Illuminate\Queue\QueueManager;
 use Facade\FlareClient\Http\Client;
-use Illuminate\Support\Facades\Log;
-use Whoops\Handler\HandlerInterface;
-use Illuminate\Support\Facades\Route;
-use Illuminate\Foundation\Application;
+use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
+use Facade\Ignition\Commands\TestCommand;
+use Facade\Ignition\Context\LaravelContextDetector;
+use Facade\Ignition\DumpRecorder\DumpRecorder;
+use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
 use Facade\Ignition\ErrorPage\Renderer;
-use Facade\Ignition\Middleware\AddLogs;
-use Illuminate\Support\ServiceProvider;
+use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
+use Facade\Ignition\Http\Controllers\HealthCheckController;
+use Facade\Ignition\Http\Controllers\ScriptController;
+use Facade\Ignition\Http\Controllers\ShareReportController;
+use Facade\Ignition\Http\Controllers\StyleController;
+use Facade\Ignition\LogRecorder\LogRecorder;
 use Facade\Ignition\Logger\FlareHandler;
 use Facade\Ignition\Middleware\AddDumps;
-use Illuminate\Log\Events\MessageLogged;
-use Facade\Ignition\Commands\TestCommand;
+use Facade\Ignition\Middleware\AddEnvironmentInformation;
+use Facade\Ignition\Middleware\AddGitInformation;
+use Facade\Ignition\Middleware\AddLogs;
 use Facade\Ignition\Middleware\AddQueries;
-use Facade\Ignition\LogRecorder\LogRecorder;
 use Facade\Ignition\Middleware\AddSolutions;
-use Facade\Ignition\Views\Engines\PhpEngine;
-use Facade\Ignition\DumpRecorder\DumpRecorder;
 use Facade\Ignition\Middleware\SetNotifierName;
-use Facade\Ignition\QueryRecorder\QueryRecorder;
-use Facade\Ignition\Middleware\AddGitInformation;
-use Facade\Ignition\Views\Engines\CompilerEngine;
-use Facade\Ignition\Context\LaravelContextDetector;
-use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
-use Facade\Ignition\Http\Controllers\StyleController;
-use Facade\Ignition\Http\Controllers\ScriptController;
-use Facade\Ignition\Middleware\AddEnvironmentInformation;
-use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
-use Facade\Ignition\Http\Controllers\HealthCheckController;
-use Facade\Ignition\Http\Controllers\ShareReportController;
 use Facade\Ignition\Middleware\UpdateMaskedRequestParameters;
-use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
-use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
-use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
+use Facade\Ignition\QueryRecorder\QueryRecorder;
 use Facade\Ignition\SolutionProviders\BadMethodCallSolutionProvider;
 use Facade\Ignition\SolutionProviders\DefaultDbNameSolutionProvider;
+use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
+use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
 use Facade\Ignition\SolutionProviders\MissingAppKeySolutionProvider;
 use Facade\Ignition\SolutionProviders\MissingImportSolutionProvider;
+use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
+use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
 use Facade\Ignition\SolutionProviders\TableNotFoundSolutionProvider;
+use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
+use Facade\Ignition\Views\Engines\CompilerEngine;
+use Facade\Ignition\Views\Engines\PhpEngine;
+use Illuminate\Foundation\Application;
+use Illuminate\Log\Events\MessageLogged;
+use Illuminate\Log\LogManager;
+use Illuminate\Queue\QueueManager;
+use Illuminate\Support\Arr;
+use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Facades\Route;
+use Illuminate\Support\ServiceProvider;
 use Illuminate\View\Engines\CompilerEngine as LaravelCompilerEngine;
-use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
-use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
-use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
-use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
+use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
+use Monolog\Logger;
+use Whoops\Handler\HandlerInterface;
 
 class IgnitionServiceProvider extends ServiceProvider
 {

Please login to merge, or discard this patch.

		@@ -2,54 +2,54 @@
		block discarded – undo
2	2
3	3	namespace Facade\Ignition;
4	4
5		-use Monolog\Logger;
6		-use Illuminate\Support\Arr;
7	5	use Facade\FlareClient\Flare;
8		-use Illuminate\Log\LogManager;
9		-use Illuminate\Queue\QueueManager;
10	6	use Facade\FlareClient\Http\Client;
11		-use Illuminate\Support\Facades\Log;
12		-use Whoops\Handler\HandlerInterface;
13		-use Illuminate\Support\Facades\Route;
14		-use Illuminate\Foundation\Application;
	7	+use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
	8	+use Facade\Ignition\Commands\TestCommand;
	9	+use Facade\Ignition\Context\LaravelContextDetector;
	10	+use Facade\Ignition\DumpRecorder\DumpRecorder;
	11	+use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
15	12	use Facade\Ignition\ErrorPage\Renderer;
16		-use Facade\Ignition\Middleware\AddLogs;
17		-use Illuminate\Support\ServiceProvider;
	13	+use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
	14	+use Facade\Ignition\Http\Controllers\HealthCheckController;
	15	+use Facade\Ignition\Http\Controllers\ScriptController;
	16	+use Facade\Ignition\Http\Controllers\ShareReportController;
	17	+use Facade\Ignition\Http\Controllers\StyleController;
	18	+use Facade\Ignition\LogRecorder\LogRecorder;
18	19	use Facade\Ignition\Logger\FlareHandler;
19	20	use Facade\Ignition\Middleware\AddDumps;
20		-use Illuminate\Log\Events\MessageLogged;
21		-use Facade\Ignition\Commands\TestCommand;
	21	+use Facade\Ignition\Middleware\AddEnvironmentInformation;
	22	+use Facade\Ignition\Middleware\AddGitInformation;
	23	+use Facade\Ignition\Middleware\AddLogs;
22	24	use Facade\Ignition\Middleware\AddQueries;
23		-use Facade\Ignition\LogRecorder\LogRecorder;
24	25	use Facade\Ignition\Middleware\AddSolutions;
25		-use Facade\Ignition\Views\Engines\PhpEngine;
26		-use Facade\Ignition\DumpRecorder\DumpRecorder;
27	26	use Facade\Ignition\Middleware\SetNotifierName;
28		-use Facade\Ignition\QueryRecorder\QueryRecorder;
29		-use Facade\Ignition\Middleware\AddGitInformation;
30		-use Facade\Ignition\Views\Engines\CompilerEngine;
31		-use Facade\Ignition\Context\LaravelContextDetector;
32		-use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
33		-use Facade\Ignition\Http\Controllers\StyleController;
34		-use Facade\Ignition\Http\Controllers\ScriptController;
35		-use Facade\Ignition\Middleware\AddEnvironmentInformation;
36		-use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
37		-use Facade\Ignition\Http\Controllers\HealthCheckController;
38		-use Facade\Ignition\Http\Controllers\ShareReportController;
39	27	use Facade\Ignition\Middleware\UpdateMaskedRequestParameters;
40		-use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
41		-use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
42		-use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
	28	+use Facade\Ignition\QueryRecorder\QueryRecorder;
43	29	use Facade\Ignition\SolutionProviders\BadMethodCallSolutionProvider;
44	30	use Facade\Ignition\SolutionProviders\DefaultDbNameSolutionProvider;
	31	+use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
	32	+use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
45	33	use Facade\Ignition\SolutionProviders\MissingAppKeySolutionProvider;
46	34	use Facade\Ignition\SolutionProviders\MissingImportSolutionProvider;
	35	+use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
	36	+use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
47	37	use Facade\Ignition\SolutionProviders\TableNotFoundSolutionProvider;
	38	+use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
	39	+use Facade\Ignition\Views\Engines\CompilerEngine;
	40	+use Facade\Ignition\Views\Engines\PhpEngine;
	41	+use Illuminate\Foundation\Application;
	42	+use Illuminate\Log\Events\MessageLogged;
	43	+use Illuminate\Log\LogManager;
	44	+use Illuminate\Queue\QueueManager;
	45	+use Illuminate\Support\Arr;
	46	+use Illuminate\Support\Facades\Log;
	47	+use Illuminate\Support\Facades\Route;
	48	+use Illuminate\Support\ServiceProvider;
48	49	use Illuminate\View\Engines\CompilerEngine as LaravelCompilerEngine;
49		-use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
50		-use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
51		-use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
52		-use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
	50	+use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
	51	+use Monolog\Logger;
	52	+use Whoops\Handler\HandlerInterface;
53	53
54	54	class IgnitionServiceProvider extends ServiceProvider
55	55	{

facade / ignition

Pull Request — master (#23)

Status

Category

Unused Use Statements +33 added lines, -33 removed lines patch added patch discarded remove patch