Inspection of "[FIX] Remove middle name as facet" - fabarea/vidi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5735a5...38aa76 )

by Fabien

created 2022-06-29 08:43 UTC

Status

Indentation +103 added lines, -103 removed lines patch added patch discarded remove patch

@@ -7,109 +7,109 @@
 block discarded – undo
 if (!defined('TYPO3')) die ('Access denied.');
 
 $tca = [
-    'ctrl' => [
-        // By default "searchFields" has many fields which has a performance cost when dealing with large data-set.
-        // Override search field for performance reason.
-        // To restore default values, just replace with this: $GLOBALS['TCA']['fe_users']['ctrl']['searchFields'] . ',usergroup',
-        'searchFields' => 'username, first_name, last_name, usergroup',
-    ],
-    'vidi' => [
-        // Special case when the field name does not follow the conventions.
-        // Vidi needs a bit of help to find the equivalence fieldName <-> propertyName.
-        'mappings' => [
-            'lockToDomain' => 'lockToDomain',
-            'TSconfig' => 'tsConfig',
-            'felogin_redirectPid' => 'feLoginRedirectPid',
-            'felogin_forgotHash' => 'feLoginForgotHash',
-        ],
-    ],
-    'grid' => [
-        'excluded_fields' => 'lockToDomain, TSconfig, felogin_redirectPid, felogin_forgotHash, auth_token, image',
-        'export' => [
-            'include_files' => false,
-        ],
-        'facets' => [
-            'uid',
-            'username',
-            'name',
-            'first_name',
-            'last_name',
-            'address',
-            'telephone',
-            'fax',
-            'email',
-            'title',
-            'zip',
-            'city',
-            'country',
-            'company',
-            'usergroup',
-            StandardFacet::class => [
-                'name' => 'disable',
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
-                'suggestions' => [
-                    '0' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.0',
-                    '1' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.1'
-                ]
-            ],
-            PageFacet::class => [
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:facet.pid'
-            ],
-        ],
-        'columns' => [
-            '__checkbox' => [
-                'renderer' => CheckBoxRenderer::class,
-            ],
-            'uid' => [
-                'visible' => false,
-                'label' => 'Id',
-                'width' => '5px',
-            ],
-            'username' => [
-                'visible' => true,
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:username',
-                'editable' => true,
-            ],
-            'name' => [
-                'visible' => true,
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:name',
-                'editable' => true,
-            ],
-            'email' => [
-                'visible' => true,
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:email',
-                'editable' => true,
-            ],
-            'usergroup' => [
-                'visible' => true,
-                'renderers' => [
-                    'Fab\Vidi\Grid\RelationEditRenderer',
-                    'Fab\Vidi\Grid\RelationRenderer',
-                ],
-                'editable' => true,
-                'sortable' => false,
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:usergroup',
-            ],
-            'tstamp' => [
-                'visible' => false,
-                'format' => 'Fab\Vidi\Formatter\Date',
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:tstamp',
-            ],
-            'crdate' => [
-                'visible' => false,
-                'format' => 'Fab\Vidi\Formatter\Date',
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:crdate',
-            ],
-            'disable' => [
-                'renderer' => 'Fab\Vidi\Grid\VisibilityRenderer',
-                'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
-                'width' => '3%',
-            ],
-            '__buttons' => [
-                'renderer' => ButtonGroupRenderer::class,
-            ],
-        ],
-    ],
+	'ctrl' => [
+		// By default "searchFields" has many fields which has a performance cost when dealing with large data-set.
+		// Override search field for performance reason.
+		// To restore default values, just replace with this: $GLOBALS['TCA']['fe_users']['ctrl']['searchFields'] . ',usergroup',
+		'searchFields' => 'username, first_name, last_name, usergroup',
+	],
+	'vidi' => [
+		// Special case when the field name does not follow the conventions.
+		// Vidi needs a bit of help to find the equivalence fieldName <-> propertyName.
+		'mappings' => [
+			'lockToDomain' => 'lockToDomain',
+			'TSconfig' => 'tsConfig',
+			'felogin_redirectPid' => 'feLoginRedirectPid',
+			'felogin_forgotHash' => 'feLoginForgotHash',
+		],
+	],
+	'grid' => [
+		'excluded_fields' => 'lockToDomain, TSconfig, felogin_redirectPid, felogin_forgotHash, auth_token, image',
+		'export' => [
+			'include_files' => false,
+		],
+		'facets' => [
+			'uid',
+			'username',
+			'name',
+			'first_name',
+			'last_name',
+			'address',
+			'telephone',
+			'fax',
+			'email',
+			'title',
+			'zip',
+			'city',
+			'country',
+			'company',
+			'usergroup',
+			StandardFacet::class => [
+				'name' => 'disable',
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
+				'suggestions' => [
+					'0' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.0',
+					'1' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.1'
+				]
+			],
+			PageFacet::class => [
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:facet.pid'
+			],
+		],
+		'columns' => [
+			'__checkbox' => [
+				'renderer' => CheckBoxRenderer::class,
+			],
+			'uid' => [
+				'visible' => false,
+				'label' => 'Id',
+				'width' => '5px',
+			],
+			'username' => [
+				'visible' => true,
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:username',
+				'editable' => true,
+			],
+			'name' => [
+				'visible' => true,
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:name',
+				'editable' => true,
+			],
+			'email' => [
+				'visible' => true,
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:email',
+				'editable' => true,
+			],
+			'usergroup' => [
+				'visible' => true,
+				'renderers' => [
+					'Fab\Vidi\Grid\RelationEditRenderer',
+					'Fab\Vidi\Grid\RelationRenderer',
+				],
+				'editable' => true,
+				'sortable' => false,
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:usergroup',
+			],
+			'tstamp' => [
+				'visible' => false,
+				'format' => 'Fab\Vidi\Formatter\Date',
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:tstamp',
+			],
+			'crdate' => [
+				'visible' => false,
+				'format' => 'Fab\Vidi\Formatter\Date',
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:crdate',
+			],
+			'disable' => [
+				'renderer' => 'Fab\Vidi\Grid\VisibilityRenderer',
+				'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
+				'width' => '3%',
+			],
+			'__buttons' => [
+				'renderer' => ButtonGroupRenderer::class,
+			],
+		],
+	],
 ];
 
 ArrayUtility::mergeRecursiveWithOverrule($GLOBALS['TCA']['fe_users'], $tca);

Please login to merge, or discard this patch.

		@@ -7,109 +7,109 @@
		block discarded – undo
7	7	if (!defined('TYPO3')) die ('Access denied.');
8	8
9	9	$tca = [
10		- 'ctrl' => [
11		- // By default "searchFields" has many fields which has a performance cost when dealing with large data-set.
12		- // Override search field for performance reason.
13		- // To restore default values, just replace with this: $GLOBALS['TCA']['fe_users']['ctrl']['searchFields'] . ',usergroup',
14		- 'searchFields' => 'username, first_name, last_name, usergroup',
15		- ],
16		- 'vidi' => [
17		- // Special case when the field name does not follow the conventions.
18		- // Vidi needs a bit of help to find the equivalence fieldName <-> propertyName.
19		- 'mappings' => [
20		- 'lockToDomain' => 'lockToDomain',
21		- 'TSconfig' => 'tsConfig',
22		- 'felogin_redirectPid' => 'feLoginRedirectPid',
23		- 'felogin_forgotHash' => 'feLoginForgotHash',
24		- ],
25		- ],
26		- 'grid' => [
27		- 'excluded_fields' => 'lockToDomain, TSconfig, felogin_redirectPid, felogin_forgotHash, auth_token, image',
28		- 'export' => [
29		- 'include_files' => false,
30		- ],
31		- 'facets' => [
32		- 'uid',
33		- 'username',
34		- 'name',
35		- 'first_name',
36		- 'last_name',
37		- 'address',
38		- 'telephone',
39		- 'fax',
40		- 'email',
41		- 'title',
42		- 'zip',
43		- 'city',
44		- 'country',
45		- 'company',
46		- 'usergroup',
47		- StandardFacet::class => [
48		- 'name' => 'disable',
49		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
50		- 'suggestions' => [
51		- '0' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.0',
52		- '1' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.1'
53		- ]
54		- ],
55		- PageFacet::class => [
56		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:facet.pid'
57		- ],
58		- ],
59		- 'columns' => [
60		- '__checkbox' => [
61		- 'renderer' => CheckBoxRenderer::class,
62		- ],
63		- 'uid' => [
64		- 'visible' => false,
65		- 'label' => 'Id',
66		- 'width' => '5px',
67		- ],
68		- 'username' => [
69		- 'visible' => true,
70		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:username',
71		- 'editable' => true,
72		- ],
73		- 'name' => [
74		- 'visible' => true,
75		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:name',
76		- 'editable' => true,
77		- ],
78		- 'email' => [
79		- 'visible' => true,
80		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:email',
81		- 'editable' => true,
82		- ],
83		- 'usergroup' => [
84		- 'visible' => true,
85		- 'renderers' => [
86		- 'Fab\Vidi\Grid\RelationEditRenderer',
87		- 'Fab\Vidi\Grid\RelationRenderer',
88		- ],
89		- 'editable' => true,
90		- 'sortable' => false,
91		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:usergroup',
92		- ],
93		- 'tstamp' => [
94		- 'visible' => false,
95		- 'format' => 'Fab\Vidi\Formatter\Date',
96		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:tstamp',
97		- ],
98		- 'crdate' => [
99		- 'visible' => false,
100		- 'format' => 'Fab\Vidi\Formatter\Date',
101		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:crdate',
102		- ],
103		- 'disable' => [
104		- 'renderer' => 'Fab\Vidi\Grid\VisibilityRenderer',
105		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
106		- 'width' => '3%',
107		- ],
108		- '__buttons' => [
109		- 'renderer' => ButtonGroupRenderer::class,
110		- ],
111		- ],
112		- ],
	10	+ 'ctrl' => [
	11	+ // By default "searchFields" has many fields which has a performance cost when dealing with large data-set.
	12	+ // Override search field for performance reason.
	13	+ // To restore default values, just replace with this: $GLOBALS['TCA']['fe_users']['ctrl']['searchFields'] . ',usergroup',
	14	+ 'searchFields' => 'username, first_name, last_name, usergroup',
	15	+ ],
	16	+ 'vidi' => [
	17	+ // Special case when the field name does not follow the conventions.
	18	+ // Vidi needs a bit of help to find the equivalence fieldName <-> propertyName.
	19	+ 'mappings' => [
	20	+ 'lockToDomain' => 'lockToDomain',
	21	+ 'TSconfig' => 'tsConfig',
	22	+ 'felogin_redirectPid' => 'feLoginRedirectPid',
	23	+ 'felogin_forgotHash' => 'feLoginForgotHash',
	24	+ ],
	25	+ ],
	26	+ 'grid' => [
	27	+ 'excluded_fields' => 'lockToDomain, TSconfig, felogin_redirectPid, felogin_forgotHash, auth_token, image',
	28	+ 'export' => [
	29	+ 'include_files' => false,
	30	+ ],
	31	+ 'facets' => [
	32	+ 'uid',
	33	+ 'username',
	34	+ 'name',
	35	+ 'first_name',
	36	+ 'last_name',
	37	+ 'address',
	38	+ 'telephone',
	39	+ 'fax',
	40	+ 'email',
	41	+ 'title',
	42	+ 'zip',
	43	+ 'city',
	44	+ 'country',
	45	+ 'company',
	46	+ 'usergroup',
	47	+ StandardFacet::class => [
	48	+ 'name' => 'disable',
	49	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
	50	+ 'suggestions' => [
	51	+ '0' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.0',
	52	+ '1' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active.1'
	53	+ ]
	54	+ ],
	55	+ PageFacet::class => [
	56	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:facet.pid'
	57	+ ],
	58	+ ],
	59	+ 'columns' => [
	60	+ '__checkbox' => [
	61	+ 'renderer' => CheckBoxRenderer::class,
	62	+ ],
	63	+ 'uid' => [
	64	+ 'visible' => false,
	65	+ 'label' => 'Id',
	66	+ 'width' => '5px',
	67	+ ],
	68	+ 'username' => [
	69	+ 'visible' => true,
	70	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:username',
	71	+ 'editable' => true,
	72	+ ],
	73	+ 'name' => [
	74	+ 'visible' => true,
	75	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:name',
	76	+ 'editable' => true,
	77	+ ],
	78	+ 'email' => [
	79	+ 'visible' => true,
	80	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:email',
	81	+ 'editable' => true,
	82	+ ],
	83	+ 'usergroup' => [
	84	+ 'visible' => true,
	85	+ 'renderers' => [
	86	+ 'Fab\Vidi\Grid\RelationEditRenderer',
	87	+ 'Fab\Vidi\Grid\RelationRenderer',
	88	+ ],
	89	+ 'editable' => true,
	90	+ 'sortable' => false,
	91	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/fe_users.xlf:usergroup',
	92	+ ],
	93	+ 'tstamp' => [
	94	+ 'visible' => false,
	95	+ 'format' => 'Fab\Vidi\Formatter\Date',
	96	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:tstamp',
	97	+ ],
	98	+ 'crdate' => [
	99	+ 'visible' => false,
	100	+ 'format' => 'Fab\Vidi\Formatter\Date',
	101	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:crdate',
	102	+ ],
	103	+ 'disable' => [
	104	+ 'renderer' => 'Fab\Vidi\Grid\VisibilityRenderer',
	105	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/locallang.xlf:active',
	106	+ 'width' => '3%',
	107	+ ],
	108	+ '__buttons' => [
	109	+ 'renderer' => ButtonGroupRenderer::class,
	110	+ ],
	111	+ ],
	112	+ ],
113	113	];
114	114
115	115	ArrayUtility::mergeRecursiveWithOverrule($GLOBALS['TCA']['fe_users'], $tca);

fabarea / vidi

Push — master ( 5735a5...38aa76 )

Status

Category

Indentation +103 added lines, -103 removed lines patch added patch discarded remove patch