Inspection of "[BUGFIX] Correct usage of "label" and "title" in T..." - fabarea/vidi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4a889f...9bbc4e )

by Fabien

created 2019-07-12 11:33 UTC

Status

Indentation +83 added lines, -83 removed lines patch added patch discarded remove patch

@@ -2,88 +2,88 @@
 block discarded – undo
 if (!defined('TYPO3_MODE')) die ('Access denied.');
 
 return [
-    'ctrl' => [
-        'title' => 'LLL:EXT:phpdisplay/Resources/Private/Language/locallang_db.xml:tx_phpdisplay_displays',
-        'label' => 'name',
-        'tstamp' => 'tstamp',
-        'crdate' => 'crdate',
-        'cruser_id' => 'cruser_id',
-        'hideTable' => true,
-        'delete' => 'deleted',
-        'enablecolumns' => [
-            'disabled' => 'hidden',
-        ],
-        'searchFields' => 'type,name,data_type',
-        'typeicon_classes' => [
-            'default' => 'extensions-vidi-selection',
-        ],
-    ],
-    'types' => [
-        '1' => ['showitem' => 'hidden,--palette--;;1, type, name, data_type, query'],
-    ],
-    'palettes' => [
-        '1' => ['showitem' => ''],
-    ],
-    'columns' => [
+	'ctrl' => [
+		'title' => 'LLL:EXT:phpdisplay/Resources/Private/Language/locallang_db.xml:tx_phpdisplay_displays',
+		'label' => 'name',
+		'tstamp' => 'tstamp',
+		'crdate' => 'crdate',
+		'cruser_id' => 'cruser_id',
+		'hideTable' => true,
+		'delete' => 'deleted',
+		'enablecolumns' => [
+			'disabled' => 'hidden',
+		],
+		'searchFields' => 'type,name,data_type',
+		'typeicon_classes' => [
+			'default' => 'extensions-vidi-selection',
+		],
+	],
+	'types' => [
+		'1' => ['showitem' => 'hidden,--palette--;;1, type, name, data_type, query'],
+	],
+	'palettes' => [
+		'1' => ['showitem' => ''],
+	],
+	'columns' => [
 
-        'hidden' => [
-            'exclude' => 1,
-            'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.hidden',
-            'config' => [
-                'type' => 'check',
-            ],
-        ],
-        'visibility' => [
-            'exclude' => 0,
-            'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility',
-            'config' => [
-                'type' => 'select',
-                'renderType' => 'selectSingle',
-                'items' => [
-                    ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.everyone', 0],
-                    ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.private', 1],
-                    ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.admin_only', 2],
-                ],
-                'size' => 1,
-                'maxitems' => 1,
-                'minitems' => 1,
-            ],
-        ],
-        'name' => [
-            'exclude' => 0,
-            'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:name',
-            'config' => [
-                'type' => 'input',
-                'size' => 30,
-                'eval' => 'trim,required'
-            ],
-        ],
-        'data_type' => [
-            'exclude' => 0,
-            'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:data_type',
-            'config' => [
-                'type' => 'input',
-                'size' => 30,
-                'eval' => 'trim,required'
-            ],
-        ],
-        'query' => [
-            'exclude' => 0,
-            'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:query',
-            'config' => [
-                'type' => 'text',
-                'rows' => 5,
-                'cols' => 5,
-            ],
-        ],
-        'speaking_query' => [
-            'exclude' => 0,
-            'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:speaking_query',
-            'config' => [
-                'type' => 'text',
-                'rows' => 5,
-                'cols' => 5,
-            ],
-        ],
-    ],
+		'hidden' => [
+			'exclude' => 1,
+			'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.hidden',
+			'config' => [
+				'type' => 'check',
+			],
+		],
+		'visibility' => [
+			'exclude' => 0,
+			'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility',
+			'config' => [
+				'type' => 'select',
+				'renderType' => 'selectSingle',
+				'items' => [
+					['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.everyone', 0],
+					['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.private', 1],
+					['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.admin_only', 2],
+				],
+				'size' => 1,
+				'maxitems' => 1,
+				'minitems' => 1,
+			],
+		],
+		'name' => [
+			'exclude' => 0,
+			'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:name',
+			'config' => [
+				'type' => 'input',
+				'size' => 30,
+				'eval' => 'trim,required'
+			],
+		],
+		'data_type' => [
+			'exclude' => 0,
+			'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:data_type',
+			'config' => [
+				'type' => 'input',
+				'size' => 30,
+				'eval' => 'trim,required'
+			],
+		],
+		'query' => [
+			'exclude' => 0,
+			'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:query',
+			'config' => [
+				'type' => 'text',
+				'rows' => 5,
+				'cols' => 5,
+			],
+		],
+		'speaking_query' => [
+			'exclude' => 0,
+			'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:speaking_query',
+			'config' => [
+				'type' => 'text',
+				'rows' => 5,
+				'cols' => 5,
+			],
+		],
+	],
 ];

Please login to merge, or discard this patch.

		@@ -2,88 +2,88 @@
		block discarded – undo
2	2	if (!defined('TYPO3_MODE')) die ('Access denied.');
3	3
4	4	return [
5		- 'ctrl' => [
6		- 'title' => 'LLL:EXT:phpdisplay/Resources/Private/Language/locallang_db.xml:tx_phpdisplay_displays',
7		- 'label' => 'name',
8		- 'tstamp' => 'tstamp',
9		- 'crdate' => 'crdate',
10		- 'cruser_id' => 'cruser_id',
11		- 'hideTable' => true,
12		- 'delete' => 'deleted',
13		- 'enablecolumns' => [
14		- 'disabled' => 'hidden',
15		- ],
16		- 'searchFields' => 'type,name,data_type',
17		- 'typeicon_classes' => [
18		- 'default' => 'extensions-vidi-selection',
19		- ],
20		- ],
21		- 'types' => [
22		- '1' => ['showitem' => 'hidden,--palette--;;1, type, name, data_type, query'],
23		- ],
24		- 'palettes' => [
25		- '1' => ['showitem' => ''],
26		- ],
27		- 'columns' => [
	5	+ 'ctrl' => [
	6	+ 'title' => 'LLL:EXT:phpdisplay/Resources/Private/Language/locallang_db.xml:tx_phpdisplay_displays',
	7	+ 'label' => 'name',
	8	+ 'tstamp' => 'tstamp',
	9	+ 'crdate' => 'crdate',
	10	+ 'cruser_id' => 'cruser_id',
	11	+ 'hideTable' => true,
	12	+ 'delete' => 'deleted',
	13	+ 'enablecolumns' => [
	14	+ 'disabled' => 'hidden',
	15	+ ],
	16	+ 'searchFields' => 'type,name,data_type',
	17	+ 'typeicon_classes' => [
	18	+ 'default' => 'extensions-vidi-selection',
	19	+ ],
	20	+ ],
	21	+ 'types' => [
	22	+ '1' => ['showitem' => 'hidden,--palette--;;1, type, name, data_type, query'],
	23	+ ],
	24	+ 'palettes' => [
	25	+ '1' => ['showitem' => ''],
	26	+ ],
	27	+ 'columns' => [
28	28
29		- 'hidden' => [
30		- 'exclude' => 1,
31		- 'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.hidden',
32		- 'config' => [
33		- 'type' => 'check',
34		- ],
35		- ],
36		- 'visibility' => [
37		- 'exclude' => 0,
38		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility',
39		- 'config' => [
40		- 'type' => 'select',
41		- 'renderType' => 'selectSingle',
42		- 'items' => [
43		- ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.everyone', 0],
44		- ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.private', 1],
45		- ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.admin_only', 2],
46		- ],
47		- 'size' => 1,
48		- 'maxitems' => 1,
49		- 'minitems' => 1,
50		- ],
51		- ],
52		- 'name' => [
53		- 'exclude' => 0,
54		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:name',
55		- 'config' => [
56		- 'type' => 'input',
57		- 'size' => 30,
58		- 'eval' => 'trim,required'
59		- ],
60		- ],
61		- 'data_type' => [
62		- 'exclude' => 0,
63		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:data_type',
64		- 'config' => [
65		- 'type' => 'input',
66		- 'size' => 30,
67		- 'eval' => 'trim,required'
68		- ],
69		- ],
70		- 'query' => [
71		- 'exclude' => 0,
72		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:query',
73		- 'config' => [
74		- 'type' => 'text',
75		- 'rows' => 5,
76		- 'cols' => 5,
77		- ],
78		- ],
79		- 'speaking_query' => [
80		- 'exclude' => 0,
81		- 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:speaking_query',
82		- 'config' => [
83		- 'type' => 'text',
84		- 'rows' => 5,
85		- 'cols' => 5,
86		- ],
87		- ],
88		- ],
	29	+ 'hidden' => [
	30	+ 'exclude' => 1,
	31	+ 'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.hidden',
	32	+ 'config' => [
	33	+ 'type' => 'check',
	34	+ ],
	35	+ ],
	36	+ 'visibility' => [
	37	+ 'exclude' => 0,
	38	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility',
	39	+ 'config' => [
	40	+ 'type' => 'select',
	41	+ 'renderType' => 'selectSingle',
	42	+ 'items' => [
	43	+ ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.everyone', 0],
	44	+ ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.private', 1],
	45	+ ['LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:visibility.admin_only', 2],
	46	+ ],
	47	+ 'size' => 1,
	48	+ 'maxitems' => 1,
	49	+ 'minitems' => 1,
	50	+ ],
	51	+ ],
	52	+ 'name' => [
	53	+ 'exclude' => 0,
	54	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:name',
	55	+ 'config' => [
	56	+ 'type' => 'input',
	57	+ 'size' => 30,
	58	+ 'eval' => 'trim,required'
	59	+ ],
	60	+ ],
	61	+ 'data_type' => [
	62	+ 'exclude' => 0,
	63	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:data_type',
	64	+ 'config' => [
	65	+ 'type' => 'input',
	66	+ 'size' => 30,
	67	+ 'eval' => 'trim,required'
	68	+ ],
	69	+ ],
	70	+ 'query' => [
	71	+ 'exclude' => 0,
	72	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:query',
	73	+ 'config' => [
	74	+ 'type' => 'text',
	75	+ 'rows' => 5,
	76	+ 'cols' => 5,
	77	+ ],
	78	+ ],
	79	+ 'speaking_query' => [
	80	+ 'exclude' => 0,
	81	+ 'label' => 'LLL:EXT:vidi/Resources/Private/Language/tx_vidi_selection.xlf:speaking_query',
	82	+ 'config' => [
	83	+ 'type' => 'text',
	84	+ 'rows' => 5,
	85	+ 'cols' => 5,
	86	+ ],
	87	+ ],
	88	+ ],
89	89	];

fabarea / vidi

Push — master ( 4a889f...9bbc4e )

Status

Category

Indentation +83 added lines, -83 removed lines patch added patch discarded remove patch