fab2s\YaEtl\Laravel\Extractors\DelayedExtractQueryTrait::setExtractQuery()

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function setExtractQuery($extractQuery): DbExtractorAbstract
    {
        if (!($extractQuery instanceof Builder)) {

$extractQuery is always a sub-type of Illuminate\Database\Query\Builder.

            throw new YaEtlException('Argument 1 passed to ' . __METHOD__ . ' must be an instance of ' . Builder::class . ', ' . \gettype($extractQuery) . ' given');
        }

        if (!isset($this->pdo)) {
            $this->configurePdo($extractQuery->getConnection()->getPdo());

It seems like configurePdo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        parent::setExtractQuery($extractQuery);

        return $this;
    }