fab2s\YaEtl\Laravel\Extractors\DelayedExtractQueryTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	setExtractQuery()	0	13	3

<?php

/*
 * This file is part of YaEtl
 *     (c) Fabrice de Stefanis / https://github.com/fab2s/YaEtl
 * This source file is licensed under the MIT license which you will
 * find in the LICENSE file or at https://opensource.org/licenses/MIT
 */

namespace fab2s\YaEtl\Laravel\Extractors;

use fab2s\YaEtl\Extractors\DbExtractorAbstract;
use fab2s\YaEtl\YaEtlException;
use Illuminate\Database\Query\Builder;

trait DelayedExtractQueryTrait
{
    /**
     * Set the extract query
     *
     * @param Builder $extractQuery
     *
     * @throws YaEtlException
     *
     * @return static
     */
    public function setExtractQuery($extractQuery): DbExtractorAbstract
    {
        if (!($extractQuery instanceof Builder)) {

$extractQuery is always a sub-type of Illuminate\Database\Query\Builder.

            throw new YaEtlException('Argument 1 passed to ' . __METHOD__ . ' must be an instance of ' . Builder::class . ', ' . \gettype($extractQuery) . ' given');
        }

        if (!isset($this->pdo)) {
            $this->configurePdo($extractQuery->getConnection()->getPdo());

It seems like configurePdo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        parent::setExtractQuery($extractQuery);

        return $this;
    }
}