ezsystems / ezpublish-kernel

eZ/Bundle/EzPublishMigrationBundle/Command/LegacyStorage/RegenerateUrlAliasesCommand.php

Doc Comments +1 added lines

@@ -893,6 +893,7 @@
      * Returns total number of Locations in the database.
      *
      * The number excludes absolute root Location, which does not have an URL alias.
+     * @return integer
      */
     protected function getTotalLocationCount()
     {

eZ/Publish/API/Repository/Tests/BaseTest.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 use eZ\Publish\API\Repository\Exceptions\ContentFieldValidationException;
 use eZ\Publish\API\Repository\Tests\PHPUnitConstraint\ValidationErrorOccurs as PHPUnitConstraintValidationErrorOccurs;
-use eZ\Publish\API\Repository\Values\Content\Location;
 use EzSystems\EzPlatformSolrSearchEngine\Tests\SetupFactory\LegacySetupFactory as LegacySolrSetupFactory;
 use PHPUnit\Framework\TestCase;
 use eZ\Publish\API\Repository\Repository;

eZ/Publish/API/Repository/Tests/URLAliasServiceTest.php

Doc Comments +5 added lines, -1 removed lines

@@ -1270,7 +1270,7 @@ 
 
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo
-     * @param $fieldDefinitionIdentifier
+     * @param string $fieldDefinitionIdentifier
      * @param array $fieldValues
      *
      * @return \eZ\Publish\API\Repository\Values\Content\Content
@@ -1387,6 +1387,10 @@ 
         $contentTypeService->publishContentTypeDraft($contentTypeDraft);
     }
 
+    /**
+     * @param string $expectedPath
+     * @param boolean $expectedIsHistory
+     */
     private function assertUrlAliasPropertiesCorrect(
         Location $expectedDestinationLocation,
         $expectedPath,

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

Doc Comments +24 added lines, -21 removed lines

@@ -95,7 +95,7 @@ 
      *
      * @todo optimize
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return array
      */
@@ -249,7 +249,7 @@ 
     /**
      * Returns data for the first level children of the location identified by given $locationId.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -376,6 +376,9 @@ 
         }
     }
 
+    /**
+     * @param string $pathString
+     */
     private function isHiddenByParent($pathString, array $rows)
     {
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -576,10 +579,10 @@ 
      * Make the location identified by $locationId1 refer to the Content
      * referred to by $locationId2 and vice versa.
      *
-     * @param mixed $locationId1
-     * @param mixed $locationId2
+     * @param integer $locationId1
+     * @param integer $locationId2
      *
-     * @return bool
+     * @return boolean|null
      */
     public function swap($locationId1, $locationId2)
     {
@@ -736,7 +739,7 @@ 
      * Create an entry in the node assignment table.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
-     * @param mixed $parentNodeId
+     * @param string $parentNodeId
      * @param int $type
      */
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -864,8 +867,8 @@ 
      *
      * Convert existing node assignments into real locations.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
     {
@@ -933,8 +936,8 @@ 
     /**
      * Updates all Locations of content identified with $contentId with $versionNo.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function updateLocationsContentVersionNo($contentId, $versionNo)
     {
@@ -1093,8 +1096,8 @@ 
      * the node identified by given $locationId (current main node).
      * Assumes that content has more than one location.
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
+     * @param integer $contentId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -1130,9 +1133,9 @@ 
      *
      * The associated content object is left untouched.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function trashLocation($locationId)
     {
@@ -1161,8 +1164,8 @@ 
      * at the old position. If this is not possible ( because the old location
      * does not exist any more) and exception is thrown.
      *
-     * @param mixed $locationId
-     * @param mixed|null $newParentId
+     * @param integer $locationId
+     * @param integer $newParentId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location
      */
@@ -1415,10 +1418,10 @@ 
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
      * $contentId, $parentLocationId and $versionNo
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
+     * @param integer $contentId
+     * @param integer $locationId
+     * @param integer $versionNo version number, needed to update eznode_assignment table
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
      *        eznode_assignment table
      */
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1546,7 +1549,7 @@ 
     /**
      * Get Query Builder for fetching data of all Locations except the Root node.
      *
-     * @param array $columns list of columns to fetch
+     * @param string[] $columns list of columns to fetch
      *
      * @return \Doctrine\DBAL\Query\QueryBuilder
      */

eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Handler.php

Doc Comments +9 added lines, -9 removed lines

@@ -307,7 +307,7 @@ 
      * If $languageCode is null the $alias is created in the system's default
      * language. $alwaysAvailable makes the alias available in all languages.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      * @param string $path
      * @param bool $forwarding
      * @param string $languageCode
@@ -473,7 +473,7 @@ 
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      * @param bool $custom if true the user generated aliases are listed otherwise the autogenerated
      *
      * @return \eZ\Publish\SPI\Persistence\Content\UrlAlias[]
@@ -611,9 +611,9 @@ 
      *
      * This method triggers the change of the autogenerated aliases.
      *
-     * @param mixed $locationId
-     * @param mixed $oldParentId
-     * @param mixed $newParentId
+     * @param integer $locationId
+     * @param integer $oldParentId
+     * @param integer $newParentId
      */
     public function locationMoved($locationId, $oldParentId, $newParentId)
     {
@@ -641,9 +641,9 @@ 
      *
      * This method triggers the creation of the autogenerated aliases for the copied locations
      *
-     * @param mixed $locationId
-     * @param mixed $newLocationId
-     * @param mixed $newParentId
+     * @param integer $locationId
+     * @param integer $newLocationId
+     * @param integer $newParentId
      */
     public function locationCopied($locationId, $newLocationId, $newParentId)
     {
@@ -972,7 +972,7 @@ 
     /**
      * Notifies the underlying engine that a location was deleted or moved to trash.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      */
     public function locationDeleted($locationId)
     {

eZ/Publish/Core/Repository/Helper/DomainMapper.php

Doc Comments +2 added lines, -2 removed lines

@@ -323,7 +323,7 @@ 
      * @param \eZ\Publish\SPI\Persistence\Content\Location $spiLocation
      * @param \eZ\Publish\SPI\Persistence\Content\ContentInfo $spiContentInfo pre-loaded Content Info
      *
-     * @return \eZ\Publish\API\Repository\Values\Content\Location
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
      *
      * @throws \eZ\Publish\Core\Base\Exceptions\InvalidArgumentException In case if the given Content does not belong to the given Location
      */
@@ -394,7 +394,7 @@ 
      * @param \eZ\Publish\API\Repository\Values\Content\Location $parentLocation
      * @param mixed $mainLocation
      * @param mixed $contentId
-     * @param mixed $contentVersionNo
+     * @param null|integer $contentVersionNo
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct
      */

eZ/Publish/Core/Repository/Tests/Service/Mock/UrlAliasTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -3585,7 +3585,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\eZ\Publish\Core\Repository\Helper\NameSchemaService
+     * @return \eZ\Publish\Core\Repository\Helper\NameSchemaService
      */
     protected function getNameSchemaServiceMock()
     {