The call to the method Symfony\Component\Config...arNodeDefinition::end() seems un-needed as the method has no side-effects.
PHP Analyzer performs a side-effects analysis of your code. A side-effect is
basically anything that might be visible after the scope of the method is left.
If we look at the getEmail() method, we can see that it has no side-effect.
Whether you call this method or not, no future calls to other methods are affected
by this. As such code as the following is useless:
$user=newUser();$user->getEmail();// This line could safely be removed as it has no effect.
On the hand, if we look at the setEmail(), this method _has_ side-effects.
In the following case, we could not remove the method call:
$user=newUser();$user->setEmail('email@domain');// This line has a side-effect (it changes an// instance variable).
Loading history...
32
->arrayNode(self::ROOT_NODE_KEY)
33
->useAttributeAsKey('name')
34
->scalarPrototype()
35
->end();
36
}
37
38
public function mapConfig(array &$scopeSettings, $currentScope, ContextualizerInterface $contextualizer): void
39
{
40
$contextualizer->setContextualParameter(
41
'location_references',
42
$currentScope,
43
$scopeSettings['location_references'] ?? []
44
);
45
}
46
47
public function postMap(array $config, ContextualizerInterface $contextualizer): void
ezsystems /
ezpublish-kernel
PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left.
Let’s take a look at an example:
If we look at the
getEmail()method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless:On the hand, if we look at the
setEmail(), this method _has_ side-effects. In the following case, we could not remove the method call: