LocationReferenceConfigParser - Code Metrics - Inspection of "Impl. Location References (CS)" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — location_references ( 47d67d )

unknown

created 2019-09-16 20:40 UTC

LocationReferenceConfigParser A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

Metric	Value
dl	0
loc	27
rs	10
c	0
b	0
f	0
wmc	3
lcom	0
cbo	5

3 Methods

Rating	Name	Size	Complexity
A	addSemanticConfig()	8	1
A	mapConfig()	8	1
A	postMap()	4	1

<?php

declare(strict_types=1);

namespace eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\Parser;

use eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\AbstractParser;
use eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\SiteAccessAware\ContextualizerInterface;
use Symfony\Component\Config\Definition\Builder\NodeBuilder;

/**
 * Configuration parser for Location References.
 *
 * Example configuration:
 *
 * ```yaml
 * ezpublish:
 *   system:
 *      default: # configuration per siteaccess or siteaccess group
 *          location_references:
 *              media: remote_id("babe4a915b1dd5d369e79adb9d6c0c6a")
 *              # ...
 * ```
 */
final class LocationReferenceConfigParser extends AbstractParser
{
    private const ROOT_NODE_KEY = 'location_references';

    public function addSemanticConfig(NodeBuilder $nodeBuilder): void
    {
        $nodeBuilder
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
            ->arrayNode(self::ROOT_NODE_KEY)
                ->useAttributeAsKey('name')
                ->scalarPrototype()
            ->end();
    }

    public function mapConfig(array &$scopeSettings, $currentScope, ContextualizerInterface $contextualizer): void
    {
        $contextualizer->setContextualParameter(
            'location_references',
            $currentScope,
            $scopeSettings['location_references'] ?? []
        );
    }

    public function postMap(array $config, ContextualizerInterface $contextualizer): void
    {
        $contextualizer->mapConfigArray('location_references', $config);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\Parser;
6
7			use eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\AbstractParser;
8			use eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\SiteAccessAware\ContextualizerInterface;
9			use Symfony\Component\Config\Definition\Builder\NodeBuilder;
10
11			/**
12			* Configuration parser for Location References.
13			*
14			* Example configuration:
15			*
16			* ```yaml
17			* ezpublish:
18			* system:
19			* default: # configuration per siteaccess or siteaccess group
20			* location_references:
21			* media: remote_id("babe4a915b1dd5d369e79adb9d6c0c6a")
22			* # ...
23			* ```
24			*/
25			final class LocationReferenceConfigParser extends AbstractParser
26			{
27			private const ROOT_NODE_KEY = 'location_references';
28
29			public function addSemanticConfig(NodeBuilder $nodeBuilder): void
30			{
31			$nodeBuilder
			0 ignored issues – show Unused Code introduced 2019-09-16 20:53 UTC by Report Bug Copy Issue Report The call to the method `Symfony\Component\Config...arNodeDefinition::end()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
32			->arrayNode(self::ROOT_NODE_KEY)
33			->useAttributeAsKey('name')
34			->scalarPrototype()
35			->end();
36			}
37
38			public function mapConfig(array &$scopeSettings, $currentScope, ContextualizerInterface $contextualizer): void
39			{
40			$contextualizer->setContextualParameter(
41			'location_references',
42			$currentScope,
43			$scopeSettings['location_references'] ?? []
44			);
45			}
46
47			public function postMap(array $config, ContextualizerInterface $contextualizer): void
48			{
49			$contextualizer->mapConfigArray('location_references', $config);
50			}
51			}
52

ezsystems / ezpublish-kernel

Push — location_references ( 47d67d )

LocationReferenceConfigParser A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like