ezsystems / ezpublish-kernel

eZ/Publish/Core/Persistence/Legacy/Content/Location/Handler.php

Doc Comments +11 added lines, -11 removed lines

@@ -365,10 +365,10 @@ 
      * destination, identified by $destinationParentId. Relations do not need
      * to be updated, since they refer to Content. URLs are not touched.
      *
-     * @param mixed $sourceId
-     * @param mixed $destinationParentId
+     * @param integer $sourceId
+     * @param integer $destinationParentId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function move($sourceId, $destinationParentId)
     {
@@ -411,7 +411,7 @@ 
     /**
      * Sets a location to be hidden, and it self + all children to invisible.
      *
-     * @param mixed $id Location ID
+     * @param integer $id Location ID
      */
     public function hide($id)
     {
@@ -424,7 +424,7 @@ 
      * Sets a location to be unhidden, and self + children to visible unless a parent is hiding the tree.
      * If not make sure only children down to first hidden node is marked visible.
      *
-     * @param mixed $id
+     * @param integer $id
      */
     public function unHide($id)
     {
@@ -439,10 +439,10 @@ 
      * Make the location identified by $locationId1 refer to the Content
      * referred to by $locationId2 and vice versa.
      *
-     * @param mixed $locationId1
-     * @param mixed $locationId2
+     * @param integer $locationId1
+     * @param integer $locationId2
      *
-     * @return bool
+     * @return boolean|null
      */
     public function swap($locationId1, $locationId2)
     {
@@ -489,9 +489,9 @@ 
      * main Location will get the first of its other Locations assigned as the
      * new main Location.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function removeSubtree($locationId)
     {
@@ -502,7 +502,7 @@ 
      * Set section on all content objects in the subtree.
      *
      * @param mixed $locationId
-     * @param mixed $sectionId
+     * @param integer $sectionId
      */
     public function setSectionForSubtree($locationId, $sectionId)
     {

eZ/Publish/Core/Persistence/Cache/LocationHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -339,9 +339,9 @@
      * Return relevant content and location tags so cache can be purged reliably.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location $location
-     * @param array $tags Optional, can be used to specify additional tags.
+     * @param string[] $tags Optional, can be used to specify additional tags.
      *
-     * @return array
+     * @return string[]
      */
     private function getCacheTags(Location $location, $tags = [])
     {

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

Doc Comments +20 added lines, -17 removed lines

@@ -247,7 +247,7 @@ 
     /**
      * Returns data for the first level children of the location identified by given $locationId.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -374,6 +374,9 @@ 
         }
     }
 
+    /**
+     * @param string $pathString
+     */
     private function isHiddenByParent($pathString, array $rows)
     {
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -751,7 +754,7 @@ 
      * Create an entry in the node assignment table.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
-     * @param mixed $parentNodeId
+     * @param string $parentNodeId
      * @param int $type
      */
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -879,8 +882,8 @@ 
      *
      * Convert existing node assignments into real locations.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
     {
@@ -948,8 +951,8 @@ 
     /**
      * Updates all Locations of content identified with $contentId with $versionNo.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function updateLocationsContentVersionNo($contentId, $versionNo)
     {
@@ -1108,8 +1111,8 @@ 
      * the node identified by given $locationId (current main node).
      * Assumes that content has more than one location.
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
+     * @param integer $contentId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -1145,9 +1148,9 @@ 
      *
      * The associated content object is left untouched.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function trashLocation($locationId)
     {
@@ -1177,8 +1180,8 @@ 
      * at the old position. If this is not possible ( because the old location
      * does not exist any more) and exception is thrown.
      *
-     * @param mixed $locationId
-     * @param mixed|null $newParentId
+     * @param integer $locationId
+     * @param integer $newParentId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location
      */
@@ -1431,10 +1434,10 @@ 
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
      * $contentId, $parentLocationId and $versionNo
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
+     * @param integer $contentId
+     * @param integer $locationId
+     * @param integer $versionNo version number, needed to update eznode_assignment table
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
      *        eznode_assignment table
      */
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1564,7 +1567,7 @@ 
      *
      * @todo Align with createNodeQueryBuilder, removing the need for both(?)
      *
-     * @param array $columns list of columns to fetch
+     * @param string[] $columns list of columns to fetch
      *
      * @return \Doctrine\DBAL\Query\QueryBuilder
      */

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/ExceptionConversion.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use eZ\Publish\Core\Persistence\Legacy\Content\Location\Gateway;
 use eZ\Publish\SPI\Persistence\Content\Location\UpdateStruct;
 use eZ\Publish\SPI\Persistence\Content\Location\CreateStruct;
-use Doctrine\DBAL\DBALException;
 use PDOException;
 
 /**