BookmarkListTest::testVisit() - Code Metrics - Inspection of "fix review comments" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — siteaccessaware-layer-only ( 37e924...bf143e )

by André

created 2018-06-16 08:18 UTC

BookmarkListTest::testVisit() A

↳ Parent: BookmarkListTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	11

Duplication

Lines	19
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	11
nc	1
nop	0
dl	19
loc	19
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
declare(strict_types=1);

namespace eZ\Publish\Core\REST\Server\Tests\Output\ValueObjectVisitor;

use DOMDocument;
use DOMXPath;
use eZ\Publish\API\Repository\Values\Content\Location;
use eZ\Publish\Core\REST\Common\Tests\Output\ValueObjectVisitorBaseTest;
use eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
use eZ\Publish\Core\REST\Server\Values\BookmarkList;
use eZ\Publish\Core\REST\Server\Values\RestLocation;

class BookmarkListTest extends ValueObjectVisitorBaseTest
{
    /**
     * @var \eZ\Publish\Core\REST\Server\Values\BookmarkList
     */
    private $data;


    protected function setUp()
    {
        $this->data = new BookmarkList(10, [
            new RestLocation($this->createMock(Location::class), 0),
            new RestLocation($this->createMock(Location::class), 0),
            new RestLocation($this->createMock(Location::class), 0),
        ]);
    }

    public function testVisit(): string
    {
        $visitor = $this->getVisitor();
        $generator = $this->getGenerator();

        $generator->startDocument(null);

        $visitor->visit(
            $this->getVisitorMock(),

            $generator,
            $this->data
        );

        $result = $generator->endDocument(null);

        $this->assertNotNull($result);

        return $result;
    }

    /**
     * @depends testVisit
     */
    public function testResultContainsBookmarkListElement(string $result): void
    {
        $this->assertXMLTag(
            [
                'tag' => 'BookmarkList',
                'attributes' => [
                    'media-type' => 'application/vnd.ez.api.BookmarkList+xml',
                ],
            ],
            $result,
            'Invalid <BookmarkList> attributes.'
        );
    }

    /**
     * @depends testVisit
     */
    public function testResultContainsCountElement(string $result): void
    {
        $this->assertXMLTag(
            [
                'tag' => 'count',
                'content' => $this->data->totalCount,
            ],
            $result
        );
    }

    /**
     * @depends testVisit
     */
    public function testResultContainsBookmarkElement(string $result): void
    {
        $query = "//BookmarkList/Bookmark[@media-type='application/vnd.ez.api.Bookmark+xml']";

        $document = new DOMDocument();
        $document->loadXML($result);
        $xpath = new DOMXPath($document);

        $this->assertEquals(count($this->data->items), $xpath->query($query)->length);
    }

    /**
     * {@inheritdoc}
     */
    protected function internalGetVisitor()
    {
        return new ValueObjectVisitor\BookmarkList();
    }
}


1		<?php
2
3		/**
4		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5		* @license For full copyright and license information view LICENSE file distributed with this source code.
6		*/
7		declare(strict_types=1);
8
9		namespace eZ\Publish\Core\REST\Server\Tests\Output\ValueObjectVisitor;
10
11		use DOMDocument;
12		use DOMXPath;
13		use eZ\Publish\API\Repository\Values\Content\Location;
14		use eZ\Publish\Core\REST\Common\Tests\Output\ValueObjectVisitorBaseTest;
15		use eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
16		use eZ\Publish\Core\REST\Server\Values\BookmarkList;
17		use eZ\Publish\Core\REST\Server\Values\RestLocation;
18
19		class BookmarkListTest extends ValueObjectVisitorBaseTest
20		{
21		/**
22		* @var \eZ\Publish\Core\REST\Server\Values\BookmarkList
23		*/
24		private $data;
		0 ignored issues – show Comprehensibility introduced 2018-06-11 12:50 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
25
26		protected function setUp()
27		{
28		$this->data = new BookmarkList(10, [
29		new RestLocation($this->createMock(Location::class), 0),
30		new RestLocation($this->createMock(Location::class), 0),
31		new RestLocation($this->createMock(Location::class), 0),
32		]);
33		}
34
35	View Code Duplication	public function testVisit(): string
36		{
37		$visitor = $this->getVisitor();
38		$generator = $this->getGenerator();
39
40		$generator->startDocument(null);
41
42		$visitor->visit(
43		$this->getVisitorMock(),
		0 ignored issues – show Bug introduced 2018-06-11 12:50 UTC by Report Bug Copy Issue Report It seems like `$this->getVisitorMock()` targeting `eZ\Publish\Core\REST\Com...eTest::getVisitorMock()` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `eZ\Publish\Core\REST\Com...eObjectVisitor::visit()` does only seem to accept `object<eZ\Publish\Core\R...\Common\Output\Visitor>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
44		$generator,
45		$this->data
46		);
47
48		$result = $generator->endDocument(null);
49
50		$this->assertNotNull($result);
51
52		return $result;
53		}
54
55		/**
56		* @depends testVisit
57		*/
58		public function testResultContainsBookmarkListElement(string $result): void
59		{
60		$this->assertXMLTag(
61		[
62		'tag' => 'BookmarkList',
63		'attributes' => [
64		'media-type' => 'application/vnd.ez.api.BookmarkList+xml',
65		],
66		],
67		$result,
68		'Invalid <BookmarkList> attributes.'
69		);
70		}
71
72		/**
73		* @depends testVisit
74		*/
75		public function testResultContainsCountElement(string $result): void
76		{
77		$this->assertXMLTag(
78		[
79		'tag' => 'count',
80		'content' => $this->data->totalCount,
81		],
82		$result
83		);
84		}
85
86		/**
87		* @depends testVisit
88		*/
89		public function testResultContainsBookmarkElement(string $result): void
90		{
91		$query = "//BookmarkList/Bookmark[@media-type='application/vnd.ez.api.Bookmark+xml']";
92
93		$document = new DOMDocument();
94		$document->loadXML($result);
95		$xpath = new DOMXPath($document);
96
97		$this->assertEquals(count($this->data->items), $xpath->query($query)->length);
98		}
99
100		/**
101		* {@inheritdoc}
102		*/
103		protected function internalGetVisitor()
104		{
105		return new ValueObjectVisitor\BookmarkList();
106		}
107		}
108

ezsystems / ezpublish-kernel

Push — siteaccessaware-layer-only ( 37e924...bf143e )

BookmarkListTest::testVisit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like