eZ\Publish\Core\REST\Server\Tests\Output\ValueObjectVisitor\BookmarkListTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	89
Duplicated Lines	21.35 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	8	1
A	testVisit()	19	19	1
A	testResultContainsBookmarkListElement()	0	13	1
A	testResultContainsCountElement()	0	10	1
A	testResultContainsBookmarkElement()	0	10	1
A	internalGetVisitor()	0	4	1

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
declare(strict_types=1);

namespace eZ\Publish\Core\REST\Server\Tests\Output\ValueObjectVisitor;

use DOMDocument;
use DOMXPath;
use eZ\Publish\API\Repository\Values\Content\Location;
use eZ\Publish\Core\REST\Common\Tests\Output\ValueObjectVisitorBaseTest;
use eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
use eZ\Publish\Core\REST\Server\Values\BookmarkList;
use eZ\Publish\Core\REST\Server\Values\RestLocation;

class BookmarkListTest extends ValueObjectVisitorBaseTest
{
    /**
     * @var \eZ\Publish\Core\REST\Server\Values\BookmarkList
     */
    private $data;

Consider using a different property name as you override a private property of the parent class.

    protected function setUp()
    {
        $this->data = new BookmarkList(10, [
            new RestLocation($this->createMock(Location::class), 0),
            new RestLocation($this->createMock(Location::class), 0),
            new RestLocation($this->createMock(Location::class), 0),
        ]);
    }

    public function testVisit(): string
    {
        $visitor = $this->getVisitor();
        $generator = $this->getGenerator();

        $generator->startDocument(null);

        $visitor->visit(
            $this->getVisitorMock(),

It seems like $this->getVisitorMock() targeting eZ\Publish\Core\REST\Common\Tests\Output\ValueObjectVisitorBaseTest::getVisitorMock() can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor::visit() does only seem to accept object<eZ\Publish\Core\REST\Common\Output\Visitor>, maybe add an additional type check?

            $generator,
            $this->data
        );

        $result = $generator->endDocument(null);

        $this->assertNotNull($result);

        return $result;
    }

    /**
     * @depends testVisit
     */
    public function testResultContainsBookmarkListElement(string $result): void
    {
        $this->assertXMLTag(
            [
                'tag' => 'BookmarkList',
                'attributes' => [
                    'media-type' => 'application/vnd.ez.api.BookmarkList+xml',
                ],
            ],
            $result,
            'Invalid <BookmarkList> attributes.'
        );
    }

    /**
     * @depends testVisit
     */
    public function testResultContainsCountElement(string $result): void
    {
        $this->assertXMLTag(
            [
                'tag' => 'count',
                'content' => $this->data->totalCount,
            ],
            $result
        );
    }

    /**
     * @depends testVisit
     */
    public function testResultContainsBookmarkElement(string $result): void
    {
        $query = "//BookmarkList/Bookmark[@media-type='application/vnd.ez.api.Bookmark+xml']";

        $document = new DOMDocument();
        $document->loadXML($result);
        $xpath = new DOMXPath($document);

        $this->assertEquals(count($this->data->items), $xpath->query($query)->length);
    }

    /**
     * {@inheritdoc}
     */
    protected function internalGetVisitor()
    {
        return new ValueObjectVisitor\BookmarkList();
    }
}