exussum12 / coverageChecker

src/DiffFileLoader.php

<?php
namespace exussum12\CoverageChecker;

use InvalidArgumentException;

class DiffFileLoader
{
    protected $fileLocation;

    protected $diffLines = [
        DiffLineHandle\NewVersion\NewFile::class,
        DiffLineHandle\NewVersion\AddedLine::class,
        DiffLineHandle\NewVersion\RemovedLine::class,
        DiffLineHandle\NewVersion\DiffStart::class,
    ];
    protected $handles = [];
    protected $diff;

    public function __construct($fileName)
    {
        $this->fileLocation = $fileName;
        $this->diff = new DiffFileState();
    }

    public function getChangedLines(): array
    {
        if ((
            !is_readable($this->fileLocation) &&
            strpos($this->fileLocation, "php://") !== 0
        )) {
            throw new InvalidArgumentException("Can't read file", 1);
        }

        $handle = fopen($this->fileLocation, 'r');

        while (($line = fgets($handle)) !== false) {

It seems like $handle can also be of type false; however, parameter $handle of fgets() does only seem to accept resource, maybe add an additional type check?

            // process the line read.
            $lineHandle = $this->getLineHandle($line);
            $lineHandle->handle($line);
            $this->diff->incrementCurrentPosition();
        }

        fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        return $this->diff->getChangedLines();
    }

    private function getLineHandle(string $line): DiffLineHandle
    {
        foreach ($this->diffLines as $lineType) {
            $lineType = $this->getClass($lineType);
            if ($lineType->isValid($line)) {
                return $lineType;
            }
        }
        // the line doesn't have a special meaning, its probably context
        return $this->getClass(DiffLineHandle\ContextLine::class);
    }

    private function getClass(string $className): DiffLineHandle
    {
        if (!isset($this->handles[$this->getFileHandleName($className)])) {
            $this->handles[
                $this->getFileHandleName($className)
            ] = new $className($this->diff);
        }

        return $this->handles[$this->getFileHandleName($className)];
    }

    private function getFileHandleName(string $namespace): string
    {
        $namespace = explode('\\', $namespace);
        return end($namespace);
    }
}