exussum12\CoverageChecker\DiffFileLoader::getChangedLines()

Complexity

Conditions	4
Paths	3

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getChangedLines(): array
    {
        if ((
            !is_readable($this->fileLocation) &&
            strpos($this->fileLocation, "php://") !== 0
        )) {
            throw new InvalidArgumentException("Can't read file", 1);
        }

        $handle = fopen($this->fileLocation, 'r');

        while (($line = fgets($handle)) !== false) {

It seems like $handle can also be of type false; however, parameter $handle of fgets() does only seem to accept resource, maybe add an additional type check?

            // process the line read.
            $lineHandle = $this->getLineHandle($line);
            $lineHandle->handle($line);
            $this->diff->incrementCurrentPosition();
        }

        fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        return $this->diff->getChangedLines();
    }