XMLReport::getLines() - Code Metrics - Inspection of "Improve error handeling" - exussum12/coverageChecker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Scott

created 2017-08-16 13:08 UTC

XMLReport::getLines() B

↳ Parent: XMLReport

Complexity

Conditions	6
Paths	5

Size

Total Lines	28
Code Lines	19

Duplication

Lines	7
Ratio	25 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	19
c	1
b	0
f	0
nc	5
nop	0
dl	7
loc	28
rs	8.439

<?php
namespace exussum12\CoverageChecker;

use XMLReader;

/**
 * Class XMLReport
 * Used for reading in a phpunit clover XML file
 * @package exussum12\CoverageChecker
 */
class XMLReport implements FileChecker
{
    /**
     * @var string
     */
    protected $file;
    /**
     * @var array
     */
    protected $coveredLines;

    /**
     * XMLReport constructor.
     * @param string $file the path the to phpunit clover file
     */
    public function __construct($file)
    {
        $this->file = $file;
    }

    /**
     * {@inheritdoc}
     */
    public function getLines()
    {
        $this->coveredLines = [];
        $reader = new XMLReader;
        $reader->open($this->file);
        $currentFile = '';
        while ($reader->read()) {
            if ((
                $reader->name === "file" &&
                $reader->nodeType == XMLReader::ELEMENT
            )) {
                $currentFile = $reader->getAttribute('name');
                $this->coveredLines[$currentFile] = [];
            }

            if ((
                $reader->name === "line" &&
                $reader->getAttribute("type") == "stmt"
            )) {
                $this->coveredLines
                    [$currentFile]
                    [$reader->getAttribute('num')]
                    = (int) $reader->getAttribute("count");
            }
        }

        return $this->coveredLines;
    }

    /**
     * {@inheritdoc}
     */
    public function isValidLine($file, $line)
    {
        if (!isset($this->coveredLines[$file][$line])) {
            return;
        }

        return $this->coveredLines[$file][$line] > 0;
    }

    /**
     * {@inheritdoc}
     */
    public function handleNotFoundFile()
    {
        return null;
    }

    /**
     * {@inheritdoc}
     */
    public static function getDescription()
    {
        return 'Parses text output in clover (xml) format designed for ' .
            'phpunit but any tool which outputs in this format should work';
    }
}


1		<?php
2		namespace exussum12\CoverageChecker;
3
4		use XMLReader;
5
6		/**
7		* Class XMLReport
8		* Used for reading in a phpunit clover XML file
9		* @package exussum12\CoverageChecker
10		*/
11		class XMLReport implements FileChecker
12		{
13		/**
14		* @var string
15		*/
16		protected $file;
17		/**
18		* @var array
19		*/
20		protected $coveredLines;
21
22		/**
23		* XMLReport constructor.
24		* @param string $file the path the to phpunit clover file
25		*/
26		public function __construct($file)
27		{
28		$this->file = $file;
29		}
30
31		/**
32		* {@inheritdoc}
33		*/
34		public function getLines()
35		{
36		$this->coveredLines = [];
37		$reader = new XMLReader;
38		$reader->open($this->file);
39		$currentFile = '';
40		while ($reader->read()) {
41	View Code Duplication	if ((
42		$reader->name === "file" &&
43		$reader->nodeType == XMLReader::ELEMENT
44		)) {
45		$currentFile = $reader->getAttribute('name');
46		$this->coveredLines[$currentFile] = [];
47		}
48
49		if ((
50		$reader->name === "line" &&
51		$reader->getAttribute("type") == "stmt"
52		)) {
53		$this->coveredLines
54		[$currentFile]
55		[$reader->getAttribute('num')]
56		= (int) $reader->getAttribute("count");
57		}
58		}
59
60		return $this->coveredLines;
61		}
62
63		/**
64		* {@inheritdoc}
65		*/
66		public function isValidLine($file, $line)
67		{
68		if (!isset($this->coveredLines[$file][$line])) {
69		return;
70		}
71
72		return $this->coveredLines[$file][$line] > 0;
73		}
74
75		/**
76		* {@inheritdoc}
77		*/
78		public function handleNotFoundFile()
79		{
80		return null;
81		}
82
83		/**
84		* {@inheritdoc}
85		*/
86		public static function getDescription()
87		{
88		return 'Parses text output in clover (xml) format designed for ' .
89		'phpunit but any tool which outputs in this format should work';
90		}
91		}
92

exussum12 / coverageChecker

Pull Request — master (#9)

XMLReport::getLines() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like