Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | class XMLReport implements FileChecker |
||
12 | { |
||
13 | /** |
||
14 | * @var string |
||
15 | */ |
||
16 | protected $file; |
||
17 | /** |
||
18 | * @var array |
||
19 | */ |
||
20 | protected $coveredLines; |
||
21 | |||
22 | /** |
||
23 | * XMLReport constructor. |
||
24 | * @param string $file the path the to phpunit clover file |
||
25 | */ |
||
26 | public function __construct($file) |
||
30 | |||
31 | /** |
||
32 | * {@inheritdoc} |
||
33 | */ |
||
34 | public function getLines() |
||
62 | |||
63 | /** |
||
64 | * {@inheritdoc} |
||
65 | */ |
||
66 | public function isValidLine($file, $line) |
||
74 | |||
75 | /** |
||
76 | * {@inheritdoc} |
||
77 | */ |
||
78 | public function handleNotFoundFile() |
||
82 | |||
83 | /** |
||
84 | * {@inheritdoc} |
||
85 | */ |
||
86 | public static function getDescription() |
||
91 | } |
||
92 |