Harmonic::getSoundingPitch() - Code Metrics - Inspection of "Add getSeriesAsStringLengths()" - extended-strings/strings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0a935a...c739e1 )

by Patrick

created 2017-05-27 20:17 UTC

Harmonic::getSoundingPitch() A

↳ Parent: Harmonic

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1

<?php

declare(strict_types=1);

namespace ExtendedStrings\Strings;

class Harmonic
{
    private $halfStop;
    private $baseStop;

    /**
     * @param float $halfStop
     * @param float $baseStop
     */
    public function __construct(float $halfStop, float $baseStop = 1.0)
    {
        if ($halfStop > $baseStop) {
            throw new \InvalidArgumentException("The half-stop's string length cannot be longer than the base stop's.");
        }

        $this->baseStop = $baseStop;
        $this->halfStop = $halfStop;
    }

    /**
     * @param \ExtendedStrings\Strings\VibratingString $string
     *
     * @return float
     */
    public function getSoundingPitch(VibratingString $string): float
    {
        // Transpose the half-stop onto the new string length, which was formed
        // by the stop.
        $pseudoString = new VibratingString($string->getStoppedFrequency($this->baseStop));
        $pseudoHalfStop = $this->halfStop / $this->baseStop;

        return $pseudoString->getHarmonicSoundingFrequency($pseudoHalfStop);
    }

    /**
     * @param int $limit
     *
     * @return float[]
     */
    public static function getSeries(int $limit): array
    {
        $series = [];
        $base = 0;
        for ($denominator = 1; $denominator <= $limit; $denominator++) {

            $base = $series[$denominator] = $base + 1 / $denominator;
        }

        return $series;
    }

    /**
     * @param int $limit
     *
     * @return float[]
     */
    public static function getSeriesAsStringLengths(int $limit): array
    {
        $series = [];
        for ($denominator = 1; $denominator <= $limit; $denominator++) {

            $series[$denominator] = 1 / $denominator;
        }

        return $series;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ExtendedStrings\Strings;
6
7		class Harmonic
8		{
9		private $halfStop;
10		private $baseStop;
11
12		/**
13		* @param float $halfStop
14		* @param float $baseStop
15		*/
16		public function __construct(float $halfStop, float $baseStop = 1.0)
17		{
18		if ($halfStop > $baseStop) {
19		throw new \InvalidArgumentException("The half-stop's string length cannot be longer than the base stop's.");
20		}
21
22		$this->baseStop = $baseStop;
23		$this->halfStop = $halfStop;
24		}
25
26		/**
27		* @param \ExtendedStrings\Strings\VibratingString $string
28		*
29		* @return float
30		*/
31		public function getSoundingPitch(VibratingString $string): float
32		{
33		// Transpose the half-stop onto the new string length, which was formed
34		// by the stop.
35		$pseudoString = new VibratingString($string->getStoppedFrequency($this->baseStop));
36		$pseudoHalfStop = $this->halfStop / $this->baseStop;
37
38		return $pseudoString->getHarmonicSoundingFrequency($pseudoHalfStop);
39		}
40
41		/**
42		* @param int $limit
43		*
44		* @return float[]
45		*/
46		public static function getSeries(int $limit): array
47		{
48		$series = [];
49		$base = 0;
50	View Code Duplication	for ($denominator = 1; $denominator <= $limit; $denominator++) {
		0 ignored issues – show Duplication introduced 2017-05-27 20:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		$base = $series[$denominator] = $base + 1 / $denominator;
52		}
53
54		return $series;
55		}
56
57		/**
58		* @param int $limit
59		*
60		* @return float[]
61		*/
62		public static function getSeriesAsStringLengths(int $limit): array
63		{
64		$series = [];
65	View Code Duplication	for ($denominator = 1; $denominator <= $limit; $denominator++) {
		0 ignored issues – show Duplication introduced 2017-05-27 20:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		$series[$denominator] = 1 / $denominator;
67		}
68
69		return $series;
70		}
71		}
72

extended-strings / strings

Push — master ( 0a935a...c739e1 )

Harmonic::getSoundingPitch() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like