ExtendedStrings\Strings\Harmonic

Complexity

Total Complexity

7

Size/Duplication

Total Lines	65
Duplicated Lines	9.23 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	getSoundingPitch()	0	9	1
A	getSeries()	3	10	2
A	getSeriesAsStringLengths()	3	9	2

<?php

declare(strict_types=1);

namespace ExtendedStrings\Strings;

class Harmonic
{
    private $halfStop;
    private $baseStop;

    /**
     * @param float $halfStop
     * @param float $baseStop
     */
    public function __construct(float $halfStop, float $baseStop = 1.0)
    {
        if ($halfStop > $baseStop) {
            throw new \InvalidArgumentException("The half-stop's string length cannot be longer than the base stop's.");
        }

        $this->baseStop = $baseStop;
        $this->halfStop = $halfStop;
    }

    /**
     * @param \ExtendedStrings\Strings\VibratingString $string
     *
     * @return float
     */
    public function getSoundingPitch(VibratingString $string): float
    {
        // Transpose the half-stop onto the new string length, which was formed
        // by the stop.
        $pseudoString = new VibratingString($string->getStoppedFrequency($this->baseStop));
        $pseudoHalfStop = $this->halfStop / $this->baseStop;

        return $pseudoString->getHarmonicSoundingFrequency($pseudoHalfStop);
    }

    /**
     * @param int $limit
     *
     * @return float[]
     */
    public static function getSeries(int $limit): array
    {
        $series = [];
        $base = 0;
        for ($denominator = 1; $denominator <= $limit; $denominator++) {

This code seems to be duplicated across your project.

            $base = $series[$denominator] = $base + 1 / $denominator;
        }

        return $series;
    }

    /**
     * @param int $limit
     *
     * @return float[]
     */
    public static function getSeriesAsStringLengths(int $limit): array
    {
        $series = [];
        for ($denominator = 1; $denominator <= $limit; $denominator++) {

This code seems to be duplicated across your project.

            $series[$denominator] = 1 / $denominator;
        }

        return $series;
    }
}