ed2d.assets.OBJ.parse() - Code Metrics - Inspection of "Rewrite obj parser to be way simpler and faster." - explosiveduck/ed2d - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c45d91...39b96d )

by Matthew

created 2016-02-21 19:47 UTC

ed2d.assets.OBJ.parse() F

↳ Parent: ed2d.assets.OBJ

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	18
dl	0
loc	69
rs	2.588

How to fix Long Method Complexity

from ed2d.assets.mtlloader import MTL
from ed2d import files

class OBJ(object):
    def __init__(self, fileName):
        ''' Wavefront .obj file parser.'''
        objPath = files.resolve_path('data', 'models', fileName + '.obj')

        self.fmvnig = {}
        
        # Shared temporary storage of data
        self.tempVertices = []
        self.tempNormals = []
        self.tempUVs = []

        # Load the obj file
        with open(objPath, 'r') as objfile:
            self.lines = objfile.readlines()
        
        self.parse()
         

    def parse(self):
        ''' Perform the parsing of the obj format  '''
        
        matname = None
        lastType = None
        valueType = None

        for line in self.lines:
            lastType = valueType
            valueType, value = line.strip().split(' ', 1)

            # Don't bother unless the following key words exist in the line
            if valueType not in ['o', 'g', 'f', 'v', 'vt', 'vn', 'usemtl', 'mtllib']:
                continue

            value = value.split(' ')

            # Check first and continue on early because of string splitting
            if valueType == "usemtl":
                matname = value[0]
                continue
            
            if valueType in ['g', 'o']:
                # These objects reset state basically
                matname = None
                continue
            
            if valueType == 'mtllib':
                mtlpath = files.resolve_path('data', 'models', value[0])
                
                # Load the mtl file
                self.mtlfile = MTL(mtlpath)
                for material in self.mtlfile.data.keys():
                    self.fmvnig[material] = [ [], [], [] ]
                
                continue

            if valueType == "f":
                face = [item.split("/") for item in value]
                for typeGroup in face:
                    for typeIndex in range(len(typeGroup)):
                        if typeIndex == 0: # Vertex
                            typeSource = self.tempVertices
                        elif typeIndex == 1: # UV
                            typeSource = self.tempUVs
                        elif typeIndex == 2: # Normal
                            typeSource = self.tempNormals
                        
                        index = typeGroup[typeIndex]
                        
                        # Make sure data exists
                        if index != '':
                            index = int(index)
                            typeData = typeSource[index - 1]
                            
                            self.fmvnig[matname][typeIndex].append(typeData)
                continue

            # Map the values after the keyword to floats
            value = list(map(float, value))

            if valueType == "v":
                self.tempVertices.append(value)

            elif valueType == "vt":
                self.tempUVs.append(value * 2)

            elif valueType == "vn":
                self.tempNormals.append(value)


1			from ed2d.assets.mtlloader import MTL
2			from ed2d import files
3
4			class OBJ(object):
5			def __init__(self, fileName):
6			''' Wavefront .obj file parser.'''
7			objPath = files.resolve_path('data', 'models', fileName + '.obj')
8
9			self.fmvnig = {}
10
11			# Shared temporary storage of data
12			self.tempVertices = []
13			self.tempNormals = []
14			self.tempUVs = []
15
16			# Load the obj file
17			with open(objPath, 'r') as objfile:
18			self.lines = objfile.readlines()
19
20			self.parse()
21
22
23			def parse(self):
24			''' Perform the parsing of the obj format '''
25
26			matname = None
27			lastType = None
28			valueType = None
29
30			for line in self.lines:
31			lastType = valueType
32			valueType, value = line.strip().split(' ', 1)
33
34			# Don't bother unless the following key words exist in the line
35			if valueType not in ['o', 'g', 'f', 'v', 'vt', 'vn', 'usemtl', 'mtllib']:
36			continue
37
38			value = value.split(' ')
39
40			# Check first and continue on early because of string splitting
41			if valueType == "usemtl":
42			matname = value[0]
43			continue
44
45			if valueType in ['g', 'o']:
46			# These objects reset state basically
47			matname = None
48			continue
49
50			if valueType == 'mtllib':
51			mtlpath = files.resolve_path('data', 'models', value[0])
52
53			# Load the mtl file
54			self.mtlfile = MTL(mtlpath)
55			for material in self.mtlfile.data.keys():
56			self.fmvnig[material] = [ [], [], [] ]
57
58			continue
59
60			if valueType == "f":
61			face = [item.split("/") for item in value]
62			for typeGroup in face:
63			for typeIndex in range(len(typeGroup)):
64			if typeIndex == 0: # Vertex
65			typeSource = self.tempVertices
66			elif typeIndex == 1: # UV
67			typeSource = self.tempUVs
68			elif typeIndex == 2: # Normal
69			typeSource = self.tempNormals
70
71			index = typeGroup[typeIndex]
72
73			# Make sure data exists
74			if index != '':
75			index = int(index)
76			typeData = typeSource[index - 1]
77
78			self.fmvnig[matname][typeIndex].append(typeData)
79			continue
80
81			# Map the values after the keyword to floats
82			value = list(map(float, value))
83
84			if valueType == "v":
85			self.tempVertices.append(value)
86
87			elif valueType == "vt":
88			self.tempUVs.append(value * 2)
89
90			elif valueType == "vn":
91			self.tempNormals.append(value)
92

explosiveduck / ed2d

Push — master ( c45d91...39b96d )

ed2d.assets.OBJ.parse() F

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like