ed2d.assets.OBJ.__process_in_house() - Code Metrics - Inspection of "Can now parse material info from obj file." - explosiveduck/ed2d - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 454eb4...f83d10 )

unknown

created 2016-01-22 14:37 UTC

ed2d.assets.OBJ.__process_in_house() F

↳ Parent: ed2d.assets.OBJ

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	13
dl	0
loc	52
rs	2.9976

How to fix Long Method Complexity


from ed2d.mesh import MeshBase
from ed2d.assets.mtlloader import MTL

class OBJ(object):
    def __init__(self, fileName):
        ''' Wavefront .obj file parser.'''
        fcount = 0
        vcount = 0
        vtcount = 0
        vncount = 0
        matcount = 0

        # Load the file
        objfile = open(fileName, "r")

        # Do a head count
        for line in objfile:
            value = line[:2]
            if value == 'f ':
                fcount += 1
            elif value == 'v ':
                vcount += 1
            elif value == 'vt':
                vtcount += 1
            elif value == 'vn':
                vncount += 1
            elif value == 'g ':
                matcount += 1

        fcount *= 3
        vcount *= 3
        vtcount *= 3
        vncount *= 3

        self.tempVertices = [None] * vcount
        self.tempNormals = [None] * vncount
        self.tempUVs = [None] * fcount
        self.tempMaterials = [None] * matcount

        self.vertexIndices = [None] * fcount
        self.normalIndices = [None] * fcount
        self.uvIndices = [None] * fcount

        self.finalVertices = [None] * fcount
        self.finalNormals = [None] * fcount
        self.finalUVs = [None] * fcount
        self.usedMaterials = [None] * matcount

        self.fnumber = 0
        self.vnumber = 0
        self.vtnumber = 0
        self.vnnumber = 0
        self.matnumber = 0

        # Process the data
        self.__process_in_house(objfile)
        # Finalize
        self.get_final_data()

        # Close the file
        objfile.close()

    def __process_in_house(self, filename):
        with open(filename, "r") as objfl:

            for line in objfl:

                value = line.split()
                valueType = value[0]

                if valueType not in ['f', 'v', 'vt', 'vn', 'g', 'usemtl']:
                    continue

                value = value[1:]

                # Check first and continue on early because of string splitting
                if valueType == "f":
                    temp = [item.split("/") for item in value]

                    for i in range(3):
                        if temp[i][1] != '':
                            self.uvIndices[self.fnumber] = int(temp[i][1])
                        self.vertexIndices[self.fnumber] = int(temp[i][0])
                        self.normalIndices[self.fnumber] = int(temp[i][2])
                        self.fnumber += 1

                    continue

                value = list(map(float, value))

                if valueType == "v":
                    v = [value[0], value[1], value[2]]
                    self.tempVertices[self.vnumber] = v
                    self.vnumber += 1

                elif valueType == "vt":
                    vt = [value[0], value[0]]
                    self.tempUVs[self.vtnumber] = vt
                    self.vtnumber += 1

                elif valueType == "vn":
                    n = [value[0], value[1], value[2]]
                    self.tempNormals[self.vnnumber] = n
                    self.vnnumber += 1

                elif valueType == "g":
                    g = value[0]
                    self.tempMaterials[self.matnumber] = g
                    self.matnumber += 1
                elif valueType == "usemtl":
                    gs = value[0]
                    # Need a way to generate which material per what face
                    # In a specific order
                    self.usedMaterials[sef.matnumber] = gs

    def get_final_data(self):
        for i in range(self.fcount):
            vertexIndex = int(self.vertexIndices[i]) - 1
            vertex = self.tempVertices[vertexIndex]
            self.finalVertices[i] = vertex

            normalIndex = self.normalIndices[i]
            normal = self.tempNormals[int(normalIndex) - 1]
            self.finalNormals[i] = normal

            if self.uvIndices[0] is None and self.vtcount != 0:
                uvIndex = self.uvIndices[i]
                uv = self.tempUVs[int(uvIndex) - 1]
                self.finalUVs[i] = uv

class ObjMesh(MeshBase):
    def __init__(self, filePath, name, program, vertexLoc, normalLoc):
        super(ObjMesh, self).__init__(filePath, name, program, vertexLoc, normalLoc)


1
2			from ed2d.mesh import MeshBase
3			from ed2d.assets.mtlloader import MTL
4
5			class OBJ(object):
6			def __init__(self, fileName):
7			''' Wavefront .obj file parser.'''
8			fcount = 0
9			vcount = 0
10			vtcount = 0
11			vncount = 0
12			matcount = 0
13
14			# Load the file
15			objfile = open(fileName, "r")
16
17			# Do a head count
18			for line in objfile:
19			value = line[:2]
20			if value == 'f ':
21			fcount += 1
22			elif value == 'v ':
23			vcount += 1
24			elif value == 'vt':
25			vtcount += 1
26			elif value == 'vn':
27			vncount += 1
28			elif value == 'g ':
29			matcount += 1
30
31			fcount *= 3
32			vcount *= 3
33			vtcount *= 3
34			vncount *= 3
35
36			self.tempVertices = [None] * vcount
37			self.tempNormals = [None] * vncount
38			self.tempUVs = [None] * fcount
39			self.tempMaterials = [None] * matcount
40
41			self.vertexIndices = [None] * fcount
42			self.normalIndices = [None] * fcount
43			self.uvIndices = [None] * fcount
44
45			self.finalVertices = [None] * fcount
46			self.finalNormals = [None] * fcount
47			self.finalUVs = [None] * fcount
48			self.usedMaterials = [None] * matcount
49
50			self.fnumber = 0
51			self.vnumber = 0
52			self.vtnumber = 0
53			self.vnnumber = 0
54			self.matnumber = 0
55
56			# Process the data
57			self.__process_in_house(objfile)
58			# Finalize
59			self.get_final_data()
60
61			# Close the file
62			objfile.close()
63
64			def __process_in_house(self, filename):
65			with open(filename, "r") as objfl:
66
67			for line in objfl:
68
69			value = line.split()
70			valueType = value[0]
71
72			if valueType not in ['f', 'v', 'vt', 'vn', 'g', 'usemtl']:
73			continue
74
75			value = value[1:]
76
77			# Check first and continue on early because of string splitting
78			if valueType == "f":
79			temp = [item.split("/") for item in value]
80
81			for i in range(3):
82			if temp[i][1] != '':
83			self.uvIndices[self.fnumber] = int(temp[i][1])
84			self.vertexIndices[self.fnumber] = int(temp[i][0])
85			self.normalIndices[self.fnumber] = int(temp[i][2])
86			self.fnumber += 1
87
88			continue
89
90			value = list(map(float, value))
91
92			if valueType == "v":
93			v = [value[0], value[1], value[2]]
94			self.tempVertices[self.vnumber] = v
95			self.vnumber += 1
96
97			elif valueType == "vt":
98			vt = [value[0], value[0]]
99			self.tempUVs[self.vtnumber] = vt
100			self.vtnumber += 1
101
102			elif valueType == "vn":
103			n = [value[0], value[1], value[2]]
104			self.tempNormals[self.vnnumber] = n
105			self.vnnumber += 1
106
107			elif valueType == "g":
108			g = value[0]
109			self.tempMaterials[self.matnumber] = g
110			self.matnumber += 1
111			elif valueType == "usemtl":
112			gs = value[0]
113			# Need a way to generate which material per what face
114			# In a specific order
115			self.usedMaterials[sef.matnumber] = gs
116
117			def get_final_data(self):
118			for i in range(self.fcount):
119			vertexIndex = int(self.vertexIndices[i]) - 1
120			vertex = self.tempVertices[vertexIndex]
121			self.finalVertices[i] = vertex
122
123			normalIndex = self.normalIndices[i]
124			normal = self.tempNormals[int(normalIndex) - 1]
125			self.finalNormals[i] = normal
126
127			if self.uvIndices[0] is None and self.vtcount != 0:
128			uvIndex = self.uvIndices[i]
129			uv = self.tempUVs[int(uvIndex) - 1]
130			self.finalUVs[i] = uv
131
132			class ObjMesh(MeshBase):
133			def __init__(self, filePath, name, program, vertexLoc, normalLoc):
134			super(ObjMesh, self).__init__(filePath, name, program, vertexLoc, normalLoc)
135

explosiveduck / ed2d

Push — master ( 454eb4...f83d10 )

ed2d.assets.OBJ.__process_in_house() F

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like