ed2d.assets.OBJ.__init__() - Code Metrics - Inspection of "Small update to objloader." - explosiveduck/ed2d - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0dba88...7a21f8 )

unknown

created 2016-01-14 06:23 UTC

ed2d.assets.OBJ.init() B

↳ Parent: ed2d.assets.OBJ

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	6
dl	0
loc	52
rs	7.7931

How to fix Long Method


from ed2d.mesh import MeshBase
from ed2d.assets.mtlloader import MTL

class OBJ(object):
    def __init__(self, fileName):
        ''' Wavefront .obj file parser.'''
        fcount = 0
        vcount = 0
        vtcount = 0
        vncount = 0

        # Load the file
        objfile = open(fileName, "r")

        # Do a head count
        for line in objfile:
            value = line[:2]
            if value == 'f ':
                fcount += 1
            elif value == 'v ':
                vcount += 1
            elif value == 'vt':
                vtcount += 1
            elif value == 'vn':
                vncount += 1

        fcount *= 3
        vcount *= 3
        vtcount *= 3
        vncount *= 3

        self.tempVertices = [None] * vcount
        self.tempNormals = [None] * vncount

        self.tempUVs = [None] * fcount

        self.vertexIndices = [None] * fcount
        self.normalIndices = [None] * fcount
        self.uvIndices = [None] * fcount

        self.finalVertices = [None] * fcount
        self.finalNormals = [None] * fcount
        self.finalUVs = [None] * fcount

        self.fnumber = 0
        self.vnumber = 0
        self.vtnumber = 0
        self.vnnumber = 0

        # Process the data
        self.__process_in_house(objfile)
        # Finalize
        self.get_final_data()

        # Close the file
        objfile.close()

    def __process_in_house(self, objfl):
        with open(filename, "r") as objfl:

            for line in objfl:

                value = line.split()
                valueType = value[0]

                if valueType not in ['f', 'v', 'vt', 'vn']:
                    continue

                value = value[1:]

                # Check first and continue on early because of string splitting
                if valueType == "f":
                    temp = [item.split("/") for item in value]

                    for i in range(3):
                        if temp[i][1] != '':
                            self.uvIndices[fnumber] = int(temp[i][1])
                        self.vertexIndices[fnumber] = int(temp[i][0])
                        self.normalIndices[fnumber] = int(temp[i][2])
                        fnumber += 1

                    continue

                value = list(map(float, value))

                if valueType == "v":
                    v = [value[0], value[1], value[2]]
                    self.tempVertices[vnumber] = v
                    self.vnumber += 1

                elif valueType == "vt":
                    vt = [value[0], value[0]]
                    self.tempUVs[vtnumber] = vt
                    self.vtnumber += 1

                elif valueType == "vn":
                    n = [value[0], value[1], value[2]]
                    self.tempNormals[vnnumber] = n
                    self.vnnumber += 1

    def get_final_data(self):
        for i in range(fcount):
            vertexIndex = int(self.vertexIndices[i]) - 1
            vertex = self.tempVertices[vertexIndex]
            self.finalVertices[i] = vertex

            normalIndex = self.normalIndices[i]
            normal = self.tempNormals[int(normalIndex) - 1]
            self.finalNormals[i] = normal

            if self.uvIndices[0] is None and vtcount != 0:
                uvIndex = self.uvIndices[i]
                uv = self.tempUVs[int(uvIndex) - 1]
                self.finalUVs[i] = uv

class ObjMesh(MeshBase):
    def __init__(self, filePath, name, program, vertexLoc, normalLoc):
        super(ObjMesh, self).__init__(filePath, name, program, vertexLoc, normalLoc)


1
2			from ed2d.mesh import MeshBase
3			from ed2d.assets.mtlloader import MTL
4
5			class OBJ(object):
6			def __init__(self, fileName):
7			''' Wavefront .obj file parser.'''
8			fcount = 0
9			vcount = 0
10			vtcount = 0
11			vncount = 0
12
13			# Load the file
14			objfile = open(fileName, "r")
15
16			# Do a head count
17			for line in objfile:
18			value = line[:2]
19			if value == 'f ':
20			fcount += 1
21			elif value == 'v ':
22			vcount += 1
23			elif value == 'vt':
24			vtcount += 1
25			elif value == 'vn':
26			vncount += 1
27
28			fcount *= 3
29			vcount *= 3
30			vtcount *= 3
31			vncount *= 3
32
33			self.tempVertices = [None] * vcount
34			self.tempNormals = [None] * vncount
35
36			self.tempUVs = [None] * fcount
37
38			self.vertexIndices = [None] * fcount
39			self.normalIndices = [None] * fcount
40			self.uvIndices = [None] * fcount
41
42			self.finalVertices = [None] * fcount
43			self.finalNormals = [None] * fcount
44			self.finalUVs = [None] * fcount
45
46			self.fnumber = 0
47			self.vnumber = 0
48			self.vtnumber = 0
49			self.vnnumber = 0
50
51			# Process the data
52			self.__process_in_house(objfile)
53			# Finalize
54			self.get_final_data()
55
56			# Close the file
57			objfile.close()
58
59			def __process_in_house(self, objfl):
60			with open(filename, "r") as objfl:
61
62			for line in objfl:
63
64			value = line.split()
65			valueType = value[0]
66
67			if valueType not in ['f', 'v', 'vt', 'vn']:
68			continue
69
70			value = value[1:]
71
72			# Check first and continue on early because of string splitting
73			if valueType == "f":
74			temp = [item.split("/") for item in value]
75
76			for i in range(3):
77			if temp[i][1] != '':
78			self.uvIndices[fnumber] = int(temp[i][1])
79			self.vertexIndices[fnumber] = int(temp[i][0])
80			self.normalIndices[fnumber] = int(temp[i][2])
81			fnumber += 1
82
83			continue
84
85			value = list(map(float, value))
86
87			if valueType == "v":
88			v = [value[0], value[1], value[2]]
89			self.tempVertices[vnumber] = v
90			self.vnumber += 1
91
92			elif valueType == "vt":
93			vt = [value[0], value[0]]
94			self.tempUVs[vtnumber] = vt
95			self.vtnumber += 1
96
97			elif valueType == "vn":
98			n = [value[0], value[1], value[2]]
99			self.tempNormals[vnnumber] = n
100			self.vnnumber += 1
101
102			def get_final_data(self):
103			for i in range(fcount):
104			vertexIndex = int(self.vertexIndices[i]) - 1
105			vertex = self.tempVertices[vertexIndex]
106			self.finalVertices[i] = vertex
107
108			normalIndex = self.normalIndices[i]
109			normal = self.tempNormals[int(normalIndex) - 1]
110			self.finalNormals[i] = normal
111
112			if self.uvIndices[0] is None and vtcount != 0:
113			uvIndex = self.uvIndices[i]
114			uv = self.tempUVs[int(uvIndex) - 1]
115			self.finalUVs[i] = uv
116
117			class ObjMesh(MeshBase):
118			def __init__(self, filePath, name, program, vertexLoc, normalLoc):
119			super(ObjMesh, self).__init__(filePath, name, program, vertexLoc, normalLoc)
120

explosiveduck / ed2d

Push — master ( 0dba88...7a21f8 )

ed2d.assets.OBJ.__init__() B

Complexity

Size

Duplication

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ed2d.assets.OBJ.init() B