Completed
Branch BUG-7537 (42ca46)
by
unknown
435:54 queued 422:19
created
core/data_migration_scripts/EE_DMS_Core_4_7_0.dms.php 1 patch
Spacing   +49 added lines, -49 removed lines patch added patch discarded remove patch
@@ -14,13 +14,13 @@  discard block
 block discarded – undo
14 14
 // (all other times it gets resurrected from a wordpress option)
15 15
 $stages = glob(EE_CORE.'data_migration_scripts/4_7_0_stages/*');
16 16
 $class_to_filepath = array();
17
-foreach($stages as $filepath){
17
+foreach ($stages as $filepath) {
18 18
 	$matches = array();
19
-	preg_match('~4_7_0_stages/(.*).dmsstage.php~',$filepath,$matches);
19
+	preg_match('~4_7_0_stages/(.*).dmsstage.php~', $filepath, $matches);
20 20
 	$class_to_filepath[$matches[1]] = $filepath;
21 21
 }
22 22
 //give addons a chance to autoload their stages too
23
-$class_to_filepath = apply_filters('FHEE__EE_DMS_4_7_0__autoloaded_stages',$class_to_filepath);
23
+$class_to_filepath = apply_filters('FHEE__EE_DMS_4_7_0__autoloaded_stages', $class_to_filepath);
24 24
 EEH_Autoloader::register_autoloader($class_to_filepath);
25 25
 
26 26
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
  * @since                4.7.0
37 37
  *
38 38
  */
39
-class EE_DMS_Core_4_7_0 extends EE_Data_Migration_Script_Base{
39
+class EE_DMS_Core_4_7_0 extends EE_Data_Migration_Script_Base {
40 40
 
41 41
 	/**
42 42
 	 * return EE_DMS_Core_4_7_0
@@ -58,18 +58,18 @@  discard block
 block discarded – undo
58 58
 	 * @return bool
59 59
 	 */
60 60
 	public function can_migrate_from_version($version_array) {
61
-		EE_Registry::instance()->load_helper( 'Activation' );
61
+		EE_Registry::instance()->load_helper('Activation');
62 62
 		$version_string = $version_array['Core'];
63 63
 		if (
64
-			( $version_string <= '4.7.0' && $version_string >= '4.6.0' )
64
+			($version_string <= '4.7.0' && $version_string >= '4.6.0')
65 65
 			||
66
-			( $version_string >= '4.7.0' &&
67
-					! EEH_Activation::table_exists( 'esp_registration_payment' ) &&
68
-					EEH_Activation::table_exists( 'esp_registration' ) ) ) {
66
+			($version_string >= '4.7.0' &&
67
+					! EEH_Activation::table_exists('esp_registration_payment') &&
68
+					EEH_Activation::table_exists('esp_registration')) ) {
69 69
 			return true;
70
-		} elseif ( ! $version_string ) {
70
+		} elseif ( ! $version_string) {
71 71
 			//no version string provided... this must be pre 4.3
72
-			return false;//changed mind. dont want people thinking they should migrate yet because they cant
72
+			return false; //changed mind. dont want people thinking they should migrate yet because they cant
73 73
 		} else {
74 74
 			return false;
75 75
 		}
@@ -91,16 +91,16 @@  discard block
 block discarded – undo
91 91
 	 */
92 92
 	public function schema_changes_before_migration() {
93 93
 		//relies on 4.1's EEH_Activation::create_table
94
-		require_once( EE_HELPERS . 'EEH_Activation.helper.php' );
95
-		$table_name='esp_answer';
96
-		$sql=" ANS_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
94
+		require_once(EE_HELPERS.'EEH_Activation.helper.php');
95
+		$table_name = 'esp_answer';
96
+		$sql = " ANS_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
97 97
 					REG_ID INT UNSIGNED NOT NULL,
98 98
 					QST_ID INT UNSIGNED NOT NULL,
99 99
 					ANS_value TEXT NOT NULL,
100 100
 					PRIMARY KEY  (ANS_ID),
101 101
 					KEY REG_ID (REG_ID),
102 102
 					KEY QST_ID (QST_ID)";
103
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
103
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
104 104
 
105 105
 		$table_name = 'esp_attendee_meta';
106 106
 		$sql = "ATTM_ID INT(10) UNSIGNED NOT	NULL AUTO_INCREMENT,
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 					  CNT_is_EU TINYINT(1) DEFAULT '0',
141 141
 					  CNT_active TINYINT(1) DEFAULT '0',
142 142
 					  PRIMARY KEY  (CNT_ISO)";
143
-		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB' );
143
+		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB');
144 144
 
145 145
 		$table_name = 'esp_currency';
146 146
 		$sql = "CUR_code VARCHAR(6) COLLATE utf8_bin NOT NULL,
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 				CUR_dec_plc VARCHAR(1) COLLATE utf8_bin NOT NULL DEFAULT '2',
151 151
 				CUR_active TINYINT(1) DEFAULT '0',
152 152
 				PRIMARY KEY  (CUR_code)";
153
-		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB' );
153
+		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB');
154 154
 
155 155
 
156 156
 		$table_name = 'esp_currency_payment_method';
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 						KEY EVT_ID (EVT_ID),
181 181
 						KEY DTT_is_primary (DTT_is_primary)";
182 182
 
183
-		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB' );
183
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
184 184
 
185 185
 		$table_name = 'esp_event_meta';
186 186
 		$sql = "
@@ -199,44 +199,44 @@  discard block
 block discarded – undo
199 199
 			EVT_donations TINYINT(1) NULL,
200 200
 			PRIMARY KEY  (EVTM_ID),
201 201
 			KEY EVT_ID (EVT_ID)";
202
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
202
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
203 203
 
204 204
 
205 205
 
206
-		$table_name='esp_event_question_group';
207
-		$sql="EQG_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
206
+		$table_name = 'esp_event_question_group';
207
+		$sql = "EQG_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
208 208
 					EVT_ID BIGINT(20) UNSIGNED NOT NULL,
209 209
 					QSG_ID INT UNSIGNED NOT NULL,
210 210
 					EQG_primary TINYINT(1) UNSIGNED NOT NULL DEFAULT 0,
211 211
 					PRIMARY KEY  (EQG_ID),
212 212
 					KEY EVT_ID (EVT_ID),
213 213
 					KEY QSG_ID (QSG_ID)";
214
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
214
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
215 215
 
216 216
 
217 217
 
218
-		$table_name='esp_event_venue';
219
-		$sql="EVV_ID INT(11) NOT NULL AUTO_INCREMENT,
218
+		$table_name = 'esp_event_venue';
219
+		$sql = "EVV_ID INT(11) NOT NULL AUTO_INCREMENT,
220 220
 				EVT_ID BIGINT(20) UNSIGNED NOT NULL,
221 221
 				VNU_ID BIGINT(20) UNSIGNED NOT NULL,
222 222
 				EVV_primary TINYINT(1) UNSIGNED NOT NULL DEFAULT 0,
223 223
 				PRIMARY KEY  (EVV_ID)";
224
-		$this->_table_has_not_changed_since_previous($table_name,$sql, 'ENGINE=InnoDB');
224
+		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB');
225 225
 
226 226
 
227 227
 
228
-		$table_name='esp_extra_meta';
229
-		$sql="EXM_ID INT(11) NOT NULL AUTO_INCREMENT,
228
+		$table_name = 'esp_extra_meta';
229
+		$sql = "EXM_ID INT(11) NOT NULL AUTO_INCREMENT,
230 230
 				OBJ_ID INT(11) DEFAULT NULL,
231 231
 				EXM_type VARCHAR(45) DEFAULT NULL,
232 232
 				EXM_key VARCHAR(45) DEFAULT NULL,
233 233
 				EXM_value TEXT,
234 234
 				PRIMARY KEY  (EXM_ID),
235 235
 				KEY EXM_type (EXM_type, OBJ_ID, EXM_key(45))";
236
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
236
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
237 237
 
238
-		$table_name='esp_line_item';
239
-		$sql="LIN_ID INT(11) NOT NULL AUTO_INCREMENT,
238
+		$table_name = 'esp_line_item';
239
+		$sql = "LIN_ID INT(11) NOT NULL AUTO_INCREMENT,
240 240
 				LIN_code VARCHAR(245) NOT NULL DEFAULT '',
241 241
 				TXN_ID INT(11) DEFAULT NULL,
242 242
 				LIN_name VARCHAR(245) NOT NULL DEFAULT '',
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 				PRIMARY KEY  (LIN_ID),
255 255
 				KEY LIN_code (LIN_code(191)),
256 256
 				KEY TXN_ID (TXN_ID)";
257
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB' );
257
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
258 258
 
259 259
 		$table_name = 'esp_log';
260 260
 		$sql = "LOG_ID INT(11) NOT NULL AUTO_INCREMENT,
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
 					MTP_is_active TINYINT(1) NOT NULL DEFAULT '1',
295 295
 					PRIMARY KEY  (GRP_ID),
296 296
 					KEY MTP_user_id (MTP_user_id)";
297
-		$this->_table_has_not_changed_since_previous( $table_name, $sql, 'ENGINE=InnoDB');
297
+		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB');
298 298
 
299 299
 		$table_name = 'esp_event_message_template';
300 300
 		$sql = "EMT_ID BIGINT(20) UNSIGNED NOT NULL AUTO_INCREMENT,
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
 					PRIMARY KEY  (EMT_ID),
304 304
 					KEY EVT_ID (EVT_ID),
305 305
 					KEY GRP_ID (GRP_ID)";
306
-		$this->_table_has_not_changed_since_previous( $table_name, $sql, 'ENGINE=InnoDB');
306
+		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB');
307 307
 
308 308
 
309 309
 		$table_name = 'esp_payment';
@@ -376,8 +376,8 @@  discard block
 block discarded – undo
376 376
 					  PRIMARY KEY  (TTM_ID)";
377 377
 		$this->_table_has_not_changed_since_previous($table_name, $sql, 'ENGINE=InnoDB');
378 378
 
379
-		$table_name='esp_question';
380
-		$sql='QST_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
379
+		$table_name = 'esp_question';
380
+		$sql = 'QST_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
381 381
 					QST_display_text TEXT NOT NULL,
382 382
 					QST_admin_label VARCHAR(255) NOT NULL,
383 383
 					QST_system VARCHAR(25) DEFAULT NULL,
@@ -390,22 +390,22 @@  discard block
 block discarded – undo
390 390
 					QST_deleted TINYINT UNSIGNED NOT NULL DEFAULT 0,
391 391
 					PRIMARY KEY  (QST_ID),
392 392
 					KEY QST_order (QST_order)';
393
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
393
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
394 394
 
395
-		$table_name='esp_question_group_question';
396
-		$sql="QGQ_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
395
+		$table_name = 'esp_question_group_question';
396
+		$sql = "QGQ_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
397 397
 					QSG_ID INT UNSIGNED NOT NULL,
398 398
 					QST_ID INT UNSIGNED NOT NULL,
399 399
 					QGQ_order INT UNSIGNED NOT NULL DEFAULT 0,
400 400
 					PRIMARY KEY  (QGQ_ID),
401 401
 					KEY QST_ID (QST_ID),
402 402
 					KEY QSG_ID_order (QSG_ID, QGQ_order)";
403
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
403
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
404 404
 
405 405
 
406 406
 
407
-		$table_name='esp_question_option';
408
-		$sql="QSO_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
407
+		$table_name = 'esp_question_option';
408
+		$sql = "QSO_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
409 409
 					QSO_value VARCHAR(255) NOT NULL,
410 410
 					QSO_desc TEXT NOT NULL,
411 411
 					QST_ID INT UNSIGNED NOT NULL,
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 					PRIMARY KEY  (QSO_ID),
415 415
 					KEY QST_ID (QST_ID),
416 416
 					KEY QSO_order (QSO_order)";
417
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
417
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
418 418
 
419 419
 
420 420
 
@@ -460,8 +460,8 @@  discard block
 block discarded – undo
460 460
 
461 461
 
462 462
 
463
-		$table_name='esp_checkin';
464
-		$sql="CHK_ID INT(10) UNSIGNED NOT NULL AUTO_INCREMENT,
463
+		$table_name = 'esp_checkin';
464
+		$sql = "CHK_ID INT(10) UNSIGNED NOT NULL AUTO_INCREMENT,
465 465
 					REG_ID INT(10) UNSIGNED NOT NULL,
466 466
 					DTT_ID INT(10) UNSIGNED NOT NULL,
467 467
 					CHK_in TINYINT(1) UNSIGNED NOT NULL DEFAULT 1,
@@ -556,7 +556,7 @@  discard block
 block discarded – undo
556 556
 					  PRC_parent INT(10) UNSIGNED DEFAULT 0,
557 557
 					  PRIMARY KEY  (PRC_ID),
558 558
 					  KEY PRT_ID (PRT_ID)";
559
-		$this->_table_is_changed_in_this_version($table_name,$sql, 'ENGINE=InnoDB');
559
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
560 560
 
561 561
 		$table_name = "esp_price_type";
562 562
 		$sql = "PRT_ID TINYINT(3) UNSIGNED NOT NULL AUTO_INCREMENT,
@@ -594,10 +594,10 @@  discard block
 block discarded – undo
594 594
 					  TKT_deleted TINYINT(1) NOT NULL DEFAULT '0',
595 595
 					  PRIMARY KEY  (TKT_ID),
596 596
 					  KEY TKT_start_date (TKT_start_date)";
597
-		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB' );
597
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
598 598
 
599 599
 		$table_name = 'esp_question_group';
600
-		$sql='QSG_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
600
+		$sql = 'QSG_ID INT UNSIGNED NOT NULL AUTO_INCREMENT,
601 601
 					QSG_name VARCHAR(255) NOT NULL,
602 602
 					QSG_identifier VARCHAR(100) NOT NULL,
603 603
 					QSG_desc TEXT NULL,
@@ -610,7 +610,7 @@  discard block
 block discarded – undo
610 610
 					PRIMARY KEY  (QSG_ID),
611 611
 					UNIQUE KEY QSG_identifier_UNIQUE (QSG_identifier ASC),
612 612
 					KEY QSG_order (QSG_order)';
613
-		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB' );
613
+		$this->_table_is_changed_in_this_version($table_name, $sql, 'ENGINE=InnoDB');
614 614
 
615 615
 		/** @var EE_DMS_Core_4_1_0 $script_4_1_defaults */
616 616
 		$script_4_1_defaults = EE_Registry::instance()->load_dms('Core_4_1_0');
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
 		return true;
643 643
 	}
644 644
 
645
-	public function migration_page_hooks(){
645
+	public function migration_page_hooks() {
646 646
 
647 647
 	}
648 648
 
Please login to merge, or discard this patch.
core/EE_System.core.php 2 patches
Indentation   +60 added lines, -60 removed lines patch added patch discarded remove patch
@@ -203,14 +203,14 @@  discard block
 block discarded – undo
203 203
 
204 204
 
205 205
 	/**
206
-	* detect_if_activation_or_upgrade
207
-	*
208
-	* Takes care of detecting whether this is a brand new install or code upgrade,
209
-	* and either setting up the DB or setting up maintenance mode etc.
210
-	*
211
-	* @access public
212
-	* @return void
213
-	*/
206
+	 * detect_if_activation_or_upgrade
207
+	 *
208
+	 * Takes care of detecting whether this is a brand new install or code upgrade,
209
+	 * and either setting up the DB or setting up maintenance mode etc.
210
+	 *
211
+	 * @access public
212
+	 * @return void
213
+	 */
214 214
 	public function detect_if_activation_or_upgrade() {
215 215
 		do_action('AHEE__EE_System___detect_if_activation_or_upgrade__begin');
216 216
 
@@ -514,11 +514,11 @@  discard block
 block discarded – undo
514 514
 			$query_params =  array( 'page' => 'espresso_about' );
515 515
 
516 516
 			if ( EE_System::instance()->detect_req_type() == EE_System::req_type_new_activation ) {
517
-			    $query_params['new_activation'] = TRUE;
517
+				$query_params['new_activation'] = TRUE;
518 518
 			}
519 519
 
520 520
 			if ( EE_System::instance()->detect_req_type() == EE_System::req_type_reactivation ) {
521
-			    $query_params['reactivation'] = TRUE;
521
+				$query_params['reactivation'] = TRUE;
522 522
 			}
523 523
 			$url = add_query_arg( $query_params, admin_url( 'admin.php' ) );
524 524
 			wp_safe_redirect( $url );
@@ -621,11 +621,11 @@  discard block
 block discarded – undo
621 621
 
622 622
 
623 623
 	/**
624
-	* _incompatible_addon_error
625
-	*
626
-	* @access public
627
-	* @return void
628
-	*/
624
+	 * _incompatible_addon_error
625
+	 *
626
+	 * @access public
627
+	 * @return void
628
+	 */
629 629
 	private function _incompatible_addon_error() {
630 630
 		// get array of classes hooking into here
631 631
 		$class_names = EEH_Class_Tools::get_class_names_for_all_callbacks_on_hook( 'AHEE__EE_System__register_shortcodes_modules_and_addons' );
@@ -747,14 +747,14 @@  discard block
 block discarded – undo
747 747
 
748 748
 
749 749
 	/**
750
-	* load_controllers
751
-	*
752
-	* this is the best place to load any additional controllers that needs access to EE core.
753
-	* it is expected that all basic core EE systems, that are not dependant on the current request are loaded at this time
754
-	*
755
-	* @access public
756
-	* @return void
757
-	*/
750
+	 * load_controllers
751
+	 *
752
+	 * this is the best place to load any additional controllers that needs access to EE core.
753
+	 * it is expected that all basic core EE systems, that are not dependant on the current request are loaded at this time
754
+	 *
755
+	 * @access public
756
+	 * @return void
757
+	 */
758 758
 	public function load_controllers() {
759 759
 		do_action( 'AHEE__EE_System__load_controllers__start' );
760 760
 		// let's get it started
@@ -771,13 +771,13 @@  discard block
 block discarded – undo
771 771
 
772 772
 
773 773
 	/**
774
-	* core_loaded_and_ready
775
-	*
776
-	* all of the basic EE core should be loaded at this point and available regardless of M-Mode
777
-	*
778
-	* @access public
779
-	* @return void
780
-	*/
774
+	 * core_loaded_and_ready
775
+	 *
776
+	 * all of the basic EE core should be loaded at this point and available regardless of M-Mode
777
+	 *
778
+	 * @access public
779
+	 * @return void
780
+	 */
781 781
 	public function core_loaded_and_ready() {
782 782
 		do_action( 'AHEE__EE_System__core_loaded_and_ready' );
783 783
 		do_action( 'AHEE__EE_System__set_hooks_for_shortcodes_modules_and_addons' );
@@ -788,13 +788,13 @@  discard block
 block discarded – undo
788 788
 
789 789
 
790 790
 	/**
791
-	* initialize
792
-	*
793
-	* this is the best place to begin initializing client code
794
-	*
795
-	* @access public
796
-	* @return void
797
-	*/
791
+	 * initialize
792
+	 *
793
+	 * this is the best place to begin initializing client code
794
+	 *
795
+	 * @access public
796
+	 * @return void
797
+	 */
798 798
 	public function initialize() {
799 799
 		do_action( 'AHEE__EE_System__initialize' );
800 800
 	}
@@ -802,13 +802,13 @@  discard block
 block discarded – undo
802 802
 
803 803
 
804 804
 	/**
805
-	* initialize_last
806
-	*
807
-	* this is run really late during the WP init hookpoint, and ensures that mostly everything else that needs to initialize has done so
808
-	*
809
-	* @access public
810
-	* @return void
811
-	*/
805
+	 * initialize_last
806
+	 *
807
+	 * this is run really late during the WP init hookpoint, and ensures that mostly everything else that needs to initialize has done so
808
+	 *
809
+	 * @access public
810
+	 * @return void
811
+	 */
812 812
 	public function initialize_last() {
813 813
 		do_action( 'AHEE__EE_System__initialize_last' );
814 814
 	}
@@ -817,14 +817,14 @@  discard block
 block discarded – undo
817 817
 
818 818
 
819 819
 	/**
820
-	* set_hooks_for_shortcodes_modules_and_addons
821
-	*
822
-	* this is the best place for other systems to set callbacks for hooking into other parts of EE
823
-	* this happens at the very beginning of the wp_loaded hookpoint
824
-	*
825
-	* @access public
826
-	* @return void
827
-	*/
820
+	 * set_hooks_for_shortcodes_modules_and_addons
821
+	 *
822
+	 * this is the best place for other systems to set callbacks for hooking into other parts of EE
823
+	 * this happens at the very beginning of the wp_loaded hookpoint
824
+	 *
825
+	 * @access public
826
+	 * @return void
827
+	 */
828 828
 	public function set_hooks_for_shortcodes_modules_and_addons() {
829 829
 //		do_action( 'AHEE__EE_System__set_hooks_for_shortcodes_modules_and_addons' );
830 830
 	}
@@ -833,13 +833,13 @@  discard block
 block discarded – undo
833 833
 
834 834
 
835 835
 	/**
836
-	* do_not_cache
837
-	*
838
-	* sets no cache headers and defines no cache constants for WP plugins
839
-	*
840
-	* @access public
841
-	* @return void
842
-	*/
836
+	 * do_not_cache
837
+	 *
838
+	 * sets no cache headers and defines no cache constants for WP plugins
839
+	 *
840
+	 * @access public
841
+	 * @return void
842
+	 */
843 843
 	public static function do_not_cache() {
844 844
 		// set no cache constants
845 845
 		if ( ! defined( 'DONOTCACHEPAGE' ) ) {
@@ -957,7 +957,7 @@  discard block
 block discarded – undo
957 957
 			//Current post
958 958
 			global $post;		
959 959
     	
960
-	    	if ( EE_Registry::instance()->CAP->current_user_can( 'ee_edit_event', 'ee_admin_bar_menu_espresso-toolbar-events-edit', $post->ID ) ) {
960
+			if ( EE_Registry::instance()->CAP->current_user_can( 'ee_edit_event', 'ee_admin_bar_menu_espresso-toolbar-events-edit', $post->ID ) ) {
961 961
 				//Events Edit Current Event
962 962
 				$admin_bar->add_menu(array(
963 963
 						'id' => 'espresso-toolbar-events-edit',
Please login to merge, or discard this patch.
Spacing   +255 added lines, -255 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 */
103 103
 	public static function instance() {
104 104
 		// check if class object is instantiated
105
-		if ( ! self::$_instance instanceof EE_System ) {
105
+		if ( ! self::$_instance instanceof EE_System) {
106 106
 			self::$_instance = new self();
107 107
 		}
108 108
 		return self::$_instance;
@@ -113,12 +113,12 @@  discard block
 block discarded – undo
113 113
 	 * resets the instance and returns it
114 114
 	 * @return EE_System
115 115
 	 */
116
-	public static function reset(){
116
+	public static function reset() {
117 117
 		self::$_instance->_req_type = NULL;
118 118
 		//we need to reset the migration manager in order for it to detect DMSs properly
119 119
 		EE_Data_Migration_Manager::reset();
120 120
 		//make sure none of the old hooks are left hanging around
121
-		remove_all_actions( 'AHEE__EE_System__perform_activations_upgrades_and_migrations');
121
+		remove_all_actions('AHEE__EE_System__perform_activations_upgrades_and_migrations');
122 122
 		self::instance()->detect_activations_or_upgrades();
123 123
 		self::instance()->perform_activations_upgrades_and_migrations();
124 124
 		return self::instance();
@@ -134,26 +134,26 @@  discard block
 block discarded – undo
134 134
 	 * @access    private
135 135
 	 */
136 136
 	private function __construct() {
137
-		do_action( 'AHEE__EE_System__construct__begin', $this );
137
+		do_action('AHEE__EE_System__construct__begin', $this);
138 138
 		// allow addons to load first so that they can register autoloaders, set hooks for running DMS's, etc
139
-		add_action( 'AHEE__EE_Bootstrap__load_espresso_addons', array( $this, 'load_espresso_addons' ) );
139
+		add_action('AHEE__EE_Bootstrap__load_espresso_addons', array($this, 'load_espresso_addons'));
140 140
 		// when an ee addon is activated, we want to call the core hook(s) again
141 141
 		// because the newly-activated addon didn't get a chance to run at all
142
-		add_action( 'activate_plugin', array( $this, 'load_espresso_addons' ), 1 );
142
+		add_action('activate_plugin', array($this, 'load_espresso_addons'), 1);
143 143
 		// detect whether install or upgrade
144
-		add_action( 'AHEE__EE_Bootstrap__detect_activations_or_upgrades', array( $this, 'detect_activations_or_upgrades' ), 3 );
144
+		add_action('AHEE__EE_Bootstrap__detect_activations_or_upgrades', array($this, 'detect_activations_or_upgrades'), 3);
145 145
 		// load EE_Config, EE_Textdomain, etc
146
-		add_action( 'AHEE__EE_Bootstrap__load_core_configuration', array( $this, 'load_core_configuration' ), 5 );
146
+		add_action('AHEE__EE_Bootstrap__load_core_configuration', array($this, 'load_core_configuration'), 5);
147 147
 		// load EE_Config, EE_Textdomain, etc
148
-		add_action( 'AHEE__EE_Bootstrap__register_shortcodes_modules_and_widgets', array( $this, 'register_shortcodes_modules_and_widgets' ), 7 );
148
+		add_action('AHEE__EE_Bootstrap__register_shortcodes_modules_and_widgets', array($this, 'register_shortcodes_modules_and_widgets'), 7);
149 149
 		// you wanna get going? I wanna get going... let's get going!
150
-		add_action( 'AHEE__EE_Bootstrap__brew_espresso', array( $this, 'brew_espresso' ), 9 );
150
+		add_action('AHEE__EE_Bootstrap__brew_espresso', array($this, 'brew_espresso'), 9);
151 151
 		//other housekeeping
152 152
 		//exclude EE critical pages from wp_list_pages
153
-		add_filter( 'wp_list_pages_excludes', array( $this, 'remove_pages_from_wp_list_pages' ), 10 );
153
+		add_filter('wp_list_pages_excludes', array($this, 'remove_pages_from_wp_list_pages'), 10);
154 154
 		// ALL EE Addons should use the following hook point to attach their initial setup too
155 155
 		// it's extremely important for EE Addons to register any class autoloaders so that they can be available when the EE_Config loads
156
-		do_action( 'AHEE__EE_System__construct__complete', $this );
156
+		do_action('AHEE__EE_System__construct__complete', $this);
157 157
 	}
158 158
 
159 159
 
@@ -173,13 +173,13 @@  discard block
 block discarded – undo
173 173
 	public function load_espresso_addons() {
174 174
 		// set autoloaders for all of the classes implementing EEI_Plugin_API
175 175
 		// which provide helpers for EE plugin authors to more easily register certain components with EE.
176
-		EEH_Autoloader::instance()->register_autoloaders_for_each_file_in_folder( EE_LIBRARIES . 'plugin_api' );
176
+		EEH_Autoloader::instance()->register_autoloaders_for_each_file_in_folder(EE_LIBRARIES.'plugin_api');
177 177
 		//load and setup EE_Capabilities
178
-		EE_Registry::instance()->load_core( 'Capabilities' );
178
+		EE_Registry::instance()->load_core('Capabilities');
179 179
 		//caps need to be initialized on every request so that capability maps are set.
180 180
 		//@see https://events.codebasehq.com/projects/event-espresso/tickets/8674
181 181
 		EE_Registry::instance()->CAP->init_caps();
182
-		do_action( 'AHEE__EE_System__load_espresso_addons' );
182
+		do_action('AHEE__EE_System__load_espresso_addons');
183 183
 	}
184 184
 
185 185
 
@@ -194,10 +194,10 @@  discard block
 block discarded – undo
194 194
 	 * @access public
195 195
 	 * @return void
196 196
 	 */
197
-	public function detect_activations_or_upgrades(){
197
+	public function detect_activations_or_upgrades() {
198 198
 		//first off: let's make sure to handle core
199 199
 		$this->detect_if_activation_or_upgrade();
200
-		foreach(EE_Registry::instance()->addons as $addon){
200
+		foreach (EE_Registry::instance()->addons as $addon) {
201 201
 			//detect teh request type for that addon
202 202
 			$addon->detect_activation_or_upgrade();
203 203
 		}
@@ -218,44 +218,44 @@  discard block
 block discarded – undo
218 218
 		do_action('AHEE__EE_System___detect_if_activation_or_upgrade__begin');
219 219
 
220 220
 		// load M-Mode class
221
-		EE_Registry::instance()->load_core( 'Maintenance_Mode' );
221
+		EE_Registry::instance()->load_core('Maintenance_Mode');
222 222
 		// check if db has been updated, or if its a brand-new installation
223 223
 
224 224
 		$espresso_db_update = $this->fix_espresso_db_upgrade_option();
225
-		$request_type =  $this->detect_req_type($espresso_db_update);
225
+		$request_type = $this->detect_req_type($espresso_db_update);
226 226
 		//EEH_Debug_Tools::printr( $request_type, '$request_type', __FILE__, __LINE__ );
227
-		if( $request_type != EE_System::req_type_normal){
227
+		if ($request_type != EE_System::req_type_normal) {
228 228
 			EE_Registry::instance()->load_helper('Activation');
229 229
 		}
230 230
 
231
-		switch($request_type){
231
+		switch ($request_type) {
232 232
 			case EE_System::req_type_new_activation:
233
-				do_action( 'AHEE__EE_System__detect_if_activation_or_upgrade__new_activation' );
234
-				$this->_handle_core_version_change( $espresso_db_update );
233
+				do_action('AHEE__EE_System__detect_if_activation_or_upgrade__new_activation');
234
+				$this->_handle_core_version_change($espresso_db_update);
235 235
 				break;
236 236
 			case EE_System::req_type_reactivation:
237
-				do_action( 'AHEE__EE_System__detect_if_activation_or_upgrade__reactivation' );
238
-				$this->_handle_core_version_change( $espresso_db_update );
237
+				do_action('AHEE__EE_System__detect_if_activation_or_upgrade__reactivation');
238
+				$this->_handle_core_version_change($espresso_db_update);
239 239
 				break;
240 240
 			case EE_System::req_type_upgrade:
241
-				do_action( 'AHEE__EE_System__detect_if_activation_or_upgrade__upgrade' );
241
+				do_action('AHEE__EE_System__detect_if_activation_or_upgrade__upgrade');
242 242
 				//migrations may be required now that we've upgraded
243 243
 				EE_Maintenance_Mode::instance()->set_maintenance_mode_if_db_old();
244
-				$this->_handle_core_version_change( $espresso_db_update );
244
+				$this->_handle_core_version_change($espresso_db_update);
245 245
 //				echo "done upgrade";die;
246 246
 				break;
247 247
 			case EE_System::req_type_downgrade:
248
-				do_action( 'AHEE__EE_System__detect_if_activation_or_upgrade__downgrade' );
248
+				do_action('AHEE__EE_System__detect_if_activation_or_upgrade__downgrade');
249 249
 				//its possible migrations are no longer required
250 250
 				EE_Maintenance_Mode::instance()->set_maintenance_mode_if_db_old();
251
-				$this->_handle_core_version_change( $espresso_db_update );
251
+				$this->_handle_core_version_change($espresso_db_update);
252 252
 				break;
253 253
 			case EE_System::req_type_normal:
254 254
 			default:
255 255
 //				$this->_maybe_redirect_to_ee_about();
256 256
 				break;
257 257
 		}
258
-		do_action( 'AHEE__EE_System__detect_if_activation_or_upgrade__complete' );
258
+		do_action('AHEE__EE_System__detect_if_activation_or_upgrade__complete');
259 259
 	}
260 260
 
261 261
 	/**
@@ -263,10 +263,10 @@  discard block
 block discarded – undo
263 263
 	 * initializing the database later during the request
264 264
 	 * @param array $espresso_db_update
265 265
 	 */
266
-	protected function _handle_core_version_change( $espresso_db_update ){
267
-		$this->update_list_of_installed_versions( $espresso_db_update );
266
+	protected function _handle_core_version_change($espresso_db_update) {
267
+		$this->update_list_of_installed_versions($espresso_db_update);
268 268
 		//get ready to verify the DB is ok (provided we aren't in maintenance mode, of course)
269
-		add_action( 'AHEE__EE_System__perform_activations_upgrades_and_migrations', array( $this, 'initialize_db_if_no_migrations_required' ));
269
+		add_action('AHEE__EE_System__perform_activations_upgrades_and_migrations', array($this, 'initialize_db_if_no_migrations_required'));
270 270
 	}
271 271
 
272 272
 
@@ -281,44 +281,44 @@  discard block
 block discarded – undo
281 281
 	 * @internal param array $espresso_db_update_value the value of the WordPress option. If not supplied, fetches it from the options table
282 282
 	 * @return array the correct value of 'espresso_db_upgrade', after saving it, if it needed correction
283 283
 	 */
284
-	private function fix_espresso_db_upgrade_option($espresso_db_update = null){
285
-		do_action( 'FHEE__EE_System__manage_fix_espresso_db_upgrade_option__begin', $espresso_db_update );
286
-		if( ! $espresso_db_update){
287
-			$espresso_db_update = get_option( 'espresso_db_update' );
284
+	private function fix_espresso_db_upgrade_option($espresso_db_update = null) {
285
+		do_action('FHEE__EE_System__manage_fix_espresso_db_upgrade_option__begin', $espresso_db_update);
286
+		if ( ! $espresso_db_update) {
287
+			$espresso_db_update = get_option('espresso_db_update');
288 288
 		}
289 289
 		// check that option is an array
290
-		if( ! is_array( $espresso_db_update )) {
290
+		if ( ! is_array($espresso_db_update)) {
291 291
 			// if option is FALSE, then it never existed
292
-			if ( $espresso_db_update === FALSE ) {
292
+			if ($espresso_db_update === FALSE) {
293 293
 				// make $espresso_db_update an array and save option with autoload OFF
294
-				$espresso_db_update =  array();
295
-				add_option( 'espresso_db_update', $espresso_db_update, '', 'no' );
294
+				$espresso_db_update = array();
295
+				add_option('espresso_db_update', $espresso_db_update, '', 'no');
296 296
 			} else {
297 297
 				// option is NOT FALSE but also is NOT an array, so make it an array and save it
298
-				$espresso_db_update =  array( $espresso_db_update=>array() );
299
-				update_option( 'espresso_db_update', $espresso_db_update );
298
+				$espresso_db_update = array($espresso_db_update=>array());
299
+				update_option('espresso_db_update', $espresso_db_update);
300 300
 			}
301
-		}else{
301
+		} else {
302 302
 			$corrected_db_update = array();
303 303
 			//if IS an array, but is it an array where KEYS are version numbers, and values are arrays?
304
-			foreach($espresso_db_update as $should_be_version_string => $should_be_array){
305
-				if(is_int($should_be_version_string) && ! is_array($should_be_array)){
304
+			foreach ($espresso_db_update as $should_be_version_string => $should_be_array) {
305
+				if (is_int($should_be_version_string) && ! is_array($should_be_array)) {
306 306
 					//the key is an int, and the value IS NOT an array
307 307
 					//so it must be numerically-indexed, where values are versions installed...
308 308
 					//fix it!
309 309
 					$version_string = $should_be_array;
310 310
 					$corrected_db_update[$version_string] = array('unknown-date');
311
-				}else{
311
+				} else {
312 312
 					//ok it checks out
313 313
 					$corrected_db_update[$should_be_version_string] = $should_be_array;
314 314
 				}
315 315
 			}
316 316
 			$espresso_db_update = $corrected_db_update;
317
-			update_option( 'espresso_db_update', $espresso_db_update );
317
+			update_option('espresso_db_update', $espresso_db_update);
318 318
 
319 319
 		}
320 320
 
321
-		do_action( 'FHEE__EE_System__manage_fix_espresso_db_upgrade_option__complete', $espresso_db_update );
321
+		do_action('FHEE__EE_System__manage_fix_espresso_db_upgrade_option__complete', $espresso_db_update);
322 322
 		return $espresso_db_update;
323 323
 	}
324 324
 
@@ -337,33 +337,33 @@  discard block
 block discarded – undo
337 337
 	 * so we prefer to only do it when necessary
338 338
 	 * @return void
339 339
 	 */
340
-	public function initialize_db_if_no_migrations_required( $initialize_addons_too = FALSE, $verify_schema = true ){
340
+	public function initialize_db_if_no_migrations_required($initialize_addons_too = FALSE, $verify_schema = true) {
341 341
 		$request_type = $this->detect_req_type();
342 342
 		//only initialize system if we're not in maintenance mode.
343
-		if( EE_Maintenance_Mode::instance()->level() != EE_Maintenance_Mode::level_2_complete_maintenance ){
344
-			update_option( 'ee_flush_rewrite_rules', TRUE );
343
+		if (EE_Maintenance_Mode::instance()->level() != EE_Maintenance_Mode::level_2_complete_maintenance) {
344
+			update_option('ee_flush_rewrite_rules', TRUE);
345 345
 			EEH_Activation::system_initialization();
346
-			if( $verify_schema ) {
346
+			if ($verify_schema) {
347 347
 				EEH_Activation::initialize_db_and_folders();
348 348
 			}
349 349
 			EEH_Activation::initialize_db_content();
350
-			if( $initialize_addons_too ) {
350
+			if ($initialize_addons_too) {
351 351
 				$this->initialize_addons();
352 352
 			}
353
-		}else{
354
-			EE_Data_Migration_Manager::instance()->enqueue_db_initialization_for( 'Core' );
353
+		} else {
354
+			EE_Data_Migration_Manager::instance()->enqueue_db_initialization_for('Core');
355 355
 		}
356
-		if ( $request_type == EE_System::req_type_new_activation || $request_type == EE_System::req_type_reactivation || $request_type == EE_System::req_type_upgrade ) {
357
-			add_action( 'AHEE__EE_System__load_CPTs_and_session__start', array( $this, 'redirect_to_about_ee' ), 9 );
356
+		if ($request_type == EE_System::req_type_new_activation || $request_type == EE_System::req_type_reactivation || $request_type == EE_System::req_type_upgrade) {
357
+			add_action('AHEE__EE_System__load_CPTs_and_session__start', array($this, 'redirect_to_about_ee'), 9);
358 358
 		}
359 359
 	}
360 360
 
361 361
 	/**
362 362
 	 * Initializes the db for all registered addons
363 363
 	 */
364
-	public function initialize_addons(){
364
+	public function initialize_addons() {
365 365
 		//foreach registered addon, make sure its db is up-to-date too
366
-		foreach(EE_Registry::instance()->addons as $addon){
366
+		foreach (EE_Registry::instance()->addons as $addon) {
367 367
 			$addon->initialize_db_if_no_migrations_required();
368 368
 		}
369 369
 	}
@@ -375,16 +375,16 @@  discard block
 block discarded – undo
375 375
 	 * @param 	string 	$current_version_to_add 	version to be added to the version history
376 376
 	 * @return 	boolean success as to whether or not this option was changed
377 377
 	 */
378
-	public function update_list_of_installed_versions($version_history = NULL,$current_version_to_add = NULL) {
379
-		if( ! $version_history ) {
378
+	public function update_list_of_installed_versions($version_history = NULL, $current_version_to_add = NULL) {
379
+		if ( ! $version_history) {
380 380
 			$version_history = $this->fix_espresso_db_upgrade_option($version_history);
381 381
 		}
382
-		if( $current_version_to_add == NULL){
382
+		if ($current_version_to_add == NULL) {
383 383
 			$current_version_to_add = espresso_version();
384 384
 		}
385
-		$version_history[ $current_version_to_add ][] = date( 'Y-m-d H:i:s',time() );
385
+		$version_history[$current_version_to_add][] = date('Y-m-d H:i:s', time());
386 386
 		// re-save
387
-		return update_option( 'espresso_db_update', $version_history );
387
+		return update_option('espresso_db_update', $version_history);
388 388
 	}
389 389
 
390 390
 
@@ -401,10 +401,10 @@  discard block
 block discarded – undo
401 401
 	 *                            but still know if this is a new install or not
402 402
 	 * @return int one of the constants on EE_System::req_type_
403 403
 	 */
404
-	public function detect_req_type( $espresso_db_update = NULL ){
405
-		if ( $this->_req_type === NULL ){
406
-			$espresso_db_update = ! empty( $espresso_db_update ) ? $espresso_db_update : $this->fix_espresso_db_upgrade_option();
407
-			$this->_req_type = $this->detect_req_type_given_activation_history( $espresso_db_update, 'ee_espresso_activation', espresso_version() );
404
+	public function detect_req_type($espresso_db_update = NULL) {
405
+		if ($this->_req_type === NULL) {
406
+			$espresso_db_update = ! empty($espresso_db_update) ? $espresso_db_update : $this->fix_espresso_db_upgrade_option();
407
+			$this->_req_type = $this->detect_req_type_given_activation_history($espresso_db_update, 'ee_espresso_activation', espresso_version());
408 408
 		}
409 409
 		return $this->_req_type;
410 410
 	}
@@ -420,39 +420,39 @@  discard block
 block discarded – undo
420 420
 	 * @param string $version_to_upgrade_to the version that was just upgraded to (for core that will be espresso_version())
421 421
 	 * @return int one of the constants on EE_System::req_type_*
422 422
 	 */
423
-	public static function detect_req_type_given_activation_history( $activation_history_for_addon, $activation_indicator_option_name, $version_to_upgrade_to ){
424
-		$version_is_higher = self::_new_version_is_higher( $activation_history_for_addon, $version_to_upgrade_to );
425
-		if( $activation_history_for_addon ){
423
+	public static function detect_req_type_given_activation_history($activation_history_for_addon, $activation_indicator_option_name, $version_to_upgrade_to) {
424
+		$version_is_higher = self::_new_version_is_higher($activation_history_for_addon, $version_to_upgrade_to);
425
+		if ($activation_history_for_addon) {
426 426
 			//it exists, so this isn't a completely new install
427 427
 			//check if this version already in that list of previously installed versions
428
-			if ( ! isset( $activation_history_for_addon[ $version_to_upgrade_to ] )) {
428
+			if ( ! isset($activation_history_for_addon[$version_to_upgrade_to])) {
429 429
 				//it a version we haven't seen before
430
-				if( $version_is_higher === 1 ){
430
+				if ($version_is_higher === 1) {
431 431
 					$req_type = EE_System::req_type_upgrade;
432
-				}else{
432
+				} else {
433 433
 					$req_type = EE_System::req_type_downgrade;
434 434
 				}
435
-				delete_option( $activation_indicator_option_name );
435
+				delete_option($activation_indicator_option_name);
436 436
 			} else {
437 437
 				// its not an update. maybe a reactivation?
438
-				if( get_option( $activation_indicator_option_name, FALSE ) ){
439
-					if ( $version_is_higher === -1 ){
438
+				if (get_option($activation_indicator_option_name, FALSE)) {
439
+					if ($version_is_higher === -1) {
440 440
 						$req_type = EE_System::req_type_downgrade;
441
-					}elseif( $version_is_higher === 0 ){
441
+					}elseif ($version_is_higher === 0) {
442 442
 						//we've seen this version before, but it's an activation. must be a reactivation
443 443
 						$req_type = EE_System::req_type_reactivation;
444
-					}else{//$version_is_higher === 1
444
+					} else {//$version_is_higher === 1
445 445
 						$req_type = EE_System::req_type_upgrade;
446 446
 					}
447
-					delete_option( $activation_indicator_option_name );
447
+					delete_option($activation_indicator_option_name);
448 448
 				} else {
449 449
 					//we've seen this version before and the activation indicate doesn't show it was just activated
450
-					if ( $version_is_higher === -1 ){
450
+					if ($version_is_higher === -1) {
451 451
 						$req_type = EE_System::req_type_downgrade;
452
-					}elseif( $version_is_higher === 0 ){
452
+					}elseif ($version_is_higher === 0) {
453 453
 						//we've seen this version before and it's not an activation. its normal request
454 454
 						$req_type = EE_System::req_type_normal;
455
-					}else{//$version_is_higher === 1
455
+					} else {//$version_is_higher === 1
456 456
 						$req_type = EE_System::req_type_upgrade;
457 457
 					}
458 458
 				}
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
 		} else {
461 461
 			//brand new install
462 462
 			$req_type = EE_System::req_type_new_activation;
463
-			delete_option( $activation_indicator_option_name );
463
+			delete_option($activation_indicator_option_name);
464 464
 		}
465 465
 		return $req_type;
466 466
 	}
@@ -478,30 +478,30 @@  discard block
 block discarded – undo
478 478
 	 *		0 if $version_to_upgrade_to MATCHES (reactivation or normal request);
479 479
 	 *		1 if $version_to_upgrade_to is HIGHER (upgrade) ;
480 480
 	 */
481
-	protected static function _new_version_is_higher( $activation_history_for_addon, $version_to_upgrade_to ){
481
+	protected static function _new_version_is_higher($activation_history_for_addon, $version_to_upgrade_to) {
482 482
 		//find the most recently-activated version
483 483
 		$most_recently_active_version_activation = '1970-01-01 00:00:00';
484 484
 		$most_recently_active_version = '0.0.0.dev.000';
485
-		if( is_array( $activation_history_for_addon ) ){
486
-			foreach( $activation_history_for_addon as $version => $times_activated ){
485
+		if (is_array($activation_history_for_addon)) {
486
+			foreach ($activation_history_for_addon as $version => $times_activated) {
487 487
 				//check there is a record of when this version was activated. Otherwise,
488 488
 				//mark it as unknown
489
-				if( ! $times_activated ){
490
-					$times_activated = array( 'unknown-date');
489
+				if ( ! $times_activated) {
490
+					$times_activated = array('unknown-date');
491 491
 				}
492
-				if( is_string( $times_activated ) ){
493
-					$times_activated = array( $times_activated );
492
+				if (is_string($times_activated)) {
493
+					$times_activated = array($times_activated);
494 494
 				}
495
-				foreach( $times_activated as $an_activation ){
496
-					if( $an_activation != 'unknown-date' &&
497
-							$an_activation > $most_recently_active_version_activation  ){
495
+				foreach ($times_activated as $an_activation) {
496
+					if ($an_activation != 'unknown-date' &&
497
+							$an_activation > $most_recently_active_version_activation) {
498 498
 						$most_recently_active_version = $version;
499 499
 						$most_recently_active_version_activation = $an_activation == 'unknown-date' ? '1970-01-01 00:00:00' : $an_activation;
500 500
 					}
501 501
 				}
502 502
 			}
503 503
 		}
504
-		return version_compare( $version_to_upgrade_to, $most_recently_active_version );
504
+		return version_compare($version_to_upgrade_to, $most_recently_active_version);
505 505
 	}
506 506
 
507 507
 
@@ -511,20 +511,20 @@  discard block
 block discarded – undo
511 511
 	 * @return void
512 512
 	 */
513 513
 	public function redirect_to_about_ee() {
514
-		$notices = EE_Error::get_notices( FALSE );
514
+		$notices = EE_Error::get_notices(FALSE);
515 515
 		//if current user is an admin and it's not an ajax request
516
-		if(EE_Registry::instance()->CAP->current_user_can( 'manage_options', 'espresso_about_default' ) && ! ( defined('DOING_AJAX') && DOING_AJAX  ) && ! isset( $notices[ 'errors' ] ) ){
517
-			$query_params =  array( 'page' => 'espresso_about' );
516
+		if (EE_Registry::instance()->CAP->current_user_can('manage_options', 'espresso_about_default') && ! (defined('DOING_AJAX') && DOING_AJAX) && ! isset($notices['errors'])) {
517
+			$query_params = array('page' => 'espresso_about');
518 518
 
519
-			if ( EE_System::instance()->detect_req_type() == EE_System::req_type_new_activation ) {
519
+			if (EE_System::instance()->detect_req_type() == EE_System::req_type_new_activation) {
520 520
 			    $query_params['new_activation'] = TRUE;
521 521
 			}
522 522
 
523
-			if ( EE_System::instance()->detect_req_type() == EE_System::req_type_reactivation ) {
523
+			if (EE_System::instance()->detect_req_type() == EE_System::req_type_reactivation) {
524 524
 			    $query_params['reactivation'] = TRUE;
525 525
 			}
526
-			$url = add_query_arg( $query_params, admin_url( 'admin.php' ) );
527
-			wp_safe_redirect( $url );
526
+			$url = add_query_arg($query_params, admin_url('admin.php'));
527
+			wp_safe_redirect($url);
528 528
 			exit();
529 529
 		}
530 530
 	}
@@ -538,31 +538,31 @@  discard block
 block discarded – undo
538 538
 	 *
539 539
 	 * @return void
540 540
 	 */
541
-	public function load_core_configuration(){
542
-		do_action( 'AHEE__EE_System__load_core_configuration__begin', $this );
543
-		EE_Registry::instance()->load_core( 'EE_Load_Textdomain' );
541
+	public function load_core_configuration() {
542
+		do_action('AHEE__EE_System__load_core_configuration__begin', $this);
543
+		EE_Registry::instance()->load_core('EE_Load_Textdomain');
544 544
 		//load textdomain
545 545
 		EE_Load_Textdomain::load_textdomain();
546 546
 		// load and setup EE_Config and EE_Network_Config
547
-		EE_Registry::instance()->load_core( 'Config' );
548
-		EE_Registry::instance()->load_core( 'Network_Config' );
547
+		EE_Registry::instance()->load_core('Config');
548
+		EE_Registry::instance()->load_core('Network_Config');
549 549
 		// setup autoloaders
550 550
 		// enable logging?
551
-		if ( EE_Registry::instance()->CFG->admin->use_full_logging ) {
552
-			EE_Registry::instance()->load_core( 'Log' );
551
+		if (EE_Registry::instance()->CFG->admin->use_full_logging) {
552
+			EE_Registry::instance()->load_core('Log');
553 553
 		}
554 554
 		// check for activation errors
555
-		$activation_errors = get_option( 'ee_plugin_activation_errors', FALSE );
556
-		if ( $activation_errors ) {
557
-			EE_Error::add_error( $activation_errors, __FILE__, __FUNCTION__, __LINE__ );
558
-			update_option( 'ee_plugin_activation_errors', FALSE );
555
+		$activation_errors = get_option('ee_plugin_activation_errors', FALSE);
556
+		if ($activation_errors) {
557
+			EE_Error::add_error($activation_errors, __FILE__, __FUNCTION__, __LINE__);
558
+			update_option('ee_plugin_activation_errors', FALSE);
559 559
 		}
560 560
 		// get model names
561 561
 		$this->_parse_model_names();
562 562
 
563 563
 		//load caf stuff a chance to play during the activation process too.
564 564
 		$this->_maybe_brew_regular();
565
-		do_action( 'AHEE__EE_System__load_core_configuration__complete', $this );
565
+		do_action('AHEE__EE_System__load_core_configuration__complete', $this);
566 566
 	}
567 567
 
568 568
 
@@ -571,23 +571,23 @@  discard block
 block discarded – undo
571 571
 	 *
572 572
 	 * @return void
573 573
 	 */
574
-	private function _parse_model_names(){
574
+	private function _parse_model_names() {
575 575
 		//get all the files in the EE_MODELS folder that end in .model.php
576
-		$models = glob( EE_MODELS.'*.model.php');
576
+		$models = glob(EE_MODELS.'*.model.php');
577 577
 		$model_names = array();
578 578
 		$non_abstract_db_models = array();
579
-		foreach( $models as $model ){
579
+		foreach ($models as $model) {
580 580
 			// get model classname
581
-			$classname = EEH_File::get_classname_from_filepath_with_standard_filename( $model );
582
-			$shortname = str_replace( 'EEM_', '', $classname );
581
+			$classname = EEH_File::get_classname_from_filepath_with_standard_filename($model);
582
+			$shortname = str_replace('EEM_', '', $classname);
583 583
 			$reflectionClass = new ReflectionClass($classname);
584
-			if( $reflectionClass->isSubclassOf('EEM_Base') && ! $reflectionClass->isAbstract()){
584
+			if ($reflectionClass->isSubclassOf('EEM_Base') && ! $reflectionClass->isAbstract()) {
585 585
 				$non_abstract_db_models[$shortname] = $classname;
586 586
 			}
587
-			$model_names[ $shortname ] = $classname;
587
+			$model_names[$shortname] = $classname;
588 588
 		}
589
-		EE_Registry::instance()->models = apply_filters( 'FHEE__EE_System__parse_model_names', $model_names );
590
-		EE_Registry::instance()->non_abstract_db_models = apply_filters( 'FHEE__EE_System__parse_implemented_model_names', $non_abstract_db_models );
589
+		EE_Registry::instance()->models = apply_filters('FHEE__EE_System__parse_model_names', $model_names);
590
+		EE_Registry::instance()->non_abstract_db_models = apply_filters('FHEE__EE_System__parse_implemented_model_names', $non_abstract_db_models);
591 591
 	}
592 592
 
593 593
 
@@ -597,8 +597,8 @@  discard block
 block discarded – undo
597 597
 	 * @return void
598 598
 	 */
599 599
 	private function _maybe_brew_regular() {
600
-		if (( ! defined( 'EE_DECAF' ) ||  EE_DECAF !== TRUE ) && is_readable( EE_CAFF_PATH . 'brewing_regular.php' )) {
601
-			require_once EE_CAFF_PATH . 'brewing_regular.php';
600
+		if (( ! defined('EE_DECAF') || EE_DECAF !== TRUE) && is_readable(EE_CAFF_PATH.'brewing_regular.php')) {
601
+			require_once EE_CAFF_PATH.'brewing_regular.php';
602 602
 		}
603 603
 	}
604 604
 
@@ -615,9 +615,9 @@  discard block
 block discarded – undo
615 615
 	 * @return void
616 616
 	 */
617 617
 	public function register_shortcodes_modules_and_widgets() {
618
-		do_action( 'AHEE__EE_System__register_shortcodes_modules_and_widgets' );
618
+		do_action('AHEE__EE_System__register_shortcodes_modules_and_widgets');
619 619
 		// check for addons using old hookpoint
620
-		if ( has_action( 'AHEE__EE_System__register_shortcodes_modules_and_addons' )) {
620
+		if (has_action('AHEE__EE_System__register_shortcodes_modules_and_addons')) {
621 621
 			$this->_incompatible_addon_error();
622 622
 		}
623 623
 	}
@@ -631,19 +631,19 @@  discard block
 block discarded – undo
631 631
 	*/
632 632
 	private function _incompatible_addon_error() {
633 633
 		// get array of classes hooking into here
634
-		$class_names = EEH_Class_Tools::get_class_names_for_all_callbacks_on_hook( 'AHEE__EE_System__register_shortcodes_modules_and_addons' );
635
-		if ( ! empty( $class_names )) {
636
-			$msg = __( 'The following plugins, addons, or modules appear to be incompatible with this version of Event Espresso and were automatically deactivated to avoid fatal errors:', 'event_espresso' );
634
+		$class_names = EEH_Class_Tools::get_class_names_for_all_callbacks_on_hook('AHEE__EE_System__register_shortcodes_modules_and_addons');
635
+		if ( ! empty($class_names)) {
636
+			$msg = __('The following plugins, addons, or modules appear to be incompatible with this version of Event Espresso and were automatically deactivated to avoid fatal errors:', 'event_espresso');
637 637
 			$msg .= '<ul>';
638
-			foreach ( $class_names as $class_name ) {
639
-				$msg .= '<li><b>Event Espresso - ' . str_replace( array( 'EE_', 'EEM_', 'EED_', 'EES_', 'EEW_' ), '', $class_name ) . '</b></li>';
638
+			foreach ($class_names as $class_name) {
639
+				$msg .= '<li><b>Event Espresso - '.str_replace(array('EE_', 'EEM_', 'EED_', 'EES_', 'EEW_'), '', $class_name).'</b></li>';
640 640
 			}
641 641
 			$msg .= '</ul>';
642
-			$msg .= __( 'Compatibility issues can be avoided and/or resolved by keeping addons and plugins updated to the latest version.', 'event_espresso' );
642
+			$msg .= __('Compatibility issues can be avoided and/or resolved by keeping addons and plugins updated to the latest version.', 'event_espresso');
643 643
 			// save list of incompatible addons to wp-options for later use
644
-			add_option( 'ee_incompatible_addons', $class_names, '', 'no' );
645
-			if ( is_admin() ) {
646
-				EE_Error::add_error( $msg, __FILE__, __FUNCTION__, __LINE__ );
644
+			add_option('ee_incompatible_addons', $class_names, '', 'no');
645
+			if (is_admin()) {
646
+				EE_Error::add_error($msg, __FILE__, __FUNCTION__, __LINE__);
647 647
 			}
648 648
 		}
649 649
 	}
@@ -660,25 +660,25 @@  discard block
 block discarded – undo
660 660
 	 *
661 661
 	 * @return void
662 662
 	 */
663
-	public function brew_espresso(){
664
-		do_action( 'AHEE__EE_System__brew_espresso__begin', $this );
663
+	public function brew_espresso() {
664
+		do_action('AHEE__EE_System__brew_espresso__begin', $this);
665 665
 		// load some final core systems
666
-		add_action( 'init', array( $this, 'set_hooks_for_core' ), 1 );
667
-		add_action( 'init', array( $this, 'perform_activations_upgrades_and_migrations' ), 3 );
668
-		add_action( 'init', array( $this, 'load_CPTs_and_session' ), 5 );
669
-		add_action( 'init', array( $this, 'load_controllers' ), 7 );
670
-		add_action( 'init', array( $this, 'core_loaded_and_ready' ), 9 );
671
-		add_action( 'init', array( $this, 'initialize' ), 10 );
672
-		add_action( 'init', array( $this, 'initialize_last' ), 100 );
673
-		add_action('wp_enqueue_scripts', array( $this, 'wp_enqueue_scripts' ), 25 );
674
-		add_action( 'admin_bar_menu', array( $this, 'espresso_toolbar_items' ), 100 );
675
-
676
-		if ( is_admin() && apply_filters( 'FHEE__EE_System__brew_espresso__load_pue', TRUE )  ) {
666
+		add_action('init', array($this, 'set_hooks_for_core'), 1);
667
+		add_action('init', array($this, 'perform_activations_upgrades_and_migrations'), 3);
668
+		add_action('init', array($this, 'load_CPTs_and_session'), 5);
669
+		add_action('init', array($this, 'load_controllers'), 7);
670
+		add_action('init', array($this, 'core_loaded_and_ready'), 9);
671
+		add_action('init', array($this, 'initialize'), 10);
672
+		add_action('init', array($this, 'initialize_last'), 100);
673
+		add_action('wp_enqueue_scripts', array($this, 'wp_enqueue_scripts'), 25);
674
+		add_action('admin_bar_menu', array($this, 'espresso_toolbar_items'), 100);
675
+
676
+		if (is_admin() && apply_filters('FHEE__EE_System__brew_espresso__load_pue', TRUE)) {
677 677
 			// pew pew pew
678
-			EE_Registry::instance()->load_core( 'PUE' );
679
-			do_action( 'AHEE__EE_System__brew_espresso__after_pue_init' );
678
+			EE_Registry::instance()->load_core('PUE');
679
+			do_action('AHEE__EE_System__brew_espresso__after_pue_init');
680 680
 		}
681
-		do_action( 'AHEE__EE_System__brew_espresso__complete', $this );
681
+		do_action('AHEE__EE_System__brew_espresso__complete', $this);
682 682
 	}
683 683
 
684 684
 
@@ -692,7 +692,7 @@  discard block
 block discarded – undo
692 692
 	 */
693 693
 	public function set_hooks_for_core() {
694 694
 		$this->_deactivate_incompatible_addons();
695
-		do_action( 'AHEE__EE_System__set_hooks_for_core' );
695
+		do_action('AHEE__EE_System__set_hooks_for_core');
696 696
 	}
697 697
 
698 698
 
@@ -701,15 +701,15 @@  discard block
 block discarded – undo
701 701
 	 * Using the information gathered in EE_System::_incompatible_addon_error,
702 702
 	 * deactivates any addons considered incompatible with the current version of EE
703 703
 	 */
704
-	private function _deactivate_incompatible_addons(){
705
-		$incompatible_addons = get_option( 'ee_incompatible_addons', array() );
706
-		if ( ! empty( $incompatible_addons )) {
707
-			$active_plugins = get_option( 'active_plugins', array() );
708
-			foreach ( $active_plugins as $active_plugin ) {
709
-				foreach ( $incompatible_addons as $incompatible_addon ) {
710
-					if ( strpos( $active_plugin,  $incompatible_addon ) !== FALSE ) {
711
-						unset( $_GET['activate'] );
712
-						espresso_deactivate_plugin( $active_plugin );
704
+	private function _deactivate_incompatible_addons() {
705
+		$incompatible_addons = get_option('ee_incompatible_addons', array());
706
+		if ( ! empty($incompatible_addons)) {
707
+			$active_plugins = get_option('active_plugins', array());
708
+			foreach ($active_plugins as $active_plugin) {
709
+				foreach ($incompatible_addons as $incompatible_addon) {
710
+					if (strpos($active_plugin, $incompatible_addon) !== FALSE) {
711
+						unset($_GET['activate']);
712
+						espresso_deactivate_plugin($active_plugin);
713 713
 					}
714 714
 				}
715 715
 			}
@@ -726,10 +726,10 @@  discard block
 block discarded – undo
726 726
 	 */
727 727
 	public function perform_activations_upgrades_and_migrations() {
728 728
 		//first check if we had previously attempted to setup EE's directories but failed
729
-		if( EEH_Activation::upload_directories_incomplete() ) {
729
+		if (EEH_Activation::upload_directories_incomplete()) {
730 730
 			EEH_Activation::create_upload_directories();
731 731
 		}
732
-		do_action( 'AHEE__EE_System__perform_activations_upgrades_and_migrations' );
732
+		do_action('AHEE__EE_System__perform_activations_upgrades_and_migrations');
733 733
 	}
734 734
 
735 735
 
@@ -741,10 +741,10 @@  discard block
 block discarded – undo
741 741
 	 *  	@return 	void
742 742
 	 */
743 743
 	public function load_CPTs_and_session() {
744
-		do_action( 'AHEE__EE_System__load_CPTs_and_session__start' );
744
+		do_action('AHEE__EE_System__load_CPTs_and_session__start');
745 745
 		// register Custom Post Types
746
-		EE_Registry::instance()->load_core( 'Register_CPTs' );
747
-		do_action( 'AHEE__EE_System__load_CPTs_and_session__complete' );
746
+		EE_Registry::instance()->load_core('Register_CPTs');
747
+		do_action('AHEE__EE_System__load_CPTs_and_session__complete');
748 748
 	}
749 749
 
750 750
 
@@ -759,16 +759,16 @@  discard block
 block discarded – undo
759 759
 	* @return void
760 760
 	*/
761 761
 	public function load_controllers() {
762
-		do_action( 'AHEE__EE_System__load_controllers__start' );
762
+		do_action('AHEE__EE_System__load_controllers__start');
763 763
 		// let's get it started
764
-		if ( ! is_admin() && !  EE_Maintenance_Mode::instance()->level() ) {
765
-			do_action( 'AHEE__EE_System__load_controllers__load_front_controllers' );
766
-			EE_Registry::instance()->load_core( 'Front_Controller' );
767
-		} else if ( ! EE_FRONT_AJAX ) {
768
-			do_action( 'AHEE__EE_System__load_controllers__load_admin_controllers' );
769
-			EE_Registry::instance()->load_core( 'Admin' );
764
+		if ( ! is_admin() && ! EE_Maintenance_Mode::instance()->level()) {
765
+			do_action('AHEE__EE_System__load_controllers__load_front_controllers');
766
+			EE_Registry::instance()->load_core('Front_Controller');
767
+		} else if ( ! EE_FRONT_AJAX) {
768
+			do_action('AHEE__EE_System__load_controllers__load_admin_controllers');
769
+			EE_Registry::instance()->load_core('Admin');
770 770
 		}
771
-		do_action( 'AHEE__EE_System__load_controllers__complete' );
771
+		do_action('AHEE__EE_System__load_controllers__complete');
772 772
 	}
773 773
 
774 774
 
@@ -782,10 +782,10 @@  discard block
 block discarded – undo
782 782
 	* @return void
783 783
 	*/
784 784
 	public function core_loaded_and_ready() {
785
-		do_action( 'AHEE__EE_System__core_loaded_and_ready' );
786
-		do_action( 'AHEE__EE_System__set_hooks_for_shortcodes_modules_and_addons' );
785
+		do_action('AHEE__EE_System__core_loaded_and_ready');
786
+		do_action('AHEE__EE_System__set_hooks_for_shortcodes_modules_and_addons');
787 787
 //		add_action( 'wp_loaded', array( $this, 'set_hooks_for_shortcodes_modules_and_addons' ), 1 );
788
-		EE_Registry::instance()->load_core( 'Session' );
788
+		EE_Registry::instance()->load_core('Session');
789 789
 	}
790 790
 
791 791
 
@@ -799,7 +799,7 @@  discard block
 block discarded – undo
799 799
 	* @return void
800 800
 	*/
801 801
 	public function initialize() {
802
-		do_action( 'AHEE__EE_System__initialize' );
802
+		do_action('AHEE__EE_System__initialize');
803 803
 	}
804 804
 
805 805
 
@@ -813,7 +813,7 @@  discard block
 block discarded – undo
813 813
 	* @return void
814 814
 	*/
815 815
 	public function initialize_last() {
816
-		do_action( 'AHEE__EE_System__initialize_last' );
816
+		do_action('AHEE__EE_System__initialize_last');
817 817
 	}
818 818
 
819 819
 
@@ -845,21 +845,21 @@  discard block
 block discarded – undo
845 845
 	*/
846 846
 	public static function do_not_cache() {
847 847
 		// set no cache constants
848
-		if ( ! defined( 'DONOTCACHEPAGE' ) ) {
849
-			define( 'DONOTCACHEPAGE', true );
848
+		if ( ! defined('DONOTCACHEPAGE')) {
849
+			define('DONOTCACHEPAGE', true);
850 850
 		}
851
-		if ( ! defined( 'DONOTCACHCEOBJECT' ) ) {
852
-			define( 'DONOTCACHCEOBJECT', true );
851
+		if ( ! defined('DONOTCACHCEOBJECT')) {
852
+			define('DONOTCACHCEOBJECT', true);
853 853
 		}
854
-		if ( ! defined( 'DONOTCACHEDB' ) ) {
855
-			define( 'DONOTCACHEDB', true );
854
+		if ( ! defined('DONOTCACHEDB')) {
855
+			define('DONOTCACHEDB', true);
856 856
 		}
857 857
 		// add no cache headers
858
-		add_action( 'send_headers' , array( 'EE_System', 'nocache_headers' ), 10 );
858
+		add_action('send_headers', array('EE_System', 'nocache_headers'), 10);
859 859
 		// plus a little extra for nginx
860
-		add_filter( 'nocache_headers', array( 'EE_System', 'nocache_headers_nginx' ), 10, 1 );
860
+		add_filter('nocache_headers', array('EE_System', 'nocache_headers_nginx'), 10, 1);
861 861
 		// prevent browsers from prefetching of the rel='next' link, because it may contain content that interferes with the registration process
862
-		remove_action( 'wp_head', 'adjacent_posts_rel_link_wp_head' );
862
+		remove_action('wp_head', 'adjacent_posts_rel_link_wp_head');
863 863
 	}
864 864
 
865 865
 
@@ -871,7 +871,7 @@  discard block
 block discarded – undo
871 871
 	 * @param $headers
872 872
 	 * @return    array
873 873
 	 */
874
-	public static function nocache_headers_nginx ( $headers ) {
874
+	public static function nocache_headers_nginx($headers) {
875 875
 		$headers['X-Accel-Expires'] = 0;
876 876
 		return $headers;
877 877
 	}
@@ -897,15 +897,15 @@  discard block
 block discarded – undo
897 897
 	 * @param $admin_bar
898 898
 	 * @return    void
899 899
 	 */
900
-	public function espresso_toolbar_items( $admin_bar ) {
900
+	public function espresso_toolbar_items($admin_bar) {
901 901
 
902 902
 		// if in full M-Mode, or its an AJAX request, or user is NOT an admin
903
-		if ( EE_Maintenance_Mode::instance()->level() == EE_Maintenance_Mode::level_2_complete_maintenance || defined( 'DOING_AJAX' ) || ! EE_Registry::instance()->CAP->current_user_can( 'ee_read_ee', 'ee_admin_bar_menu_top_level' )) {
903
+		if (EE_Maintenance_Mode::instance()->level() == EE_Maintenance_Mode::level_2_complete_maintenance || defined('DOING_AJAX') || ! EE_Registry::instance()->CAP->current_user_can('ee_read_ee', 'ee_admin_bar_menu_top_level')) {
904 904
 			return;
905 905
 		}
906 906
 
907
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
908
-		EE_Registry::instance()->load_helper( 'URL' );
907
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
908
+		EE_Registry::instance()->load_helper('URL');
909 909
 		$menu_class = 'espresso_menu_item_class';
910 910
 		//we don't use the constants EVENTS_ADMIN_URL or REG_ADMIN_URL
911 911
 		//because they're only defined in each of their respective constructors
@@ -917,20 +917,20 @@  discard block
 block discarded – undo
917 917
 		//Top Level
918 918
 		$admin_bar->add_menu(array(
919 919
 				'id' => 'espresso-toolbar',
920
-				'title' => '<span class="ee-icon ee-icon-ee-cup-thick ee-icon-size-20"></span><span class="ab-label">' . _x('Event Espresso', 'admin bar menu group label', 'event_espresso') . '</span>',
920
+				'title' => '<span class="ee-icon ee-icon-ee-cup-thick ee-icon-size-20"></span><span class="ab-label">'._x('Event Espresso', 'admin bar menu group label', 'event_espresso').'</span>',
921 921
 				'href' => $events_admin_url,
922 922
 				'meta' => array(
923 923
 						'title' => __('Event Espresso', 'event_espresso'),
924
-						'class' => $menu_class . 'first'
924
+						'class' => $menu_class.'first'
925 925
 				),
926 926
 		));
927 927
 
928 928
 		//Events
929
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events' ) ) {
929
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events')) {
930 930
 			$admin_bar->add_menu(array(
931 931
 					'id' => 'espresso-toolbar-events',
932 932
 					'parent' => 'espresso-toolbar',
933
-					'title' => __( 'Events', 'event_espresso' ),
933
+					'title' => __('Events', 'event_espresso'),
934 934
 					'href' => $events_admin_url,
935 935
 					'meta' => array(
936 936
 							'title' => __('Events', 'event_espresso'),
@@ -941,13 +941,13 @@  discard block
 block discarded – undo
941 941
 		}
942 942
 
943 943
 
944
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_edit_events', 'ee_admin_bar_menu_espresso-toolbar-events-new' ) ) {
944
+		if (EE_Registry::instance()->CAP->current_user_can('ee_edit_events', 'ee_admin_bar_menu_espresso-toolbar-events-new')) {
945 945
 			//Events Add New
946 946
 			$admin_bar->add_menu(array(
947 947
 					'id' => 'espresso-toolbar-events-new',
948 948
 					'parent' => 'espresso-toolbar-events',
949 949
 					'title' => __('Add New', 'event_espresso'),
950
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'create_new' ), $events_admin_url ),
950
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'create_new'), $events_admin_url),
951 951
 					'meta' => array(
952 952
 							'title' => __('Add New', 'event_espresso'),
953 953
 							'target' => '',
@@ -956,18 +956,18 @@  discard block
 block discarded – undo
956 956
 			));
957 957
 		}
958 958
 
959
-		if ( is_single() && ( get_post_type() == 'espresso_events' ) ) {
959
+		if (is_single() && (get_post_type() == 'espresso_events')) {
960 960
 
961 961
 			//Current post
962 962
 			global $post;		
963 963
     	
964
-	    	if ( EE_Registry::instance()->CAP->current_user_can( 'ee_edit_event', 'ee_admin_bar_menu_espresso-toolbar-events-edit', $post->ID ) ) {
964
+	    	if (EE_Registry::instance()->CAP->current_user_can('ee_edit_event', 'ee_admin_bar_menu_espresso-toolbar-events-edit', $post->ID)) {
965 965
 				//Events Edit Current Event
966 966
 				$admin_bar->add_menu(array(
967 967
 						'id' => 'espresso-toolbar-events-edit',
968 968
 						'parent' => 'espresso-toolbar-events',
969 969
 						'title' => __('Edit Event', 'event_espresso'),
970
-						'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'edit', 'post'=>$post->ID ), $events_admin_url ),
970
+						'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'edit', 'post'=>$post->ID), $events_admin_url),
971 971
 						'meta' => array(
972 972
 								'title' => __('Edit Event', 'event_espresso'),
973 973
 								'target' => '',
@@ -979,11 +979,11 @@  discard block
 block discarded – undo
979 979
 		}
980 980
 
981 981
 		//Events View
982
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-view' ) ) {
982
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-view')) {
983 983
 			$admin_bar->add_menu(array(
984 984
 					'id' => 'espresso-toolbar-events-view',
985 985
 					'parent' => 'espresso-toolbar-events',
986
-					'title' => __( 'View', 'event_espresso' ),
986
+					'title' => __('View', 'event_espresso'),
987 987
 					'href' => $events_admin_url,
988 988
 					'meta' => array(
989 989
 							'title' => __('View', 'event_espresso'),
@@ -993,12 +993,12 @@  discard block
 block discarded – undo
993 993
 			));
994 994
 		}
995 995
 
996
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-all' ) ) {
996
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-all')) {
997 997
 			//Events View All
998 998
 			$admin_bar->add_menu(array(
999 999
 					'id' => 'espresso-toolbar-events-all',
1000 1000
 					'parent' => 'espresso-toolbar-events-view',
1001
-					'title' => __( 'All', 'event_espresso' ),
1001
+					'title' => __('All', 'event_espresso'),
1002 1002
 					'href' => $events_admin_url,
1003 1003
 					'meta' => array(
1004 1004
 							'title' => __('All', 'event_espresso'),
@@ -1009,13 +1009,13 @@  discard block
 block discarded – undo
1009 1009
 		}
1010 1010
 
1011 1011
 
1012
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-today' ) ) {
1012
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-today')) {
1013 1013
 			//Events View Today
1014 1014
 			$admin_bar->add_menu(array(
1015 1015
 					'id' => 'espresso-toolbar-events-today',
1016 1016
 					'parent' => 'espresso-toolbar-events-view',
1017 1017
 					'title' => __('Today', 'event_espresso'),
1018
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'today' ), $events_admin_url ),
1018
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'today'), $events_admin_url),
1019 1019
 					'meta' => array(
1020 1020
 							'title' => __('Today', 'event_espresso'),
1021 1021
 							'target' => '',
@@ -1025,13 +1025,13 @@  discard block
 block discarded – undo
1025 1025
 		}
1026 1026
 
1027 1027
 
1028
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-month' ) ) {
1028
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_events', 'ee_admin_bar_menu_espresso-toolbar-events-month')) {
1029 1029
 			//Events View This Month
1030 1030
 			$admin_bar->add_menu(array(
1031 1031
 					'id' => 'espresso-toolbar-events-month',
1032 1032
 					'parent' => 'espresso-toolbar-events-view',
1033
-					'title' => __( 'This Month', 'event_espresso'),
1034
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'month' ), $events_admin_url ),
1033
+					'title' => __('This Month', 'event_espresso'),
1034
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'month'), $events_admin_url),
1035 1035
 					'meta' => array(
1036 1036
 							'title' => __('This Month', 'event_espresso'),
1037 1037
 							'target' => '',
@@ -1041,11 +1041,11 @@  discard block
 block discarded – undo
1041 1041
 		}
1042 1042
 
1043 1043
 		//Registration Overview
1044
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations' ) ) {
1044
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations')) {
1045 1045
 			$admin_bar->add_menu(array(
1046 1046
 					'id' => 'espresso-toolbar-registrations',
1047 1047
 					'parent' => 'espresso-toolbar',
1048
-					'title' => __( 'Registrations', 'event_espresso' ),
1048
+					'title' => __('Registrations', 'event_espresso'),
1049 1049
 					'href' => $reg_admin_url,
1050 1050
 					'meta' => array(
1051 1051
 							'title' => __('Registrations', 'event_espresso'),
@@ -1056,12 +1056,12 @@  discard block
 block discarded – undo
1056 1056
 		}
1057 1057
 
1058 1058
 		//Registration Overview Today
1059
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today' ) ) {
1059
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today')) {
1060 1060
 			$admin_bar->add_menu(array(
1061 1061
 					'id' => 'espresso-toolbar-registrations-today',
1062 1062
 					'parent' => 'espresso-toolbar-registrations',
1063
-					'title' => __( 'Today', 'event_espresso'),
1064
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'today' ), $reg_admin_url ),
1063
+					'title' => __('Today', 'event_espresso'),
1064
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'today'), $reg_admin_url),
1065 1065
 					'meta' => array(
1066 1066
 							'title' => __('Today', 'event_espresso'),
1067 1067
 							'target' => '',
@@ -1071,14 +1071,14 @@  discard block
 block discarded – undo
1071 1071
 		}
1072 1072
 
1073 1073
 		//Registration Overview Today Completed
1074
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-approved' ) ) {
1074
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-approved')) {
1075 1075
 			$admin_bar->add_menu(array(
1076 1076
 					'id' => 'espresso-toolbar-registrations-today-approved',
1077 1077
 					'parent' => 'espresso-toolbar-registrations-today',
1078
-					'title' => __( 'Approved', 'event_espresso' ),
1079
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'today', '_reg_status'=>EEM_Registration::status_id_approved ), $reg_admin_url ),
1078
+					'title' => __('Approved', 'event_espresso'),
1079
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'today', '_reg_status'=>EEM_Registration::status_id_approved), $reg_admin_url),
1080 1080
 					'meta' => array(
1081
-							'title' => __('Approved', 'event_espresso' ),
1081
+							'title' => __('Approved', 'event_espresso'),
1082 1082
 							'target' => '',
1083 1083
 							'class' => $menu_class
1084 1084
 					),
@@ -1086,14 +1086,14 @@  discard block
 block discarded – undo
1086 1086
 		}
1087 1087
 
1088 1088
 		//Registration Overview Today Pending\
1089
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-pending' ) ) {
1089
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-pending')) {
1090 1090
 			$admin_bar->add_menu(array(
1091 1091
 					'id' => 'espresso-toolbar-registrations-today-pending',
1092 1092
 					'parent' => 'espresso-toolbar-registrations-today',
1093
-					'title' => __( 'Pending', 'event_espresso' ),
1094
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'today', 'reg_status'=>EEM_Registration::status_id_pending_payment ), $reg_admin_url ),
1093
+					'title' => __('Pending', 'event_espresso'),
1094
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'today', 'reg_status'=>EEM_Registration::status_id_pending_payment), $reg_admin_url),
1095 1095
 					'meta' => array(
1096
-							'title' => __('Pending Payment', 'event_espresso' ),
1096
+							'title' => __('Pending Payment', 'event_espresso'),
1097 1097
 							'target' => '',
1098 1098
 							'class' => $menu_class
1099 1099
 					),
@@ -1101,14 +1101,14 @@  discard block
 block discarded – undo
1101 1101
 		}
1102 1102
 
1103 1103
 		//Registration Overview Today Incomplete
1104
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-not-approved' ) ) {
1104
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-not-approved')) {
1105 1105
 			$admin_bar->add_menu(array(
1106 1106
 					'id' => 'espresso-toolbar-registrations-today-not-approved',
1107 1107
 					'parent' => 'espresso-toolbar-registrations-today',
1108
-					'title' => __( 'Not Approved', 'event_espresso' ),
1109
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'today', '_reg_status'=>EEM_Registration::status_id_not_approved ), $reg_admin_url ),
1108
+					'title' => __('Not Approved', 'event_espresso'),
1109
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'today', '_reg_status'=>EEM_Registration::status_id_not_approved), $reg_admin_url),
1110 1110
 					'meta' => array(
1111
-							'title' => __('Not Approved', 'event_espresso' ),
1111
+							'title' => __('Not Approved', 'event_espresso'),
1112 1112
 							'target' => '',
1113 1113
 							'class' => $menu_class
1114 1114
 					),
@@ -1116,12 +1116,12 @@  discard block
 block discarded – undo
1116 1116
 		}
1117 1117
 
1118 1118
 		//Registration Overview Today Incomplete
1119
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-cancelled' ) ) {
1119
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-today-cancelled')) {
1120 1120
 			$admin_bar->add_menu(array(
1121 1121
 					'id' => 'espresso-toolbar-registrations-today-cancelled',
1122 1122
 					'parent' => 'espresso-toolbar-registrations-today',
1123
-					'title' => __( 'Cancelled', 'event_espresso'),
1124
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'today', '_reg_status'=>EEM_Registration::status_id_cancelled ), $reg_admin_url ),
1123
+					'title' => __('Cancelled', 'event_espresso'),
1124
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'today', '_reg_status'=>EEM_Registration::status_id_cancelled), $reg_admin_url),
1125 1125
 					'meta' => array(
1126 1126
 							'title' => __('Cancelled', 'event_espresso'),
1127 1127
 							'target' => '',
@@ -1131,12 +1131,12 @@  discard block
 block discarded – undo
1131 1131
 		}
1132 1132
 
1133 1133
 		//Registration Overview This Month
1134
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month' ) ) {
1134
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month')) {
1135 1135
 			$admin_bar->add_menu(array(
1136 1136
 					'id' => 'espresso-toolbar-registrations-month',
1137 1137
 					'parent' => 'espresso-toolbar-registrations',
1138
-					'title' => __( 'This Month', 'event_espresso' ),
1139
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'month' ), $reg_admin_url ),
1138
+					'title' => __('This Month', 'event_espresso'),
1139
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'month'), $reg_admin_url),
1140 1140
 					'meta' => array(
1141 1141
 							'title' => __('This Month', 'event_espresso'),
1142 1142
 							'target' => '',
@@ -1146,12 +1146,12 @@  discard block
 block discarded – undo
1146 1146
 		}
1147 1147
 
1148 1148
 		//Registration Overview This Month Approved
1149
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-approved' ) ) {
1149
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-approved')) {
1150 1150
 			$admin_bar->add_menu(array(
1151 1151
 					'id' => 'espresso-toolbar-registrations-month-approved',
1152 1152
 					'parent' => 'espresso-toolbar-registrations-month',
1153
-					'title' => __( 'Approved', 'event_espresso' ),
1154
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_approved ), $reg_admin_url ),
1153
+					'title' => __('Approved', 'event_espresso'),
1154
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_approved), $reg_admin_url),
1155 1155
 					'meta' => array(
1156 1156
 							'title' => __('Approved', 'event_espresso'),
1157 1157
 							'target' => '',
@@ -1161,12 +1161,12 @@  discard block
 block discarded – undo
1161 1161
 		}
1162 1162
 
1163 1163
 		//Registration Overview This Month Pending
1164
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-pending' ) ) {
1164
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-pending')) {
1165 1165
 			$admin_bar->add_menu(array(
1166 1166
 					'id' => 'espresso-toolbar-registrations-month-pending',
1167 1167
 					'parent' => 'espresso-toolbar-registrations-month',
1168
-					'title' => __( 'Pending', 'event_espresso'),
1169
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_pending_payment ), $reg_admin_url ),
1168
+					'title' => __('Pending', 'event_espresso'),
1169
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_pending_payment), $reg_admin_url),
1170 1170
 					'meta' => array(
1171 1171
 							'title' => __('Pending', 'event_espresso'),
1172 1172
 							'target' => '',
@@ -1176,14 +1176,14 @@  discard block
 block discarded – undo
1176 1176
 		}
1177 1177
 
1178 1178
 		//Registration Overview This Month Not Approved
1179
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-not-approved' ) ) {
1179
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-not-approved')) {
1180 1180
 			$admin_bar->add_menu(array(
1181 1181
 					'id' => 'espresso-toolbar-registrations-month-not-approved',
1182 1182
 					'parent' => 'espresso-toolbar-registrations-month',
1183
-					'title' => __( 'Not Approved', 'event_espresso'),
1184
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_not_approved ), $reg_admin_url ),
1183
+					'title' => __('Not Approved', 'event_espresso'),
1184
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_not_approved), $reg_admin_url),
1185 1185
 					'meta' => array(
1186
-							'title' => __('Not Approved', 'event_espresso' ),
1186
+							'title' => __('Not Approved', 'event_espresso'),
1187 1187
 							'target' => '',
1188 1188
 							'class' => $menu_class
1189 1189
 					),
@@ -1192,12 +1192,12 @@  discard block
 block discarded – undo
1192 1192
 
1193 1193
 
1194 1194
 		//Registration Overview This Month Cancelled
1195
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-cancelled' ) ) {
1195
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_registrations', 'ee_admin_bar_menu_espresso-toolbar-registrations-month-cancelled')) {
1196 1196
 			$admin_bar->add_menu(array(
1197 1197
 					'id' => 'espresso-toolbar-registrations-month-cancelled',
1198 1198
 					'parent' => 'espresso-toolbar-registrations-month',
1199 1199
 					'title' => __('Cancelled', 'event_espresso'),
1200
-					'href' => EEH_URL::add_query_args_and_nonce( array( 'action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_cancelled ), $reg_admin_url ),
1200
+					'href' => EEH_URL::add_query_args_and_nonce(array('action'=>'default', 'status'=>'month', '_reg_status'=>EEM_Registration::status_id_cancelled), $reg_admin_url),
1201 1201
 					'meta' => array(
1202 1202
 							'title' => __('Cancelled', 'event_espresso'),
1203 1203
 							'target' => '',
@@ -1207,11 +1207,11 @@  discard block
 block discarded – undo
1207 1207
 		}
1208 1208
 
1209 1209
 		//Extensions & Services
1210
-		if ( EE_Registry::instance()->CAP->current_user_can( 'ee_read_ee', 'ee_admin_bar_menu_espresso-toolbar-extensions-and-services' ) ) {
1210
+		if (EE_Registry::instance()->CAP->current_user_can('ee_read_ee', 'ee_admin_bar_menu_espresso-toolbar-extensions-and-services')) {
1211 1211
 			$admin_bar->add_menu(array(
1212 1212
 					'id' => 'espresso-toolbar-extensions-and-services',
1213 1213
 					'parent' => 'espresso-toolbar',
1214
-					'title' => __( 'Extensions & Services', 'event_espresso' ),
1214
+					'title' => __('Extensions & Services', 'event_espresso'),
1215 1215
 					'href' => $extensions_admin_url,
1216 1216
 					'meta' => array(
1217 1217
 							'title' => __('Extensions & Services', 'event_espresso'),
@@ -1233,8 +1233,8 @@  discard block
 block discarded – undo
1233 1233
 	 * @param  array  $exclude_array any existing pages being excluded are in this array.
1234 1234
 	 * @return array
1235 1235
 	 */
1236
-	public function remove_pages_from_wp_list_pages( $exclude_array ) {
1237
-		return  array_merge( $exclude_array, EE_Registry::instance()->CFG->core->get_critical_pages_array() );
1236
+	public function remove_pages_from_wp_list_pages($exclude_array) {
1237
+		return  array_merge($exclude_array, EE_Registry::instance()->CFG->core->get_critical_pages_array());
1238 1238
 	}
1239 1239
 
1240 1240
 
@@ -1254,11 +1254,11 @@  discard block
 block discarded – undo
1254 1254
 	 */
1255 1255
 	public function wp_enqueue_scripts() {
1256 1256
 		// unlike other systems, EE_System_scripts loading is turned ON by default, but prior to the init hook, can be turned off via: add_filter( 'FHEE_load_EE_System_scripts', '__return_false' );
1257
-		if ( apply_filters( 'FHEE_load_EE_System_scripts', TRUE ) ) {
1257
+		if (apply_filters('FHEE_load_EE_System_scripts', TRUE)) {
1258 1258
 			// jquery_validate loading is turned OFF by default, but prior to the wp_enqueue_scripts hook, can be turned back on again via:  add_filter( 'FHEE_load_jquery_validate', '__return_true' );
1259
-			if ( apply_filters( 'FHEE_load_jquery_validate', FALSE ) ) {
1259
+			if (apply_filters('FHEE_load_jquery_validate', FALSE)) {
1260 1260
 				// register jQuery Validate
1261
-				wp_register_script( 'jquery-validate', EE_GLOBAL_ASSETS_URL . 'scripts/jquery.validate.min.js', array('jquery'), '1.11.1', TRUE );
1261
+				wp_register_script('jquery-validate', EE_GLOBAL_ASSETS_URL.'scripts/jquery.validate.min.js', array('jquery'), '1.11.1', TRUE);
1262 1262
 			}
1263 1263
 		}
1264 1264
 	}
Please login to merge, or discard this patch.
core/EE_Payment_Processor.core.php 1 patch
Spacing   +136 added lines, -136 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php if ( ! defined('EVENT_ESPRESSO_VERSION')) { exit('No direct script access allowed'); }
2
-EE_Registry::instance()->load_class( 'Processor_Base' );
2
+EE_Registry::instance()->load_class('Processor_Base');
3 3
 /**
4 4
  *
5 5
  * EE_Payment_Processor
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	 */
28 28
 	public static function instance() {
29 29
 		// check if class object is instantiated
30
-		if ( ! self::$_instance instanceof EE_Payment_Processor ) {
30
+		if ( ! self::$_instance instanceof EE_Payment_Processor) {
31 31
 			self::$_instance = new self();
32 32
 		}
33 33
 		return self::$_instance;
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 	 *@return EE_Payment_Processor
43 43
 	 */
44 44
 	private function __construct() {
45
-		do_action( 'AHEE__EE_Payment_Processor__construct' );
45
+		do_action('AHEE__EE_Payment_Processor__construct');
46 46
 	}
47 47
 
48 48
 
@@ -64,42 +64,42 @@  discard block
 block discarded – undo
64 64
 	 * @param string 	       						$cancel_url 	URL to return to if off-site payments are cancelled
65 65
 	 * @return EE_Payment
66 66
 	 */
67
-	public function process_payment( EE_Payment_Method $payment_method, EE_Transaction $transaction, $amount = NULL, $billing_form = NULL, $return_url = NULL, $method = 'CART', $by_admin = FALSE, $update_txn = TRUE, $cancel_url = '' ) {
68
-		if( $amount < 0 ) {
67
+	public function process_payment(EE_Payment_Method $payment_method, EE_Transaction $transaction, $amount = NULL, $billing_form = NULL, $return_url = NULL, $method = 'CART', $by_admin = FALSE, $update_txn = TRUE, $cancel_url = '') {
68
+		if ($amount < 0) {
69 69
 			throw new EE_Error( 
70 70
 					sprintf(
71
-							__( 'Attempting to make a payment for a negative amount of %1$d for transaction %2$d. That should be a refund', 'event_espresso' ),
71
+							__('Attempting to make a payment for a negative amount of %1$d for transaction %2$d. That should be a refund', 'event_espresso'),
72 72
 							$amount,
73 73
 							$transaction->ID() ) );
74 74
 		}
75 75
 		// verify payment method
76
-		$payment_method = EEM_Payment_Method::instance()->ensure_is_obj( $payment_method, TRUE );
76
+		$payment_method = EEM_Payment_Method::instance()->ensure_is_obj($payment_method, TRUE);
77 77
 		// verify transaction
78
-		EEM_Transaction::instance()->ensure_is_obj( $transaction );
79
-		$transaction->set_payment_method_ID( $payment_method->ID() );
78
+		EEM_Transaction::instance()->ensure_is_obj($transaction);
79
+		$transaction->set_payment_method_ID($payment_method->ID());
80 80
 		// verify payment method type
81
-		if ( $payment_method->type_obj() instanceof EE_PMT_Base ){
81
+		if ($payment_method->type_obj() instanceof EE_PMT_Base) {
82 82
 			$payment = $payment_method->type_obj()->process_payment(
83 83
 				$transaction,
84
-				min( $amount, $transaction->remaining() ),//make sure we don't overcharge
84
+				min($amount, $transaction->remaining()), //make sure we don't overcharge
85 85
 				$billing_form,
86 86
 				$return_url,
87
-				add_query_arg( array( 'ee_cancel_payment' => true ), $return_url ),
87
+				add_query_arg(array('ee_cancel_payment' => true), $return_url),
88 88
 				$method,
89 89
 				$by_admin
90 90
 			);
91 91
 			// check if payment method uses an off-site gateway
92
-			if ( $payment_method->type_obj()->payment_occurs() != EE_PMT_Base::offsite ) {
92
+			if ($payment_method->type_obj()->payment_occurs() != EE_PMT_Base::offsite) {
93 93
 				// don't process payments for off-site gateways yet because no payment has occurred yet
94
-				$this->update_txn_based_on_payment( $transaction, $payment, $update_txn );
94
+				$this->update_txn_based_on_payment($transaction, $payment, $update_txn);
95 95
 			}
96 96
 			return $payment;
97 97
 		} else {
98 98
 			EE_Error::add_error(
99 99
 				sprintf(
100
-					__( 'A valid payment method could not be determined due to a technical issue.%sPlease try again or contact %s for assistance.', 'event_espresso' ),
100
+					__('A valid payment method could not be determined due to a technical issue.%sPlease try again or contact %s for assistance.', 'event_espresso'),
101 101
 					'<br/>',
102
-					EE_Registry::instance()->CFG->organization->get_pretty( 'email' )
102
+					EE_Registry::instance()->CFG->organization->get_pretty('email')
103 103
 				), __FILE__, __FUNCTION__, __LINE__
104 104
 			);
105 105
 			return NULL;
@@ -115,14 +115,14 @@  discard block
 block discarded – undo
115 115
 	 * @throws EE_Error
116 116
 	 * @return string
117 117
 	 */
118
-	public function get_ipn_url_for_payment_method( $transaction, $payment_method ){
118
+	public function get_ipn_url_for_payment_method($transaction, $payment_method) {
119 119
 		/** @type EE_Transaction $transaction */
120
-		$transaction = EEM_Transaction::instance()->ensure_is_obj( $transaction );
120
+		$transaction = EEM_Transaction::instance()->ensure_is_obj($transaction);
121 121
 		$primary_reg = $transaction->primary_registration();
122
-		if( ! $primary_reg instanceof EE_Registration ){
123
-			throw new EE_Error(sprintf(__("Cannot get IPN URL for transaction with ID %d because it has no primary registration", "event_espresso"),$transaction->ID()));
122
+		if ( ! $primary_reg instanceof EE_Registration) {
123
+			throw new EE_Error(sprintf(__("Cannot get IPN URL for transaction with ID %d because it has no primary registration", "event_espresso"), $transaction->ID()));
124 124
 		}
125
-		$payment_method = EEM_Payment_Method::instance()->ensure_is_obj($payment_method,true);
125
+		$payment_method = EEM_Payment_Method::instance()->ensure_is_obj($payment_method, true);
126 126
 		$url = add_query_arg(
127 127
 			array(
128 128
 				'e_reg_url_link'=>$primary_reg->reg_url_link(),
@@ -149,81 +149,81 @@  discard block
 block discarded – undo
149 149
 	 * @throws Exception
150 150
 	 * @return EE_Payment
151 151
 	 */
152
-	public function process_ipn( $_req_data, $transaction = NULL, $payment_method = NULL, $update_txn = true, $separate_IPN_request = true ){
153
-		$_req_data = $this->_remove_unusable_characters( $_req_data );
154
-		EE_Registry::instance()->load_model( 'Change_Log' );
155
-		EE_Processor_Base::set_IPN( $separate_IPN_request );
156
-		if( $transaction instanceof EE_Transaction && $payment_method instanceof EE_Payment_Method ){
157
-			$obj_for_log = EEM_Payment::instance()->get_one( array( array( 'TXN_ID' => $transaction->ID(), 'PMD_ID' => $payment_method->ID() ), 'order_by' => array( 'PAY_timestamp' => 'desc' ) ) );
158
-		}elseif( $payment_method instanceof EE_Payment ){
152
+	public function process_ipn($_req_data, $transaction = NULL, $payment_method = NULL, $update_txn = true, $separate_IPN_request = true) {
153
+		$_req_data = $this->_remove_unusable_characters($_req_data);
154
+		EE_Registry::instance()->load_model('Change_Log');
155
+		EE_Processor_Base::set_IPN($separate_IPN_request);
156
+		if ($transaction instanceof EE_Transaction && $payment_method instanceof EE_Payment_Method) {
157
+			$obj_for_log = EEM_Payment::instance()->get_one(array(array('TXN_ID' => $transaction->ID(), 'PMD_ID' => $payment_method->ID()), 'order_by' => array('PAY_timestamp' => 'desc')));
158
+		}elseif ($payment_method instanceof EE_Payment) {
159 159
 			$obj_for_log = $payment_method;
160
-		}elseif( $transaction instanceof EE_Transaction ){
160
+		}elseif ($transaction instanceof EE_Transaction) {
161 161
 			$obj_for_log = $transaction;
162
-		}else{
162
+		} else {
163 163
 			$obj_for_log = null;
164 164
 		}
165 165
 		$log = EEM_Change_Log::instance()->log(EEM_Change_Log::type_gateway, array('IPN data received'=>$_req_data), $obj_for_log);
166
-		try{
166
+		try {
167 167
 			/**
168 168
 			 * @var EE_Payment $payment
169 169
 			 */
170 170
 			$payment = NULL;
171
-			if($transaction && $payment_method){
171
+			if ($transaction && $payment_method) {
172 172
 				/** @type EE_Transaction $transaction */
173 173
 				$transaction = EEM_Transaction::instance()->ensure_is_obj($transaction);
174 174
 				/** @type EE_Payment_Method $payment_method */
175 175
 				$payment_method = EEM_Payment_Method::instance()->ensure_is_obj($payment_method);
176
-				if ( $payment_method->type_obj() instanceof EE_PMT_Base ) {
177
-						$payment = $payment_method->type_obj()->handle_ipn( $_req_data, $transaction );
176
+				if ($payment_method->type_obj() instanceof EE_PMT_Base) {
177
+						$payment = $payment_method->type_obj()->handle_ipn($_req_data, $transaction);
178 178
 						$log->set_object($payment);
179 179
 				} else {
180 180
 					// not a payment
181 181
 					EE_Error::add_error(
182 182
 						sprintf(
183
-							__( 'A valid payment method could not be determined due to a technical issue.%sPlease refresh your browser and try again or contact %s for assistance.', 'event_espresso' ),
183
+							__('A valid payment method could not be determined due to a technical issue.%sPlease refresh your browser and try again or contact %s for assistance.', 'event_espresso'),
184 184
 							'<br/>',
185
-							EE_Registry::instance()->CFG->organization->get_pretty( 'email' )
185
+							EE_Registry::instance()->CFG->organization->get_pretty('email')
186 186
 						),
187 187
 						__FILE__, __FUNCTION__, __LINE__
188 188
 					);
189 189
 				}
190
-			}else{
190
+			} else {
191 191
 				//that's actually pretty ok. The IPN just wasn't able
192 192
 				//to identify which transaction or payment method this was for
193 193
 				// give all active payment methods a chance to claim it
194 194
 				$active_pms = EEM_Payment_Method::instance()->get_all_active();
195
-				foreach( $active_pms as $payment_method ){
196
-					try{
197
-						$payment = $payment_method->type_obj()->handle_unclaimed_ipn( $_req_data );
195
+				foreach ($active_pms as $payment_method) {
196
+					try {
197
+						$payment = $payment_method->type_obj()->handle_unclaimed_ipn($_req_data);
198 198
 						EEM_Change_Log::instance()->log(EEM_Change_Log::type_gateway, array('IPN data'=>$_req_data), $payment);
199 199
 						break;
200
-					} catch( EE_Error $e ) {
200
+					} catch (EE_Error $e) {
201 201
 						//that's fine- it apparently couldn't handle the IPN
202 202
 					}
203 203
 				}
204 204
 
205 205
 			}
206 206
 // 			EEM_Payment_Log::instance()->log("got to 7",$transaction,$payment_method);
207
-			if( $payment instanceof EE_Payment){
207
+			if ($payment instanceof EE_Payment) {
208 208
 				$payment->save();
209 209
 				//  update the TXN
210
-				$this->update_txn_based_on_payment( $transaction, $payment, $update_txn, $separate_IPN_request );
211
-			}else{
210
+				$this->update_txn_based_on_payment($transaction, $payment, $update_txn, $separate_IPN_request);
211
+			} else {
212 212
 				//we couldn't find the payment for this IPN... let's try and log at least SOMETHING
213
-				if($payment_method){
213
+				if ($payment_method) {
214 214
 					EEM_Change_Log::instance()->log(EEM_Change_Log::type_gateway, array('IPN data'=>$_req_data), $payment_method);
215
-				}elseif($transaction){
215
+				}elseif ($transaction) {
216 216
 					EEM_Change_Log::instance()->log(EEM_Change_Log::type_gateway, array('IPN data'=>$_req_data), $transaction);
217 217
 				}
218 218
 			}
219 219
 			return $payment;
220 220
 
221
-		} catch( EE_Error $e ) {
221
+		} catch (EE_Error $e) {
222 222
 			do_action(
223 223
 				'AHEE__log', __FILE__, __FUNCTION__, sprintf(
224
-					__( 'Error occurred while receiving IPN. Transaction: %1$s, req data: %2$s. The error was "%3$s"', 'event_espresso' ),
225
-					print_r( $transaction, TRUE ),
226
-					print_r( $_req_data, TRUE ),
224
+					__('Error occurred while receiving IPN. Transaction: %1$s, req data: %2$s. The error was "%3$s"', 'event_espresso'),
225
+					print_r($transaction, TRUE),
226
+					print_r($_req_data, TRUE),
227 227
 					$e->getMessage()
228 228
 				)
229 229
 			);
@@ -237,14 +237,14 @@  discard block
 block discarded – undo
237 237
 	 * @param array $request_data
238 238
 	 * @return array|string
239 239
 	 */
240
-	protected function _remove_unusable_characters( $request_data ) {
241
-		if( is_array( $request_data ) ) {
240
+	protected function _remove_unusable_characters($request_data) {
241
+		if (is_array($request_data)) {
242 242
 			$return_data = array();
243
-			foreach( $request_data as $key => $value ) {
244
-				$return_data[ $this->_remove_unusable_characters( $key ) ] = $this->_remove_unusable_characters( $value );
243
+			foreach ($request_data as $key => $value) {
244
+				$return_data[$this->_remove_unusable_characters($key)] = $this->_remove_unusable_characters($value);
245 245
 			}
246
-		}else{
247
-			$return_data =  preg_replace('/[^[:print:]]/', '', $request_data);
246
+		} else {
247
+			$return_data = preg_replace('/[^[:print:]]/', '', $request_data);
248 248
 		}
249 249
 		return $return_data;
250 250
 	}
@@ -266,13 +266,13 @@  discard block
 block discarded – undo
266 266
 	 * @return EE_Payment
267 267
 	 * @deprecated 4.6.24 method is no longer used. Instead it is up to client code, like SPCO, to call handle_ipn() for offsite gateways that don't receive separate IPNs
268 268
 	 */
269
-	public function finalize_payment_for( $transaction, $update_txn = TRUE ){
269
+	public function finalize_payment_for($transaction, $update_txn = TRUE) {
270 270
 		/** @var $transaction EE_Transaction */
271
-		$transaction = EEM_Transaction::instance()->ensure_is_obj( $transaction );
271
+		$transaction = EEM_Transaction::instance()->ensure_is_obj($transaction);
272 272
 		$last_payment_method = $transaction->payment_method();
273
-		if ( $last_payment_method instanceof EE_Payment_Method ) {
274
-			$payment = $last_payment_method->type_obj()->finalize_payment_for( $transaction );
275
-			$this->update_txn_based_on_payment( $transaction, $payment, $update_txn );
273
+		if ($last_payment_method instanceof EE_Payment_Method) {
274
+			$payment = $last_payment_method->type_obj()->finalize_payment_for($transaction);
275
+			$this->update_txn_based_on_payment($transaction, $payment, $update_txn);
276 276
 			return $payment;
277 277
 		} else {
278 278
 			return NULL;
@@ -289,10 +289,10 @@  discard block
 block discarded – undo
289 289
 	 * @internal param float $amount
290 290
 	 * @return EE_Payment
291 291
 	 */
292
-	public function process_refund( EE_Payment_Method $payment_method, EE_Payment $payment_to_refund, $refund_info = array() ){
293
-		if ( $payment_method instanceof EE_Payment_Method && $payment_method->type_obj()->supports_sending_refunds() ) {
294
-			$payment_method->type_obj()->process_refund( $payment_to_refund, $refund_info );
295
-			$this->update_txn_based_on_payment( $payment_to_refund->transaction(), $payment_to_refund );
292
+	public function process_refund(EE_Payment_Method $payment_method, EE_Payment $payment_to_refund, $refund_info = array()) {
293
+		if ($payment_method instanceof EE_Payment_Method && $payment_method->type_obj()->supports_sending_refunds()) {
294
+			$payment_method->type_obj()->process_refund($payment_to_refund, $refund_info);
295
+			$this->update_txn_based_on_payment($payment_to_refund->transaction(), $payment_to_refund);
296 296
 		}
297 297
 		return $payment_to_refund;
298 298
 	}
@@ -334,12 +334,12 @@  discard block
 block discarded – undo
334 334
 	 *                        TXN is locked before updating
335 335
 	 * @throws \EE_Error
336 336
 	 */
337
-	public function update_txn_based_on_payment( $transaction, $payment, $update_txn = true, $IPN = false ){
337
+	public function update_txn_based_on_payment($transaction, $payment, $update_txn = true, $IPN = false) {
338 338
 		$do_action = 'AHEE__EE_Payment_Processor__update_txn_based_on_payment__not_successful';
339 339
 		/** @type EE_Transaction $transaction */
340
-		$transaction = EEM_Transaction::instance()->ensure_is_obj( $transaction );
340
+		$transaction = EEM_Transaction::instance()->ensure_is_obj($transaction);
341 341
 		// can we freely update the TXN at this moment?
342
-		if ( $IPN && $transaction->is_locked() ) {
342
+		if ($IPN && $transaction->is_locked()) {
343 343
 			// don't update the transaction at this exact moment
344 344
 			// because the TXN is active in another request
345 345
 			EE_Cron_Tasks::schedule_update_transaction_with_payment(
@@ -349,40 +349,40 @@  discard block
 block discarded – undo
349 349
 			);
350 350
 		} else {
351 351
 			// verify payment and that it has been saved
352
-			if ( $payment instanceof EE_Payment && $payment->ID() ) {
353
-				if( $payment->payment_method() instanceof EE_Payment_Method && $payment->payment_method()->type_obj() instanceof EE_PMT_Base ){
354
-					$payment->payment_method()->type_obj()->update_txn_based_on_payment( $payment );
352
+			if ($payment instanceof EE_Payment && $payment->ID()) {
353
+				if ($payment->payment_method() instanceof EE_Payment_Method && $payment->payment_method()->type_obj() instanceof EE_PMT_Base) {
354
+					$payment->payment_method()->type_obj()->update_txn_based_on_payment($payment);
355 355
 					// update TXN registrations with payment info
356
-					$this->process_registration_payments( $transaction, $payment );
356
+					$this->process_registration_payments($transaction, $payment);
357 357
 				}
358 358
 				$do_action = $payment->just_approved() ? 'AHEE__EE_Payment_Processor__update_txn_based_on_payment__successful' : $do_action;
359 359
 			} else {
360 360
 				// send out notifications
361
-				add_filter( 'FHEE__EED_Messages___maybe_registration__deliver_notifications', '__return_true' );
361
+				add_filter('FHEE__EED_Messages___maybe_registration__deliver_notifications', '__return_true');
362 362
 				$do_action = 'AHEE__EE_Payment_Processor__update_txn_based_on_payment__no_payment_made';
363 363
 			}
364 364
 			// if this is an IPN, then we want to know the initial TXN status prior to updating the TXN
365 365
 			// so that we know whether the status has changed and notifications should be triggered
366
-			if ( $IPN ) {
366
+			if ($IPN) {
367 367
 				/** @type EE_Transaction_Processor $transaction_processor */
368
-				$transaction_processor = EE_Registry::instance()->load_class( 'Transaction_Processor' );
369
-				$transaction_processor->set_old_txn_status( $transaction->status_ID() );
368
+				$transaction_processor = EE_Registry::instance()->load_class('Transaction_Processor');
369
+				$transaction_processor->set_old_txn_status($transaction->status_ID());
370 370
 			}
371
-			if ( $payment->status() !== EEM_Payment::status_id_failed ) {
371
+			if ($payment->status() !== EEM_Payment::status_id_failed) {
372 372
 				/** @type EE_Transaction_Payments $transaction_payments */
373
-				$transaction_payments = EE_Registry::instance()->load_class( 'Transaction_Payments' );
373
+				$transaction_payments = EE_Registry::instance()->load_class('Transaction_Payments');
374 374
 				// set new value for total paid
375
-				$transaction_payments->calculate_total_payments_and_update_status( $transaction );
375
+				$transaction_payments->calculate_total_payments_and_update_status($transaction);
376 376
 				// call EE_Transaction_Processor::update_transaction_and_registrations_after_checkout_or_payment() ???
377
-				if ( $update_txn ) {
378
-					$this->_post_payment_processing( $transaction, $payment, $IPN );
377
+				if ($update_txn) {
378
+					$this->_post_payment_processing($transaction, $payment, $IPN);
379 379
 				}
380 380
 			}
381 381
 			// granular hook for others to use.
382
-			do_action( $do_action, $transaction, $payment );
383
-			do_action( 'AHEE_log', __CLASS__, __FUNCTION__, $do_action, '$do_action' );
382
+			do_action($do_action, $transaction, $payment);
383
+			do_action('AHEE_log', __CLASS__, __FUNCTION__, $do_action, '$do_action');
384 384
 			//global hook for others to use.
385
-			do_action( 'AHEE__EE_Payment_Processor__update_txn_based_on_payment', $transaction, $payment );
385
+			do_action('AHEE__EE_Payment_Processor__update_txn_based_on_payment', $transaction, $payment);
386 386
 		}
387 387
 	}
388 388
 
@@ -396,25 +396,25 @@  discard block
 block discarded – undo
396 396
 	 * @param EE_Registration[] $registrations
397 397
 	 * @throws \EE_Error
398 398
 	 */
399
-	public function process_registration_payments( EE_Transaction $transaction, EE_Payment $payment, $registrations = array() ) {
399
+	public function process_registration_payments(EE_Transaction $transaction, EE_Payment $payment, $registrations = array()) {
400 400
 		// only process if payment was successful
401
-		if ( $payment->status() !== EEM_Payment::status_id_approved ) {
401
+		if ($payment->status() !== EEM_Payment::status_id_approved) {
402 402
 			return;
403 403
 		}
404 404
 		//EEM_Registration::instance()->show_next_x_db_queries();
405
-		if ( empty( $registrations )) {
405
+		if (empty($registrations)) {
406 406
 			// find registrations with monies owing that can receive a payment
407
-			$registrations = $transaction->registrations( array(
407
+			$registrations = $transaction->registrations(array(
408 408
 				array(
409 409
 					// only these reg statuses can receive payments
410
-					'STS_ID'  => array( 'IN', EEM_Registration::reg_statuses_that_allow_payment() ),
411
-					'REG_final_price'  => array( '!=', 0 ),
412
-					'REG_final_price*' => array( '!=', 'REG_paid', true ),
410
+					'STS_ID'  => array('IN', EEM_Registration::reg_statuses_that_allow_payment()),
411
+					'REG_final_price'  => array('!=', 0),
412
+					'REG_final_price*' => array('!=', 'REG_paid', true),
413 413
 				)
414
-			) );
414
+			));
415 415
 		}
416 416
 		// still nothing ??!??
417
-		if ( empty( $registrations )) {
417
+		if (empty($registrations)) {
418 418
 			return;
419 419
 		}
420 420
 		// todo: break out the following logic into a separate strategy class
@@ -426,28 +426,28 @@  discard block
 block discarded – undo
426 426
 
427 427
 		$refund = $payment->is_a_refund();
428 428
 		// how much is available to apply to registrations?
429
-		$available_payment_amount = abs( $payment->amount() );
430
-		foreach ( $registrations as $registration ) {
431
-			if ( $registration instanceof EE_Registration ) {
429
+		$available_payment_amount = abs($payment->amount());
430
+		foreach ($registrations as $registration) {
431
+			if ($registration instanceof EE_Registration) {
432 432
 				// nothing left?
433
-				if ( $available_payment_amount <= 0 ) {
433
+				if ($available_payment_amount <= 0) {
434 434
 					break;
435 435
 				}
436
-				if ( $refund ) {
437
-					$available_payment_amount = $this->process_registration_refund( $registration, $payment, $available_payment_amount );
436
+				if ($refund) {
437
+					$available_payment_amount = $this->process_registration_refund($registration, $payment, $available_payment_amount);
438 438
 				} else {
439
-					$available_payment_amount = $this->process_registration_payment( $registration, $payment, $available_payment_amount );
439
+					$available_payment_amount = $this->process_registration_payment($registration, $payment, $available_payment_amount);
440 440
 				}
441 441
 			}
442 442
 		}
443
-		if ( $available_payment_amount > 0 && apply_filters( 'FHEE__EE_Payment_Processor__process_registration_payments__display_notifications', false ) ) {
443
+		if ($available_payment_amount > 0 && apply_filters('FHEE__EE_Payment_Processor__process_registration_payments__display_notifications', false)) {
444 444
 			EE_Error::add_attention(
445 445
 				sprintf(
446
-					__( 'A remainder of %1$s exists after applying this payment to Registration(s) %2$s.%3$sPlease verify that the original payment amount of %4$s is correct. If so, you should edit this payment and select at least one additional registration in the "Registrations to Apply Payment to" section, so that the remainder of this payment can be applied to the additional registration(s).', 'event_espresso' ),
447
-					EEH_Template::format_currency( $available_payment_amount ),
448
-					implode( ', ',  array_keys( $registrations ) ),
446
+					__('A remainder of %1$s exists after applying this payment to Registration(s) %2$s.%3$sPlease verify that the original payment amount of %4$s is correct. If so, you should edit this payment and select at least one additional registration in the "Registrations to Apply Payment to" section, so that the remainder of this payment can be applied to the additional registration(s).', 'event_espresso'),
447
+					EEH_Template::format_currency($available_payment_amount),
448
+					implode(', ', array_keys($registrations)),
449 449
 					'<br/>',
450
-					EEH_Template::format_currency( $payment->amount() )
450
+					EEH_Template::format_currency($payment->amount())
451 451
 				),
452 452
 				__FILE__, __FUNCTION__, __LINE__
453 453
 			);
@@ -464,17 +464,17 @@  discard block
 block discarded – undo
464 464
 	 * @param float $available_payment_amount
465 465
 	 * @return float
466 466
 	 */
467
-	public function process_registration_payment( EE_Registration $registration, EE_Payment $payment, $available_payment_amount = 0.00 ) {
467
+	public function process_registration_payment(EE_Registration $registration, EE_Payment $payment, $available_payment_amount = 0.00) {
468 468
 		$owing = $registration->final_price() - $registration->paid();
469
-		if ( $owing > 0 ) {
469
+		if ($owing > 0) {
470 470
 			// don't allow payment amount to exceed the available payment amount, OR the amount owing
471
-			$payment_amount = min( $available_payment_amount, $owing );
471
+			$payment_amount = min($available_payment_amount, $owing);
472 472
 			// update $available_payment_amount
473 473
 			$available_payment_amount = $available_payment_amount - $payment_amount;
474 474
 			//calculate and set new REG_paid
475
-			$registration->set_paid( $registration->paid() + $payment_amount );
475
+			$registration->set_paid($registration->paid() + $payment_amount);
476 476
 			// now save it
477
-			$this->_apply_registration_payment( $registration, $payment, $payment_amount );
477
+			$this->_apply_registration_payment($registration, $payment, $payment_amount);
478 478
 		}
479 479
 		return $available_payment_amount;
480 480
 	}
@@ -489,19 +489,19 @@  discard block
 block discarded – undo
489 489
 	 * @param float $payment_amount
490 490
 	 * @return float
491 491
 	 */
492
-	protected function _apply_registration_payment( EE_Registration $registration, EE_Payment $payment, $payment_amount = 0.00 ) {
492
+	protected function _apply_registration_payment(EE_Registration $registration, EE_Payment $payment, $payment_amount = 0.00) {
493 493
 		// find any existing reg payment records for this registration and payment
494 494
 		$existing_reg_payment = EEM_Registration_Payment::instance()->get_one(
495
-			array( array( 'REG_ID' => $registration->ID(), 'PAY_ID' => $payment->ID() ) )
495
+			array(array('REG_ID' => $registration->ID(), 'PAY_ID' => $payment->ID()))
496 496
 		);
497 497
 		// if existing registration payment exists
498
-		if ( $existing_reg_payment instanceof EE_Registration_Payment ) {
498
+		if ($existing_reg_payment instanceof EE_Registration_Payment) {
499 499
 			// then update that record
500
-			$existing_reg_payment->set_amount( $payment_amount );
500
+			$existing_reg_payment->set_amount($payment_amount);
501 501
 			$existing_reg_payment->save();
502 502
 		} else {
503 503
 			// or add new relation between registration and payment and set amount
504
-			$registration->_add_relation_to( $payment, 'Payment', array( 'RPY_amount' => $payment_amount ) );
504
+			$registration->_add_relation_to($payment, 'Payment', array('RPY_amount' => $payment_amount));
505 505
 			// make it stick
506 506
 			$registration->save();
507 507
 		}
@@ -517,21 +517,21 @@  discard block
 block discarded – undo
517 517
 	 * @param float $available_refund_amount - IMPORTANT !!! SEND AVAILABLE REFUND AMOUNT AS A POSITIVE NUMBER
518 518
 	 * @return float
519 519
 	 */
520
-	public function process_registration_refund( EE_Registration $registration, EE_Payment $payment, $available_refund_amount = 0.00 ) {
520
+	public function process_registration_refund(EE_Registration $registration, EE_Payment $payment, $available_refund_amount = 0.00) {
521 521
 		//EEH_Debug_Tools::printr( $payment->amount(), '$payment->amount()', __FILE__, __LINE__ );
522
-		if ( $registration->paid() > 0 ) {
522
+		if ($registration->paid() > 0) {
523 523
 			// ensure $available_refund_amount is NOT negative
524
-			$available_refund_amount = abs( $available_refund_amount );
524
+			$available_refund_amount = abs($available_refund_amount);
525 525
 			// don't allow refund amount to exceed the available payment amount, OR the amount paid
526
-			$refund_amount = min( $available_refund_amount, $registration->paid() );
526
+			$refund_amount = min($available_refund_amount, $registration->paid());
527 527
 			// update $available_payment_amount
528 528
 			$available_refund_amount = $available_refund_amount - $refund_amount;
529 529
 			//calculate and set new REG_paid
530
-			$registration->set_paid( $registration->paid() - $refund_amount );
530
+			$registration->set_paid($registration->paid() - $refund_amount);
531 531
 			// convert payment amount back to a negative value for storage in the db
532
-			$refund_amount = abs( $refund_amount ) * -1;
532
+			$refund_amount = abs($refund_amount) * -1;
533 533
 			// now save it
534
-			$this->_apply_registration_payment( $registration, $payment, $refund_amount );
534
+			$this->_apply_registration_payment($registration, $payment, $refund_amount);
535 535
 		}
536 536
 		return $available_refund_amount;
537 537
 	}
@@ -549,12 +549,12 @@  discard block
 block discarded – undo
549 549
 	 * @param EE_Payment     $payment
550 550
 	 * @param bool           $IPN
551 551
 	 */
552
-	protected function _post_payment_processing( EE_Transaction $transaction, EE_Payment $payment, $IPN = false ) {
552
+	protected function _post_payment_processing(EE_Transaction $transaction, EE_Payment $payment, $IPN = false) {
553 553
 
554 554
 		/** @type EE_Transaction_Processor $transaction_processor */
555
-		$transaction_processor = EE_Registry::instance()->load_class( 'Transaction_Processor' );
555
+		$transaction_processor = EE_Registry::instance()->load_class('Transaction_Processor');
556 556
 		// is the Payment Options Reg Step completed ?
557
-		$payment_options_step_completed = $transaction_processor->reg_step_completed( $transaction, 'payment_options' );
557
+		$payment_options_step_completed = $transaction_processor->reg_step_completed($transaction, 'payment_options');
558 558
 		// DEBUG LOG
559 559
 		//$this->log(
560 560
 		//	__CLASS__, __FUNCTION__, __LINE__,
@@ -567,14 +567,14 @@  discard block
 block discarded – undo
567 567
 		// if the Payment Options Reg Step is completed...
568 568
 		$revisit = $payment_options_step_completed === true ? true : false;
569 569
 		// then this is kinda sorta a revisit with regards to payments at least
570
-		$transaction_processor->set_revisit( $revisit );
570
+		$transaction_processor->set_revisit($revisit);
571 571
 		// if this is an IPN, let's consider the Payment Options Reg Step completed if not already
572 572
 		if (
573 573
 			$IPN &&
574 574
 			$payment_options_step_completed !== true &&
575
-			( $payment->is_approved() || $payment->is_pending() )
575
+			($payment->is_approved() || $payment->is_pending())
576 576
 		) {
577
-			$payment_options_step_completed = $transaction_processor->set_reg_step_completed( $transaction, 'payment_options' );
577
+			$payment_options_step_completed = $transaction_processor->set_reg_step_completed($transaction, 'payment_options');
578 578
 		}
579 579
 		// DEBUG LOG
580 580
 		//$this->log(
@@ -586,11 +586,11 @@  discard block
 block discarded – undo
586 586
 		//	)
587 587
 		//);
588 588
 		/** @type EE_Transaction_Payments $transaction_payments */
589
-		$transaction_payments = EE_Registry::instance()->load_class( 'Transaction_Payments' );
589
+		$transaction_payments = EE_Registry::instance()->load_class('Transaction_Payments');
590 590
 		// maybe update status, but don't save transaction just yet
591
-		$transaction_payments->update_transaction_status_based_on_total_paid( $transaction, false );
591
+		$transaction_payments->update_transaction_status_based_on_total_paid($transaction, false);
592 592
 		// check if 'finalize_registration' step has been completed...
593
-		$finalized = $transaction_processor->reg_step_completed( $transaction, 'finalize_registration' );
593
+		$finalized = $transaction_processor->reg_step_completed($transaction, 'finalize_registration');
594 594
 		// DEBUG LOG
595 595
 		//$this->log(
596 596
 		//	__CLASS__, __FUNCTION__, __LINE__,
@@ -601,9 +601,9 @@  discard block
 block discarded – undo
601 601
 		//	)
602 602
 		//);
603 603
 		//  if this is an IPN and the final step has not been initiated
604
-		if ( $IPN && $payment_options_step_completed && $finalized === false ) {
604
+		if ($IPN && $payment_options_step_completed && $finalized === false) {
605 605
 			// and if it hasn't already been set as being started...
606
-			$finalized = $transaction_processor->set_reg_step_initiated( $transaction, 'finalize_registration' );
606
+			$finalized = $transaction_processor->set_reg_step_initiated($transaction, 'finalize_registration');
607 607
 			// DEBUG LOG
608 608
 			//$this->log(
609 609
 			//	__CLASS__, __FUNCTION__, __LINE__,
@@ -616,13 +616,13 @@  discard block
 block discarded – undo
616 616
 		}
617 617
 		$transaction->save();
618 618
 		// because the above will return false if the final step was not fully completed, we need to check again...
619
-		if ( $IPN && $finalized !== false ) {
619
+		if ($IPN && $finalized !== false) {
620 620
 			// and if we are all good to go, then send out notifications
621
-			add_filter( 'FHEE__EED_Messages___maybe_registration__deliver_notifications', '__return_true' );
621
+			add_filter('FHEE__EED_Messages___maybe_registration__deliver_notifications', '__return_true');
622 622
 			// DEBUG LOG
623 623
 			//$this->log( __CLASS__, __FUNCTION__, __LINE__, $transaction );
624 624
 			//ok, now process the transaction according to the payment
625
-			$transaction_processor->update_transaction_and_registrations_after_checkout_or_payment( $transaction, $payment );
625
+			$transaction_processor->update_transaction_and_registrations_after_checkout_or_payment($transaction, $payment);
626 626
 		}
627 627
 		// DEBUG LOG
628 628
 		//$this->log(
Please login to merge, or discard this patch.
core/db_classes/EE_Transaction.class.php 1 patch
Spacing   +111 added lines, -111 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1
-<?php if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
2
-	exit( 'No direct script access allowed' );
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) {
2
+	exit('No direct script access allowed');
3 3
 }
4 4
 /**
5 5
  * Event Espresso
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  * @subpackage 	includes/classes/EE_Transaction.class.php
27 27
  * @author 				Brent Christensen
28 28
  */
29
-class EE_Transaction extends EE_Base_Class implements EEI_Transaction{
29
+class EE_Transaction extends EE_Base_Class implements EEI_Transaction {
30 30
 
31 31
 
32 32
 	/**
@@ -38,9 +38,9 @@  discard block
 block discarded – undo
38 38
 	 *                             		    date_format and the second value is the time format
39 39
 	 * @return EE_Transaction
40 40
 	 */
41
-	public static function new_instance( $props_n_values = array(), $timezone = null, $date_formats = array() ) {
42
-		$has_object = parent::_check_for_object( $props_n_values, __CLASS__ );
43
-		return $has_object ? $has_object : new self( $props_n_values, false, $timezone, $date_formats );
41
+	public static function new_instance($props_n_values = array(), $timezone = null, $date_formats = array()) {
42
+		$has_object = parent::_check_for_object($props_n_values, __CLASS__);
43
+		return $has_object ? $has_object : new self($props_n_values, false, $timezone, $date_formats);
44 44
 	}
45 45
 
46 46
 
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 	 *                          		the website will be used.
52 52
 	 * @return EE_Attendee
53 53
 	 */
54
-	public static function new_instance_from_db( $props_n_values = array(), $timezone = null ) {
55
-		return new self( $props_n_values, TRUE, $timezone );
54
+	public static function new_instance_from_db($props_n_values = array(), $timezone = null) {
55
+		return new self($props_n_values, TRUE, $timezone);
56 56
 	}
57 57
 
58 58
 
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
 	 * @return 	void
68 68
 	 */
69 69
 	public function lock() {
70
-		$locked_transactions = get_option( 'ee_locked_transactions', array() );
71
-		$locked_transactions[ $this->ID() ] = true;
72
-		update_option( 'ee_locked_transactions', $locked_transactions );
70
+		$locked_transactions = get_option('ee_locked_transactions', array());
71
+		$locked_transactions[$this->ID()] = true;
72
+		update_option('ee_locked_transactions', $locked_transactions);
73 73
 	}
74 74
 
75 75
 
@@ -83,9 +83,9 @@  discard block
 block discarded – undo
83 83
 	 * @return 	void
84 84
 	 */
85 85
 	public function unlock() {
86
-		$locked_transactions = get_option( 'ee_locked_transactions', array() );
87
-		unset( $locked_transactions[ $this->ID() ] );
88
-		update_option( 'ee_locked_transactions', $locked_transactions );
86
+		$locked_transactions = get_option('ee_locked_transactions', array());
87
+		unset($locked_transactions[$this->ID()]);
88
+		update_option('ee_locked_transactions', $locked_transactions);
89 89
 	}
90 90
 
91 91
 	/**
@@ -102,8 +102,8 @@  discard block
 block discarded – undo
102 102
 	 * @return boolean
103 103
 	 */
104 104
 	public function is_locked() {
105
-		$locked_transactions = get_option( 'ee_locked_transactions', array() );
106
-		return isset( $locked_transactions[ $this->ID() ] ) ? true : false;
105
+		$locked_transactions = get_option('ee_locked_transactions', array());
106
+		return isset($locked_transactions[$this->ID()]) ? true : false;
107 107
 	}
108 108
 
109 109
 
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
 	 * @access        public
115 115
 	 * @param        float $total total value of transaction
116 116
 	 */
117
-	public function set_total( $total = 0.00 ) {
118
-		$this->set( 'TXN_total', $total );
117
+	public function set_total($total = 0.00) {
118
+		$this->set('TXN_total', $total);
119 119
 	}
120 120
 
121 121
 
@@ -126,8 +126,8 @@  discard block
 block discarded – undo
126 126
 	 * @access        public
127 127
 	 * @param        float $total_paid total amount paid to date (sum of all payments)
128 128
 	 */
129
-	public function set_paid( $total_paid = 0.00 ) {
130
-		$this->set( 'TXN_paid', $total_paid );
129
+	public function set_paid($total_paid = 0.00) {
130
+		$this->set('TXN_paid', $total_paid);
131 131
 	}
132 132
 
133 133
 
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
 	 * @access        public
139 139
 	 * @param        string $status whether the transaction is open, declined, accepted, or any number of custom values that can be set
140 140
 	 */
141
-	public function set_status( $status = '' ) {
142
-		$this->set( 'STS_ID', $status );
141
+	public function set_status($status = '') {
142
+		$this->set('STS_ID', $status);
143 143
 	}
144 144
 
145 145
 
@@ -150,8 +150,8 @@  discard block
 block discarded – undo
150 150
 	 * @access        public
151 151
 	 * @param        string $hash_salt required for some payment gateways
152 152
 	 */
153
-	public function set_hash_salt( $hash_salt = '' ) {
154
-		$this->set( 'TXN_hash_salt', $hash_salt );
153
+	public function set_hash_salt($hash_salt = '') {
154
+		$this->set('TXN_hash_salt', $hash_salt);
155 155
 	}
156 156
 
157 157
 
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 	 * Sets TXN_reg_steps array
161 161
 	 * @param array $txn_reg_steps
162 162
 	 */
163
-	function set_reg_steps( $txn_reg_steps ) {
164
-		$this->set( 'TXN_reg_steps', $txn_reg_steps );
163
+	function set_reg_steps($txn_reg_steps) {
164
+		$this->set('TXN_reg_steps', $txn_reg_steps);
165 165
 	}
166 166
 
167 167
 
@@ -171,8 +171,8 @@  discard block
 block discarded – undo
171 171
 	 * @return array
172 172
 	 */
173 173
 	function reg_steps() {
174
-		$TXN_reg_steps = $this->get( 'TXN_reg_steps' );
175
-		return is_array( $TXN_reg_steps ) ? $TXN_reg_steps : array();
174
+		$TXN_reg_steps = $this->get('TXN_reg_steps');
175
+		return is_array($TXN_reg_steps) ? $TXN_reg_steps : array();
176 176
 	}
177 177
 
178 178
 
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	 * @return string of transaction's total cost, with currency symbol and decimal
183 183
 	 */
184 184
 	public function pretty_total() {
185
-		return $this->get_pretty( 'TXN_total' );
185
+		return $this->get_pretty('TXN_total');
186 186
 	}
187 187
 
188 188
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 	 * @return string
193 193
 	 */
194 194
 	public function pretty_paid() {
195
-		return $this->get_pretty( 'TXN_paid' );
195
+		return $this->get_pretty('TXN_paid');
196 196
 	}
197 197
 
198 198
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 	 * @return float amount remaining
205 205
 	 */
206 206
 	public function remaining() {
207
-		return (float)( $this->total() - $this->paid() );
207
+		return (float) ($this->total() - $this->paid());
208 208
 	}
209 209
 
210 210
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 	 * @return float
216 216
 	 */
217 217
 	public function total() {
218
-		return $this->get( 'TXN_total' );
218
+		return $this->get('TXN_total');
219 219
 	}
220 220
 
221 221
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 	 * @return float
227 227
 	 */
228 228
 	public function paid() {
229
-		return $this->get( 'TXN_paid' );
229
+		return $this->get('TXN_paid');
230 230
 	}
231 231
 
232 232
 
@@ -236,8 +236,8 @@  discard block
 block discarded – undo
236 236
 	 * @access        public
237 237
 	 */
238 238
 	public function get_cart_session() {
239
-		$session_data = $this->get( 'TXN_session_data' );
240
-		return isset( $session_data[ 'cart' ] ) && $session_data[ 'cart' ] instanceof EE_Cart ? $session_data[ 'cart' ] : NULL;
239
+		$session_data = $this->get('TXN_session_data');
240
+		return isset($session_data['cart']) && $session_data['cart'] instanceof EE_Cart ? $session_data['cart'] : NULL;
241 241
 	}
242 242
 
243 243
 
@@ -247,9 +247,9 @@  discard block
 block discarded – undo
247 247
 	 * @access        public
248 248
 	 */
249 249
 	public function session_data() {
250
-		$session_data = $this->get( 'TXN_session_data' );
251
-		if ( empty( $session_data ) ) {
252
-			$session_data = array( 'id' => NULL, 'user_id' => NULL, 'ip_address' => NULL, 'user_agent' => NULL, 'init_access' => NULL, 'last_access' => NULL, 'pages_visited' => array() );
250
+		$session_data = $this->get('TXN_session_data');
251
+		if (empty($session_data)) {
252
+			$session_data = array('id' => NULL, 'user_id' => NULL, 'ip_address' => NULL, 'user_agent' => NULL, 'init_access' => NULL, 'last_access' => NULL, 'pages_visited' => array());
253 253
 		}
254 254
 		return $session_data;
255 255
 	}
@@ -262,11 +262,11 @@  discard block
 block discarded – undo
262 262
 	 * @access        public
263 263
 	 * @param        EE_Session|array $session_data
264 264
 	 */
265
-	public function set_txn_session_data( $session_data ) {
266
-		if ( $session_data instanceof EE_Session ) {
267
-			$this->set( 'TXN_session_data', $session_data->get_session_data( NULL, TRUE ));
265
+	public function set_txn_session_data($session_data) {
266
+		if ($session_data instanceof EE_Session) {
267
+			$this->set('TXN_session_data', $session_data->get_session_data(NULL, TRUE));
268 268
 		} else {
269
-			$this->set( 'TXN_session_data', $session_data );
269
+			$this->set('TXN_session_data', $session_data);
270 270
 		}
271 271
 	}
272 272
 
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 	 * @access        public
278 278
 	 */
279 279
 	public function hash_salt_() {
280
-		return $this->get( 'TXN_hash_salt' );
280
+		return $this->get('TXN_hash_salt');
281 281
 	}
282 282
 
283 283
 
@@ -297,13 +297,13 @@  discard block
 block discarded – undo
297 297
 	 * @param 	boolean 	$gmt - whether to return a unix timestamp with UTC offset applied (default) or no UTC offset applied
298 298
 	 * @return 	string | int
299 299
 	 */
300
-	public function datetime( $format = FALSE, $gmt = FALSE ) {
301
-		if ( $format ) {
302
-			return $this->get_pretty( 'TXN_timestamp' );
303
-		} else if ( $gmt ) {
304
-			return $this->get_raw( 'TXN_timestamp' );
300
+	public function datetime($format = FALSE, $gmt = FALSE) {
301
+		if ($format) {
302
+			return $this->get_pretty('TXN_timestamp');
303
+		} else if ($gmt) {
304
+			return $this->get_raw('TXN_timestamp');
305 305
 		} else {
306
-			return $this->get( 'TXN_timestamp' );
306
+			return $this->get('TXN_timestamp');
307 307
 		}
308 308
 	}
309 309
 
@@ -315,10 +315,10 @@  discard block
 block discarded – undo
315 315
 	 * @param        boolean $get_cached   TRUE to retrieve cached registrations or FALSE to pull from the db
316 316
 	 * @return EE_Registration[]
317 317
 	 */
318
-	public function registrations( $query_params = array(), $get_cached = FALSE ) {
319
-		$query_params = ( empty( $query_params ) || ! is_array( $query_params ) ) ? array( 'order_by' => array( 'Event.EVT_name' => 'ASC', 'Attendee.ATT_lname' => 'ASC', 'Attendee.ATT_fname' => 'ASC' ) ) : $query_params;
318
+	public function registrations($query_params = array(), $get_cached = FALSE) {
319
+		$query_params = (empty($query_params) || ! is_array($query_params)) ? array('order_by' => array('Event.EVT_name' => 'ASC', 'Attendee.ATT_lname' => 'ASC', 'Attendee.ATT_fname' => 'ASC')) : $query_params;
320 320
 		$query_params = $get_cached ? array() : $query_params;
321
-		return $this->get_many_related( 'Registration', $query_params );
321
+		return $this->get_many_related('Registration', $query_params);
322 322
 	}
323 323
 
324 324
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 	 * @return mixed EE_Attendee[] by default, int if $output is set to 'COUNT'
330 330
 	 */
331 331
 	public function attendees() {
332
-		return $this->get_many_related( 'Attendee', array( array( 'Registration.Transaction.TXN_ID' => $this->ID() ) ) );
332
+		return $this->get_many_related('Attendee', array(array('Registration.Transaction.TXN_ID' => $this->ID())));
333 333
 	}
334 334
 
335 335
 
@@ -339,8 +339,8 @@  discard block
 block discarded – undo
339 339
 	 * @param array $query_params like EEM_Base::get_all
340 340
 	 * @return EE_Payment[]
341 341
 	 */
342
-	public function payments( $query_params = array() ) {
343
-		return $this->get_many_related( 'Payment', $query_params );
342
+	public function payments($query_params = array()) {
343
+		return $this->get_many_related('Payment', $query_params);
344 344
 	}
345 345
 
346 346
 
@@ -350,8 +350,8 @@  discard block
 block discarded – undo
350 350
 	 * @return EE_Payment[]
351 351
 	 */
352 352
 	public function approved_payments() {
353
-		EE_Registry::instance()->load_model( 'Payment' );
354
-		return $this->get_many_related( 'Payment', array( array( 'STS_ID' => EEM_Payment::status_id_approved ), 'order_by' => array( 'PAY_timestamp' => 'DESC' ) ) );
353
+		EE_Registry::instance()->load_model('Payment');
354
+		return $this->get_many_related('Payment', array(array('STS_ID' => EEM_Payment::status_id_approved), 'order_by' => array('PAY_timestamp' => 'DESC')));
355 355
 	}
356 356
 
357 357
 
@@ -361,8 +361,8 @@  discard block
 block discarded – undo
361 361
 	 * @param bool $show_icons
362 362
 	 * @return string
363 363
 	 */
364
-	public function e_pretty_status( $show_icons = FALSE ) {
365
-		echo $this->pretty_status( $show_icons );
364
+	public function e_pretty_status($show_icons = FALSE) {
365
+		echo $this->pretty_status($show_icons);
366 366
 	}
367 367
 
368 368
 
@@ -372,10 +372,10 @@  discard block
 block discarded – undo
372 372
 	 * @param bool $show_icons
373 373
 	 * @return string
374 374
 	 */
375
-	public function pretty_status( $show_icons = FALSE ) {
376
-		$status = EEM_Status::instance()->localized_status( array( $this->status_ID() => __( 'unknown', 'event_espresso' ) ), FALSE, 'sentence' );
375
+	public function pretty_status($show_icons = FALSE) {
376
+		$status = EEM_Status::instance()->localized_status(array($this->status_ID() => __('unknown', 'event_espresso')), FALSE, 'sentence');
377 377
 		$icon = '';
378
-		switch ( $this->status_ID() ) {
378
+		switch ($this->status_ID()) {
379 379
 			case EEM_Transaction::complete_status_code:
380 380
 				$icon = $show_icons ? '<span class="dashicons dashicons-yes ee-icon-size-24 green-text"></span>' : '';
381 381
 				break;
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
 				$icon = $show_icons ? '<span class="dashicons dashicons-plus ee-icon-size-16 orange-text"></span>' : '';
393 393
 				break;
394 394
 		}
395
-		return $icon . $status[ $this->status_ID() ];
395
+		return $icon.$status[$this->status_ID()];
396 396
 	}
397 397
 
398 398
 
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
 	 * @access        public
403 403
 	 */
404 404
 	public function status_ID() {
405
-		return $this->get( 'STS_ID' );
405
+		return $this->get('STS_ID');
406 406
 	}
407 407
 
408 408
 
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 	 * @return boolean
413 413
 	 */
414 414
 	public function is_free() {
415
-		return (float)$this->get( 'TXN_total' ) == 0 ? TRUE : FALSE;
415
+		return (float) $this->get('TXN_total') == 0 ? TRUE : FALSE;
416 416
 	}
417 417
 
418 418
 
@@ -480,12 +480,12 @@  discard block
 block discarded – undo
480 480
 	 * @access public
481 481
 	 * @return string
482 482
 	 */
483
-	public function invoice_url( $type = 'html' ) {
483
+	public function invoice_url($type = 'html') {
484 484
 		$REG = $this->primary_registration();
485
-		if ( ! $REG instanceof EE_Registration ) {
485
+		if ( ! $REG instanceof EE_Registration) {
486 486
 			return '';
487 487
 		}
488
-		return $REG->invoice_url( $type );
488
+		return $REG->invoice_url($type);
489 489
 	}
490 490
 
491 491
 
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
 	 * @return EE_Registration
496 496
 	 */
497 497
 	public function primary_registration() {
498
-		return $this->get_first_related( 'Registration', array( array( 'REG_count' => EEM_Registration::PRIMARY_REGISTRANT_COUNT ) ) );
498
+		return $this->get_first_related('Registration', array(array('REG_count' => EEM_Registration::PRIMARY_REGISTRANT_COUNT)));
499 499
 	}
500 500
 
501 501
 
@@ -505,12 +505,12 @@  discard block
 block discarded – undo
505 505
 	 * @param string $type 'pdf' or 'html' (default is 'html')
506 506
 	 * @return string
507 507
 	 */
508
-	public function receipt_url( $type = 'html' ) {
508
+	public function receipt_url($type = 'html') {
509 509
 		$REG = $this->primary_registration();
510
-		if ( ! $REG instanceof EE_Registration ) {
510
+		if ( ! $REG instanceof EE_Registration) {
511 511
 			return '';
512 512
 		}
513
-		return $REG->receipt_url( $type );
513
+		return $REG->receipt_url($type);
514 514
 	}
515 515
 
516 516
 
@@ -535,15 +535,15 @@  discard block
 block discarded – undo
535 535
 	 * @deprecated
536 536
 	 * @return boolean
537 537
 	 */
538
-	public function update_based_on_payments(){
538
+	public function update_based_on_payments() {
539 539
 		EE_Error::doing_it_wrong(
540
-			__CLASS__ . '::' . __FUNCTION__,
541
-			sprintf( __( 'This method is deprecated. Please use "%s" instead', 'event_espresso' ), 'EE_Transaction_Processor::update_transaction_and_registrations_after_checkout_or_payment()' ),
540
+			__CLASS__.'::'.__FUNCTION__,
541
+			sprintf(__('This method is deprecated. Please use "%s" instead', 'event_espresso'), 'EE_Transaction_Processor::update_transaction_and_registrations_after_checkout_or_payment()'),
542 542
 			'4.6.0'
543 543
 		);
544 544
 		/** @type EE_Transaction_Processor $transaction_processor */
545
-		$transaction_processor = EE_Registry::instance()->load_class( 'Transaction_Processor' );
546
-		return  $transaction_processor->update_transaction_and_registrations_after_checkout_or_payment( $this );
545
+		$transaction_processor = EE_Registry::instance()->load_class('Transaction_Processor');
546
+		return  $transaction_processor->update_transaction_and_registrations_after_checkout_or_payment($this);
547 547
 	}
548 548
 
549 549
 
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 	 * @return string
553 553
 	 */
554 554
 	public function gateway_response_on_transaction() {
555
-		$payment = $this->get_first_related( 'Payment' );
555
+		$payment = $this->get_first_related('Payment');
556 556
 		return $payment instanceof EE_Payment ? $payment->gateway_response() : '';
557 557
 	}
558 558
 
@@ -563,7 +563,7 @@  discard block
 block discarded – undo
563 563
 	 * @return EE_Status
564 564
 	 */
565 565
 	public function status_obj() {
566
-		return $this->get_first_related( 'Status' );
566
+		return $this->get_first_related('Status');
567 567
 	}
568 568
 
569 569
 
@@ -573,8 +573,8 @@  discard block
 block discarded – undo
573 573
 	 * @param array $query_params like EEM_Base::get_all
574 574
 	 * @return EE_Extra_Meta
575 575
 	 */
576
-	public function extra_meta( $query_params = array() ) {
577
-		return $this->get_many_related( 'Extra_Meta', $query_params );
576
+	public function extra_meta($query_params = array()) {
577
+		return $this->get_many_related('Extra_Meta', $query_params);
578 578
 	}
579 579
 
580 580
 
@@ -584,8 +584,8 @@  discard block
 block discarded – undo
584 584
 	 * @param EE_Registration $registration
585 585
 	 * @return EE_Base_Class the relation was added to
586 586
 	 */
587
-	public function add_registration( EE_Registration $registration ) {
588
-		return $this->_add_relation_to( $registration, 'Registration' );
587
+	public function add_registration(EE_Registration $registration) {
588
+		return $this->_add_relation_to($registration, 'Registration');
589 589
 	}
590 590
 
591 591
 
@@ -596,8 +596,8 @@  discard block
 block discarded – undo
596 596
 	 * @param int $registration_or_id
597 597
 	 * @return EE_Base_Class that was removed from being related
598 598
 	 */
599
-	public function remove_registration_with_id( $registration_or_id ) {
600
-		return $this->_remove_relation_to( $registration_or_id, 'Registration' );
599
+	public function remove_registration_with_id($registration_or_id) {
600
+		return $this->_remove_relation_to($registration_or_id, 'Registration');
601 601
 	}
602 602
 
603 603
 
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
 	 * @return EE_Line_Item[]
608 608
 	 */
609 609
 	public function items_purchased() {
610
-		return $this->line_items( array( array( 'LIN_type' => EEM_Line_Item::type_line_item ) ) );
610
+		return $this->line_items(array(array('LIN_type' => EEM_Line_Item::type_line_item)));
611 611
 	}
612 612
 
613 613
 
@@ -617,8 +617,8 @@  discard block
 block discarded – undo
617 617
 	 * @param EE_Line_Item $line_item
618 618
 	 * @return EE_Base_Class the relation was added to
619 619
 	 */
620
-	public function add_line_item( EE_Line_Item $line_item ) {
621
-		return $this->_add_relation_to( $line_item, 'Line_Item' );
620
+	public function add_line_item(EE_Line_Item $line_item) {
621
+		return $this->_add_relation_to($line_item, 'Line_Item');
622 622
 	}
623 623
 
624 624
 
@@ -628,8 +628,8 @@  discard block
 block discarded – undo
628 628
 	 * @param array $query_params
629 629
 	 * @return EE_Line_Item[]
630 630
 	 */
631
-	public function line_items( $query_params = array() ) {
632
-		return $this->get_many_related( 'Line_Item', $query_params );
631
+	public function line_items($query_params = array()) {
632
+		return $this->get_many_related('Line_Item', $query_params);
633 633
 	}
634 634
 
635 635
 
@@ -639,7 +639,7 @@  discard block
 block discarded – undo
639 639
 	 * @return EE_Line_Item[]
640 640
 	 */
641 641
 	public function tax_items() {
642
-		return $this->line_items( array( array( 'LIN_type' => EEM_Line_Item::type_tax ) ) );
642
+		return $this->line_items(array(array('LIN_type' => EEM_Line_Item::type_tax)));
643 643
 	}
644 644
 
645 645
 
@@ -650,10 +650,10 @@  discard block
 block discarded – undo
650 650
 	 * @return EE_Line_Item
651 651
 	 */
652 652
 	public function total_line_item() {
653
-		$item =  $this->get_first_related( 'Line_Item', array( array( 'LIN_type' => EEM_Line_Item::type_total ) ) );
654
-		if( ! $item ){
655
-			EE_Registry::instance()->load_helper( 'Line_Item' );
656
-			$item = EEH_Line_Item::create_total_line_item( $this );
653
+		$item = $this->get_first_related('Line_Item', array(array('LIN_type' => EEM_Line_Item::type_total)));
654
+		if ( ! $item) {
655
+			EE_Registry::instance()->load_helper('Line_Item');
656
+			$item = EEH_Line_Item::create_total_line_item($this);
657 657
 		}
658 658
 		return $item;
659 659
 	}
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
 	 */
668 668
 	public function tax_total() {
669 669
 		$tax_line_item = $this->tax_total_line_item();
670
-		if ( $tax_line_item ) {
670
+		if ($tax_line_item) {
671 671
 			return $tax_line_item->total();
672 672
 		} else {
673 673
 			return 0;
@@ -681,7 +681,7 @@  discard block
 block discarded – undo
681 681
 	 * @return EE_Line_Item
682 682
 	 */
683 683
 	public function tax_total_line_item() {
684
-		return EEH_Line_Item::get_taxes_subtotal( $this->total_line_item() );
684
+		return EEH_Line_Item::get_taxes_subtotal($this->total_line_item());
685 685
 	}
686 686
 
687 687
 
@@ -690,20 +690,20 @@  discard block
 block discarded – undo
690 690
 	 *  Gets the array of billing info for the gateway and for this transaction's primary registration's attendee.
691 691
 	 * @return EE_Form_Section_Proper
692 692
 	 */
693
-	public function billing_info(){
693
+	public function billing_info() {
694 694
 		$payment_method = $this->payment_method();
695
-		if ( !$payment_method){
695
+		if ( ! $payment_method) {
696 696
 			EE_Error::add_error(__("Could not find billing info for transaction because no gateway has been used for it yet", "event_espresso"), __FILE__, __FUNCTION__, __LINE__);
697 697
 			return false;
698 698
 		}
699 699
 		$primary_reg = $this->primary_registration();
700
-		if ( ! $primary_reg ) {
701
-			EE_Error::add_error( __( "Cannot get billing info for gateway %s on transaction because no primary registration exists", "event_espresso" ), __FILE__, __FUNCTION__, __LINE__ );
700
+		if ( ! $primary_reg) {
701
+			EE_Error::add_error(__("Cannot get billing info for gateway %s on transaction because no primary registration exists", "event_espresso"), __FILE__, __FUNCTION__, __LINE__);
702 702
 			return FALSE;
703 703
 		}
704 704
 		$attendee = $primary_reg->attendee();
705
-		if ( ! $attendee ) {
706
-			EE_Error::add_error( __( "Cannot get billing info for gateway %s on transaction because the primary registration has no attendee exists", "event_espresso" ), __FILE__, __FUNCTION__, __LINE__ );
705
+		if ( ! $attendee) {
706
+			EE_Error::add_error(__("Cannot get billing info for gateway %s on transaction because the primary registration has no attendee exists", "event_espresso"), __FILE__, __FUNCTION__, __LINE__);
707 707
 			return FALSE;
708 708
 		}
709 709
 		return $attendee->billing_info_for_payment_method($payment_method);
@@ -738,15 +738,15 @@  discard block
 block discarded – undo
738 738
 	 * offline ones, dont' create payments)
739 739
 	 * @return EE_Payment_Method
740 740
 	 */
741
-	function payment_method(){
741
+	function payment_method() {
742 742
 		$pm = $this->get_first_related('Payment_Method');
743
-		if( $pm instanceof EE_Payment_Method ){
743
+		if ($pm instanceof EE_Payment_Method) {
744 744
 			return $pm;
745
-		}else{
745
+		} else {
746 746
 			$last_payment = $this->last_payment();
747
-			if( $last_payment instanceof EE_Payment && $last_payment->payment_method() ){
747
+			if ($last_payment instanceof EE_Payment && $last_payment->payment_method()) {
748 748
 				return $last_payment->payment_method();
749
-			}else{
749
+			} else {
750 750
 				return NULL;
751 751
 			}
752 752
 		}
@@ -757,15 +757,15 @@  discard block
 block discarded – undo
757 757
 	 * @return EE_Payment
758 758
 	 */
759 759
 	public function last_payment() {
760
-		return $this->get_first_related( 'Payment', array( 'order_by' => array( 'PAY_ID' => 'desc' ) ) );
760
+		return $this->get_first_related('Payment', array('order_by' => array('PAY_ID' => 'desc')));
761 761
 	}
762 762
 
763 763
 	/**
764 764
 	 * Gets all the line items which are unrelated to tickets on this transaction
765 765
 	 * @return EE_Line_Item[]
766 766
 	 */
767
-	public function non_ticket_line_items(){
768
-		return EEM_Line_Item::instance()->get_all_non_ticket_line_items_for_transaction( $this->ID() );
767
+	public function non_ticket_line_items() {
768
+		return EEM_Line_Item::instance()->get_all_non_ticket_line_items_for_transaction($this->ID());
769 769
 	}
770 770
 
771 771
 
Please login to merge, or discard this patch.
core/helpers/EEH_Line_Item.helper.php 2 patches
Spacing   +293 added lines, -293 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php if (!defined('EVENT_ESPRESSO_VERSION')) { exit('No direct script access allowed'); }
1
+<?php if ( ! defined('EVENT_ESPRESSO_VERSION')) { exit('No direct script access allowed'); }
2 2
 /**
3 3
  *
4 4
  * EEH_Line_Item
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
40 40
 	 * @param boolean $code if set to a value, ensures there is only one line item with that code
41 41
 	 * @return boolean success
42 42
 	 */
43
-	public static function add_unrelated_item( EE_Line_Item $parent_line_item, $name, $unit_price, $description = '', $quantity = 1, $taxable = FALSE, $code = NULL  ){
44
-		$items_subtotal = self::get_pre_tax_subtotal( $parent_line_item );
43
+	public static function add_unrelated_item(EE_Line_Item $parent_line_item, $name, $unit_price, $description = '', $quantity = 1, $taxable = FALSE, $code = NULL) {
44
+		$items_subtotal = self::get_pre_tax_subtotal($parent_line_item);
45 45
 		$line_item = EE_Line_Item::new_instance(array(
46 46
 			'LIN_name' => $name,
47 47
 			'LIN_desc' => $description,
@@ -49,8 +49,8 @@  discard block
 block discarded – undo
49 49
 			'LIN_quantity' => $quantity,
50 50
 			'LIN_percent' => null,
51 51
 			'LIN_is_taxable' => $taxable,
52
-			'LIN_order' => $items_subtotal instanceof EE_Line_Item ? count( $items_subtotal->children() ) : 0,
53
-			'LIN_total' => floatval( $unit_price ) * intval( $quantity ),
52
+			'LIN_order' => $items_subtotal instanceof EE_Line_Item ? count($items_subtotal->children()) : 0,
53
+			'LIN_total' => floatval($unit_price) * intval($quantity),
54 54
 			'LIN_type'=>  EEM_Line_Item::type_line_item,
55 55
 			'LIN_code' => $code,
56 56
 		));
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 			$line_item,
60 60
 			$parent_line_item
61 61
 		);
62
-		return self::add_item( $parent_line_item, $line_item );
62
+		return self::add_item($parent_line_item, $line_item);
63 63
 	}
64 64
 
65 65
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 * @param boolean      $taxable
81 81
 	 * @return boolean success
82 82
 	 */
83
-	public static function add_percentage_based_item( EE_Line_Item $parent_line_item, $name, $percentage_amount, $description = '', $taxable = FALSE ){
83
+	public static function add_percentage_based_item(EE_Line_Item $parent_line_item, $name, $percentage_amount, $description = '', $taxable = FALSE) {
84 84
 		$line_item = EE_Line_Item::new_instance(array(
85 85
 			'LIN_name' => $name,
86 86
 			'LIN_desc' => $description,
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 			'LIN_percent' => $percentage_amount,
89 89
 			'LIN_quantity' => NULL,
90 90
 			'LIN_is_taxable' => $taxable,
91
-			'LIN_total' => floatval( $percentage_amount * ( $parent_line_item->total() / 100 )),
91
+			'LIN_total' => floatval($percentage_amount * ($parent_line_item->total() / 100)),
92 92
 			'LIN_type'=>  EEM_Line_Item::type_line_item,
93 93
 			'LIN_parent' => $parent_line_item->ID()
94 94
 		));
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 			'FHEE__EEH_Line_Item__add_percentage_based_item__line_item',
97 97
 			$line_item
98 98
 		);
99
-		return self::add_item( $parent_line_item, $line_item );
99
+		return self::add_item($parent_line_item, $line_item);
100 100
 	}
101 101
 
102 102
 
@@ -117,15 +117,15 @@  discard block
 block discarded – undo
117 117
 	 * @return \EE_Line_Item
118 118
 	 * @throws \EE_Error
119 119
 	 */
120
-	public static function add_ticket_purchase( EE_Line_Item $total_line_item, EE_Ticket $ticket, $qty = 1 ){
121
-		if ( ! $total_line_item instanceof EE_Line_Item || ! $total_line_item->is_total() ) {
122
-			throw new EE_Error( sprintf( __( 'A valid line item total is required in order to add tickets. A line item of type "%s" was passed.', 'event_espresso' ), $ticket->ID(), $total_line_item->ID() ) );
120
+	public static function add_ticket_purchase(EE_Line_Item $total_line_item, EE_Ticket $ticket, $qty = 1) {
121
+		if ( ! $total_line_item instanceof EE_Line_Item || ! $total_line_item->is_total()) {
122
+			throw new EE_Error(sprintf(__('A valid line item total is required in order to add tickets. A line item of type "%s" was passed.', 'event_espresso'), $ticket->ID(), $total_line_item->ID()));
123 123
 		}
124 124
 		// either increment the qty for an existing ticket
125
-		$line_item = self::increment_ticket_qty_if_already_in_cart( $total_line_item, $ticket, $qty );
125
+		$line_item = self::increment_ticket_qty_if_already_in_cart($total_line_item, $ticket, $qty);
126 126
 		// or add a new one
127
-		if ( ! $line_item instanceof EE_Line_Item ) {
128
-			$line_item = self::create_ticket_line_item( $total_line_item, $ticket, $qty );
127
+		if ( ! $line_item instanceof EE_Line_Item) {
128
+			$line_item = self::create_ticket_line_item($total_line_item, $ticket, $qty);
129 129
 		}
130 130
 		$total_line_item->recalculate_total_including_taxes();
131 131
 		return $line_item;
@@ -141,19 +141,19 @@  discard block
 block discarded – undo
141 141
 	 * @return \EE_Line_Item
142 142
 	 * @throws \EE_Error
143 143
 	 */
144
-	public static function increment_ticket_qty_if_already_in_cart( EE_Line_Item $total_line_item, EE_Ticket $ticket, $qty = 1 ) {
144
+	public static function increment_ticket_qty_if_already_in_cart(EE_Line_Item $total_line_item, EE_Ticket $ticket, $qty = 1) {
145 145
 		$line_item = null;
146
-		if ( $total_line_item instanceof EE_Line_Item && $total_line_item->is_total() ) {
147
-			$ticket_line_items = EEH_Line_Item::get_ticket_line_items( $total_line_item );
148
-			foreach ( (array)$ticket_line_items as $ticket_line_item ) {
149
-				if ( $ticket_line_item instanceof EE_Line_Item && $ticket_line_item->OBJ_ID() == $ticket->ID() ) {
146
+		if ($total_line_item instanceof EE_Line_Item && $total_line_item->is_total()) {
147
+			$ticket_line_items = EEH_Line_Item::get_ticket_line_items($total_line_item);
148
+			foreach ((array) $ticket_line_items as $ticket_line_item) {
149
+				if ($ticket_line_item instanceof EE_Line_Item && $ticket_line_item->OBJ_ID() == $ticket->ID()) {
150 150
 					$line_item = $ticket_line_item;
151 151
 					break;
152 152
 				}
153 153
 			}
154 154
 		}
155
-		if ( $line_item instanceof EE_Line_Item ) {
156
-			EEH_Line_Item::increment_quantity( $line_item, $qty );
155
+		if ($line_item instanceof EE_Line_Item) {
156
+			EEH_Line_Item::increment_quantity($line_item, $qty);
157 157
 			return $line_item;
158 158
 		}
159 159
 		return null;
@@ -166,15 +166,15 @@  discard block
 block discarded – undo
166 166
 	 * @param int $qty
167 167
 	 * @return void
168 168
 	 */
169
-	public static function increment_quantity( EE_Line_Item $line_item, $qty = 1 ) {
170
-		if( ! $line_item->is_percent() ) {
169
+	public static function increment_quantity(EE_Line_Item $line_item, $qty = 1) {
170
+		if ( ! $line_item->is_percent()) {
171 171
 			$qty += $line_item->quantity();
172
-			$line_item->set_quantity( $qty );
173
-			$line_item->set_total( $line_item->unit_price() * $qty );
172
+			$line_item->set_quantity($qty);
173
+			$line_item->set_total($line_item->unit_price() * $qty);
174 174
 		}
175
-		foreach( $line_item->children() as $child ) {
176
-			if( $child->is_sub_line_item() ) {
177
-				EEH_Line_Item::update_quantity( $child, $line_item->quantity() );
175
+		foreach ($line_item->children() as $child) {
176
+			if ($child->is_sub_line_item()) {
177
+				EEH_Line_Item::update_quantity($child, $line_item->quantity());
178 178
 			}
179 179
 		}
180 180
 	}
@@ -185,14 +185,14 @@  discard block
 block discarded – undo
185 185
 	 * @param EE_Line_Item $line_item
186 186
 	 * @param int $new_quantity
187 187
 	 */
188
-	public static function update_quantity( EE_Line_Item $line_item, $new_quantity ) {
189
-		if( ! $line_item->is_percent() ) {
190
-			$line_item->set_quantity( $new_quantity );
191
-			$line_item->set_total( $line_item->unit_price() * $new_quantity );
188
+	public static function update_quantity(EE_Line_Item $line_item, $new_quantity) {
189
+		if ( ! $line_item->is_percent()) {
190
+			$line_item->set_quantity($new_quantity);
191
+			$line_item->set_total($line_item->unit_price() * $new_quantity);
192 192
 		}
193
-		foreach( $line_item->children() as $child ) {
194
-			if( $child->is_sub_line_item() ) {
195
-				EEH_Line_Item::update_quantity( $child, $new_quantity );
193
+		foreach ($line_item->children() as $child) {
194
+			if ($child->is_sub_line_item()) {
195
+				EEH_Line_Item::update_quantity($child, $new_quantity);
196 196
 			}
197 197
 		}
198 198
 	}
@@ -207,45 +207,45 @@  discard block
 block discarded – undo
207 207
 	 * @return \EE_Line_Item
208 208
 	 * @throws \EE_Error
209 209
 	 */
210
-	public static function create_ticket_line_item( EE_Line_Item $total_line_item, EE_Ticket $ticket, $qty = 1 ) {
210
+	public static function create_ticket_line_item(EE_Line_Item $total_line_item, EE_Ticket $ticket, $qty = 1) {
211 211
 		$datetimes = $ticket->datetimes();
212
-		$first_datetime = reset( $datetimes );
213
-		if( $first_datetime instanceof EE_Datetime &&
214
-				$first_datetime->event() instanceof EE_Event ) {
212
+		$first_datetime = reset($datetimes);
213
+		if ($first_datetime instanceof EE_Datetime &&
214
+				$first_datetime->event() instanceof EE_Event) {
215 215
 			$first_datetime_name = $first_datetime->event()->name();
216 216
 		} else {
217
-			$first_datetime_name = __( 'Event', 'event_espresso' );
217
+			$first_datetime_name = __('Event', 'event_espresso');
218 218
 		}
219
-		$event = sprintf( _x( '(For %1$s)', '(For Event Name)', 'event_espresso' ), $first_datetime_name );
219
+		$event = sprintf(_x('(For %1$s)', '(For Event Name)', 'event_espresso'), $first_datetime_name);
220 220
 		// get event subtotal line
221
-		$events_sub_total = self::get_event_line_item_for_ticket( $total_line_item, $ticket );
222
-		if ( ! $events_sub_total instanceof EE_Line_Item ) {
223
-			throw new EE_Error( sprintf( __( 'There is no events sub-total for ticket %s on total line item %d', 'event_espresso' ), $ticket->ID(), $total_line_item->ID() ) );
221
+		$events_sub_total = self::get_event_line_item_for_ticket($total_line_item, $ticket);
222
+		if ( ! $events_sub_total instanceof EE_Line_Item) {
223
+			throw new EE_Error(sprintf(__('There is no events sub-total for ticket %s on total line item %d', 'event_espresso'), $ticket->ID(), $total_line_item->ID()));
224 224
 		}
225 225
 		// add $ticket to cart
226
-		$line_item = EE_Line_Item::new_instance( array(
226
+		$line_item = EE_Line_Item::new_instance(array(
227 227
 			'LIN_name'       	=> $ticket->name(),
228
-			'LIN_desc'       		=> $ticket->description() != '' ? $ticket->description() . ' ' . $event : $event,
228
+			'LIN_desc'       		=> $ticket->description() != '' ? $ticket->description().' '.$event : $event,
229 229
 			'LIN_unit_price' 	=> $ticket->price(),
230 230
 			'LIN_quantity'   	=> $qty,
231 231
 			'LIN_is_taxable' 	=> $ticket->taxable(),
232
-			'LIN_order'      	=> count( $events_sub_total->children() ),
232
+			'LIN_order'      	=> count($events_sub_total->children()),
233 233
 			'LIN_total'      		=> $ticket->price() * $qty,
234 234
 			'LIN_type'       		=> EEM_Line_Item::type_line_item,
235 235
 			'OBJ_ID'         		=> $ticket->ID(),
236 236
 			'OBJ_type'       	=> 'Ticket'
237
-		) );
237
+		));
238 238
 		$line_item = apply_filters(
239 239
 			'FHEE__EEH_Line_Item__create_ticket_line_item__line_item',
240 240
 			$line_item
241 241
 		);
242
-		$events_sub_total->add_child_line_item( $line_item );
242
+		$events_sub_total->add_child_line_item($line_item);
243 243
 		//now add the sub-line items
244 244
 		$running_total_for_ticket = 0;
245
-		foreach ( $ticket->prices( array( 'order_by' => array( 'PRC_order' => 'ASC' ) ) ) as $price ) {
245
+		foreach ($ticket->prices(array('order_by' => array('PRC_order' => 'ASC'))) as $price) {
246 246
 			$sign = $price->is_discount() ? -1 : 1;
247 247
 			$price_total = $price->is_percent() ? $running_total_for_ticket * $price->amount() / 100 : $price->amount() * $qty;
248
-			$sub_line_item = EE_Line_Item::new_instance( array(
248
+			$sub_line_item = EE_Line_Item::new_instance(array(
249 249
 				'LIN_name'       	=> $price->name(),
250 250
 				'LIN_desc'       		=> $price->desc(),
251 251
 				'LIN_quantity'   	=> $price->is_percent() ? null : $qty,
@@ -255,18 +255,18 @@  discard block
 block discarded – undo
255 255
 				'LIN_type'       		=> EEM_Line_Item::type_sub_line_item,
256 256
 				'OBJ_ID'         		=> $price->ID(),
257 257
 				'OBJ_type'       	=> 'Price'
258
-			) );
258
+			));
259 259
 			$sub_line_item = apply_filters(
260 260
 				'FHEE__EEH_Line_Item__create_ticket_line_item__sub_line_item',
261 261
 				$sub_line_item
262 262
 			);
263
-			if ( $price->is_percent() ) {
264
-				$sub_line_item->set_percent( $sign * $price->amount() );
263
+			if ($price->is_percent()) {
264
+				$sub_line_item->set_percent($sign * $price->amount());
265 265
 			} else {
266
-				$sub_line_item->set_unit_price( $sign * $price->amount() );
266
+				$sub_line_item->set_unit_price($sign * $price->amount());
267 267
 			}
268 268
 			$running_total_for_ticket += $price_total;
269
-			$line_item->add_child_line_item( $sub_line_item );
269
+			$line_item->add_child_line_item($sub_line_item);
270 270
 		}
271 271
 		return $line_item;
272 272
 	}
@@ -284,11 +284,11 @@  discard block
 block discarded – undo
284 284
 	 * @param EE_Line_Item $item to be added
285 285
 	 * @return boolean
286 286
 	 */
287
-	public static function add_item( EE_Line_Item $total_line_item, EE_Line_Item $item ){
288
-		$pre_tax_subtotal = self::get_pre_tax_subtotal( $total_line_item );
289
-		if ( $pre_tax_subtotal instanceof EE_Line_Item ){
287
+	public static function add_item(EE_Line_Item $total_line_item, EE_Line_Item $item) {
288
+		$pre_tax_subtotal = self::get_pre_tax_subtotal($total_line_item);
289
+		if ($pre_tax_subtotal instanceof EE_Line_Item) {
290 290
 			$success = $pre_tax_subtotal->add_child_line_item($item);
291
-		}else{
291
+		} else {
292 292
 			return FALSE;
293 293
 		}
294 294
 		$total_line_item->recalculate_total_including_taxes();
@@ -302,9 +302,9 @@  discard block
 block discarded – undo
302 302
 	 * @param EE_Line_Item $total_line_item of type EEM_Line_Item::type_total
303 303
 	 *	@return \EE_Line_Item
304 304
 	 */
305
-	public static function get_pre_tax_subtotal( EE_Line_Item $total_line_item ){
306
-		$pre_tax_subtotal = $total_line_item->get_child_line_item( 'pre-tax-subtotal' );
307
-		return $pre_tax_subtotal instanceof EE_Line_Item ? $pre_tax_subtotal : self::create_pre_tax_subtotal( $total_line_item );
305
+	public static function get_pre_tax_subtotal(EE_Line_Item $total_line_item) {
306
+		$pre_tax_subtotal = $total_line_item->get_child_line_item('pre-tax-subtotal');
307
+		return $pre_tax_subtotal instanceof EE_Line_Item ? $pre_tax_subtotal : self::create_pre_tax_subtotal($total_line_item);
308 308
 	}
309 309
 
310 310
 
@@ -314,9 +314,9 @@  discard block
 block discarded – undo
314 314
 	 * @param EE_Line_Item $total_line_item of type EEM_Line_Item::type_total
315 315
 	 * @return \EE_Line_Item
316 316
 	 */
317
-	public static function get_taxes_subtotal( EE_Line_Item $total_line_item ){
318
-		$taxes = $total_line_item->get_child_line_item( 'taxes' );
319
-		return $taxes ? $taxes : self::create_taxes_subtotal( $total_line_item );
317
+	public static function get_taxes_subtotal(EE_Line_Item $total_line_item) {
318
+		$taxes = $total_line_item->get_child_line_item('taxes');
319
+		return $taxes ? $taxes : self::create_taxes_subtotal($total_line_item);
320 320
 	}
321 321
 
322 322
 
@@ -327,12 +327,12 @@  discard block
 block discarded – undo
327 327
 	 * @param EE_Transaction $transaction
328 328
 	 * @return void
329 329
 	 */
330
-	public static function set_TXN_ID( EE_Line_Item $line_item, $transaction = NULL ){
331
-		if( $transaction ){
330
+	public static function set_TXN_ID(EE_Line_Item $line_item, $transaction = NULL) {
331
+		if ($transaction) {
332 332
 			/** @type EEM_Transaction $EEM_Transaction */
333
-			$EEM_Transaction = EE_Registry::instance()->load_model( 'Transaction' );
334
-			$transaction = $EEM_Transaction->ensure_is_ID( $transaction );
335
-			$line_item->set_TXN_ID( $transaction );
333
+			$EEM_Transaction = EE_Registry::instance()->load_model('Transaction');
334
+			$transaction = $EEM_Transaction->ensure_is_ID($transaction);
335
+			$line_item->set_TXN_ID($transaction);
336 336
 		}
337 337
 	}
338 338
 
@@ -345,8 +345,8 @@  discard block
 block discarded – undo
345 345
 	 * @param EE_Transaction $transaction
346 346
 	 * @return \EE_Line_Item of type total
347 347
 	 */
348
-	public static function create_total_line_item( $transaction = NULL ){
349
-		$total_line_item = EE_Line_Item::new_instance( array(
348
+	public static function create_total_line_item($transaction = NULL) {
349
+		$total_line_item = EE_Line_Item::new_instance(array(
350 350
 			'LIN_code'	=> 'total',
351 351
 			'LIN_name'	=> __('Grand Total', 'event_espresso'),
352 352
 			'LIN_type'	=> EEM_Line_Item::type_total,
@@ -356,9 +356,9 @@  discard block
 block discarded – undo
356 356
 			'FHEE__EEH_Line_Item__create_total_line_item__total_line_item',
357 357
 			$total_line_item
358 358
 		);
359
-		self::set_TXN_ID( $total_line_item, $transaction );
360
-		self::create_pre_tax_subtotal( $total_line_item, $transaction );
361
-		self::create_taxes_subtotal( $total_line_item, $transaction );
359
+		self::set_TXN_ID($total_line_item, $transaction);
360
+		self::create_pre_tax_subtotal($total_line_item, $transaction);
361
+		self::create_taxes_subtotal($total_line_item, $transaction);
362 362
 		return $total_line_item;
363 363
 	}
364 364
 
@@ -370,19 +370,19 @@  discard block
 block discarded – undo
370 370
 	 * @param EE_Transaction $transaction
371 371
 	 * @return EE_Line_Item
372 372
 	 */
373
-	protected static function create_pre_tax_subtotal( EE_Line_Item $total_line_item, $transaction = NULL ){
374
-		$pre_tax_line_item = EE_Line_Item::new_instance( array(
373
+	protected static function create_pre_tax_subtotal(EE_Line_Item $total_line_item, $transaction = NULL) {
374
+		$pre_tax_line_item = EE_Line_Item::new_instance(array(
375 375
 			'LIN_code' 	=> 'pre-tax-subtotal',
376
-			'LIN_name' 	=> __( 'Pre-Tax Subtotal', 'event_espresso' ),
376
+			'LIN_name' 	=> __('Pre-Tax Subtotal', 'event_espresso'),
377 377
 			'LIN_type' 	=> EEM_Line_Item::type_sub_total
378
-		) );
378
+		));
379 379
 		$pre_tax_line_item = apply_filters(
380 380
 			'FHEE__EEH_Line_Item__create_pre_tax_subtotal__pre_tax_line_item',
381 381
 			$pre_tax_line_item
382 382
 		);
383
-		self::set_TXN_ID( $pre_tax_line_item, $transaction );
384
-		$total_line_item->add_child_line_item( $pre_tax_line_item );
385
-		self::create_event_subtotal( $pre_tax_line_item, $transaction );
383
+		self::set_TXN_ID($pre_tax_line_item, $transaction);
384
+		$total_line_item->add_child_line_item($pre_tax_line_item);
385
+		self::create_event_subtotal($pre_tax_line_item, $transaction);
386 386
 		return $pre_tax_line_item;
387 387
 	}
388 388
 
@@ -395,21 +395,21 @@  discard block
 block discarded – undo
395 395
 	 * @param EE_Transaction $transaction
396 396
 	 * @return EE_Line_Item
397 397
 	 */
398
-	protected static function create_taxes_subtotal( EE_Line_Item $total_line_item, $transaction = NULL ){
398
+	protected static function create_taxes_subtotal(EE_Line_Item $total_line_item, $transaction = NULL) {
399 399
 		$tax_line_item = EE_Line_Item::new_instance(array(
400 400
 			'LIN_code'	=> 'taxes',
401 401
 			'LIN_name' 	=> __('Taxes', 'event_espresso'),
402 402
 			'LIN_type'	=> EEM_Line_Item::type_tax_sub_total,
403
-			'LIN_order' => 1000,//this should always come last
403
+			'LIN_order' => 1000, //this should always come last
404 404
 		));
405 405
 		$tax_line_item = apply_filters(
406 406
 			'FHEE__EEH_Line_Item__create_taxes_subtotal__tax_line_item',
407 407
 			$tax_line_item
408 408
 		);
409
-		self::set_TXN_ID( $tax_line_item, $transaction );
410
-		$total_line_item->add_child_line_item( $tax_line_item );
409
+		self::set_TXN_ID($tax_line_item, $transaction);
410
+		$total_line_item->add_child_line_item($tax_line_item);
411 411
 		//and lastly, add the actual taxes
412
-		self::apply_taxes( $total_line_item );
412
+		self::apply_taxes($total_line_item);
413 413
 		return $tax_line_item;
414 414
 	}
415 415
 
@@ -422,11 +422,11 @@  discard block
 block discarded – undo
422 422
 	 * @param EE_Event $event
423 423
 	 * @return EE_Line_Item
424 424
 	 */
425
-	public static function create_event_subtotal( EE_Line_Item $pre_tax_line_item, $transaction = NULL, $event = NULL ){
425
+	public static function create_event_subtotal(EE_Line_Item $pre_tax_line_item, $transaction = NULL, $event = NULL) {
426 426
 		$event_line_item = EE_Line_Item::new_instance(array(
427
-			'LIN_code'	=> self::get_event_code( $event ),
428
-			'LIN_name' 	=> self::get_event_name( $event ),
429
-			'LIN_desc' 	=> self::get_event_desc( $event ),
427
+			'LIN_code'	=> self::get_event_code($event),
428
+			'LIN_name' 	=> self::get_event_name($event),
429
+			'LIN_desc' 	=> self::get_event_desc($event),
430 430
 			'LIN_type'	=> EEM_Line_Item::type_sub_total,
431 431
 			'OBJ_type' 	=> 'Event',
432 432
 			'OBJ_ID' 		=>  $event instanceof EE_Event ? $event->ID() : 0
@@ -435,8 +435,8 @@  discard block
 block discarded – undo
435 435
 			'FHEE__EEH_Line_Item__create_event_subtotal__event_line_item',
436 436
 			$event_line_item
437 437
 		);
438
-		self::set_TXN_ID( $event_line_item, $transaction );
439
-		$pre_tax_line_item->add_child_line_item( $event_line_item );
438
+		self::set_TXN_ID($event_line_item, $transaction);
439
+		$pre_tax_line_item->add_child_line_item($event_line_item);
440 440
 		return $event_line_item;
441 441
 	}
442 442
 
@@ -445,8 +445,8 @@  discard block
 block discarded – undo
445 445
 	 * @param EE_Event $event
446 446
 	 * @return string
447 447
 	 */
448
-	public static function get_event_code( $event ) {
449
-		return 'event-' . ( $event instanceof EE_Event ? $event->ID() : '0' );
448
+	public static function get_event_code($event) {
449
+		return 'event-'.($event instanceof EE_Event ? $event->ID() : '0');
450 450
 	}
451 451
 
452 452
 	/**
@@ -454,8 +454,8 @@  discard block
 block discarded – undo
454 454
 	 * @param EE_Event $event
455 455
 	 * @return string
456 456
 	 */
457
-	public static function get_event_name( $event ) {
458
-		return $event instanceof EE_Event ? $event->name() : __( 'Event', 'event_espresso' );
457
+	public static function get_event_name($event) {
458
+		return $event instanceof EE_Event ? $event->name() : __('Event', 'event_espresso');
459 459
 	}
460 460
 
461 461
 	/**
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
 	 * @param EE_Event $event
464 464
 	 * @return string
465 465
 	 */
466
-	public static function get_event_desc( $event ) {
466
+	public static function get_event_desc($event) {
467 467
 		return $event instanceof EE_Event ? $event->short_description() : '';
468 468
 	}
469 469
 
@@ -477,16 +477,16 @@  discard block
 block discarded – undo
477 477
 	  * @throws \EE_Error
478 478
 	  * @return EE_Line_Item
479 479
 	  */
480
-	public static function get_event_line_item_for_ticket( EE_Line_Item $grand_total, EE_Ticket $ticket ) {
480
+	public static function get_event_line_item_for_ticket(EE_Line_Item $grand_total, EE_Ticket $ticket) {
481 481
 		$first_datetime = $ticket->first_datetime();
482
-		if( ! $first_datetime instanceof EE_Datetime ){
483
-			throw new EE_Error( sprintf( __( 'The supplied ticket (ID %d) has no datetimes', 'event_espresso' ), $ticket->ID() ) );
482
+		if ( ! $first_datetime instanceof EE_Datetime) {
483
+			throw new EE_Error(sprintf(__('The supplied ticket (ID %d) has no datetimes', 'event_espresso'), $ticket->ID()));
484 484
 		}
485 485
 		$event = $first_datetime->event();
486
-		if ( ! $event instanceof EE_Event ) {
487
-			throw new EE_Error( sprintf( __( 'The supplied ticket (ID %d) has no event data associated with it.','event_espresso' ), $ticket->ID() ) );
486
+		if ( ! $event instanceof EE_Event) {
487
+			throw new EE_Error(sprintf(__('The supplied ticket (ID %d) has no event data associated with it.', 'event_espresso'), $ticket->ID()));
488 488
 		}
489
-		return EEH_Line_Item::get_event_line_item( $grand_total, $event );
489
+		return EEH_Line_Item::get_event_line_item($grand_total, $event);
490 490
 	}
491 491
 
492 492
 	/**
@@ -495,31 +495,31 @@  discard block
 block discarded – undo
495 495
 	 * @param EE_Event $event
496 496
 	 * @return EE_Line_Item for the event subtotal which is a child of $grand_total
497 497
 	 */
498
-	public static function get_event_line_item( EE_Line_Item $grand_total, $event ) {
498
+	public static function get_event_line_item(EE_Line_Item $grand_total, $event) {
499 499
 		/** @type EE_Event $event */
500
-		$event = EEM_Event::instance()->ensure_is_obj( $event, true );
500
+		$event = EEM_Event::instance()->ensure_is_obj($event, true);
501 501
 		$event_line_item = NULL;
502 502
 		$found = false;
503
-		foreach ( EEH_Line_Item::get_event_subtotals( $grand_total ) as $event_line_item ) {
503
+		foreach (EEH_Line_Item::get_event_subtotals($grand_total) as $event_line_item) {
504 504
 			// default event subtotal, we should only ever find this the first time this method is called
505
-			if ( ! $event_line_item->OBJ_ID() ) {
505
+			if ( ! $event_line_item->OBJ_ID()) {
506 506
 				// let's use this! but first... set the event details
507
-				EEH_Line_Item::set_event_subtotal_details( $event_line_item, $event );
507
+				EEH_Line_Item::set_event_subtotal_details($event_line_item, $event);
508 508
 				$found = true;
509 509
 				break;
510
-			} else if ( $event_line_item->OBJ_ID() === $event->ID() ) {
510
+			} else if ($event_line_item->OBJ_ID() === $event->ID()) {
511 511
 				// found existing line item for this event in the cart, so break out of loop and use this one
512 512
 				$found = true;
513 513
 				break;
514 514
 			}
515 515
 		}
516
-		if ( ! $found ) {
516
+		if ( ! $found) {
517 517
 			//there is no event sub-total yet, so add it
518
-			$pre_tax_subtotal = EEH_Line_Item::get_pre_tax_subtotal( $grand_total );
518
+			$pre_tax_subtotal = EEH_Line_Item::get_pre_tax_subtotal($grand_total);
519 519
 			// create a new "event" subtotal below that
520
-			$event_line_item = EEH_Line_Item::create_event_subtotal( $pre_tax_subtotal, null, $event );
520
+			$event_line_item = EEH_Line_Item::create_event_subtotal($pre_tax_subtotal, null, $event);
521 521
 			// and set the event details
522
-			EEH_Line_Item::set_event_subtotal_details( $event_line_item, $event );
522
+			EEH_Line_Item::set_event_subtotal_details($event_line_item, $event);
523 523
 		}
524 524
 		return $event_line_item;
525 525
 	}
@@ -533,14 +533,14 @@  discard block
 block discarded – undo
533 533
 	 * @param EE_Transaction $transaction
534 534
 	 * @return EE_Line_Item
535 535
 	 */
536
-	public static function set_event_subtotal_details( EE_Line_Item $event_line_item, EE_Event $event, $transaction = NULL ){
537
-		if ( $event instanceof EE_Event ) {
538
-			$event_line_item->set_code( self::get_event_code( $event ) );
539
-			$event_line_item->set_name( self::get_event_name( $event ) );
540
-			$event_line_item->set_desc( self::get_event_desc( $event ) );
541
-			$event_line_item->set_OBJ_ID( $event->ID() );
536
+	public static function set_event_subtotal_details(EE_Line_Item $event_line_item, EE_Event $event, $transaction = NULL) {
537
+		if ($event instanceof EE_Event) {
538
+			$event_line_item->set_code(self::get_event_code($event));
539
+			$event_line_item->set_name(self::get_event_name($event));
540
+			$event_line_item->set_desc(self::get_event_desc($event));
541
+			$event_line_item->set_OBJ_ID($event->ID());
542 542
 		}
543
-		self::set_TXN_ID( $event_line_item, $transaction );
543
+		self::set_TXN_ID($event_line_item, $transaction);
544 544
 	}
545 545
 
546 546
 
@@ -551,19 +551,19 @@  discard block
 block discarded – undo
551 551
 	 * any old taxes are removed
552 552
 	 * @param EE_Line_Item $total_line_item of type EEM_Line_Item::type_total
553 553
 	 */
554
-	public static function apply_taxes( EE_Line_Item $total_line_item ){
554
+	public static function apply_taxes(EE_Line_Item $total_line_item) {
555 555
 		/** @type EEM_Price $EEM_Price */
556
-		$EEM_Price = EE_Registry::instance()->load_model( 'Price' );
556
+		$EEM_Price = EE_Registry::instance()->load_model('Price');
557 557
 		// get array of taxes via Price Model
558 558
 		$ordered_taxes = $EEM_Price->get_all_prices_that_are_taxes();
559
-		ksort( $ordered_taxes );
560
-		$taxes_line_item = self::get_taxes_subtotal( $total_line_item );
559
+		ksort($ordered_taxes);
560
+		$taxes_line_item = self::get_taxes_subtotal($total_line_item);
561 561
 		//just to be safe, remove its old tax line items
562 562
 		$taxes_line_item->delete_children_line_items();
563 563
 		//loop thru taxes
564
-		foreach ( $ordered_taxes as $order => $taxes ) {
565
-			foreach ( $taxes as $tax ) {
566
-				if ( $tax instanceof EE_Price ) {
564
+		foreach ($ordered_taxes as $order => $taxes) {
565
+			foreach ($taxes as $tax) {
566
+				if ($tax instanceof EE_Price) {
567 567
 					$tax_line_item = EE_Line_Item::new_instance(
568 568
 						array(
569 569
 							'LIN_name'       => $tax->name(),
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
 						'FHEE__EEH_Line_Item__apply_taxes__tax_line_item',
582 582
 						$tax_line_item
583 583
 					);
584
-					$taxes_line_item->add_child_line_item( $tax_line_item );
584
+					$taxes_line_item->add_child_line_item($tax_line_item);
585 585
 				}
586 586
 			}
587 587
 		}
@@ -596,10 +596,10 @@  discard block
 block discarded – undo
596 596
 	 * @param EE_Line_Item $total_line_item of type EEM_Line_Item::type_total
597 597
 	 * @return float
598 598
 	 */
599
-	public static function ensure_taxes_applied( $total_line_item ){
600
-		$taxes_subtotal = self::get_taxes_subtotal( $total_line_item );
601
-		if( ! $taxes_subtotal->children()){
602
-			self::apply_taxes( $total_line_item );
599
+	public static function ensure_taxes_applied($total_line_item) {
600
+		$taxes_subtotal = self::get_taxes_subtotal($total_line_item);
601
+		if ( ! $taxes_subtotal->children()) {
602
+			self::apply_taxes($total_line_item);
603 603
 		}
604 604
 		return $taxes_subtotal->total();
605 605
 	}
@@ -612,16 +612,16 @@  discard block
 block discarded – undo
612 612
 	 * @param EE_Line_Item $parent_line_item
613 613
 	 * @return bool
614 614
 	 */
615
-	public static function delete_all_child_items( EE_Line_Item $parent_line_item ) {
615
+	public static function delete_all_child_items(EE_Line_Item $parent_line_item) {
616 616
 		$deleted = 0;
617
-		foreach ( $parent_line_item->children() as $child_line_item ) {
618
-			if ( $child_line_item instanceof EE_Line_Item ) {
619
-				$deleted += EEH_Line_Item::delete_all_child_items( $child_line_item );
620
-				if ( $child_line_item->ID() ) {
617
+		foreach ($parent_line_item->children() as $child_line_item) {
618
+			if ($child_line_item instanceof EE_Line_Item) {
619
+				$deleted += EEH_Line_Item::delete_all_child_items($child_line_item);
620
+				if ($child_line_item->ID()) {
621 621
 					$child_line_item->delete();
622
-					unset( $child_line_item );
622
+					unset($child_line_item);
623 623
 				} else {
624
-					$parent_line_item->delete_child_line_item( $child_line_item->code() );
624
+					$parent_line_item->delete_child_line_item($child_line_item->code());
625 625
 				}
626 626
 				$deleted++;
627 627
 			}
@@ -643,25 +643,25 @@  discard block
 block discarded – undo
643 643
 	 * @param array|bool|string $line_item_codes
644 644
 	 * @return int number of items successfully removed
645 645
 	 */
646
-	public static function delete_items( EE_Line_Item $total_line_item, $line_item_codes = FALSE ) {
646
+	public static function delete_items(EE_Line_Item $total_line_item, $line_item_codes = FALSE) {
647 647
 
648
-		if( $total_line_item->type() != EEM_Line_Item::type_total ){
649
-			EE_Error::doing_it_wrong('EEH_Line_Item::delete_items', __( 'This static method should only be called with a TOTAL line item, otherwise we won\'t recalculate the totals correctly', 'event_espresso' ), '4.6.18' );
648
+		if ($total_line_item->type() != EEM_Line_Item::type_total) {
649
+			EE_Error::doing_it_wrong('EEH_Line_Item::delete_items', __('This static method should only be called with a TOTAL line item, otherwise we won\'t recalculate the totals correctly', 'event_espresso'), '4.6.18');
650 650
 		}
651
-		do_action( 'AHEE_log', __FILE__, __FUNCTION__, '' );
651
+		do_action('AHEE_log', __FILE__, __FUNCTION__, '');
652 652
 
653 653
 		// check if only a single line_item_id was passed
654
-		if ( ! empty( $line_item_codes ) && ! is_array( $line_item_codes )) {
654
+		if ( ! empty($line_item_codes) && ! is_array($line_item_codes)) {
655 655
 			// place single line_item_id in an array to appear as multiple line_item_ids
656
-			$line_item_codes = array ( $line_item_codes );
656
+			$line_item_codes = array($line_item_codes);
657 657
 		}
658 658
 		$removals = 0;
659 659
 		// cycle thru line_item_ids
660
-		foreach ( $line_item_codes as $line_item_id ) {
660
+		foreach ($line_item_codes as $line_item_id) {
661 661
 			$removals += $total_line_item->delete_child_line_item($line_item_id);
662 662
 		}
663 663
 
664
-		if ( $removals > 0 ) {
664
+		if ($removals > 0) {
665 665
 			$total_line_item->recalculate_taxes_and_tax_total();
666 666
 			return $removals;
667 667
 		} else {
@@ -684,32 +684,32 @@  discard block
 block discarded – undo
684 684
 	 *                                           $amount will be added onto it; otherwise will simply set the taxes to match $amount
685 685
 	 * @return EE_Line_Item the new tax line item created
686 686
 	 */
687
-	public static function set_total_tax_to( EE_Line_Item $total_line_item, $amount, $name = NULL, $description = NULL, $code = NULL, $add_to_existing_line_item = false ){
688
-            $tax_subtotal = self::get_taxes_subtotal( $total_line_item );
687
+	public static function set_total_tax_to(EE_Line_Item $total_line_item, $amount, $name = NULL, $description = NULL, $code = NULL, $add_to_existing_line_item = false) {
688
+            $tax_subtotal = self::get_taxes_subtotal($total_line_item);
689 689
             $taxable_total = $total_line_item->taxable_total();
690 690
 
691
-            if( $add_to_existing_line_item ) {
692
-                $new_tax = $tax_subtotal->get_child_line_item( $code );
693
-                EEM_Line_Item::instance()->delete( array( array( 'LIN_code' => array( '!=', $code ), 'LIN_parent' => $tax_subtotal->ID() ) ) );
691
+            if ($add_to_existing_line_item) {
692
+                $new_tax = $tax_subtotal->get_child_line_item($code);
693
+                EEM_Line_Item::instance()->delete(array(array('LIN_code' => array('!=', $code), 'LIN_parent' => $tax_subtotal->ID())));
694 694
             } else {
695 695
                 $new_tax = null;
696 696
                 $tax_subtotal->delete_children_line_items();
697 697
             }
698
-            if( $new_tax ) {
699
-                $new_tax->set_total( $new_tax->total() + $amount );
700
-                $new_tax->set_percent( $taxable_total ? ( $new_tax->total() ) / $taxable_total * 100 : 0 );
698
+            if ($new_tax) {
699
+                $new_tax->set_total($new_tax->total() + $amount);
700
+                $new_tax->set_percent($taxable_total ? ($new_tax->total()) / $taxable_total * 100 : 0);
701 701
             } else {
702 702
                 //no existing tax item. Create it
703
-				$new_tax = EE_Line_Item::new_instance( array(
703
+				$new_tax = EE_Line_Item::new_instance(array(
704 704
 					'TXN_ID'      => $total_line_item->TXN_ID(),
705
-					'LIN_name'    => $name ? $name : __( 'Tax', 'event_espresso' ),
705
+					'LIN_name'    => $name ? $name : __('Tax', 'event_espresso'),
706 706
 					'LIN_desc'    => $description ? $description : '',
707
-					'LIN_percent' => $taxable_total ? ( $amount / $taxable_total * 100 ) : 0,
707
+					'LIN_percent' => $taxable_total ? ($amount / $taxable_total * 100) : 0,
708 708
 					'LIN_total'   => $amount,
709 709
 					'LIN_parent'  => $tax_subtotal->ID(),
710 710
 					'LIN_type'    => EEM_Line_Item::type_tax,
711 711
 					'LIN_code'    => $code
712
-				) );
712
+				));
713 713
 			}
714 714
 
715 715
             $new_tax = apply_filters(
@@ -718,7 +718,7 @@  discard block
 block discarded – undo
718 718
 				$total_line_item
719 719
             );
720 720
             $new_tax->save();
721
-            $tax_subtotal->set_total( $new_tax->total() );
721
+            $tax_subtotal->set_total($new_tax->total());
722 722
             $tax_subtotal->save();
723 723
             $total_line_item->recalculate_total_including_taxes();
724 724
             return $new_tax;
@@ -734,17 +734,17 @@  discard block
 block discarded – undo
734 734
 	 *  it will be whitelisted (ie, except from becoming taxable)
735 735
 	 * @param boolean $taxable
736 736
 	 */
737
-	public static function set_line_items_taxable( EE_Line_Item $line_item, $taxable = true, $code_substring_for_whitelist = null ) {
738
-		if( $code_substring_for_whitelist !== null ) {
739
-			$whitelisted = strpos( $line_item->code(), $code_substring_for_whitelist ) !== false ? true : false;
737
+	public static function set_line_items_taxable(EE_Line_Item $line_item, $taxable = true, $code_substring_for_whitelist = null) {
738
+		if ($code_substring_for_whitelist !== null) {
739
+			$whitelisted = strpos($line_item->code(), $code_substring_for_whitelist) !== false ? true : false;
740 740
 		} else {
741 741
 			$whitelisted = false;
742 742
 		}
743
-		if( $line_item->is_line_item() && ! $whitelisted ) {
744
-			$line_item->set_is_taxable( $taxable );
743
+		if ($line_item->is_line_item() && ! $whitelisted) {
744
+			$line_item->set_is_taxable($taxable);
745 745
 		}
746
-		foreach( $line_item->children() as $child_line_item ) {
747
-			EEH_Line_Item::set_line_items_taxable( $child_line_item, $taxable, $code_substring_for_whitelist );
746
+		foreach ($line_item->children() as $child_line_item) {
747
+			EEH_Line_Item::set_line_items_taxable($child_line_item, $taxable, $code_substring_for_whitelist);
748 748
 		}
749 749
 	}
750 750
 
@@ -757,8 +757,8 @@  discard block
 block discarded – undo
757 757
 	 * @param \EE_Line_Item $parent_line_item - the line item to find descendants of
758 758
 	 * @return EE_Line_Item[]
759 759
 	 */
760
-	public static function get_event_subtotals( EE_Line_Item $parent_line_item ) {
761
-		return self::get_subtotals_of_object_type( $parent_line_item, 'Event' );
760
+	public static function get_event_subtotals(EE_Line_Item $parent_line_item) {
761
+		return self::get_subtotals_of_object_type($parent_line_item, 'Event');
762 762
 	}
763 763
 
764 764
 
@@ -771,8 +771,8 @@  discard block
 block discarded – undo
771 771
 	 * @param string $obj_type
772 772
 	 * @return EE_Line_Item[]
773 773
 	 */
774
-	public static function get_subtotals_of_object_type( EE_Line_Item $parent_line_item, $obj_type = '' ) {
775
-		return self::_get_descendants_by_type_and_object_type( $parent_line_item, EEM_Line_Item::type_sub_total, $obj_type );
774
+	public static function get_subtotals_of_object_type(EE_Line_Item $parent_line_item, $obj_type = '') {
775
+		return self::_get_descendants_by_type_and_object_type($parent_line_item, EEM_Line_Item::type_sub_total, $obj_type);
776 776
 	}
777 777
 
778 778
 
@@ -784,8 +784,8 @@  discard block
 block discarded – undo
784 784
 	 * @param \EE_Line_Item $parent_line_item - the line item to find descendants of
785 785
 	 * @return EE_Line_Item[]
786 786
 	 */
787
-	public static function get_ticket_line_items( EE_Line_Item $parent_line_item ) {
788
-		return self::get_line_items_of_object_type( $parent_line_item, 'Ticket' );
787
+	public static function get_ticket_line_items(EE_Line_Item $parent_line_item) {
788
+		return self::get_line_items_of_object_type($parent_line_item, 'Ticket');
789 789
 	}
790 790
 
791 791
 
@@ -798,8 +798,8 @@  discard block
 block discarded – undo
798 798
 	 * @param string $obj_type
799 799
 	 * @return EE_Line_Item[]
800 800
 	 */
801
-	public static function get_line_items_of_object_type( EE_Line_Item $parent_line_item, $obj_type = '' ) {
802
-		return self::_get_descendants_by_type_and_object_type( $parent_line_item, EEM_Line_Item::type_line_item, $obj_type );
801
+	public static function get_line_items_of_object_type(EE_Line_Item $parent_line_item, $obj_type = '') {
802
+		return self::_get_descendants_by_type_and_object_type($parent_line_item, EEM_Line_Item::type_line_item, $obj_type);
803 803
 	}
804 804
 
805 805
 
@@ -810,8 +810,8 @@  discard block
 block discarded – undo
810 810
 	 * @param \EE_Line_Item $parent_line_item - the line item to find descendants of
811 811
 	 * @return EE_Line_Item[]
812 812
 	 */
813
-	public static function get_tax_descendants( EE_Line_Item $parent_line_item ) {
814
-		return EEH_Line_Item::get_descendants_of_type( $parent_line_item, EEM_Line_Item::type_tax );
813
+	public static function get_tax_descendants(EE_Line_Item $parent_line_item) {
814
+		return EEH_Line_Item::get_descendants_of_type($parent_line_item, EEM_Line_Item::type_tax);
815 815
 	}
816 816
 
817 817
 
@@ -822,8 +822,8 @@  discard block
 block discarded – undo
822 822
 	 * @param \EE_Line_Item $parent_line_item - the line item to find descendants of
823 823
 	 * @return EE_Line_Item[]
824 824
 	 */
825
-	public static function get_line_item_descendants( EE_Line_Item $parent_line_item ) {
826
-		return EEH_Line_Item::get_descendants_of_type( $parent_line_item, EEM_Line_Item::type_line_item );
825
+	public static function get_line_item_descendants(EE_Line_Item $parent_line_item) {
826
+		return EEH_Line_Item::get_descendants_of_type($parent_line_item, EEM_Line_Item::type_line_item);
827 827
 	}
828 828
 
829 829
 
@@ -836,8 +836,8 @@  discard block
 block discarded – undo
836 836
 	 * @param string $line_item_type one of the EEM_Line_Item constants
837 837
 	 * @return EE_Line_Item[]
838 838
 	 */
839
-	public static function get_descendants_of_type( EE_Line_Item $parent_line_item, $line_item_type ) {
840
-		return self::_get_descendants_by_type_and_object_type( $parent_line_item, $line_item_type, NULL );
839
+	public static function get_descendants_of_type(EE_Line_Item $parent_line_item, $line_item_type) {
840
+		return self::_get_descendants_by_type_and_object_type($parent_line_item, $line_item_type, NULL);
841 841
 	}
842 842
 
843 843
 
@@ -850,15 +850,15 @@  discard block
 block discarded – undo
850 850
 	 * @param string | NULL $obj_type object model class name (minus prefix) or NULL to ignore object type when searching
851 851
 	 * @return EE_Line_Item[]
852 852
 	 */
853
-	protected static function _get_descendants_by_type_and_object_type( EE_Line_Item $parent_line_item, $line_item_type, $obj_type = NULL ) {
853
+	protected static function _get_descendants_by_type_and_object_type(EE_Line_Item $parent_line_item, $line_item_type, $obj_type = NULL) {
854 854
 		$objects = array();
855
-		foreach ( $parent_line_item->children() as $child_line_item ) {
856
-			if ( $child_line_item instanceof EE_Line_Item ) {
857
-				if ( $child_line_item->type() == $line_item_type && ( $child_line_item->OBJ_type() == $obj_type || $obj_type === NULL )) {
855
+		foreach ($parent_line_item->children() as $child_line_item) {
856
+			if ($child_line_item instanceof EE_Line_Item) {
857
+				if ($child_line_item->type() == $line_item_type && ($child_line_item->OBJ_type() == $obj_type || $obj_type === NULL)) {
858 858
 					$objects[] = $child_line_item;
859 859
 				} else {
860 860
 					//go-through-all-its children looking for more matches
861
-					$objects = array_merge( $objects, self::_get_descendants_by_type_and_object_type( $child_line_item, $line_item_type, $obj_type ));
861
+					$objects = array_merge($objects, self::_get_descendants_by_type_and_object_type($child_line_item, $line_item_type, $obj_type));
862 862
 				}
863 863
 			}
864 864
 		}
@@ -876,8 +876,8 @@  discard block
 block discarded – undo
876 876
 	 * @param array $OBJ_IDs array of OBJ_IDs
877 877
 	 * @return EE_Line_Item[]
878 878
 	 */
879
-	public static function get_line_items_by_object_type_and_IDs( EE_Line_Item $parent_line_item, $OBJ_type = '', $OBJ_IDs = array() ) {
880
-		return self::_get_descendants_by_object_type_and_object_ID( $parent_line_item, $OBJ_type, $OBJ_IDs );
879
+	public static function get_line_items_by_object_type_and_IDs(EE_Line_Item $parent_line_item, $OBJ_type = '', $OBJ_IDs = array()) {
880
+		return self::_get_descendants_by_object_type_and_object_ID($parent_line_item, $OBJ_type, $OBJ_IDs);
881 881
 	}
882 882
 
883 883
 
@@ -890,15 +890,15 @@  discard block
 block discarded – undo
890 890
 	 * @param array $OBJ_IDs array of OBJ_IDs
891 891
 	 * @return EE_Line_Item[]
892 892
 	 */
893
-	protected static function _get_descendants_by_object_type_and_object_ID( EE_Line_Item $parent_line_item, $OBJ_type, $OBJ_IDs ) {
893
+	protected static function _get_descendants_by_object_type_and_object_ID(EE_Line_Item $parent_line_item, $OBJ_type, $OBJ_IDs) {
894 894
 		$objects = array();
895
-		foreach ( $parent_line_item->children() as $child_line_item ) {
896
-			if ( $child_line_item instanceof EE_Line_Item ) {
897
-				if ( is_array( $OBJ_IDs ) && $child_line_item->OBJ_type() == $OBJ_type && in_array( $child_line_item->OBJ_ID(), $OBJ_IDs )) {
895
+		foreach ($parent_line_item->children() as $child_line_item) {
896
+			if ($child_line_item instanceof EE_Line_Item) {
897
+				if (is_array($OBJ_IDs) && $child_line_item->OBJ_type() == $OBJ_type && in_array($child_line_item->OBJ_ID(), $OBJ_IDs)) {
898 898
 					$objects[] = $child_line_item;
899 899
 				} else {
900 900
 					//go-through-all-its children looking for more matches
901
-					$objects = array_merge( $objects, self::_get_descendants_by_object_type_and_object_ID( $child_line_item, $OBJ_type, $OBJ_IDs ));
901
+					$objects = array_merge($objects, self::_get_descendants_by_object_type_and_object_ID($child_line_item, $OBJ_type, $OBJ_IDs));
902 902
 				}
903 903
 			}
904 904
 		}
@@ -916,8 +916,8 @@  discard block
 block discarded – undo
916 916
 	 * @param string $type like one of the EEM_Line_Item::type_*
917 917
 	 * @return EE_Line_Item
918 918
 	 */
919
-	public static function get_nearest_descendant_of_type( EE_Line_Item $parent_line_item, $type ) {
920
-		return self::_get_nearest_descendant( $parent_line_item, 'LIN_type' , $type );
919
+	public static function get_nearest_descendant_of_type(EE_Line_Item $parent_line_item, $type) {
920
+		return self::_get_nearest_descendant($parent_line_item, 'LIN_type', $type);
921 921
 	}
922 922
 
923 923
 
@@ -930,8 +930,8 @@  discard block
 block discarded – undo
930 930
 	 * @param string $code any value used for LIN_code
931 931
 	 * @return EE_Line_Item
932 932
 	 */
933
-	public static function get_nearest_descendant_having_code( EE_Line_Item $parent_line_item, $code ) {
934
-		return self::_get_nearest_descendant( $parent_line_item, 'LIN_code' , $code );
933
+	public static function get_nearest_descendant_having_code(EE_Line_Item $parent_line_item, $code) {
934
+		return self::_get_nearest_descendant($parent_line_item, 'LIN_code', $code);
935 935
 	}
936 936
 
937 937
 
@@ -944,15 +944,15 @@  discard block
 block discarded – undo
944 944
 	 * @param string $value any value stored in $search_field
945 945
 	 * @return EE_Line_Item
946 946
 	 */
947
-	protected static function _get_nearest_descendant( EE_Line_Item $parent_line_item, $search_field, $value ) {
948
-		foreach( $parent_line_item->children() as $child ){
949
-			if ( $child->get( $search_field ) == $value ){
947
+	protected static function _get_nearest_descendant(EE_Line_Item $parent_line_item, $search_field, $value) {
948
+		foreach ($parent_line_item->children() as $child) {
949
+			if ($child->get($search_field) == $value) {
950 950
 				return $child;
951 951
 			}
952 952
 		}
953
-		foreach( $parent_line_item->children() as $child ){
954
-			$descendant_found = self::_get_nearest_descendant( $child, $search_field, $value );
955
-			if ( $descendant_found ){
953
+		foreach ($parent_line_item->children() as $child) {
954
+			$descendant_found = self::_get_nearest_descendant($child, $search_field, $value);
955
+			if ($descendant_found) {
956 956
 				return $descendant_found;
957 957
 			}
958 958
 		}
@@ -968,22 +968,22 @@  discard block
 block discarded – undo
968 968
 	 * @param int $indentation
969 969
 	 * @return void
970 970
 	 */
971
-	public static function visualize( EE_Line_Item $line_item, $indentation = 0 ){
971
+	public static function visualize(EE_Line_Item $line_item, $indentation = 0) {
972 972
 		echo "\n<br />";
973
-		for( $i = 0; $i < $indentation; $i++ ){
973
+		for ($i = 0; $i < $indentation; $i++) {
974 974
 			echo " - ";
975 975
 		}
976
-		if( $line_item->is_percent() ) {
977
-			$breakdown = $line_item->percent() . '%';
976
+		if ($line_item->is_percent()) {
977
+			$breakdown = $line_item->percent().'%';
978 978
 		} else {
979
-			$breakdown = '$' . $line_item->unit_price() . "x" . $line_item->quantity();
979
+			$breakdown = '$'.$line_item->unit_price()."x".$line_item->quantity();
980 980
 		}
981
-		echo $line_item->name() . "( " . $line_item->ID() . " ) : " . $line_item->type() . " $" . $line_item->total() . "(" . $breakdown . ")";
982
-		if( $line_item->is_taxable() ){
981
+		echo $line_item->name()."( ".$line_item->ID()." ) : ".$line_item->type()." $".$line_item->total()."(".$breakdown.")";
982
+		if ($line_item->is_taxable()) {
983 983
 			echo "  * taxable";
984 984
 		}
985
-		if( $line_item->children() ){
986
-			foreach($line_item->children() as $child){
985
+		if ($line_item->children()) {
986
+			foreach ($line_item->children() as $child) {
987 987
 				self::visualize($child, $indentation + 1);
988 988
 			}
989 989
 		}
@@ -1024,88 +1024,88 @@  discard block
 block discarded – undo
1024 1024
 	 *                                          is theirs, which can be done with
1025 1025
 	 *                                          `EEM_Line_Item::instance()->get_line_item_for_registration( $registration );`
1026 1026
 	 */
1027
-	public static function calculate_reg_final_prices_per_line_item( EE_Line_Item $line_item, $billable_ticket_quantities = array() ) {
1027
+	public static function calculate_reg_final_prices_per_line_item(EE_Line_Item $line_item, $billable_ticket_quantities = array()) {
1028 1028
 		//init running grand total if not already
1029
-		if ( ! isset( $running_totals[ 'total' ] ) ) {
1030
-			$running_totals[ 'total' ] = 0;
1029
+		if ( ! isset($running_totals['total'])) {
1030
+			$running_totals['total'] = 0;
1031 1031
 		}
1032
-		if( ! isset( $running_totals[ 'taxable' ] ) ) {
1033
-			$running_totals[ 'taxable' ] = array( 'total' => 0 );
1032
+		if ( ! isset($running_totals['taxable'])) {
1033
+			$running_totals['taxable'] = array('total' => 0);
1034 1034
 		}
1035
-		foreach ( $line_item->children() as $child_line_item ) {
1036
-			switch ( $child_line_item->type() ) {
1035
+		foreach ($line_item->children() as $child_line_item) {
1036
+			switch ($child_line_item->type()) {
1037 1037
 
1038 1038
 				case EEM_Line_Item::type_sub_total :
1039
-					$running_totals_from_subtotal = EEH_Line_Item::calculate_reg_final_prices_per_line_item( $child_line_item, $billable_ticket_quantities );
1039
+					$running_totals_from_subtotal = EEH_Line_Item::calculate_reg_final_prices_per_line_item($child_line_item, $billable_ticket_quantities);
1040 1040
 					//combine arrays but preserve numeric keys
1041
-					$running_totals = array_replace_recursive( $running_totals_from_subtotal, $running_totals );
1042
-					$running_totals[ 'total' ] += $running_totals_from_subtotal[ 'total' ];
1043
-					$running_totals[ 'taxable'][ 'total' ] += $running_totals_from_subtotal[ 'taxable' ][ 'total' ];
1041
+					$running_totals = array_replace_recursive($running_totals_from_subtotal, $running_totals);
1042
+					$running_totals['total'] += $running_totals_from_subtotal['total'];
1043
+					$running_totals['taxable']['total'] += $running_totals_from_subtotal['taxable']['total'];
1044 1044
 					break;
1045 1045
 
1046 1046
 				case EEM_Line_Item::type_tax_sub_total :
1047 1047
 
1048 1048
 					//find how much the taxes percentage is
1049
-					if ( $child_line_item->percent() != 0 ) {
1049
+					if ($child_line_item->percent() != 0) {
1050 1050
 						$tax_percent_decimal = $child_line_item->percent() / 100;
1051 1051
 					} else {
1052 1052
 						$tax_percent_decimal = EE_Taxes::get_total_taxes_percentage() / 100;
1053 1053
 					}
1054 1054
 					//and apply to all the taxable totals, and add to the pretax totals
1055
-					foreach ( $running_totals as $line_item_id => $this_running_total ) {
1055
+					foreach ($running_totals as $line_item_id => $this_running_total) {
1056 1056
 						//"total" and "taxable" array key is an exception
1057
-						if ( $line_item_id === 'taxable' ) {
1057
+						if ($line_item_id === 'taxable') {
1058 1058
 							continue;
1059 1059
 						}
1060
-						$taxable_total = $running_totals[ 'taxable' ][ $line_item_id ];
1061
-						$running_totals[ $line_item_id ] += ( $taxable_total * $tax_percent_decimal );
1060
+						$taxable_total = $running_totals['taxable'][$line_item_id];
1061
+						$running_totals[$line_item_id] += ($taxable_total * $tax_percent_decimal);
1062 1062
 					}
1063 1063
 					break;
1064 1064
 
1065 1065
 				case EEM_Line_Item::type_line_item :
1066 1066
 
1067 1067
 					// ticket line items or ????
1068
-					if ( $child_line_item->OBJ_type() === 'Ticket' ) {
1068
+					if ($child_line_item->OBJ_type() === 'Ticket') {
1069 1069
 						// kk it's a ticket
1070
-						if ( isset( $running_totals[ $child_line_item->ID() ] ) ) {
1070
+						if (isset($running_totals[$child_line_item->ID()])) {
1071 1071
 							//huh? that shouldn't happen.
1072
-							$running_totals[ 'total' ] += $child_line_item->total();
1072
+							$running_totals['total'] += $child_line_item->total();
1073 1073
 						} else {
1074 1074
 							//its not in our running totals yet. great.
1075
-							if ( $child_line_item->is_taxable() ) {
1075
+							if ($child_line_item->is_taxable()) {
1076 1076
 								$taxable_amount = $child_line_item->unit_price();
1077 1077
 							} else {
1078 1078
 								$taxable_amount = 0;
1079 1079
 							}
1080 1080
 							// are we only calculating totals for some tickets?
1081
-							if ( isset( $billable_ticket_quantities[ $child_line_item->OBJ_ID() ] ) ) {
1082
-								$quantity = $billable_ticket_quantities[ $child_line_item->OBJ_ID() ];
1083
-								$running_totals[ $child_line_item->ID() ] = $quantity ? $child_line_item->unit_price() : 0;
1084
-								$running_totals[ 'taxable' ][ $child_line_item->ID() ] = $quantity ? $taxable_amount : 0;
1081
+							if (isset($billable_ticket_quantities[$child_line_item->OBJ_ID()])) {
1082
+								$quantity = $billable_ticket_quantities[$child_line_item->OBJ_ID()];
1083
+								$running_totals[$child_line_item->ID()] = $quantity ? $child_line_item->unit_price() : 0;
1084
+								$running_totals['taxable'][$child_line_item->ID()] = $quantity ? $taxable_amount : 0;
1085 1085
 							} else {
1086 1086
 								$quantity = $child_line_item->quantity();
1087
-								$running_totals[ $child_line_item->ID() ] = $child_line_item->unit_price();
1088
-								$running_totals[ 'taxable' ][ $child_line_item->ID() ] = $taxable_amount;
1087
+								$running_totals[$child_line_item->ID()] = $child_line_item->unit_price();
1088
+								$running_totals['taxable'][$child_line_item->ID()] = $taxable_amount;
1089 1089
 							}
1090
-							$running_totals[ 'taxable' ][ 'total' ] += $taxable_amount * $quantity;
1091
-							$running_totals[ 'total' ] += $child_line_item->unit_price() * $quantity;
1090
+							$running_totals['taxable']['total'] += $taxable_amount * $quantity;
1091
+							$running_totals['total'] += $child_line_item->unit_price() * $quantity;
1092 1092
 						}
1093 1093
 					} else {
1094 1094
 						// it's some other type of item added to the cart
1095 1095
 						// it should affect the running totals
1096 1096
 						// basically we want to convert it into a PERCENT modifier. Because
1097 1097
 						// more clearly affect all registration's final price equally
1098
-						$line_items_percent_of_running_total = $running_totals[ 'total' ] > 0 ? ( $child_line_item->total() / $running_totals[ 'total' ] ) + 1 : 1;
1099
-						foreach ( $running_totals as $line_item_id => $this_running_total ) {
1098
+						$line_items_percent_of_running_total = $running_totals['total'] > 0 ? ($child_line_item->total() / $running_totals['total']) + 1 : 1;
1099
+						foreach ($running_totals as $line_item_id => $this_running_total) {
1100 1100
 							//the "taxable" array key is an exception
1101
-							if ( $line_item_id === 'taxable' ) {
1101
+							if ($line_item_id === 'taxable') {
1102 1102
 								continue;
1103 1103
 							}
1104 1104
 							// update the running totals
1105 1105
 							// yes this actually even works for the running grand total!
1106
-							$running_totals[ $line_item_id ] = $line_items_percent_of_running_total * $this_running_total;
1107
-							if ( $child_line_item->is_taxable() ) {
1108
-								$running_totals[ 'taxable' ][ $line_item_id ] = $line_items_percent_of_running_total * $running_totals[ 'taxable' ][ $line_item_id ];
1106
+							$running_totals[$line_item_id] = $line_items_percent_of_running_total * $this_running_total;
1107
+							if ($child_line_item->is_taxable()) {
1108
+								$running_totals['taxable'][$line_item_id] = $line_items_percent_of_running_total * $running_totals['taxable'][$line_item_id];
1109 1109
 							}
1110 1110
 						}
1111 1111
 					}
@@ -1124,15 +1124,15 @@  discard block
 block discarded – undo
1124 1124
 	 * @param EE_Registration[] $registrations
1125 1125
 	 * @return \EE_Line_Item
1126 1126
 	 */
1127
-	public static function billable_line_item_tree( EE_Line_Item $line_item, $registrations ) {
1128
-		$copy_li = EEH_Line_Item::billable_line_item( $line_item, $registrations );
1129
-		foreach ( $line_item->children() as $child_li ) {
1130
-			$copy_li->add_child_line_item( EEH_Line_Item::billable_line_item_tree( $child_li, $registrations ) );
1127
+	public static function billable_line_item_tree(EE_Line_Item $line_item, $registrations) {
1128
+		$copy_li = EEH_Line_Item::billable_line_item($line_item, $registrations);
1129
+		foreach ($line_item->children() as $child_li) {
1130
+			$copy_li->add_child_line_item(EEH_Line_Item::billable_line_item_tree($child_li, $registrations));
1131 1131
 		}
1132 1132
 		//if this is the grand total line item, make sure the totals all add up
1133 1133
 		//(we could have duplicated this logic AS we copied the line items, but
1134 1134
 		//it seems DRYer this way)
1135
-		if ( $copy_li->type() === EEM_Line_Item::type_total ) {
1135
+		if ($copy_li->type() === EEM_Line_Item::type_total) {
1136 1136
 			$copy_li->recalculate_total_including_taxes();
1137 1137
 		}
1138 1138
 		return $copy_li;
@@ -1147,26 +1147,26 @@  discard block
 block discarded – undo
1147 1147
 	 * @return EE_Line_Item
1148 1148
 	 * @param EE_Registration[] $registrations
1149 1149
 	 */
1150
-	public static function billable_line_item( EE_Line_Item $line_item, $registrations ) {
1150
+	public static function billable_line_item(EE_Line_Item $line_item, $registrations) {
1151 1151
 		$new_li_fields = $line_item->model_field_array();
1152
-		if ( $line_item->type() === EEM_Line_Item::type_line_item &&
1152
+		if ($line_item->type() === EEM_Line_Item::type_line_item &&
1153 1153
 			$line_item->OBJ_type() === 'Ticket'
1154 1154
 		) {
1155 1155
 			$count = 0;
1156
-			foreach ( $registrations as $registration ) {
1157
-				if ( $line_item->OBJ_ID() === $registration->ticket_ID() &&
1158
-					in_array( $registration->status_ID(), EEM_Registration::reg_statuses_that_allow_payment() )
1156
+			foreach ($registrations as $registration) {
1157
+				if ($line_item->OBJ_ID() === $registration->ticket_ID() &&
1158
+					in_array($registration->status_ID(), EEM_Registration::reg_statuses_that_allow_payment())
1159 1159
 				) {
1160 1160
 					$count++;
1161 1161
 				}
1162 1162
 			}
1163
-			$new_li_fields[ 'LIN_quantity' ] = $count;
1163
+			$new_li_fields['LIN_quantity'] = $count;
1164 1164
 		}
1165 1165
 		//don't set the total. We'll leave that up to the code that calculates it
1166
-		unset( $new_li_fields[ 'LIN_ID' ] );
1167
-		unset( $new_li_fields[ 'LIN_parent' ] );
1168
-		unset( $new_li_fields[ 'LIN_total' ] );
1169
-		return EE_Line_Item::new_instance( $new_li_fields );
1166
+		unset($new_li_fields['LIN_ID']);
1167
+		unset($new_li_fields['LIN_parent']);
1168
+		unset($new_li_fields['LIN_total']);
1169
+		return EE_Line_Item::new_instance($new_li_fields);
1170 1170
 	}
1171 1171
 
1172 1172
 
@@ -1178,19 +1178,19 @@  discard block
 block discarded – undo
1178 1178
 	 * @param EE_Line_Item $line_item |null
1179 1179
 	 * @return \EE_Line_Item|null
1180 1180
 	 */
1181
-	public static function non_empty_line_items( EE_Line_Item $line_item ) {
1182
-		$copied_li = EEH_Line_Item::non_empty_line_item( $line_item );
1183
-		if ( $copied_li === null ) {
1181
+	public static function non_empty_line_items(EE_Line_Item $line_item) {
1182
+		$copied_li = EEH_Line_Item::non_empty_line_item($line_item);
1183
+		if ($copied_li === null) {
1184 1184
 			return null;
1185 1185
 		}
1186 1186
 		//if this is an event subtotal, we want to only include it if it
1187 1187
 		//has a non-zero total and at least one ticket line item child
1188 1188
 		$ticket_children = 0;
1189
-		foreach ( $line_item->children() as $child_li ) {
1190
-			$child_li_copy = EEH_Line_Item::non_empty_line_items( $child_li );
1191
-			if ( $child_li_copy !== null ) {
1192
-				$copied_li->add_child_line_item( $child_li_copy );
1193
-				if ( $child_li_copy->type() === EEM_Line_Item::type_line_item &&
1189
+		foreach ($line_item->children() as $child_li) {
1190
+			$child_li_copy = EEH_Line_Item::non_empty_line_items($child_li);
1191
+			if ($child_li_copy !== null) {
1192
+				$copied_li->add_child_line_item($child_li_copy);
1193
+				if ($child_li_copy->type() === EEM_Line_Item::type_line_item &&
1194 1194
 					$child_li_copy->OBJ_type() === 'Ticket'
1195 1195
 				) {
1196 1196
 					$ticket_children++;
@@ -1199,7 +1199,7 @@  discard block
 block discarded – undo
1199 1199
 		}
1200 1200
 		//if this is an event subtotal with NO ticket children
1201 1201
 		//we basically want to ignore it
1202
-		if ( $line_item->type() === EEM_Line_Item::type_sub_total &&
1202
+		if ($line_item->type() === EEM_Line_Item::type_sub_total &&
1203 1203
 			$line_item->OBJ_type() === 'Event' &&
1204 1204
 			$ticket_children === 0 &&
1205 1205
 			$line_item->total() === 0
@@ -1217,8 +1217,8 @@  discard block
 block discarded – undo
1217 1217
 	 * @param EE_Line_Item      $line_item
1218 1218
 	 * @return EE_Line_Item
1219 1219
 	 */
1220
-	public static function non_empty_line_item( EE_Line_Item $line_item ) {
1221
-		if ( $line_item->type() === EEM_Line_Item::type_line_item &&
1220
+	public static function non_empty_line_item(EE_Line_Item $line_item) {
1221
+		if ($line_item->type() === EEM_Line_Item::type_line_item &&
1222 1222
 			$line_item->OBJ_type() === 'Ticket' &&
1223 1223
 			$line_item->quantity() == 0
1224 1224
 		) {
@@ -1226,9 +1226,9 @@  discard block
 block discarded – undo
1226 1226
 		}
1227 1227
 		$new_li_fields = $line_item->model_field_array();
1228 1228
 		//don't set the total. We'll leave that up to the code that calculates it
1229
-		unset( $new_li_fields[ 'LIN_ID' ] );
1230
-		unset( $new_li_fields[ 'LIN_parent' ] );
1231
-		return EE_Line_Item::new_instance( $new_li_fields );
1229
+		unset($new_li_fields['LIN_ID']);
1230
+		unset($new_li_fields['LIN_parent']);
1231
+		return EE_Line_Item::new_instance($new_li_fields);
1232 1232
 	}
1233 1233
 
1234 1234
 
@@ -1242,9 +1242,9 @@  discard block
 block discarded – undo
1242 1242
 	 * @param EE_Line_Item $total_line_item
1243 1243
 	 *	@return \EE_Line_Item
1244 1244
 	 */
1245
-	public static function get_items_subtotal( EE_Line_Item $total_line_item ){
1246
-		EE_Error::doing_it_wrong( 'EEH_Line_Item::get_items_subtotal()', __('Method replaced with EEH_Line_Item::get_pre_tax_subtotal()', 'event_espresso'), '4.6.0' );
1247
-		return self::get_pre_tax_subtotal( $total_line_item );
1245
+	public static function get_items_subtotal(EE_Line_Item $total_line_item) {
1246
+		EE_Error::doing_it_wrong('EEH_Line_Item::get_items_subtotal()', __('Method replaced with EEH_Line_Item::get_pre_tax_subtotal()', 'event_espresso'), '4.6.0');
1247
+		return self::get_pre_tax_subtotal($total_line_item);
1248 1248
 	}
1249 1249
 
1250 1250
 
@@ -1254,9 +1254,9 @@  discard block
 block discarded – undo
1254 1254
 	 * @param EE_Transaction $transaction
1255 1255
 	 *	@return \EE_Line_Item
1256 1256
 	 */
1257
-	public static function create_default_total_line_item( $transaction = NULL) {
1258
-		EE_Error::doing_it_wrong( 'EEH_Line_Item::create_default_total_line_item()', __('Method replaced with EEH_Line_Item::create_total_line_item()', 'event_espresso'), '4.6.0' );
1259
-		return self::create_total_line_item( $transaction );
1257
+	public static function create_default_total_line_item($transaction = NULL) {
1258
+		EE_Error::doing_it_wrong('EEH_Line_Item::create_default_total_line_item()', __('Method replaced with EEH_Line_Item::create_total_line_item()', 'event_espresso'), '4.6.0');
1259
+		return self::create_total_line_item($transaction);
1260 1260
 	}
1261 1261
 
1262 1262
 
@@ -1267,9 +1267,9 @@  discard block
 block discarded – undo
1267 1267
 	 * @param EE_Transaction $transaction
1268 1268
 	 *	@return \EE_Line_Item
1269 1269
 	 */
1270
-	public static function create_default_tickets_subtotal( EE_Line_Item $total_line_item, $transaction = NULL) {
1271
-		EE_Error::doing_it_wrong( 'EEH_Line_Item::create_default_tickets_subtotal()', __('Method replaced with EEH_Line_Item::create_pre_tax_subtotal()', 'event_espresso'), '4.6.0' );
1272
-		return self::create_pre_tax_subtotal( $total_line_item, $transaction );
1270
+	public static function create_default_tickets_subtotal(EE_Line_Item $total_line_item, $transaction = NULL) {
1271
+		EE_Error::doing_it_wrong('EEH_Line_Item::create_default_tickets_subtotal()', __('Method replaced with EEH_Line_Item::create_pre_tax_subtotal()', 'event_espresso'), '4.6.0');
1272
+		return self::create_pre_tax_subtotal($total_line_item, $transaction);
1273 1273
 	}
1274 1274
 
1275 1275
 
@@ -1280,9 +1280,9 @@  discard block
 block discarded – undo
1280 1280
 	 * @param EE_Transaction $transaction
1281 1281
 	 *	@return \EE_Line_Item
1282 1282
 	 */
1283
-	public static function create_default_taxes_subtotal( EE_Line_Item $total_line_item, $transaction = NULL) {
1284
-		EE_Error::doing_it_wrong( 'EEH_Line_Item::create_default_taxes_subtotal()', __('Method replaced with EEH_Line_Item::create_taxes_subtotal()', 'event_espresso'), '4.6.0' );
1285
-		return self::create_taxes_subtotal( $total_line_item, $transaction );
1283
+	public static function create_default_taxes_subtotal(EE_Line_Item $total_line_item, $transaction = NULL) {
1284
+		EE_Error::doing_it_wrong('EEH_Line_Item::create_default_taxes_subtotal()', __('Method replaced with EEH_Line_Item::create_taxes_subtotal()', 'event_espresso'), '4.6.0');
1285
+		return self::create_taxes_subtotal($total_line_item, $transaction);
1286 1286
 	}
1287 1287
 
1288 1288
 
@@ -1293,9 +1293,9 @@  discard block
 block discarded – undo
1293 1293
 	 * @param EE_Transaction $transaction
1294 1294
 	 *	@return \EE_Line_Item
1295 1295
 	 */
1296
-	public static function create_default_event_subtotal( EE_Line_Item $total_line_item, $transaction = NULL) {
1297
-		EE_Error::doing_it_wrong( 'EEH_Line_Item::create_default_event_subtotal()', __('Method replaced with EEH_Line_Item::create_event_subtotal()', 'event_espresso'), '4.6.0' );
1298
-		return self::create_event_subtotal( $total_line_item, $transaction );
1296
+	public static function create_default_event_subtotal(EE_Line_Item $total_line_item, $transaction = NULL) {
1297
+		EE_Error::doing_it_wrong('EEH_Line_Item::create_default_event_subtotal()', __('Method replaced with EEH_Line_Item::create_event_subtotal()', 'event_espresso'), '4.6.0');
1298
+		return self::create_event_subtotal($total_line_item, $transaction);
1299 1299
 	}
1300 1300
 
1301 1301
 
Please login to merge, or discard this patch.
Indentation   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -468,15 +468,15 @@  discard block
 block discarded – undo
468 468
 	}
469 469
 
470 470
 	/**
471
-	  * Given the grand total line item and a ticket, finds the event sub-total
472
-	  * line item the ticket's purchase should be added onto
473
-	  *
474
-	  * @access public
475
-	  * @param EE_Line_Item $grand_total the grand total line item
476
-	  * @param EE_Ticket $ticket
477
-	  * @throws \EE_Error
478
-	  * @return EE_Line_Item
479
-	  */
471
+	 * Given the grand total line item and a ticket, finds the event sub-total
472
+	 * line item the ticket's purchase should be added onto
473
+	 *
474
+	 * @access public
475
+	 * @param EE_Line_Item $grand_total the grand total line item
476
+	 * @param EE_Ticket $ticket
477
+	 * @throws \EE_Error
478
+	 * @return EE_Line_Item
479
+	 */
480 480
 	public static function get_event_line_item_for_ticket( EE_Line_Item $grand_total, EE_Ticket $ticket ) {
481 481
 		$first_datetime = $ticket->first_datetime();
482 482
 		if( ! $first_datetime instanceof EE_Datetime ){
@@ -685,21 +685,21 @@  discard block
 block discarded – undo
685 685
 	 * @return EE_Line_Item the new tax line item created
686 686
 	 */
687 687
 	public static function set_total_tax_to( EE_Line_Item $total_line_item, $amount, $name = NULL, $description = NULL, $code = NULL, $add_to_existing_line_item = false ){
688
-            $tax_subtotal = self::get_taxes_subtotal( $total_line_item );
689
-            $taxable_total = $total_line_item->taxable_total();
690
-
691
-            if( $add_to_existing_line_item ) {
692
-                $new_tax = $tax_subtotal->get_child_line_item( $code );
693
-                EEM_Line_Item::instance()->delete( array( array( 'LIN_code' => array( '!=', $code ), 'LIN_parent' => $tax_subtotal->ID() ) ) );
694
-            } else {
695
-                $new_tax = null;
696
-                $tax_subtotal->delete_children_line_items();
697
-            }
698
-            if( $new_tax ) {
699
-                $new_tax->set_total( $new_tax->total() + $amount );
700
-                $new_tax->set_percent( $taxable_total ? ( $new_tax->total() ) / $taxable_total * 100 : 0 );
701
-            } else {
702
-                //no existing tax item. Create it
688
+			$tax_subtotal = self::get_taxes_subtotal( $total_line_item );
689
+			$taxable_total = $total_line_item->taxable_total();
690
+
691
+			if( $add_to_existing_line_item ) {
692
+				$new_tax = $tax_subtotal->get_child_line_item( $code );
693
+				EEM_Line_Item::instance()->delete( array( array( 'LIN_code' => array( '!=', $code ), 'LIN_parent' => $tax_subtotal->ID() ) ) );
694
+			} else {
695
+				$new_tax = null;
696
+				$tax_subtotal->delete_children_line_items();
697
+			}
698
+			if( $new_tax ) {
699
+				$new_tax->set_total( $new_tax->total() + $amount );
700
+				$new_tax->set_percent( $taxable_total ? ( $new_tax->total() ) / $taxable_total * 100 : 0 );
701
+			} else {
702
+				//no existing tax item. Create it
703 703
 				$new_tax = EE_Line_Item::new_instance( array(
704 704
 					'TXN_ID'      => $total_line_item->TXN_ID(),
705 705
 					'LIN_name'    => $name ? $name : __( 'Tax', 'event_espresso' ),
@@ -712,16 +712,16 @@  discard block
 block discarded – undo
712 712
 				) );
713 713
 			}
714 714
 
715
-            $new_tax = apply_filters(
715
+			$new_tax = apply_filters(
716 716
 				'FHEE__EEH_Line_Item__set_total_tax_to__new_tax_subtotal',
717 717
 				$new_tax,
718 718
 				$total_line_item
719
-            );
720
-            $new_tax->save();
721
-            $tax_subtotal->set_total( $new_tax->total() );
722
-            $tax_subtotal->save();
723
-            $total_line_item->recalculate_total_including_taxes();
724
-            return $new_tax;
719
+			);
720
+			$new_tax->save();
721
+			$tax_subtotal->set_total( $new_tax->total() );
722
+			$tax_subtotal->save();
723
+			$total_line_item->recalculate_total_including_taxes();
724
+			return $new_tax;
725 725
 	}
726 726
 
727 727
 
Please login to merge, or discard this patch.
payment_methods/Paypal_Standard/EE_Paypal_Standard_Form.form.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
3
-	exit( 'No direct script access allowed' );
2
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
3
+	exit('No direct script access allowed');
4 4
 }
5 5
 
6 6
 /**
@@ -21,37 +21,37 @@  discard block
 block discarded – undo
21 21
 	/**
22 22
 	 * @param EE_PMT_Paypal_Standard $payment_method_type
23 23
 	 */
24
-	public function __construct( $payment_method_type ){
24
+	public function __construct($payment_method_type) {
25 25
 		parent::__construct(
26 26
 			array(
27 27
 				'payment_method_type'          => $payment_method_type,
28 28
 				'extra_meta_inputs'            => array(
29
-					'paypal_id'        => new EE_Text_Input( array(
30
-						'html_label_text' => sprintf( __( "Paypal Email %s", 'event_espresso' ), $payment_method_type->get_help_tab_link() ),
31
-						'html_help_text'  => __( "Typically [email protected]", 'event_espresso' ),
29
+					'paypal_id'        => new EE_Text_Input(array(
30
+						'html_label_text' => sprintf(__("Paypal Email %s", 'event_espresso'), $payment_method_type->get_help_tab_link()),
31
+						'html_help_text'  => __("Typically [email protected]", 'event_espresso'),
32 32
 						'required'        => true
33
-					) ),
34
-					'image_url'        => new EE_Admin_File_Uploader_Input( array(
35
-						'html_help_text'  => __( "Used for your business/personal logo on the PayPal page", 'event_espresso' ),
36
-						'html_label_text' => __( 'Image URL', 'event_espresso' )
37
-					) ),
38
-					'paypal_taxes'     => new EE_Yes_No_Input( array(
39
-						'html_label_text' => sprintf( __( 'Paypal Calculates Taxes %s', 'event_espresso' ), $payment_method_type->get_help_tab_link() ),
40
-						'html_help_text'  => __( 'Whether Paypal should add taxes to the order', 'event_espresso' ),
33
+					)),
34
+					'image_url'        => new EE_Admin_File_Uploader_Input(array(
35
+						'html_help_text'  => __("Used for your business/personal logo on the PayPal page", 'event_espresso'),
36
+						'html_label_text' => __('Image URL', 'event_espresso')
37
+					)),
38
+					'paypal_taxes'     => new EE_Yes_No_Input(array(
39
+						'html_label_text' => sprintf(__('Paypal Calculates Taxes %s', 'event_espresso'), $payment_method_type->get_help_tab_link()),
40
+						'html_help_text'  => __('Whether Paypal should add taxes to the order', 'event_espresso'),
41 41
 						'default'         => false
42
-					) ),
43
-					'paypal_shipping'  => new EE_Yes_No_Input( array(
44
-						'html_label_text' => sprintf( __( 'Paypal Calculates Shipping %s', 'event_espresso' ), $payment_method_type->get_help_tab_link() ),
45
-						'html_help_text'  => __( 'Whether Paypal should add shipping surcharges', 'event_espresso' ),
42
+					)),
43
+					'paypal_shipping'  => new EE_Yes_No_Input(array(
44
+						'html_label_text' => sprintf(__('Paypal Calculates Shipping %s', 'event_espresso'), $payment_method_type->get_help_tab_link()),
45
+						'html_help_text'  => __('Whether Paypal should add shipping surcharges', 'event_espresso'),
46 46
 						'default'         => false
47
-					) ),
48
-					'shipping_details' => new EE_Select_Input( array(
49
-						EE_PMT_Paypal_Standard::shipping_info_none     => __( "Do not prompt for an address", 'event_espresso' ),
50
-						EE_PMT_Paypal_Standard::shipping_info_optional => __( "Prompt for an address, but do not require it", 'event_espresso' ),
51
-						EE_PMT_Paypal_Standard::shipping_info_required => __( "Prompt for an address, and require it", 'event_espresso' )
52
-					) ),
47
+					)),
48
+					'shipping_details' => new EE_Select_Input(array(
49
+						EE_PMT_Paypal_Standard::shipping_info_none     => __("Do not prompt for an address", 'event_espresso'),
50
+						EE_PMT_Paypal_Standard::shipping_info_optional => __("Prompt for an address, but do not require it", 'event_espresso'),
51
+						EE_PMT_Paypal_Standard::shipping_info_required => __("Prompt for an address, and require it", 'event_espresso')
52
+					)),
53 53
 				),
54
-				'before_form_content_template' => $payment_method_type->file_folder() . DS . 'templates' . DS . 'paypal_standard_settings_before_form.template.php',
54
+				'before_form_content_template' => $payment_method_type->file_folder().DS.'templates'.DS.'paypal_standard_settings_before_form.template.php',
55 55
 			)
56 56
 		);
57 57
 	}
@@ -61,28 +61,28 @@  discard block
 block discarded – undo
61 61
 	/**
62 62
 	 * @param array $req_data
63 63
 	 */
64
-	protected function _normalize( $req_data ) {
65
-		parent::_normalize( $req_data );
66
-		$paypal_calculates_shipping = $this->get_input_value( 'paypal_shipping' );
67
-		$paypal_calculates_taxes = $this->get_input_value( 'paypal_taxes' );
68
-		$paypal_requests_address_info = $this->get_input_value( 'shipping_details' );
64
+	protected function _normalize($req_data) {
65
+		parent::_normalize($req_data);
66
+		$paypal_calculates_shipping = $this->get_input_value('paypal_shipping');
67
+		$paypal_calculates_taxes = $this->get_input_value('paypal_taxes');
68
+		$paypal_requests_address_info = $this->get_input_value('shipping_details');
69 69
 		if (
70
-			( $paypal_calculates_shipping || $paypal_calculates_taxes ) &&
70
+			($paypal_calculates_shipping || $paypal_calculates_taxes) &&
71 71
 			$paypal_requests_address_info == EE_PMT_Paypal_Standard::shipping_info_none
72 72
 		) {
73 73
 			//they want paypal to calculate taxes or shipping. They need to ask for
74 74
 			//address info, otherwise paypal can't calculate taxes or shipping
75 75
 			/** @type EE_Select_Input $shipping_details_input */
76
-			$shipping_details_input = $this->get_input( 'shipping_details' );
77
-			$shipping_details_input->set_default( EE_PMT_Paypal_Standard::shipping_info_optional );
76
+			$shipping_details_input = $this->get_input('shipping_details');
77
+			$shipping_details_input->set_default(EE_PMT_Paypal_Standard::shipping_info_optional);
78 78
 			$shipping_details_input_options = $shipping_details_input->options();
79 79
 			EE_Error::add_attention(
80 80
 				sprintf(
81
-					__( 'Automatically set "%s" to "%s" because Paypal requires address info in order to calculate shipping or taxes.', 'event_espresso' ),
82
-					strip_tags( $shipping_details_input->html_label_text() ),
83
-					isset( $shipping_details_input_options[ EE_PMT_Paypal_Standard::shipping_info_optional ] )
84
-						? $shipping_details_input_options[ EE_PMT_Paypal_Standard::shipping_info_optional ]
85
-						: __( 'Unknown', 'event_espresso' )
81
+					__('Automatically set "%s" to "%s" because Paypal requires address info in order to calculate shipping or taxes.', 'event_espresso'),
82
+					strip_tags($shipping_details_input->html_label_text()),
83
+					isset($shipping_details_input_options[EE_PMT_Paypal_Standard::shipping_info_optional])
84
+						? $shipping_details_input_options[EE_PMT_Paypal_Standard::shipping_info_optional]
85
+						: __('Unknown', 'event_espresso')
86 86
 				),
87 87
 				__FILE__, __FUNCTION__, __LINE__
88 88
 			);
Please login to merge, or discard this patch.
payment_methods/Paypal_Standard/EEG_Paypal_Standard.gateway.php 3 patches
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 		parent::set_settings($settings_array);
78 78
 		if($this->_debug_mode){
79 79
 			$this->_gateway_url = 'https://www.sandbox.paypal.com/cgi-bin/webscr';
80
-		}else{
80
+		} else{
81 81
 			$this->_gateway_url = 'https://www.paypal.com/cgi-bin/webscr';
82 82
 		}
83 83
 	}
@@ -340,8 +340,9 @@  discard block
 block discarded – undo
340 340
 		$update_info = array();
341 341
 		foreach ( $raw_post_array as $keyval ) {
342 342
 			$keyval = explode( '=', $keyval );
343
-			if ( count( $keyval ) == 2 )
344
-				$update_info[ $keyval[ 0 ] ] = urldecode( $keyval[ 1 ] );
343
+			if ( count( $keyval ) == 2 ) {
344
+							$update_info[ $keyval[ 0 ] ] = urldecode( $keyval[ 1 ] );
345
+			}
345 346
 		}
346 347
 		// read the IPN message sent from PayPal and prepend 'cmd=_notify-validate'
347 348
 		$req = 'cmd=_notify-validate';
Please login to merge, or discard this patch.
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -456,16 +456,16 @@
 block discarded – undo
456 456
 
457 457
 		//might paypal have changed the taxes?
458 458
 		if( $this->_paypal_taxes && $payment_was_itemized ){
459
-                    //note that we're doing this BEFORE adding shipping; we actually want PayPal's shipping to remain non-taxable
460
-                    $this->_line_item->set_line_items_taxable( $transaction->total_line_item(), true, 'paypal_shipping' );
461
-                    $this->_line_item->set_total_tax_to(
462
-                            $transaction->total_line_item(),
463
-                            floatval( $update_info['tax'] ),
464
-                            __( 'Taxes', 'event_espresso' ),
465
-                            __( 'Calculated by Paypal', 'event_espresso' ),
466
-                            'paypal_tax'
467
-                    );
468
-                    $grand_total_needs_resaving = TRUE;
459
+					//note that we're doing this BEFORE adding shipping; we actually want PayPal's shipping to remain non-taxable
460
+					$this->_line_item->set_line_items_taxable( $transaction->total_line_item(), true, 'paypal_shipping' );
461
+					$this->_line_item->set_total_tax_to(
462
+							$transaction->total_line_item(),
463
+							floatval( $update_info['tax'] ),
464
+							__( 'Taxes', 'event_espresso' ),
465
+							__( 'Calculated by Paypal', 'event_espresso' ),
466
+							'paypal_tax'
467
+					);
468
+					$grand_total_needs_resaving = TRUE;
469 469
 		}
470 470
 
471 471
 		$shipping_amount = floatval( $update_info[ 'mc_shipping' ] );
Please login to merge, or discard this patch.
Spacing   +116 added lines, -116 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	 * @return EEG_Paypal_Standard
69 69
 	 */
70 70
 	public function __construct() {
71
-		$this->set_uses_separate_IPN_request( true ) ;
71
+		$this->set_uses_separate_IPN_request(true);
72 72
 		parent::__construct();
73 73
 	}
74 74
 
@@ -78,11 +78,11 @@  discard block
 block discarded – undo
78 78
 	 * Also sets the gateway url class variable based on whether debug mode is enabled or not
79 79
 	 * @param array $settings_array
80 80
 	 */
81
-	public function set_settings($settings_array){
81
+	public function set_settings($settings_array) {
82 82
 		parent::set_settings($settings_array);
83
-		if($this->_debug_mode){
83
+		if ($this->_debug_mode) {
84 84
 			$this->_gateway_url = 'https://www.sandbox.paypal.com/cgi-bin/webscr';
85
-		}else{
85
+		} else {
86 86
 			$this->_gateway_url = 'https://www.paypal.com/cgi-bin/webscr';
87 87
 		}
88 88
 	}
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 	 * @param string      $cancel_url   URL to send the user to after a cancelled payment attempt on teh payment provider's website
98 98
 	 * @return EEI_Payment
99 99
 	 */
100
-	public function set_redirection_info( $payment, $billing_info = array(), $return_url = NULL, $notify_url = NULL, $cancel_url = NULL ){
100
+	public function set_redirection_info($payment, $billing_info = array(), $return_url = NULL, $notify_url = NULL, $cancel_url = NULL) {
101 101
 		$redirect_args = array();
102 102
 		$transaction = $payment->transaction();
103 103
 		$primary_registrant = $transaction->primary_registration();
@@ -107,42 +107,42 @@  discard block
 block discarded – undo
107 107
 
108 108
 		$total_discounts_to_cart_total = $transaction->paid();
109 109
 		//only itemize the order if we're paying for the rest of the order's amount
110
-		if( $payment->amount() == $transaction->total() ) {
111
-			$payment->update_extra_meta( EEG_Paypal_Standard::itemized_payment_option_name, true );
110
+		if ($payment->amount() == $transaction->total()) {
111
+			$payment->update_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, true);
112 112
 			//this payment is for the remaining transaction amount,
113 113
 			//keep track of exactly how much the itemized order amount equals
114 114
 			$itemized_sum = 0;
115 115
 			$shipping_previously_added = 0;
116 116
 			//so let's show all the line items
117
-			foreach($total_line_item->get_items() as $line_item){
118
-				if ( $line_item instanceof EE_Line_Item ) {
117
+			foreach ($total_line_item->get_items() as $line_item) {
118
+				if ($line_item instanceof EE_Line_Item) {
119 119
 					//it's some kind of discount
120
-					if( $line_item->total() < 0 ) {
121
-						$total_discounts_to_cart_total += abs( $line_item->total() );
120
+					if ($line_item->total() < 0) {
121
+						$total_discounts_to_cart_total += abs($line_item->total());
122 122
 						$itemized_sum += $line_item->total();
123 123
 						continue;
124 124
 					}
125 125
 					//dont include shipping again.
126
-					if( strpos( $line_item->code(), 'paypal_shipping_') === 0 ) {
126
+					if (strpos($line_item->code(), 'paypal_shipping_') === 0) {
127 127
 						$shipping_previously_added = $line_item->total();
128 128
 						continue;
129 129
 					}
130
-					$redirect_args[ 'item_name_' . $item_num ] = substr(
131
-						sprintf( _x( '%1$s for %2$s', 'Ticket for Event', 'event_espresso' ), $line_item->name(), $line_item->ticket_event_name() ),
130
+					$redirect_args['item_name_'.$item_num] = substr(
131
+						sprintf(_x('%1$s for %2$s', 'Ticket for Event', 'event_espresso'), $line_item->name(), $line_item->ticket_event_name()),
132 132
 						0, 127
133 133
 					);
134
-					$redirect_args[ 'amount_' . $item_num ] = $line_item->unit_price();
135
-					$redirect_args[ 'quantity_' . $item_num ] = $line_item->quantity();
134
+					$redirect_args['amount_'.$item_num] = $line_item->unit_price();
135
+					$redirect_args['quantity_'.$item_num] = $line_item->quantity();
136 136
 					//if we're not letting PayPal calculate shipping, tell them its 0
137
-					if ( ! $this->_paypal_shipping ) {
138
-						$redirect_args[ 'shipping_' . $item_num ] = '0';
139
-						$redirect_args[ 'shipping2_' . $item_num ] = '0';
137
+					if ( ! $this->_paypal_shipping) {
138
+						$redirect_args['shipping_'.$item_num] = '0';
139
+						$redirect_args['shipping2_'.$item_num] = '0';
140 140
 					}
141 141
 					$item_num++;
142 142
 					$itemized_sum += $line_item->total();
143 143
 				}
144 144
 			}
145
-			$taxes_li = $this->_line_item->get_taxes_subtotal( $total_line_item );
145
+			$taxes_li = $this->_line_item->get_taxes_subtotal($total_line_item);
146 146
 			//ideally itemized sum equals the transaction total. but if not (which is weird)
147 147
 			//and the itemized sum is LESS than the transaction total
148 148
 			//add another line item
@@ -152,47 +152,47 @@  discard block
 block discarded – undo
152 152
 					$transaction->total() - $itemized_sum - $taxes_li->total() - $shipping_previously_added,
153 153
 					2 
154 154
 				);
155
-			if( $itemized_sum_diff_from_txn_total < 0 ) {
155
+			if ($itemized_sum_diff_from_txn_total < 0) {
156 156
 				//itemized sum is too big
157
-				$total_discounts_to_cart_total += abs( $itemized_sum_diff_from_txn_total );
158
-			} elseif( $itemized_sum_diff_from_txn_total > 0 ) {
159
-				$redirect_args[ 'item_name_' . $item_num ] = substr(
160
-						__( 'Other charges', 'event_espresso' ), 0, 127 );
161
-				$redirect_args[ 'amount_' . $item_num ] = $this->format_currency( $itemized_sum_diff_from_txn_total );
162
-				$redirect_args[ 'quantity_' . $item_num ] = 1;
157
+				$total_discounts_to_cart_total += abs($itemized_sum_diff_from_txn_total);
158
+			} elseif ($itemized_sum_diff_from_txn_total > 0) {
159
+				$redirect_args['item_name_'.$item_num] = substr(
160
+						__('Other charges', 'event_espresso'), 0, 127 );
161
+				$redirect_args['amount_'.$item_num] = $this->format_currency($itemized_sum_diff_from_txn_total);
162
+				$redirect_args['quantity_'.$item_num] = 1;
163 163
 				$item_num++;
164 164
 			}
165
-			if( $total_discounts_to_cart_total > 0 ) {
166
-				$redirect_args[ 'discount_amount_cart' ] = $this->format_currency( $total_discounts_to_cart_total );
165
+			if ($total_discounts_to_cart_total > 0) {
166
+				$redirect_args['discount_amount_cart'] = $this->format_currency($total_discounts_to_cart_total);
167 167
 			}
168 168
 			//add our taxes to the order if we're NOT using PayPal's
169
-			if( ! $this->_paypal_taxes ){
169
+			if ( ! $this->_paypal_taxes) {
170 170
 				$redirect_args['tax_cart'] = $total_line_item->get_total_tax();
171 171
 			}
172 172
 		} else {
173
-			$payment->update_extra_meta( EEG_Paypal_Standard::itemized_payment_option_name, false );
173
+			$payment->update_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, false);
174 174
 			//partial payment that's not for the remaining amount, so we can't send an itemized list
175
-			$redirect_args['item_name_' . $item_num] = substr(
176
-				sprintf( __('Payment of %1$s for %2$s', "event_espresso"), $payment->amount(), $primary_registrant->reg_code() ),
175
+			$redirect_args['item_name_'.$item_num] = substr(
176
+				sprintf(__('Payment of %1$s for %2$s', "event_espresso"), $payment->amount(), $primary_registrant->reg_code()),
177 177
 				0, 127
178 178
 			);
179
-			$redirect_args['amount_' . $item_num] = $payment->amount();
180
-			$redirect_args['shipping_' . $item_num ] = '0';
181
-			$redirect_args['shipping2_' . $item_num ] = '0';
179
+			$redirect_args['amount_'.$item_num] = $payment->amount();
180
+			$redirect_args['shipping_'.$item_num] = '0';
181
+			$redirect_args['shipping2_'.$item_num] = '0';
182 182
 			$redirect_args['tax_cart'] = '0';
183 183
 			$item_num++;
184 184
 		}
185 185
 
186
-		if($this->_debug_mode){
187
-			$redirect_args['item_name_' . $item_num] = 'DEBUG INFO (this item only added in sandbox mode';
188
-			$redirect_args['amount_' . $item_num] = 0;
186
+		if ($this->_debug_mode) {
187
+			$redirect_args['item_name_'.$item_num] = 'DEBUG INFO (this item only added in sandbox mode';
188
+			$redirect_args['amount_'.$item_num] = 0;
189 189
 			$redirect_args['on0_'.$item_num] = 'NOTIFY URL';
190
-			$redirect_args['os0_' . $item_num] = $notify_url;
190
+			$redirect_args['os0_'.$item_num] = $notify_url;
191 191
 			$redirect_args['on1_'.$item_num] = 'RETURN URL';
192
-			$redirect_args['os1_' . $item_num] = $return_url;
192
+			$redirect_args['os1_'.$item_num] = $return_url;
193 193
 //			$redirect_args['option_index_' . $item_num] = 1; // <-- dunno if this is needed ?
194
-			$redirect_args['shipping_' . $item_num ] = '0';
195
-			$redirect_args['shipping2_' . $item_num ] = '0';
194
+			$redirect_args['shipping_'.$item_num] = '0';
195
+			$redirect_args['shipping2_'.$item_num] = '0';
196 196
 		}
197 197
 
198 198
 		$redirect_args['business'] = $this->_paypal_id;
@@ -202,14 +202,14 @@  discard block
 block discarded – undo
202 202
 		$redirect_args['cmd'] = '_cart';
203 203
 		$redirect_args['upload'] = 1;
204 204
 		$redirect_args['currency_code'] = $payment->currency_code();
205
-		$redirect_args['rm'] = 2;//makes the user return with method=POST
206
-		if($this->_image_url){
205
+		$redirect_args['rm'] = 2; //makes the user return with method=POST
206
+		if ($this->_image_url) {
207 207
 			$redirect_args['image_url'] = $this->_image_url;
208 208
 		}
209 209
 		$redirect_args['no_shipping'] = $this->_shipping_details;
210
-		$redirect_args['bn'] = 'EventEspresso_SP';//EE will blow up if you change this
210
+		$redirect_args['bn'] = 'EventEspresso_SP'; //EE will blow up if you change this
211 211
 
212
-		$redirect_args = apply_filters( "FHEE__EEG_Paypal_Standard__set_redirection_info__arguments", $redirect_args, $this );
212
+		$redirect_args = apply_filters("FHEE__EEG_Paypal_Standard__set_redirection_info__arguments", $redirect_args, $this);
213 213
 
214 214
 		$payment->set_redirect_url($this->_gateway_url);
215 215
 		$payment->set_redirect_args($redirect_args);
@@ -230,55 +230,55 @@  discard block
 block discarded – undo
230 230
 	 * @return \EEI_Payment updated
231 231
 	 * @throws \EE_Error
232 232
 	 */
233
-	public function handle_payment_update( $update_info, $transaction ){
233
+	public function handle_payment_update($update_info, $transaction) {
234 234
 		//verify there's payment data that's been sent
235
-		if ( empty( $update_info[ 'payment_status' ] ) || empty( $update_info[ 'txn_id' ] ) ) {
235
+		if (empty($update_info['payment_status']) || empty($update_info['txn_id'])) {
236 236
 			// waaaait... is this a PDT request? (see https://developer.paypal.com/docs/classic/products/payment-data-transfer/)
237 237
 			// indicated by the "tx" argument? If so, we don't need it. We'll just use the IPN data when it comes
238
-			if ( isset( $update_info[ 'tx' ] ) ) {
238
+			if (isset($update_info['tx'])) {
239 239
 				return $transaction->last_payment();
240 240
 			} else {
241 241
 				return null;
242 242
 			}
243 243
 		}
244
-		$payment = $this->_pay_model->get_payment_by_txn_id_chq_nmbr( $update_info[ 'txn_id' ] );
245
-		if ( ! $payment instanceof EEI_Payment ) {
244
+		$payment = $this->_pay_model->get_payment_by_txn_id_chq_nmbr($update_info['txn_id']);
245
+		if ( ! $payment instanceof EEI_Payment) {
246 246
 			$payment = $transaction->last_payment();
247 247
 		}
248 248
 		// ok, then validate the IPN. Even if we've already processed this payment,
249 249
 		// let PayPal know we don't want to hear from them anymore!
250
-		if ( ! $this->validate_ipn( $update_info, $payment ) ) {
250
+		if ( ! $this->validate_ipn($update_info, $payment)) {
251 251
 			return $payment;
252 252
 		}
253 253
 		//ok, well let's process this payment then!
254
-		switch ( $update_info[ 'payment_status' ] ) {
254
+		switch ($update_info['payment_status']) {
255 255
 
256 256
 			case 'Completed' :
257 257
 				$status = $this->_pay_model->approved_status();
258
-				$gateway_response = __( 'The payment is approved.', 'event_espresso' );
258
+				$gateway_response = __('The payment is approved.', 'event_espresso');
259 259
 				break;
260 260
 
261 261
 			case 'Pending' :
262 262
 				$status = $this->_pay_model->pending_status();
263
-				$gateway_response = __( 'The payment is in progress. Another message will be sent when payment is approved.', 'event_espresso' );
263
+				$gateway_response = __('The payment is in progress. Another message will be sent when payment is approved.', 'event_espresso');
264 264
 				break;
265 265
 
266 266
 			case 'Denied' :
267 267
 				$status = $this->_pay_model->declined_status();
268
-				$gateway_response = __( 'The payment has been declined.', 'event_espresso' );
268
+				$gateway_response = __('The payment has been declined.', 'event_espresso');
269 269
 				break;
270 270
 
271 271
 			case 'Expired' :
272 272
 			case 'Failed' :
273 273
 				$status = $this->_pay_model->failed_status();
274
-				$gateway_response = __( 'The payment failed for technical reasons or expired.', 'event_espresso' );
274
+				$gateway_response = __('The payment failed for technical reasons or expired.', 'event_espresso');
275 275
 				break;
276 276
 
277 277
 			case 'Refunded' :
278 278
 			case 'Partially_Refunded' :
279 279
 				// even though it's a refund, we consider the payment as approved, it just has a negative value
280 280
 				$status = $this->_pay_model->approved_status();
281
-				$gateway_response = __( 'The payment has been refunded. Please update registrations accordingly.', 'event_espresso' );
281
+				$gateway_response = __('The payment has been refunded. Please update registrations accordingly.', 'event_espresso');
282 282
 				break;
283 283
 
284 284
 			case 'Voided' :
@@ -286,25 +286,25 @@  discard block
 block discarded – undo
286 286
 			case 'Canceled_Reversal' :
287 287
 			default :
288 288
 				$status = $this->_pay_model->cancelled_status();
289
-				$gateway_response = __( 'The payment was cancelled, reversed, or voided. Please update registrations accordingly.', 'event_espresso' );
289
+				$gateway_response = __('The payment was cancelled, reversed, or voided. Please update registrations accordingly.', 'event_espresso');
290 290
 				break;
291 291
 
292 292
 		}
293 293
 
294 294
 		//check if we've already processed this payment
295
-		if ( $payment instanceof EEI_Payment ) {
295
+		if ($payment instanceof EEI_Payment) {
296 296
 			//payment exists. if this has the exact same status and amount, don't bother updating. just return
297
-			if ( $payment->status() == $status && $payment->amount() == $update_info[ 'mc_gross' ] ) {
297
+			if ($payment->status() == $status && $payment->amount() == $update_info['mc_gross']) {
298 298
 				// DUPLICATED IPN! dont bother updating transaction foo!;
299
-				$message_log = sprintf( __( 'It appears we have received a duplicate IPN from PayPal for payment %d', 'event_espresso' ), $payment->ID() );
299
+				$message_log = sprintf(__('It appears we have received a duplicate IPN from PayPal for payment %d', 'event_espresso'), $payment->ID());
300 300
 			} else {
301 301
 				// new payment yippee !!!
302
-				$payment->set_status( $status );
303
-				$payment->set_amount( floatval( $update_info[ 'mc_gross' ] ) );
304
-				$payment->set_gateway_response( $gateway_response );
305
-				$payment->set_details( $update_info );
306
-				$payment->set_txn_id_chq_nmbr( $update_info[ 'txn_id' ] );
307
-				$message_log = sprintf( __( 'Updated payment either from IPN or as part of POST from PayPal', 'event_espresso' ) );
302
+				$payment->set_status($status);
303
+				$payment->set_amount(floatval($update_info['mc_gross']));
304
+				$payment->set_gateway_response($gateway_response);
305
+				$payment->set_details($update_info);
306
+				$payment->set_txn_id_chq_nmbr($update_info['txn_id']);
307
+				$message_log = sprintf(__('Updated payment either from IPN or as part of POST from PayPal', 'event_espresso'));
308 308
 			}
309 309
 			$this->log(
310 310
 				array(
@@ -316,11 +316,11 @@  discard block
 block discarded – undo
316 316
 				$payment
317 317
 			);
318 318
 		}
319
-		do_action( 'FHEE__EEG_Paypal_Standard__handle_payment_update__payment_processed', $payment, $this );
319
+		do_action('FHEE__EEG_Paypal_Standard__handle_payment_update__payment_processed', $payment, $this);
320 320
 		// kill request here if this is a refund
321
-		if ( $update_info[ 'payment_status' ] == 'Refunded' || $update_info[ 'payment_status' ] == 'Partially_Refunded'   ) {
322
-			if ( apply_filters( 'FHEE__EEG_Paypal_Standard__handle_payment_update__kill_refund_request', true ) ) {
323
-				status_header( 200 );
321
+		if ($update_info['payment_status'] == 'Refunded' || $update_info['payment_status'] == 'Partially_Refunded') {
322
+			if (apply_filters('FHEE__EEG_Paypal_Standard__handle_payment_update__kill_refund_request', true)) {
323
+				status_header(200);
324 324
 				exit();
325 325
 			}
326 326
 		}
@@ -336,9 +336,9 @@  discard block
 block discarded – undo
336 336
 	 * @param EE_Payment|EEI_Payment $payment
337 337
 	 * @return boolean
338 338
 	 */
339
-	public function validate_ipn( $update_info, $payment ) {
339
+	public function validate_ipn($update_info, $payment) {
340 340
 		//allow us to skip validating IPNs with PayPal (useful for testing)
341
-		if ( apply_filters( 'FHEE__EEG_Paypal_Standard__validate_ipn__skip', false ) ) {
341
+		if (apply_filters('FHEE__EEG_Paypal_Standard__validate_ipn__skip', false)) {
342 342
 			return true;
343 343
 		}
344 344
 		//...otherwise, we actually don't care what the $update_info is, we need to look
@@ -346,22 +346,22 @@  discard block
 block discarded – undo
346 346
 		// Reading POSTed data directly from $_POST causes serialization issues with array data in the POST.
347 347
 		// Instead, read raw POST data from the input stream.
348 348
 		// @see https://gist.github.com/xcommerce-gists/3440401
349
-		$raw_post_data = file_get_contents( 'php://input' );
350
-		$raw_post_array = explode( '&', $raw_post_data );
349
+		$raw_post_data = file_get_contents('php://input');
350
+		$raw_post_array = explode('&', $raw_post_data);
351 351
 		$update_info = array();
352
-		foreach ( $raw_post_array as $keyval ) {
353
-			$keyval = explode( '=', $keyval );
354
-			if ( count( $keyval ) == 2 )
355
-				$update_info[ $keyval[ 0 ] ] = urldecode( $keyval[ 1 ] );
352
+		foreach ($raw_post_array as $keyval) {
353
+			$keyval = explode('=', $keyval);
354
+			if (count($keyval) == 2)
355
+				$update_info[$keyval[0]] = urldecode($keyval[1]);
356 356
 		}
357 357
 		// read the IPN message sent from PayPal and prepend 'cmd=_notify-validate'
358 358
 		$req = 'cmd=_notify-validate';
359
-		$get_magic_quotes_exists = function_exists( 'get_magic_quotes_gpc' ) ? true : false;
360
-		foreach ( $update_info as $key => $value ) {
361
-			if ( $get_magic_quotes_exists && get_magic_quotes_gpc() == 1 ) {
362
-				$value = urlencode( stripslashes( $value ) );
359
+		$get_magic_quotes_exists = function_exists('get_magic_quotes_gpc') ? true : false;
360
+		foreach ($update_info as $key => $value) {
361
+			if ($get_magic_quotes_exists && get_magic_quotes_gpc() == 1) {
362
+				$value = urlencode(stripslashes($value));
363 363
 			} else {
364
-				$value = urlencode( $value );
364
+				$value = urlencode($value);
365 365
 			}
366 366
 			$req .= "&$key=$value";
367 367
 		}
@@ -371,21 +371,21 @@  discard block
 block discarded – undo
371 371
 			array(
372 372
 				'body' 				=> $req,
373 373
 				'sslverify' 		=> false,
374
-				'timeout' 		=> 60 ,
374
+				'timeout' 		=> 60,
375 375
 				// make sure to set a site specific unique "user-agent" string since the WordPres default gets declined by PayPal
376 376
 				// plz see: https://github.com/websharks/s2member/issues/610
377
-				'user-agent' 	=> 'Event Espresso v' . EVENT_ESPRESSO_VERSION . '; ' . home_url(),
377
+				'user-agent' 	=> 'Event Espresso v'.EVENT_ESPRESSO_VERSION.'; '.home_url(),
378 378
 			)
379 379
 		);
380 380
 		// then check the response
381
-		if ( ! is_wp_error( $response ) && array_key_exists( 'body', $response ) && strcmp( $response[ 'body' ], "VERIFIED" ) == 0 ) {
381
+		if ( ! is_wp_error($response) && array_key_exists('body', $response) && strcmp($response['body'], "VERIFIED") == 0) {
382 382
 			return true;
383 383
 		} else {
384 384
 			// huh, something's wack... the IPN didn't validate. We must have replied to the IPN incorrectly,
385 385
 			// or their API must have changed: http://www.paypalobjects.com/en_US/ebook/PP_OrderManagement_IntegrationGuide/ipn.html
386
-			$payment->set_gateway_response( sprintf( __( "IPN Validation failed! Paypal responded with '%s'", "event_espresso" ), $response[ 'body' ] ) );
387
-			$payment->set_details( array( 'REQUEST' => $update_info, 'VALIDATION_RESPONSE' => $response ) );
388
-			$payment->set_status( EEM_Payment::status_id_failed );
386
+			$payment->set_gateway_response(sprintf(__("IPN Validation failed! Paypal responded with '%s'", "event_espresso"), $response['body']));
387
+			$payment->set_details(array('REQUEST' => $update_info, 'VALIDATION_RESPONSE' => $response));
388
+			$payment->set_status(EEM_Payment::status_id_failed);
389 389
 			// log the results
390 390
 			$this->log(
391 391
 				array(
@@ -407,9 +407,9 @@  discard block
 block discarded – undo
407 407
 	 */
408 408
 	protected function _process_response_url() {
409 409
 		EE_Registry::instance()->load_helper('URL');
410
-		if ( isset( $_SERVER[ 'HTTP_HOST' ], $_SERVER[ 'REQUEST_URI' ] ) ) {
410
+		if (isset($_SERVER['HTTP_HOST'], $_SERVER['REQUEST_URI'])) {
411 411
 			$url = is_ssl() ? 'https://' : 'http://';
412
-			$url .= EEH_URL::filter_input_server_url( 'HTTP_HOST' );
412
+			$url .= EEH_URL::filter_input_server_url('HTTP_HOST');
413 413
 			$url .= EEH_URL::filter_input_server_url();
414 414
 		} else {
415 415
 			$url = 'unknown';
@@ -425,30 +425,30 @@  discard block
 block discarded – undo
425 425
 	 * like the taxes or shipping
426 426
 	 * @param EEI_Payment $payment
427 427
 	 */
428
-	public function update_txn_based_on_payment( $payment ) {
428
+	public function update_txn_based_on_payment($payment) {
429 429
 		$update_info = $payment->details();
430 430
 		$transaction = $payment->transaction();
431
-		$payment_was_itemized = $payment->get_extra_meta( EEG_Paypal_Standard::itemized_payment_option_name, true, false );
432
-		if( ! $transaction ){
433
-			$this->log( __( 'Payment with ID %d has no related transaction, and so update_txn_based_on_payment couldn\'t be executed properly', 'event_espresso' ), $payment );
431
+		$payment_was_itemized = $payment->get_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, true, false);
432
+		if ( ! $transaction) {
433
+			$this->log(__('Payment with ID %d has no related transaction, and so update_txn_based_on_payment couldn\'t be executed properly', 'event_espresso'), $payment);
434 434
 			return;
435 435
 		}
436
-		if( ! is_array( $update_info ) || ! isset( $update_info[ 'mc_shipping' ] ) || ! isset( $update_info[ 'tax' ] ) ) {
436
+		if ( ! is_array($update_info) || ! isset($update_info['mc_shipping']) || ! isset($update_info['tax'])) {
437 437
 			$this->log(
438 438
 				array(
439 439
 					'url' 				=> $this->_process_response_url(),
440
-					'message' 	=> __( 'Could not update transaction based on payment because the payment details have not yet been put on the payment. This normally happens during the IPN or returning from PayPal', 'event_espresso' ),
440
+					'message' 	=> __('Could not update transaction based on payment because the payment details have not yet been put on the payment. This normally happens during the IPN or returning from PayPal', 'event_espresso'),
441 441
 					'payment' 	=> $payment->model_field_array()
442 442
 				),
443 443
 				$payment
444 444
 			);
445 445
 			return;
446 446
 		}
447
-		if( $payment->status() !== $this->_pay_model->approved_status() ) {
447
+		if ($payment->status() !== $this->_pay_model->approved_status()) {
448 448
 			$this->log(
449 449
 				array(
450 450
 					'url' 				=> $this->_process_response_url(),
451
-					'message' 	=> __( 'We shouldn\'t update transactions taxes or shipping data from non-approved payments', 'event_espresso' ),
451
+					'message' 	=> __('We shouldn\'t update transactions taxes or shipping data from non-approved payments', 'event_espresso'),
452 452
 					'payment' 	=> $payment->model_field_array()
453 453
 				),
454 454
 				$payment
@@ -458,43 +458,43 @@  discard block
 block discarded – undo
458 458
 		$grand_total_needs_resaving = false;
459 459
 
460 460
 		//might paypal have changed the taxes?
461
-		if( $this->_paypal_taxes && $payment_was_itemized ){
461
+		if ($this->_paypal_taxes && $payment_was_itemized) {
462 462
                     //note that we're doing this BEFORE adding shipping; we actually want PayPal's shipping to remain non-taxable
463
-                    $this->_line_item->set_line_items_taxable( $transaction->total_line_item(), true, 'paypal_shipping' );
463
+                    $this->_line_item->set_line_items_taxable($transaction->total_line_item(), true, 'paypal_shipping');
464 464
                     $this->_line_item->set_total_tax_to(
465 465
                             $transaction->total_line_item(),
466
-                            floatval( $update_info['tax'] ),
467
-                            __( 'Taxes', 'event_espresso' ),
468
-                            __( 'Calculated by Paypal', 'event_espresso' ),
466
+                            floatval($update_info['tax']),
467
+                            __('Taxes', 'event_espresso'),
468
+                            __('Calculated by Paypal', 'event_espresso'),
469 469
                             'paypal_tax'
470 470
                     );
471 471
                     $grand_total_needs_resaving = TRUE;
472 472
 		}
473 473
 
474
-		$shipping_amount = floatval( $update_info[ 'mc_shipping' ] );
474
+		$shipping_amount = floatval($update_info['mc_shipping']);
475 475
 		//might paypal have added shipping?
476
-		if( $this->_paypal_shipping && $shipping_amount && $payment_was_itemized ){
476
+		if ($this->_paypal_shipping && $shipping_amount && $payment_was_itemized) {
477 477
 			$this->_line_item->add_unrelated_item(
478 478
 				$transaction->total_line_item(),
479
-				sprintf( __('Shipping for transaction %1$s', 'event_espresso'), $transaction->ID() ),
479
+				sprintf(__('Shipping for transaction %1$s', 'event_espresso'), $transaction->ID()),
480 480
 				$shipping_amount,
481 481
 				__('Shipping charges calculated by Paypal', 'event_espresso'),
482 482
 				1,
483 483
 				false,
484
-				'paypal_shipping_' . $transaction->ID()
484
+				'paypal_shipping_'.$transaction->ID()
485 485
 			);
486 486
 			$grand_total_needs_resaving = true;
487 487
 		}
488 488
 
489
-		if( $grand_total_needs_resaving ){
490
-			$transaction->total_line_item()->save_this_and_descendants_to_txn( $transaction->ID() );
491
-			$registration_processor = EE_Registry::instance()->load_class( 'Registration_Processor' );
492
-			$registration_processor->update_registration_final_prices( $transaction );
489
+		if ($grand_total_needs_resaving) {
490
+			$transaction->total_line_item()->save_this_and_descendants_to_txn($transaction->ID());
491
+			$registration_processor = EE_Registry::instance()->load_class('Registration_Processor');
492
+			$registration_processor->update_registration_final_prices($transaction);
493 493
 		}
494 494
 		$this->log(
495 495
 			array(
496 496
 				'url' 													=> $this->_process_response_url(),
497
-				'message' 										=> __( 'Updated transaction related to payment', 'event_espresso' ),
497
+				'message' 										=> __('Updated transaction related to payment', 'event_espresso'),
498 498
 				'transaction (updated)' 					=> $transaction->model_field_array(),
499 499
 				'payment (updated)' 						=> $payment->model_field_array(),
500 500
 				'use_paypal_shipping' 					=> $this->_paypal_shipping,
Please login to merge, or discard this patch.
core/libraries/plugin_api/EE_Register_Addon.lib.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -138,10 +138,10 @@
 block discarded – undo
138 138
 	 *       		 An array of message types with the key as the message type name and the values as below:
139 139
 	 *        		@type string $mtfilename The filename of the message type being registered.  This will be the main
140 140
 	 *                                       EE_{Messagetype_Name}_message_type class. (eg. EE_Declined_Registration_message_type.class.php). Required.
141
-	*               @type array $autoloadpaths An array of paths to add to the messages autoloader for the new message type. Required.
142
-	*               @type array $messengers_to_activate_with An array of messengers that this message
143
-	*                           type should activate with. Each value in the array should match the name property of a EE_messenger. Optional.
144
-	*               @type array $messengers_to_validate_with An array of messengers that this message
141
+	 *               @type array $autoloadpaths An array of paths to add to the messages autoloader for the new message type. Required.
142
+	 *               @type array $messengers_to_activate_with An array of messengers that this message
143
+	 *                           type should activate with. Each value in the array should match the name property of a EE_messenger. Optional.
144
+	 *               @type array $messengers_to_validate_with An array of messengers that this message
145 145
 	 *                          type should validate with. Each value in the array should match the name property of an EE_messenger. Optional.
146 146
 	 *       	}
147 147
 	 *			@type array $custom_post_types
Please login to merge, or discard this patch.
core/db_classes/EE_CSV.class.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -315,7 +315,7 @@
 block discarded – undo
315 315
 //		header("Content-Type: application/download");
316 316
 		header('Content-disposition: attachment; filename='.$filename);
317 317
 		header("Content-Type: text/csv; charset=utf-8");
318
-                do_action( 'AHEE__EE_CSV__begin_sending_csv__headers' );
318
+				do_action( 'AHEE__EE_CSV__begin_sending_csv__headers' );
319 319
 		echo apply_filters('FHEE__EE_CSV__begin_sending_csv__start_writing', "\xEF\xBB\xBF" ); // makes excel open it as UTF-8. UTF-8 BOM, see http://stackoverflow.com/a/4440143/2773835
320 320
 		$fh = fopen('php://output', 'w');
321 321
 		return $fh;
Please login to merge, or discard this patch.